diff --git a/test/EndToEnd-Installer.Tests/ProjectBuildTests.cs b/test/EndToEnd-Installer.Tests/ProjectBuildTests.cs index 225c5530d7..385375118f 100644 --- a/test/EndToEnd-Installer.Tests/ProjectBuildTests.cs +++ b/test/EndToEnd-Installer.Tests/ProjectBuildTests.cs @@ -358,7 +358,7 @@ namespace EndToEnd.Tests [InlineData("wpflib", "VB")] [InlineData("wpfcustomcontrollib")] [InlineData("wpfcustomcontrollib", "C#")] - [InlineData("wpfcustomcontrollib", "VB", Skip = "Skipping since the Generic.xaml it creates from the template fails to compile.")] + [InlineData("wpfcustomcontrollib", "VB")] [InlineData("wpfusercontrollib")] [InlineData("wpfusercontrollib", "C#")] [InlineData("wpfusercontrollib", "VB")] diff --git a/test/EndToEnd-Installer.Tests/TelemetryOptOutDefaultTests.cs b/test/EndToEnd-Installer.Tests/TelemetryOptOutDefaultTests.cs index 1e4e7338d0..96451823fa 100644 --- a/test/EndToEnd-Installer.Tests/TelemetryOptOutDefaultTests.cs +++ b/test/EndToEnd-Installer.Tests/TelemetryOptOutDefaultTests.cs @@ -9,7 +9,7 @@ namespace EndToEnd.Tests { public class TelemetryOptOutDefault : TestBase { - [Fact(Skip = "TODO: This test can only be ran in CI because the local build does not adjust telemetry settings.")] + [Fact] public void TelemetryOptOutDefaultAttribute() { var versionCommand = new DotnetCommand().ExecuteWithCapturedOutput("--version"); diff --git a/test/Microsoft.DotNet.Configurer.UnitTests/GivenAFirstTimeUseNoticeSentinel.cs b/test/Microsoft.DotNet.Configurer.UnitTests/GivenAFirstTimeUseNoticeSentinel.cs index 274aad639d..39564c5592 100644 --- a/test/Microsoft.DotNet.Configurer.UnitTests/GivenAFirstTimeUseNoticeSentinel.cs +++ b/test/Microsoft.DotNet.Configurer.UnitTests/GivenAFirstTimeUseNoticeSentinel.cs @@ -18,7 +18,7 @@ namespace Microsoft.DotNet.Configurer.UnitTests _fileSystemMockBuilder = FileSystemMockBuilder.Create(); } - [Fact(Skip = "Product.Version not set correctly when running tests")] + [Fact] public void TheSentinelHasTheCurrentVersionInItsName() { FirstTimeUseNoticeSentinel.SENTINEL.Should().Contain($"{Product.Version}"); diff --git a/test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs b/test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs index 1cdd6761b5..8347376786 100644 --- a/test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs +++ b/test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs @@ -552,7 +552,7 @@ public class EndToEndTests : IDisposable [DockerSupportsArchInlineData("linux/arm/v7", "linux-arm", "/app")] [DockerSupportsArchInlineData("linux/arm64/v8", "linux-arm64", "/app")] - [DockerSupportsArchInlineData("linux/386", "linux-x86", "/app", Skip = "There's no apphost for linux-x86 so we can't execute self-contained, and there's no .NET runtime base image for linux-x86 so we can't execute framework-dependent.")] + [DockerSupportsArchInlineData("linux/386", "linux-x86", "/app")] [DockerSupportsArchInlineData("windows/amd64", "win-x64", "C:\\app")] [DockerSupportsArchInlineData("linux/amd64", "linux-x64", "/app")] [DockerAvailableTheory()] diff --git a/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs b/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs index 8a1408ba0e..28f1557fef 100644 --- a/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs +++ b/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs @@ -39,7 +39,7 @@ namespace Microsoft.NET.Build.Tests .HaveStdOutContaining("Hello, World!"); } - [FullMSBuildOnlyFact(Skip = "There is no publish error when using PackageReference support which is required for testing")] + [FullMSBuildOnlyFact] public void When_not_referenced_by_csharp_project_it_fails_to_publish() { var testAsset = _testAssetsManager diff --git a/test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BlazorLegacyIntegrationTest60.cs b/test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BlazorLegacyIntegrationTest60.cs index a98a555e04..d8252f0c50 100644 --- a/test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BlazorLegacyIntegrationTest60.cs +++ b/test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BlazorLegacyIntegrationTest60.cs @@ -9,7 +9,7 @@ namespace Microsoft.NET.Sdk.BlazorWebAssembly.Tests public class BlazorLegacyIntegrationTest60(ITestOutputHelper log) : IsolatedNuGetPackageFolderAspNetSdkBaselineTest(log, nameof(BlazorLegacyIntegrationTest60)) { - [CoreMSBuildOnlyFact(Skip = "The Runtime pack resolves to 8.0 instead of 9.0")] + [CoreMSBuildOnlyFact] public void Build60Hosted_Works() { // Arrange @@ -37,7 +37,7 @@ namespace Microsoft.NET.Sdk.BlazorWebAssembly.Tests new FileInfo(Path.Combine(serverBuildOutputDirectory, $"{testAsset}.Shared.dll")).Should().Exist(); } - [CoreMSBuildOnlyFact(Skip = "The Runtime pack resolves to 8.0 instead of 9.0")] + [CoreMSBuildOnlyFact] public void Publish60Hosted_Works() { // Arrange diff --git a/test/Microsoft.TemplateEngine.Cli.UnitTests/TemplateSearchCoordinatorTests.cs b/test/Microsoft.TemplateEngine.Cli.UnitTests/TemplateSearchCoordinatorTests.cs index e5e5989eab..a2fcebe0c3 100644 --- a/test/Microsoft.TemplateEngine.Cli.UnitTests/TemplateSearchCoordinatorTests.cs +++ b/test/Microsoft.TemplateEngine.Cli.UnitTests/TemplateSearchCoordinatorTests.cs @@ -104,7 +104,7 @@ namespace Microsoft.TemplateEngine.Cli.UnitTests // The _fooOneTemplate is a non-match because of a framework choice param value mismatch. // But the _fooTwoTemplate matches because the framework choice is valid for that template. #pragma warning disable xUnit1004 // Test methods should not be skipped - [Fact(Skip = "Fails due to matching on template options is not implemented.")] + [Fact] #pragma warning restore xUnit1004 // Test methods should not be skipped public async Task CacheSearchCliSymbolNameFilterTest() { @@ -148,7 +148,7 @@ namespace Microsoft.TemplateEngine.Cli.UnitTests // test that an invalid symbol makes the search be a non-match #pragma warning disable xUnit1004 // Test methods should not be skipped - [Fact(Skip = "Fails due to matching on template options is not implemented.")] + [Fact] #pragma warning restore xUnit1004 // Test methods should not be skipped public async Task CacheSearchCliSymbolNameMismatchFilterTest() { @@ -444,9 +444,7 @@ namespace Microsoft.TemplateEngine.Cli.UnitTests } } -#pragma warning disable xUnit1004 // Test methods should not be skipped - [Fact(Skip = "Not relevant due to matching on template options is not implemented.")] -#pragma warning restore xUnit1004 // Test methods should not be skipped + [Fact] public async Task CacheSkipInvalidTemplatesTest() { string cacheLocation = TestUtils.CreateTemporaryFolder(); diff --git a/test/crossgen.Tests/crossgen.Tests.cs b/test/crossgen.Tests/crossgen.Tests.cs index b6885aa402..26958ca578 100644 --- a/test/crossgen.Tests/crossgen.Tests.cs +++ b/test/crossgen.Tests/crossgen.Tests.cs @@ -14,7 +14,7 @@ namespace Microsoft.DotNet.Tests { } - [Fact(Skip = "This coverage needs to be in core-sdk, which is where crossgen is applied")] + [Fact] public void CLI_SDK_assemblies_must_be_crossgened() { // TODO: Update method of finding cliPath (right now it's finding a ref path in stage 0 diff --git a/test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_InstalledPackage_OtherFeed.verified.txt b/test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_InstalledPackage_OtherFeed.verified.txt index fb01ea3036..eb8502c957 100644 --- a/test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_InstalledPackage_OtherFeed.verified.txt +++ b/test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_InstalledPackage_OtherFeed.verified.txt @@ -1,5 +1,5 @@ Microsoft.Azure.WebJobs.ItemTemplates - Package version: 4.0.2738 + Package version: 4.0.3038 Details: Collection of templates for Azure Functions Source Feed: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json Authors: @@ -8,30 +8,34 @@ License Url: https://go.microsoft.com/fwlink/?linkid=2028464 Repository Url: https://go.microsoft.com/fwlink/?linkid=848145 Templates: - Template Name Short Name Type Tags Language - ----------------------------------- ------------------- ---- ----------------------------------------------------- -------- - HttpTrigger http item Azure Function/Trigger/Http C#,F# - QueueTrigger queue item Azure Function/Trigger/Storage Queue C# - HttpTriggerWithOpenAPI httpOpenAPI item Azure Function/Trigger/Http C# - BlobTrigger blob item Azure Function/Trigger/Blob C#,F# - TimerTrigger timer item Azure Function/Trigger/Timer C#,F# - DurableFunctionsOrchestration durable item Azure Function/Durable Functions Orchestration C# - DurableFunctionsEntityOrchestration durableentity item Azure Function/Durable Functions Entity Orchestration C# - SendGrid sendgrid item Azure Function/Ouput/SendGrid C# - EventHubTrigger eventhub item Azure Function/Trigger/EventHub C#,F# - ServiceBusQueueTrigger squeue item Azure Function/Trigger/Service Bus/Queue C# - ServiceBusTopicTrigger stopic item Azure Function/Trigger/Service Bus/Topic C# - EventGridCloudEventTrigger eventgridcloudevent item Azure Function/Trigger/EventGrid/EventGrid CloudEvent C#,F# - EventGridTrigger eventgrid item Azure Function/Trigger/EventGrid C# - IotHubTrigger iothub item Azure Function/Trigger/IotHub C# - CosmosDBTrigger cosmos,CosmosDB item Azure Function/Trigger/Cosmos DB C#,F# - SignalRTrigger signalr item Azure Function/Trigger/Http/SignalR C# - RabbitMQTrigger rqueue item Azure Function/Trigger/RabbitMQ Queue C# - KafkaTrigger kafka item Azure Function/Trigger/Kafka C# - KafkaOutput kafkao item Azure Function/Ouput/Kafka C# - SqlInputBinding sqlinput item Azure Function/Input/SQL C# - SqlOutputBinding sqloutput item Azure Function/Output/SQL C# - SqlTriggerBinding sqltrigger item Azure Function/Trigger/SQL C# - KustoInputBinding kustoinput item Azure Function/Input/Kusto C# - KustoOutputBinding kustooutput item Azure Function/Output/Kusto C# + Template Name Short Name Type Tags Language + ----------------------------------- ---------------------------- ---- ----------------------------------------------------- -------- + HttpTrigger http item Azure Function/Trigger/Http C#,F# + QueueTrigger queue item Azure Function/Trigger/Storage Queue C# + HttpTriggerWithOpenAPI httpOpenAPI item Azure Function/Trigger/Http C# + BlobTrigger blob item Azure Function/Trigger/Blob C#,F# + TimerTrigger timer item Azure Function/Trigger/Timer C#,F# + DurableFunctionsOrchestration durable item Azure Function/Durable Functions Orchestration C# + DurableFunctionsEntityOrchestration durableentity item Azure Function/Durable Functions Entity Orchestration C# + SendGrid sendgrid item Azure Function/Ouput/SendGrid C# + EventHubTrigger eventhub item Azure Function/Trigger/EventHub C#,F# + ServiceBusQueueTrigger squeue item Azure Function/Trigger/Service Bus/Queue C# + ServiceBusTopicTrigger stopic item Azure Function/Trigger/Service Bus/Topic C# + EventGridCloudEventTrigger eventgridcloudevent item Azure Function/Trigger/EventGrid/EventGrid CloudEvent C#,F# + EventGridTrigger eventgrid item Azure Function/Trigger/EventGrid C#,F# + IotHubTrigger iothub item Azure Function/Trigger/IotHub C# + CosmosDBTrigger cosmos,CosmosDB item Azure Function/Trigger/Cosmos DB C#,F# + SignalRTrigger signalr item Azure Function/Trigger/Http/SignalR C# + RabbitMQTrigger rqueue item Azure Function/Trigger/RabbitMQ Queue C# + KafkaTrigger kafka item Azure Function/Trigger/Kafka C# + KafkaOutput kafkao item Azure Function/Ouput/Kafka C# + SqlInputBinding sqlinput item Azure Function/Input/SQL C# + SqlOutputBinding sqloutput item Azure Function/Output/SQL C# + SqlTriggerBinding sqltrigger item Azure Function/Trigger/SQL C# + KustoInputBinding kustoinput item Azure Function/Input/Kusto C# + KustoOutputBinding kustooutput item Azure Function/Output/Kusto C# + EventGridBlobTrigger eventgridblob item Azure Function/Trigger/Blob C# + DaprServiceInvocationTrigger daprServiceInvocationTrigger item Azure Function/Trigger/Dapr C# + DaprTopicTrigger daprTopicTrigger item Azure Function/Trigger/Dapr C# + DaprPublishOutputBinding daprPublishOutputBinding item Azure Function/Trigger/Dapr C# \ No newline at end of file diff --git a/test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_RemotePackage_OtherFeedNoVersion.verified.txt b/test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_RemotePackage_OtherFeedNoVersion.verified.txt index aa1da92009..076958e1cb 100644 --- a/test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_RemotePackage_OtherFeedNoVersion.verified.txt +++ b/test/dotnet-new.Tests/Approvals/DotnetNewDetailsTest.CanDisplayDetails_RemotePackage_OtherFeedNoVersion.verified.txt @@ -1,5 +1,5 @@ Microsoft.Azure.WebJobs.ItemTemplates - Package version: 4.0.2738 + Package version: 4.0.3038 Details: Collection of templates for Azure Functions Source Feed: dotnet-public [https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json] Authors: diff --git a/test/dotnet-new.Tests/DotnetNewDetailsTest.Approval.cs b/test/dotnet-new.Tests/DotnetNewDetailsTest.Approval.cs index a54fd1e05e..91f7f0a8cd 100644 --- a/test/dotnet-new.Tests/DotnetNewDetailsTest.Approval.cs +++ b/test/dotnet-new.Tests/DotnetNewDetailsTest.Approval.cs @@ -58,9 +58,7 @@ namespace Microsoft.DotNet.Cli.New.IntegrationTests return Verify(commandResult.StdOut); } -#pragma warning disable xUnit1004 // Test methods should not be skipped - [Fact(Skip = "Test targeting specific versions")] -#pragma warning restore xUnit1004 // Test methods should not be skipped + [Fact] public Task CanDisplayDetails_RemotePackage_OtherFeedNoVersion() { CommandResult commandResult = new DotnetNewCommand(_log, "details", "Microsoft.Azure.WebJobs.ItemTemplates") @@ -127,9 +125,7 @@ namespace Microsoft.DotNet.Cli.New.IntegrationTests return Verify(commandResult.StdOut); } -#pragma warning disable xUnit1004 // Test methods should not be skipped - [Fact(Skip = "Test targeting specific versions")] -#pragma warning restore xUnit1004 // Test methods should not be skipped + [Fact] public Task CanDisplayDetails_InstalledPackage_OtherFeed() { string home = CreateTemporaryFolder(folderName: "Home"); diff --git a/test/dotnet.Tests/dotnet-msbuild/GivenMsbuildForwardingApp.cs b/test/dotnet.Tests/dotnet-msbuild/GivenMsbuildForwardingApp.cs index fb9a565407..20539d6de7 100644 --- a/test/dotnet.Tests/dotnet-msbuild/GivenMsbuildForwardingApp.cs +++ b/test/dotnet.Tests/dotnet-msbuild/GivenMsbuildForwardingApp.cs @@ -50,7 +50,7 @@ namespace Microsoft.DotNet.Cli.MSBuild.Tests .Exist(); } - [Fact(Skip = "Test app base folder doesn't have Sdks")] + [Fact] public void ItSetsMSBuildSDKsPathToExistingPath() { var msbuildPath = "";