* Fix an issue parsing promises

We changed the function `getPromise` to not use a lock in version 2.1.2. This was a mistake. I thought it would return the unresolved `Promise` object if it was a sync function. That is not the behavior, instead it will skip that line of code and return null even if the promise exists. This causes multiple processes to try to grab the installer file handle.

When one fails to grab the file handle, it causes a chain-reaction of cascading failures for concurrent requests, because that is supposed to be blocked from happening.

In addition, the check I added to kill the sudo process once it is finished runs on all platforms despite the master sudo process only being present on Linux, which has resulted in some higher timeout rates. We need to not do this on other platforms.

* Fix tests

we need to clear the promise out after each test is done

* dont call uninstall all in sdk test, its the wrong command

* reset event stream in the test

* 2.1.4 branding - new version due to vscode marketplace outage causing failure to upload version 2.1.3 correctly
This commit is contained in:
Noah Gilson 2024-08-20 13:23:26 -07:00 коммит произвёл GitHub
Родитель 909fcb1bae
Коммит 95432c0296
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: B5690EEEBB952194
4 изменённых файлов: 8 добавлений и 4 удалений

Просмотреть файл

@ -1830,7 +1830,7 @@ util-deprecate@^1.0.1:
fsevents "^2.3.3"
"vscode-dotnet-runtime@file:../vscode-dotnet-runtime-extension":
version "2.1.3"
version "2.1.4"
resolved "file:../vscode-dotnet-runtime-extension"
dependencies:
"@types/chai-as-promised" "^7.1.8"

Просмотреть файл

@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning].
## [Unreleased]
## [2.1.4] - 2024-08-19
Publish a new version due to VS Marketplace Outage issue.
## [2.1.3] - 2024-08-19
Fixes an issue with concurrent SDK installs introduced in 2.1.2.

4
vscode-dotnet-runtime-extension/package-lock.json сгенерированный
Просмотреть файл

@ -1,12 +1,12 @@
{
"name": "vscode-dotnet-runtime",
"version": "2.1.3",
"version": "2.1.4",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "vscode-dotnet-runtime",
"version": "2.1.3",
"version": "2.1.4",
"license": "MIT",
"dependencies": {
"@types/chai-as-promised": "^7.1.8",

Просмотреть файл

@ -13,7 +13,7 @@
"description": "This extension installs and manages different versions of the .NET SDK and Runtime.",
"appInsightsKey": "02dc18e0-7494-43b2-b2a3-18ada5fcb522",
"icon": "images/dotnetIcon.png",
"version": "2.1.3",
"version": "2.1.4",
"publisher": "ms-dotnettools",
"engines": {
"vscode": "^1.81.1"