Noah Gilson
a1f03c60df
Use which dotnet in tests instead of the readlink for symlinks
...
After we made it so if theres no dotnet it does not try to read a symlink
which dotnet went back to being the correct result
2024-01-19 11:34:14 -08:00
Noah Gilson
6941b5c4c5
update redhat tests to read symlinks
2024-01-18 11:28:45 -08:00
Noah Gilson
37eba609fe
Merge remote-tracking branch 'upstream/main' into nagilson-2.0.1-release
2024-01-17 16:19:34 -08:00
Noah Gilson
6e264bd12f
Merge branch 'main' into nagilson-does-install-still-exist
2024-01-17 16:16:10 -08:00
Noah Gilson
fa2fc1e1e6
reject instead of throw to prevent inf loop
2024-01-17 11:58:12 -08:00
Noah Gilson
ea50349147
RHEL: dont parse failure
2024-01-17 11:45:23 -08:00
Noah Gilson
fb7306e4ce
Read symlinks on RHEL as they apparently can become symlinks too depending on install type
2024-01-17 10:29:30 -08:00
Noah Gilson
6af81276fa
dont fail with 1 if the install already exists on linux RHEL
2024-01-17 10:05:01 -08:00
Noah Gilson
9e31011bdf
Merge pull request #1612 from nagilson/nagilson-fix-package-mixups
...
Use Installer Type Conforming Installation Directory for Ubuntu
2024-01-17 09:49:25 -08:00
Noah Gilson
94c54ea1ca
convert throw to rejection as the throw will cause the promise to never finish and never error properly
2024-01-16 15:13:00 -08:00
Noah Gilson
e4f0cf1454
Add WIP bash code to run loop and finish core idea to run cmds under a sudo process
2024-01-16 11:17:48 -08:00
Noah Gilson
c4b44f84e3
Merge branch 'main' into nagilson-linux-single-prompt
2024-01-16 10:16:46 -08:00
Noah Gilson
9ddec9eb53
Merge branch 'main' into nagilson-does-install-still-exist
2024-01-16 09:54:14 -08:00
Noah Gilson
06351db20b
Merge branch 'main' into nagilson-2.0.1-release
2024-01-16 09:53:45 -08:00
Noah Gilson
bbd4d6bb3a
Merge branch 'main' into nagilson-fix-package-mixups
2024-01-16 09:52:50 -08:00
Noah Gilson
d286da855f
Merge pull request #1524 from nagilson/nagilson-intermittent-error-fix
...
Remove Infinite Print Loop After Error, Refactor
2024-01-16 09:45:27 -08:00
Noah Gilson
ef038cd907
begin to add code to spawn a remaining sudo process
2024-01-08 16:47:18 -08:00
Noah Gilson
4b1b817e38
Create a shell process before running the promise function so it can be done async
2024-01-08 13:25:45 -08:00
Noah Gilson
5ebf270493
test to see if proc method is possible
2024-01-08 11:51:36 -08:00
Noah Gilson
9812b4f694
Sanitize extension name to match vscode sudo prompt name requirements
2024-01-08 09:37:40 -08:00
Noah Gilson
701153cf94
dotnet/dotnet is the resolved path, which is expected. use the root dir instead for install comparison
2024-01-08 09:37:29 -08:00
Noah Gilson
efb2661808
expect symlink on ubuntu test only
2024-01-08 09:37:19 -08:00
Noah Gilson
904263cb67
Add symlink reading so we can resolve the global path to its true value to tell the install type of msft pmc or distro feed
2024-01-08 09:37:12 -08:00
Noah Gilson
2b450ce9d7
Merge branch 'nagilson-intermittent-error-fix' into nagilson-fix-package-mixups
2024-01-08 09:36:58 -08:00
Noah Gilson
8f154198b2
Merge branch 'nagilson-does-install-still-exist' into nagilson-2.0.1-release
2024-01-04 16:09:16 -08:00
Noah Gilson
e075c814e4
Update 2.0.1 changelog to add new changes
2024-01-04 16:09:10 -08:00
Noah Gilson
0dfaed6811
Respond to linter
2024-01-04 15:57:12 -08:00
Noah Gilson
58dda4c8ec
Fix existing tests that worked for a long time by pure magic
...
- The acquisition promises were tracking 2 things...
1 is the current working in progress installs.
2 is all installs that were ever done, with the assumption no outside source will ever delete the installs, which is incorrect.
When fixing 2, several tests broke. This is because they relied on the promises to be there even though nothing was installed. We dont actually want to install on the test so we dont change that, instead we add a boolean to fake the thing into thinking an install was laid onto the disk
2024-01-04 15:55:58 -08:00
Noah Gilson
39a8a14bd7
Merge branch 'nagilson-does-install-still-exist' of https://github.com/nagilson/vscode-dotnet-runtime into nagilson-does-install-still-exist
2024-01-04 13:36:31 -08:00
Noah Gilson
c073ed07a3
Merge remote-tracking branch 'origin/nagilson-intermittent-error-fix' into nagilson-does-install-still-exist
2024-01-04 13:36:13 -08:00
Noah Gilson
314fa0fd3f
Merge branch 'main' into nagilson-does-install-still-exist
2024-01-04 13:10:43 -08:00
Noah Gilson
ef29a912a4
Respond to linter
2024-01-04 13:07:31 -08:00
Noah Gilson
f6d006eb0c
Dont color status bar red on cancellation
2024-01-04 12:53:50 -08:00
Noah Gilson
fef303970c
Add a special message for password prompt reject and dont consider it a failure in telemetry, and so we dont print error! on cancellation
2024-01-04 12:46:40 -08:00
Noah Gilson
98dd51cd08
return null to match the spec for the api -- even if it is not a behavioral change
2024-01-04 12:05:05 -08:00
Noah Gilson
0276319b48
Merge w fixed branch
2024-01-04 12:01:22 -08:00
Noah Gilson
db5116ed64
Check command results element instead of the array for truthiness as the old version is a bug
2024-01-04 11:57:28 -08:00
Noah Gilson
cd3f6ef52b
Working windows cancellation message
2024-01-03 15:48:30 -08:00
Noah Gilson
188e53cd4a
Dont count cancelled installs as failures (excluding sudo prompt)
2024-01-03 15:44:22 -08:00
Noah Gilson
e468c21a08
Fix bug where api change caused command line exit code parsing to split a string array
2024-01-03 15:19:35 -08:00
Noah Gilson
8a8f367cc0
Add telemetry to tell if the user did not ever interact with the installer:
2024-01-03 15:02:14 -08:00
Noah Gilson
5198673f27
DO not allow feature band downgrades
2024-01-03 14:35:05 -08:00
Noah Gilson
30fbdca9ed
Add InstallLinuxChecksEvent (I forgot to save lol)
2024-01-03 14:19:07 -08:00
Noah Gilson
0067911da4
add a log message for when we start running install validation on linux
2024-01-03 14:17:43 -08:00
Noah Gilson
77ee724552
Explicitly add event stream to clarify constructor args
2024-01-03 14:08:22 -08:00
Noah Gilson
abc5f1e1de
Make update message show up only if updating not if we are repaiting packages
2024-01-03 13:54:54 -08:00
Noah Gilson
0cc90b707e
capture update stauts instead of output
2024-01-03 13:40:55 -08:00
Noah Gilson
03d7a78def
Improve logging messages so we can tell if users click thru the sudo prompts
2024-01-03 13:30:59 -08:00
Noah Gilson
e626f291e3
improve logic for detecting update and add update msg
2024-01-03 13:24:43 -08:00
Noah Gilson
83d2d7d8ef
Sanitize extension name to match vscode sudo prompt name requirements
2024-01-03 11:32:41 -08:00