5ebf270493
test to see if proc method is possible
2024-01-08 11:51:36 -08:00
9812b4f694
Sanitize extension name to match vscode sudo prompt name requirements
2024-01-08 09:37:40 -08:00
701153cf94
dotnet/dotnet is the resolved path, which is expected. use the root dir instead for install comparison
2024-01-08 09:37:29 -08:00
efb2661808
expect symlink on ubuntu test only
2024-01-08 09:37:19 -08:00
904263cb67
Add symlink reading so we can resolve the global path to its true value to tell the install type of msft pmc or distro feed
2024-01-08 09:37:12 -08:00
2b450ce9d7
Merge branch 'nagilson-intermittent-error-fix' into nagilson-fix-package-mixups
2024-01-08 09:36:58 -08:00
8f154198b2
Merge branch 'nagilson-does-install-still-exist' into nagilson-2.0.1-release
2024-01-04 16:09:16 -08:00
e075c814e4
Update 2.0.1 changelog to add new changes
2024-01-04 16:09:10 -08:00
0dfaed6811
Respond to linter
2024-01-04 15:57:12 -08:00
58dda4c8ec
Fix existing tests that worked for a long time by pure magic
...
- The acquisition promises were tracking 2 things...
1 is the current working in progress installs.
2 is all installs that were ever done, with the assumption no outside source will ever delete the installs, which is incorrect.
When fixing 2, several tests broke. This is because they relied on the promises to be there even though nothing was installed. We dont actually want to install on the test so we dont change that, instead we add a boolean to fake the thing into thinking an install was laid onto the disk
2024-01-04 15:55:58 -08:00
39a8a14bd7
Merge branch 'nagilson-does-install-still-exist' of https://github.com/nagilson/vscode-dotnet-runtime into nagilson-does-install-still-exist
2024-01-04 13:36:31 -08:00
c073ed07a3
Merge remote-tracking branch 'origin/nagilson-intermittent-error-fix' into nagilson-does-install-still-exist
2024-01-04 13:36:13 -08:00
314fa0fd3f
Merge branch 'main' into nagilson-does-install-still-exist
2024-01-04 13:10:43 -08:00
ef29a912a4
Respond to linter
2024-01-04 13:07:31 -08:00
f6d006eb0c
Dont color status bar red on cancellation
2024-01-04 12:53:50 -08:00
fef303970c
Add a special message for password prompt reject and dont consider it a failure in telemetry, and so we dont print error! on cancellation
2024-01-04 12:46:40 -08:00
98dd51cd08
return null to match the spec for the api -- even if it is not a behavioral change
2024-01-04 12:05:05 -08:00
0276319b48
Merge w fixed branch
2024-01-04 12:01:22 -08:00
db5116ed64
Check command results element instead of the array for truthiness as the old version is a bug
2024-01-04 11:57:28 -08:00
cd3f6ef52b
Working windows cancellation message
2024-01-03 15:48:30 -08:00
188e53cd4a
Dont count cancelled installs as failures (excluding sudo prompt)
2024-01-03 15:44:22 -08:00
e468c21a08
Fix bug where api change caused command line exit code parsing to split a string array
2024-01-03 15:19:35 -08:00
8a8f367cc0
Add telemetry to tell if the user did not ever interact with the installer:
2024-01-03 15:02:14 -08:00
5198673f27
DO not allow feature band downgrades
2024-01-03 14:35:05 -08:00
30fbdca9ed
Add InstallLinuxChecksEvent (I forgot to save lol)
2024-01-03 14:19:07 -08:00
0067911da4
add a log message for when we start running install validation on linux
2024-01-03 14:17:43 -08:00
77ee724552
Explicitly add event stream to clarify constructor args
2024-01-03 14:08:22 -08:00
abc5f1e1de
Make update message show up only if updating not if we are repaiting packages
2024-01-03 13:54:54 -08:00
0cc90b707e
capture update stauts instead of output
2024-01-03 13:40:55 -08:00
03d7a78def
Improve logging messages so we can tell if users click thru the sudo prompts
2024-01-03 13:30:59 -08:00
e626f291e3
improve logic for detecting update and add update msg
2024-01-03 13:24:43 -08:00
83d2d7d8ef
Sanitize extension name to match vscode sudo prompt name requirements
2024-01-03 11:32:41 -08:00
058f56ec4c
dotnet/dotnet is the resolved path, which is expected. use the root dir instead for install comparison
2024-01-03 11:19:58 -08:00
45d8df923d
expect symlink on ubuntu test only
2024-01-03 11:13:38 -08:00
2b8e3fa137
Add symlink reading so we can resolve the global path to its true value to tell the install type of msft pmc or distro feed
2024-01-03 10:27:30 -08:00
c560ef05e1
Merge branch 'nagilson-intermittent-error-fix' into nagilson-2.0.1-release
2024-01-02 16:34:40 -08:00
595003df38
Prepare for 2.0.1
2024-01-02 16:34:09 -08:00
32e18e8fd0
Update test to use new directory
2024-01-02 16:24:11 -08:00
aed689deea
Use /share/ instead of /bin/
...
The /bin/ folder is a symlink that gets used by both distro support types, PMC and Distro Built In.
I got confirmation from Cannonical that lib is where they always put their files and we should expect our PMC debs to place them into share. This is a much simpler change that reading the symlink
2024-01-02 16:22:15 -08:00
da826b5641
Add a nice explanatory comment for why a new error type was added
2024-01-02 16:11:35 -08:00
f98011b96d
Respond to linter
2024-01-02 15:58:04 -08:00
eb0e3c7d07
Add ability for tests to use a custom install directory
2024-01-02 15:54:39 -08:00
beb8ada0ef
Dont fail telemetry test if vscode telemetry is disabled
2024-01-02 15:21:28 -08:00
05551cd445
Fix unit tests expecting old data
...
The code changes that adopted the event stream were unnecessary and complicated. It is not that hard to update the version and arch of the same worker and re use it, in fact not doing so defeats the purpose
of these tests in someways.
More importantly we safe guard against an undefined proxy setting in the web worker.
2024-01-02 11:34:42 -08:00
14fa8e7122
Merge branch 'nagilson-intermittent-error-fix' of https://github.com/nagilson/vscode-dotnet-runtime into nagilson-intermittent-error-fix
2024-01-02 10:19:14 -08:00
e39dc40bb0
Merge branch 'main' into nagilson-intermittent-error-fix
2024-01-02 10:13:49 -08:00
58f879b0f8
Merge remote-tracking branch 'upstream/main' into nagilson-intermittent-error-fix
2024-01-02 10:08:46 -08:00
3a042f755c
Merge pull request #1590 from nagilson/nagilson-fix-first-run-1804
...
Add PMC Feed Earlier & Fix PMC Feed Addition with Apt-Cache
2024-01-02 10:06:33 -08:00
18d1d17b53
Migrate to optional installkey for all errors
...
Some errors can be thrown in contexts without a version to acquire such as the install linux dependencies command. Using ! is an anti pattern and removes type safety. We just need to make sure the install key is included everywhere we error from the acquisition context, which I do believe is the case, otherwise this fix will not work in those edge cases
The other thing to note here is how I added the version being set in the mock acquisition worker... the version is set by the extension in extension.ts but this does not happen in unit tests so we needed to add that logic now that everyone needs an acquisition context to be happy
2023-11-28 15:51:55 -08:00
dd9e8585b7
update web worker to usinstallkeys
2023-11-28 14:31:22 -08:00
Noah Gilson
Noah Gilson