* Fix formatting and improve coverage on some Unit Tests
Add missung argName in WindowsFormApplicationBase
* Fix type as type declarations
Add using for VBInpurBox
* PR Feedback
* Remove unneccessary imports
* revert import removal
* Rename resourceID to reflect its use as a ResourceKey
Use existing NullAndEmptyStringDataAttribute
Related #10773
Proposed changes
Add unit test PictureBoxActionListTests.cs for public properties and method of the PictureBoxActionList.
Enable nullability in PictureBoxActionList.
Adds coverage for ImageIndexEditor
Related #10773
## Proposed changes
- Adds coverage for public properties and methods of the
`ImageIndexEditor` class.
## Customer Impact
- None
## Regression?
- No
## Risk
- Minimal
## Test methodology
- Unit tests
## Test environment(s)
- 9.0.100-rc.1.24452.12
Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <v-rbossan@microsoft.com>
Added the full set of runtime assemblies with (hopefully) the right keys. Test assemblies will eventually need added.
I've introduced constants for the public key values to make this a little easier to update / follow. I didn't update all of the usages, anyone else can do so, or I'll eventually pick it off when it is convenient.
This also moves some interop down to Core and does some renaming. It is intentional that I did not change the name of some of the files to allow history to be easily kept. I'll update names to match in future pulls.
* Improve code coverage for FileLogTraceListener
* Update src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/FileLogTraceListenerTests.cs
Thanks I had no idea about boolData
Co-authored-by: Loni Tra <lonitra@microsoft.com>
---------
Co-authored-by: Loni Tra <lonitra@microsoft.com>
* Add XML Comments related to FileSystemProxy which includes SpecialDirectoriesProxy
* Fix some types
* Add some language keywords
* Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb
Co-authored-by: Loni Tra <lonitra@microsoft.com>
* Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb
Co-authored-by: Loni Tra <lonitra@microsoft.com>
* Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb
Co-authored-by: Loni Tra <lonitra@microsoft.com>
* Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb
Co-authored-by: Loni Tra <lonitra@microsoft.com>
* PR feedback
* Update all XML comments
* Fix Typo in FileSystemProxy that caused build to fail.
* Update XML Coments
* Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/SpecialDirectoriesProxy.vb
Co-authored-by: Tanya Solyanik <tanyaso@microsoft.com>
* Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/SpecialDirectoriesProxy.vb
Co-authored-by: Tanya Solyanik <tanyaso@microsoft.com>
* Redo all the comments in SpecialDirectoriesProxy
* Add cref per PR feedback and changed type to Namespace
* PR Feedback to add see cref's
---------
Co-authored-by: Loni Tra <lonitra@microsoft.com>
Co-authored-by: Tanya Solyanik <tanyaso@microsoft.com>
* Moved to SDK RC2 to get the same build errors in VS and CLI build and be able to fix them.
Before this change the IntPreview version of VS was correctly complaining about a redundant cast(IDE0004) in ToolStrip.cs
g.DrawLines(SystemPens.ControlText, (ReadOnlySpan<Point>)
[
new(verticalBeamStart, _lastInsertionMarkRect.Y), new(verticalBeamStart, _lastInsertionMarkRect.Bottom - 1),
new(verticalBeamStart + 1, _lastInsertionMarkRect.Y), new(verticalBeamStart + 1, _lastInsertionMarkRect.Bottom - 1)
]);
But the CLI build required this cast.
After the upgrade to RC2, IDE0300 - Collection initialization can be simplified - became more robust and required code fixes that use collection expressions applied to the solution.
Need a bottom level interop assembly in WPF to give all projects a common base so that CsWin32 doesn't generate duplicate defines.
WindowsBase might be able to subsume this at some point, but it doesn't have internals visible to the rest of the graph and it's current internal interop is included repeatedly in multiple assemblies.
* Enable Central Package Management (CPM)
* Move versions to D.P.p
* Add import
* Add package source mapping
* Alpha-order PackageVersion elements
* Remove old feeds
* Add LF to EOF
* Fix typos
* Switch back to properties for versions
* Update package source mapping
* Add GPF folder
* Add xunit.assert back
* Remove local directory
* Add more mappings
* Add PrivateAssets attribute, per suggestion
* Do not add a <PackageVersion /> for xunit.assert for test projects
Arcade is adding an implicit reference to xunit.assert for all test projects so this PackageVersion is only needed when a non-test project references it. This conditions out the reference to avoid the NU1009 error.
* Add references from CodeCoverage.proj
* Categorize packages
* Update MicrosoftCodeAnalysisNetAnalyzersVersion to stable version
* Pin dependencies
* Remove comments
---------
Co-authored-by: Jeff Kluge <jeffkl@microsoft.com>
In language version preview, the 'field' keyword binds to a synthesized backing field for the property. To avoid generating a synthesized backing field, and to refer to the existing member, use 'this.field' or '@field' instead.
Fixes#12187 in .NET 9.0 release
Revert "Makes DataGridView row header left border have proper luminosity in RightToLeft mode, both with VisualStyles enabled or disabled" commit 9bda02d. This change regresses the color contrast issue that we will re-do in NET10. Besides this regression, the original fix was incomplete, as it applied only to RightToLeft layout.
Customer Impact
Customer will observe visual difference between NET8 and NET9.
While fixing a color contrast issue #5961 in .NET9, we regressed a customization scenario where dev sets a custom DataGridView grid color. The grid color now partially shows in the column header bar. It should be applied only to the regular DGV cells.
Regression
Yes
Testing
Manual testing
Risk
Low. This is a revert to the NET8.0 state.
This actually removes one of the legacy methods, so yay progress.
In Form the owned forms set is now a List<Form> rather than a manually managed array.
Most of the changes are in DataGridView this time.
- Clearing DefaultHeaderCellType (to default) by setting null is something we should allow
- We shouldn't faciliate storing non AccessibleObjects
- Minor optimization tweak to AddOrRemoveValue
- Tweak AddOrRemoveValue for perf and null correctness
- Clarify logic in AddOrRemoveValue and add exception message to cast error
Related #10773
Add unit test TextBoxActionListTests.cs for public properties and method of the TextBoxActionList.
Enable nullability in TextBoxActionList.
Loni Tra
Paul M Cohen
Leaf Shi
v-olzhan
dotnet-maestro[bot]
Syareel Aiman
Ricardo Bossan
Jeremy Kuhne
Rich Lander
Tanya Solyanik
v-zhgl
Melon Wang1