Stanley Goldman
1ddfe074fe
Merge branch 'master' into build-cross-check
2018-10-02 12:54:02 -04:00
Steven Kirk
c6d7304db7
Merge pull request #1955 from github/refactor/move-views
...
Refactor: Move views to GitHub.VisualStudio.UI
2018-10-02 10:50:06 +02:00
Steven Kirk
d9ab704a87
Merge branch 'master' into refactor/move-views
2018-10-02 10:35:04 +02:00
Jamie Cansdale
13a2da02fc
Merge pull request #1965 from github/bump-version
...
Bump version to 2.5.7
2018-10-01 16:24:11 +01:00
Jamie Cansdale
01a04ed467
Bump version to 2.5.7
2018-10-01 15:46:59 +01:00
Meaghan Lewis
1f239cda11
Merge pull request #1943 from github/docs-changes
...
Documentation updates
2018-10-01 07:19:05 -07:00
Jamie Cansdale
e953a1a530
Merge branch 'master' into docs-changes
2018-09-28 17:07:25 +01:00
Jamie Cansdale
6e1a1a2023
Update highlighting
2018-09-28 17:02:06 +01:00
Steven Kirk
ae9b7083fc
Merge branch 'master' into refactor/move-views
...
Conflicts:
src/GitHub.VisualStudio.UI/Views/Dialog/Clone/RepositoryCloneView.xaml
2018-09-28 17:02:12 +02:00
Meaghan Lewis
dfb4795123
change assignable user to pull request author
2018-09-27 12:57:09 -07:00
Meaghan Lewis
bc6ba9ebb7
Specify alternate ways to open clone dialog
2018-09-27 12:54:10 -07:00
Stanley Goldman
34b1fe8226
Merge pull request #1958 from github/l10n_master
...
New Crowdin translations
2018-09-27 15:27:40 -04:00
EditorToolsTranslationBot
440c2eb9b4
New translations Resources.resx (Chinese Simplified)
2018-09-27 14:02:11 -04:00
EditorToolsTranslationBot
3cabc8a938
New translations Resources.resx (Chinese Simplified)
2018-09-27 13:12:03 -04:00
Jamie Cansdale
b582064b84
Merge pull request #1919 from github/feature/open-from-uri-clone-ui
...
Unified Clone / Open from GitHub UI
2018-09-27 18:05:22 +01:00
Jamie Cansdale
37e9acfee4
Merge branch 'master' into feature/open-from-uri-clone-ui
2018-09-27 17:09:08 +01:00
Jamie Cansdale
b18919605e
Merge pull request #1956 from github/metrics/NumberOfClonesToDefaultClonePath
...
Count the number of clones to the default clone path
2018-09-27 16:37:46 +01:00
Jamie Cansdale
704e421c8b
Collaborators, public repositories and solutions
...
- Add `collaborator` repositories to the types that appear in the list
- Mention that the URL tab can be used to clone a public repositories
- The user now needs to double-click on a solution not a repository
2018-09-27 16:16:41 +01:00
Jamie Cansdale
f5b7a057d7
Add NumberOfClonesToDefaultClonePath unit tests
...
Check that counter is only incremented when user clones a repository
into the default clone path.
2018-09-27 15:23:02 +01:00
Jamie Cansdale
916e2fd99f
Add NumberOfClonesToDefaultClonePath counter
...
Add a counter to record the number of times a repository is cloned to
the DefaultClonePath. This will give us an idea of how often users
bother to change this default and what impact it has on usage.
2018-09-27 15:05:18 +01:00
Jamie Cansdale
ca1a215945
Update ErrorType.ClonedFailed message
...
Changed ClonedFailed to CloneOrOpenFailed.
2018-09-27 14:40:13 +01:00
Jamie Cansdale
cfadc62081
Add unit tests for ValidatePathWarning
...
PathWarning_Is_Set_For_Existing_Clone_At_Destination
PathWarning_Is_Set_For_Repository_With_No_Origin
PathWarning_Is_Set_For_Directory_With_No_Repository
PathWarning_Is_Set_For_Existing_Repository_At_Destination_With_Different_Remote
2018-09-27 14:20:44 +01:00
Jamie Cansdale
5f2012a93e
Update Clone/Open enabled tests
...
Add Open_Is_Enabled_When_Path_DirectoryExists test
Fix/update some other tests
2018-09-27 12:41:00 +01:00
Jamie Cansdale
43162dbf60
Factor out magical strings
2018-09-27 12:14:07 +01:00
Jamie Cansdale
27e13d2e02
Refined wording of local path warnings
2018-09-27 12:03:49 +01:00
Jamie Cansdale
d789c4ed61
Show warning when local clone already exists
...
"You have already cloned to this location. Click 'Open' to open the
local repository."
2018-09-27 11:04:34 +01:00
Steven Kirk
0210df09d8
Merge branch 'master' into docs-changes
2018-09-27 11:59:20 +02:00
Jamie Cansdale
7344458588
Convert strings to resources
2018-09-27 10:19:04 +01:00
Jamie Cansdale
f1ba0d2bdf
Revert "Don't run XliffTasks targets during NCrunch build"
...
This reverts commit c37522ba39
.
Fixed in https://github.com/github/VisualStudio/pull/1953 instead
2018-09-26 23:22:02 +01:00
Stanley Goldman
6de1bbbedc
Merge branch 'master' into feature/open-from-uri-clone-ui
2018-09-26 17:21:20 -04:00
Stanley Goldman
43ba772464
Fixing another test
2018-09-26 17:20:37 -04:00
Stanley Goldman
09347ae5a7
Fixing test
2018-09-26 17:18:10 -04:00
Jamie Cansdale
3d2b580608
Consolidate PathError into PathWarning
...
There was an issue with PathError appearing at the top. When the error
appeared, the repository list would move down causing a different
repository to be selected. This would clause flickering between two
repositories.
This commit consolidates PathError into PathWarning (which appears
above the path which is being validated). This avoids the flicker and
puts the warning next to the text box which it applies to.
The logic to block clone or open when there is a file in the way has
been moved to the commands' `canExecute` observable.
2018-09-26 14:41:15 +01:00
Steven Kirk
fa01f84c1b
Merge branch 'master' into refactor/move-views
2018-09-26 15:19:53 +02:00
Jamie Cansdale
527b1d134f
Sanity check local repository
...
Check the following conditions:
- Local repository exists at path
- Local repository has an 'origin' remote
- Local repository's URL matches selected repository
2018-09-26 13:48:57 +01:00
Jamie Cansdale
efe148dd37
Merge pull request #1950 from github/fixes/1948-search-white-space
...
Fix for crash when search includes white-space
2018-09-26 10:22:08 +01:00
Meaghan Lewis
e0f04a70b9
Merge branch 'docs-changes' of https://github.com/github/VisualStudio into docs-changes
2018-09-25 14:27:15 -07:00
Meaghan Lewis
7c88f1f70a
make suggested edits
2018-09-25 14:26:44 -07:00
Stanley Goldman
0d8c7c78ac
Integrating msbuildlog
2018-09-25 16:46:03 -04:00
Stanley Goldman
0929fb26e1
Creating binary log file output
2018-09-25 16:42:24 -04:00
Jamie Cansdale
5913776cd1
Merge branch 'master' into fixes/1948-search-white-space
2018-09-25 19:04:26 +01:00
Jamie Cansdale
3172217b3f
Merge branch 'master' into feature/open-from-uri-clone-ui
2018-09-25 16:20:23 +01:00
Jamie Cansdale
9f8757a012
Update DestinationAlreadyExists warning
...
Change to "A file exists at the destination path."
2018-09-25 15:48:11 +01:00
Stanley Goldman
d5d223ad10
Merge pull request #1953 from github/another-ncrunch-fix
...
Including the xlf files in ncrunch's build
2018-09-25 10:27:41 -04:00
Jamie Cansdale
8067273b31
Increment NumberOf*Opens counters
...
Increment NumberOfGitHubOpens and NumberOfEnterpriseOpens counters when
CloneOrOpenRepository is called.
2018-09-25 15:14:22 +01:00
Jamie Cansdale
af55f6a282
Add tests for NumberOf*Opens counters
...
Expect to fail on this commit.
2018-09-25 15:07:02 +01:00
Stanley Goldman
38dae46243
Using a wildcard instead
2018-09-25 09:56:00 -04:00
Jamie Cansdale
d91c9ab8eb
Increment new counters in CloneOrOpenRepository
...
Increment new NumberOfGitHubClones and NumberOfEnterpriseClones
counters in CloneOrOpenRepository but not CloneRepository.
2018-09-25 14:53:33 +01:00
Stanley Goldman
67366d7ef0
Including the xlf files in ncrunch
2018-09-25 09:46:01 -04:00
Jamie Cansdale
451a5b0303
Only increment NumberOfClones during clone
...
It appears that CloneRepository is also called when a new repository is
created. Only increment the new counters during CloneOrOpenRepository.
2018-09-25 14:43:04 +01:00