1.3.4

CHANGELOG.md

@@ -1,10 +1,14 @@
+== 1.3.4
+
+* Fix issue in IE 8 and below or IE 9 in quirksmode where comment nodes were incorrectly being handled
+
 == 1.3.3
 
-Fix encryptForm so it can be called any number of times, as before 1.3.1
+* Fix encryptForm so it can be called any number of times, as before 1.3.1
 
 == 1.3.2
 
-Fix problem with select elements introduced in 1.3.1
+* Fix problem with select elements introduced in 1.3.1
 
 == 1.3.1
 

lib/braintree.js

@@ -8,7 +8,7 @@
 
 var Braintree = {
   sjcl: sjcl,
-  version: "1.3.3"
+  version: "1.3.4"
 };
 
 Braintree.generateAesKey = function () {
@@ -93,7 +93,7 @@ Braintree.EncryptionClient = function (publicKey) {
     for (i = 0; i < children.length; i++) {
       child = children[i];
 
-      if (child.attributes["data-encrypted-name"]) {
+      if (child.nodeType === 1 && child.attributes["data-encrypted-name"]) {
         found.push(child);
       } else if (child.children.length > 0) {
         found = found.concat(findInputs(child));

spec/braintree_form_spec.js

@@ -9,8 +9,10 @@ describe("Braintree#form", function() {
                 "<input type='text' data-encrypted-name='credit-card-cvv' value='cvv' />" +
                 "<input type='text' name='card-holder-first-name' value='bob' />" +
                 "<input name='expiration-month' value ='May'/>" +
+                "<!-- example comment -->"+
                 "<select data-encrypted-name='expiration-year'><option value='2013'>2013</option></select>" +
                 "<div id ='foo'>" +
+                "  <!-- example comment -->"+
                 "  <input data-encrypted-name ='credit-card-expiration-date' class='encrypted' value ='May'/>" +
                 "</div>" +
                 "<input type=\"submit\" id=\"click_me\" />" +