Apply suggestions from code review

Co-authored-by: Marco Gario  <marcogario@github.com>
This commit is contained in:
Rasmus Wriedt Larsen 2020-09-24 15:36:00 +02:00 коммит произвёл GitHub
Родитель 34955967b7
Коммит 6645c550ef
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
2 изменённых файлов: 2 добавлений и 3 удалений

Просмотреть файл

@ -30,7 +30,6 @@ def suppress_stdout_stderr():
def get_extractor_version(codeql_base_dir: str, quiet: bool = True) -> int:
extractor_dir = os.path.join(codeql_base_dir, 'python', 'tools')
sys.path = [extractor_dir] + sys.path
@ -50,4 +49,4 @@ def get_extractor_version(codeql_base_dir: str, quiet: bool = True) -> int:
if __name__ == "__main__":
codeql_base_dir = sys.argv[1]
version = get_extractor_version(codeql_base_dir)
print('{!r}'.format(version))
print('{!r}'.format(version))

Просмотреть файл

@ -21,7 +21,7 @@ python3 -m pip install --user virtualenv
# venv is required for installation of poetry or pipenv (I forgot which)
sudo apt-get install -y python3-venv
# We're install poetry with pip instead of the recommended way, since the recommended way
# We install poetry with pip instead of the recommended way, since the recommended way
# caused some problem since `poetry run` gives output like:
#
# /root/.poetry/lib/poetry/_vendor/py2.7/subprocess32.py:149: RuntimeWarning: The _posixsubprocess module is not being used. Child process reliability may suffer if your program uses threads.