Henry Mercer
6ba0a36550
Add JSDoc for `mockDownloadApi`
2023-01-11 15:25:21 +00:00
Henry Mercer
4a918790cd
Merge branch 'main' into henrymercer/fix-ghae-setup-test
2023-01-11 15:23:04 +00:00
Andrew Eisenberg
e009918fbc
Merge branch 'main' into aeisenberg/externalRepoTokenConfigParsing
2023-01-10 12:43:37 -08:00
Henry Mercer
70a288daae
Merge branch 'main' into henrymercer/fix-ghae-setup-test
2023-01-10 20:37:40 +00:00
Andrew Eisenberg
272d916f23
Address comments from PR
2023-01-10 12:17:26 -08:00
Henry Mercer
28a9b2d6d7
Add a note regarding the `sinon` workaround
2023-01-10 19:43:23 +00:00
Henry Mercer
9f8ddbdfd7
Fix GHAE CodeQL setup test
2023-01-10 19:36:29 +00:00
Henry Mercer
9203e314a3
Improve CodeQL setup test structure and naming
2023-01-10 19:35:21 +00:00
Dave Bartolomeo
bac4fe1a38
Merge branch 'main' into dbartol/bundle-20230105
2023-01-10 09:31:07 -05:00
Robert
166d98c19e
Merge pull request #1465 from github/robertbrignull/upload_database_stream
...
Use a stream when uploading database contents
2023-01-09 12:37:54 +00:00
Robert
a9337bc304
Close stream after use
2023-01-09 11:00:43 +00:00
Andrew Eisenberg
4023575d64
Send the external repository token to the CLI
...
This commit does a few related things:
1. Bumps the minimum version for cli config parsing to 2.10.6
2. Ensures that if cli config parsing is enabled, then remove repos
are _not_ downloaded by the action. It happens in the CLI.
3. Passes the `--external-repository-token-stdin` option to the CLI
and passes the appropriate token via stdin if cli config parsing is
enabled.
2023-01-06 14:46:28 -08:00
Henry Mercer
cf1437a514
Merge pull request #1462 from github/henrymercer/refactor-codeql-setup
...
Refactor CodeQL setup
2023-01-06 17:36:02 +00:00
Dave Bartolomeo
f9c9a2567c
Rebuild
2023-01-06 12:32:23 -05:00
Dave Bartolomeo
b9c859bfa1
Merge branch 'main' into dbartol/bundle-20230105
2023-01-06 11:56:06 -05:00
Angela P Wen
b4187d626b
Add CLI version field and prior release fields to `defaults` file ( #1463 )
...
* Add CLI version field to `defaults` file
* Add fields for prior CLI version
2023-01-06 08:24:28 -08:00
Dave Bartolomeo
4e5a06f009
Update to CoideQL bundle 20230105 (2.12.0)
2023-01-06 10:55:46 -05:00
Robert
e8f7169839
Move database bundling to inside the try-catch
2023-01-06 15:28:25 +00:00
Robert
6ce923c375
Use a stream when uploading database contents
2023-01-06 15:16:51 +00:00
Henry Mercer
b2b478264a
Improve logging around authorization headers
2023-01-06 12:28:54 +00:00
Henry Mercer
5eba74a3c9
Refactor CodeQL setup
2023-01-05 19:09:34 +00:00
Henry Mercer
4789c1331c
Add more tests for uploading failed SARIF
...
Test results directly via return value of `testFailedSarifUpload` vs
via checking log messages.
2022-12-22 18:48:59 +00:00
Henry Mercer
59ebabde5d
Remove redundant log messages
2022-12-22 18:47:52 +00:00
Henry Mercer
3224214d91
Improve method naming
2022-12-22 18:33:06 +00:00
Henry Mercer
e09fbf5b4a
Demote upload failed SARIF run info statements to debug
...
We now report errors via telemetry, and this feature will shortly be
enabled by default.
2022-12-21 11:41:36 +00:00
Henry Mercer
e9ff99b027
Improve error message when workflow file doesn't exist
2022-12-21 11:40:31 +00:00
Henry Mercer
8b9e982393
Add a better log message for reusable workflow calls
2022-12-21 11:40:31 +00:00
Henry Mercer
8d1e008ecb
Check for successful completion rather than SARIF upload
...
This doesn’t affect the overall behaviour, but means we can
short-circuit slightly more quickly when `analyze` is passed
`upload: false`.
2022-12-21 11:40:31 +00:00
Orhan Toy
d58039a1e3
Merge pull request #1435 from github/orhantoy/add-CODE_SCANNING_REF-tests
...
Add tests for CODE_SCANNING_REF
2022-12-13 23:10:53 +01:00
Orhan Toy
b7028afcb4
Make sure env is reset between tests
2022-12-13 12:18:40 +00:00
Henry Mercer
f629dada4c
Merge branch 'main' into henrymercer/use-codeql-2.11.6
2022-12-13 12:15:58 +00:00
Orhan Toy
ccee4c68ff
Add tests for CODE_SCANNING_REF
2022-12-13 11:51:16 +00:00
Henry Mercer
899bf9c076
Merge pull request #1432 from github/henrymercer/init-post-telemetry
...
Add telemetry for uploading failed runs
2022-12-12 18:45:41 +00:00
Henry Mercer
dd7c3ef80e
Remove debugging log statements
2022-12-12 17:59:20 +00:00
Henry Mercer
b7b875efff
Reuse existing fields in post-init status report
2022-12-12 17:54:33 +00:00
nickfyson
54d25f56dd
use .has for searchParams instead of checking for undefined
2022-12-12 16:03:07 +00:00
nickfyson
d827cf3d65
remove use of query-string package
2022-12-12 14:50:10 +00:00
Henry Mercer
5aced81848
Update bundle version to `codeql-bundle-20221211`
2022-12-12 13:10:58 +00:00
Henry Mercer
118e294bb9
Record the stack trace if applicable
2022-12-09 10:35:28 +00:00
Henry Mercer
dc9c1c1a51
Add regression test for `upload: false`
2022-12-09 10:35:28 +00:00
Henry Mercer
a409f43c7a
Handle non-string `with` inputs
2022-12-09 10:35:28 +00:00
Henry Mercer
e67ad6aaed
Add telemetry for uploading failed runs
2022-12-09 10:35:19 +00:00
Chuan-kai Lin
c51babb6c6
Merge branch 'main' into cklin/codeql-cli-2.11.5
2022-12-07 08:33:58 -08:00
Henry Mercer
79166d0788
Merge pull request #1420 from github/henrymercer/failed-runs-fix-action-not-found
...
Fix failed SARIF upload behavior when the workflow doesn't call the CodeQL Action
2022-12-07 08:48:11 +00:00
Henry Mercer
384a214d60
Allow testing workflow parsing functionality from PR checks
2022-12-06 18:37:25 +00:00
Henry Mercer
697ed97fa5
Factor out some code in post-init tests
2022-12-06 18:23:55 +00:00
Henry Mercer
2207a72006
Downgrade log severity when we can't upload a failed SARIF file
...
This isn't severe enough to appear on the Actions summary.
2022-12-06 18:18:07 +00:00
Henry Mercer
4623c8edb6
Make `getInputOrThrow` throw when it can't find any calls to the Action
...
This created unexpected behavior with a workflow calling
`codeql-action/analyze` locally.
Therefore, be more conservative with parsing inputs from workflows and
refuse to parse jobs that don't call the specified Action exactly once.
2022-12-06 18:13:47 +00:00
Henry Mercer
9085295c40
Add regression test
2022-12-06 17:59:14 +00:00
Henry Mercer
2cbc140ac5
Enable file baseline export by default
...
This is now fully rolled out.
2022-12-05 14:10:06 +00:00
Chuan-kai Lin
1e5919b22d
Bump default CodeQL version to 2.11.5
2022-12-02 07:38:17 -08:00
Henry Mercer
375dacad24
Only print the full error message in debug mode
2022-12-02 14:38:40 +00:00
Henry Mercer
e0ff272230
Merge branch 'main' into henrymercer/report-failed-runs
2022-12-02 14:31:22 +00:00
Angela P Wen
aa0e650c6a
Surface fatal CLI errors in `interpret-results` and `run-queries` ( #1407 )
...
Co-authored-by: Henry Mercer <henry.mercer@me.com>
2022-12-02 14:05:21 +01:00
Henry Mercer
98b2ddc7f9
Merge branch 'main' into henrymercer/report-failed-runs
2022-12-01 18:27:32 +00:00
Henry Mercer
0d9b15ca93
Merge pull request #1392 from github/henrymercer/parse-category
...
Add functionality for parsing Action inputs from a workflow file
2022-12-01 18:26:03 +00:00
Angela P Wen
9af9a11da8
Stop running fallback Go autobuild if database is finalized ( #1405 )
2022-12-01 11:29:03 +01:00
Henry Mercer
3d90c4f911
Improve error message when failed SARIF file doesn't process as expected
2022-11-30 11:27:03 +00:00
Andrew Eisenberg
1384ce4ab3
Fixes spurious error messages in tests
...
Previously, `isAnalyzingDefaultBranch` was failing because there are
some missing env vars: `GITHUB_SHA`, `GITHUB_REF`, and
`GITHUB_EVENT_PATH`. Also, `checkout_path` is missing as an input.
Rather than trying to set them to mock values, which would require
setting the paths to existing paths in the file system, I chose to stub
the entire function. I think this is fine since the point of the test
is to check the ram and threads values, not testing the
`isAnalyzingDefaultBranch` function.
2022-11-29 10:53:11 -08:00
Henry Mercer
58b2ab08a8
Add unit test for typical workflow
2022-11-29 17:03:01 +00:00
Henry Mercer
e0dec83cfc
Explicitly mention surrounding by try/catch in JSDoc
2022-11-29 16:29:27 +00:00
Henry Mercer
00a3c456fb
Always wait for processing when uploading a failed SARIF file
2022-11-29 16:27:04 +00:00
Henry Mercer
e628ee0ae1
Push unsuccessful execution API error detection into upload library
2022-11-29 16:25:29 +00:00
Henry Mercer
605b23d10b
Explicitly suggest wrapping in a try/catch block
2022-11-29 15:48:54 +00:00
Henry Mercer
d0517be03a
Ensure we finish the log group when waiting for processing
2022-11-25 17:55:01 +00:00
Henry Mercer
37b4358e44
Handle API versions that reject unsuccessful executions
2022-11-25 17:55:00 +00:00
Henry Mercer
122b180b66
Add an integration test for uploading SARIF when the run fails
2022-11-25 17:54:22 +00:00
Henry Mercer
8337c2be0f
Only upload failed SARIF if the run failed
2022-11-25 17:53:32 +00:00
Henry Mercer
5296a763b1
Upload failed SARIF files to Code Scanning
2022-11-25 17:52:50 +00:00
Henry Mercer
3afc2b194c
Add feature flag for uploading failed SARIF
2022-11-25 17:49:03 +00:00
Henry Mercer
3cf2a1ba2e
Add function for retrieving the "upload" input
2022-11-25 17:49:01 +00:00
Henry Mercer
9de6c31571
Log matrix input
2022-11-25 17:47:21 +00:00
Henry Mercer
e2338066a1
Add `diagnostics export` command
2022-11-25 17:47:21 +00:00
Henry Mercer
8f05fcd048
Filter set of possible Action inputs to those from a particular job
...
This better handles cases where customers have a monorepo and have
separate jobs for different components.
2022-11-25 17:40:27 +00:00
Henry Mercer
9f2aa7ec75
Merge branch 'main' into henrymercer/parse-category
2022-11-25 09:58:27 +00:00
Henry Mercer
7e73dedacc
Merge pull request #1394 from github/aeisenberg/bypass-toolcache-kotlin-swift
...
Add a way to bypass the toolcache for kotlin and swift
2022-11-25 09:30:35 +00:00
Andrew Eisenberg
102e01da36
Small refactoring of `shouldBypassToolcache`
2022-11-24 12:33:42 -08:00
Andrew Eisenberg
eb19ecbad1
Add API call for languages if java in input
...
If a user explicitly includes java in their language inputs, always
make an api call to check for kotlin in the repo.
Also, add some suggestions from code reviews.
2022-11-24 11:06:29 -08:00
Alexander Eyers-Taylor
c61f4c61f8
Merge pull request #1391 from github/alexet/update-2.11.4-v2
...
Update default CodeQL bundle version to 2.11.4
2022-11-24 14:23:06 +00:00
Andrew Eisenberg
ad7ca9bf21
Add some new tests and fix some comments
2022-11-23 22:18:12 -08:00
Andrew Eisenberg
f79028af27
Add the feature to bypass the toolcache for kotlin and swift
...
This works by moving the logic to check for toolcache bypass out of
creating the codeql instance. The logic now _may_ perform an API request
in order to check what languages are in the repository. This check is
redundant because the same call is being made later in the action when
the actual list of languages is calculated.
2022-11-23 15:11:20 -08:00
Andrew Eisenberg
5b7c9daecd
Add the bypass_toolcache_kotlin_switft_enabled flag
2022-11-23 12:20:22 -08:00
Henry Mercer
bff0be7364
Generalize `getCategoryInputOrThrow` to arbitrary inputs
2022-11-23 19:27:03 +00:00
Henry Mercer
daf4614f68
Substitute matrix variables into category input
...
This is a common case, so we should handle it.
2022-11-23 19:27:03 +00:00
Henry Mercer
e2d523ca5e
Add function to read the analysis category from a workflow
2022-11-23 19:27:03 +00:00
Henry Mercer
996d04b1e5
Fix a type error affecting later versions of TypeScript
2022-11-23 19:27:03 +00:00
Henry Mercer
79f8286c68
Refactoring: Separate out workflow related functionality
...
No semantic changes.
2022-11-23 19:27:01 +00:00
Alexander Eyers-Taylor
d52e657b2e
Update default CodeQL bundle version to 2.11.4
2022-11-23 18:56:23 +00:00
Henry Mercer
bc341c5dd1
Remove fallback logic for GHES 2.22 when determining Action repository
2022-11-23 18:19:25 +00:00
Henry Mercer
39fe7aa8a1
Remove dead guard for GHES 3.0
2022-11-23 13:57:07 +00:00
Henry Mercer
c719ec0b33
Merge pull request #1389 from github/update-supported-enterprise-server-versions
...
Update supported GitHub Enterprise Server versions.
2022-11-23 10:31:21 +00:00
GitHub
93c6b70dc3
Update supported GitHub Enterprise Server versions.
2022-11-23 00:13:03 +00:00
Henry Mercer
6013661451
Update v1 deprecation date
...
The expected deprecation date of GHES 3.3 has been postponed, so v1 will
now be deprecated in January.
2022-11-22 09:43:07 +00:00
Andrew Eisenberg
4ee97e5e55
Add extra test ensuring env var overrides cached feature flag
2022-11-21 14:30:36 -08:00
Andrew Eisenberg
cfce1c4e19
Rename
2022-11-21 13:42:32 -08:00
Andrew Eisenberg
c29fca48a1
Cache feature flags on disk
...
This will allow feature flags to be shared across steps in the same job,
avoiding an error we saw earlier where the init action had the flag
enabled, but the analyze step had it disabled.
This uses the runner's temp folder to cache the flags file, which will
stick around until the job completes.
2022-11-21 11:14:38 -08:00
Angela P Wen
4fddc51e4f
Support Kotlin for public beta ( #1370 )
2022-11-17 18:38:48 +00:00
Henry Mercer
0f07790b74
Merge pull request #1374 from github/henrymercer/pass-testing-environment
...
Set testing environment for CodeQL workflow
2022-11-16 18:05:00 +00:00
Henry Mercer
a190d3876a
Rename `TEST_MODE` to specific variable for CodeQL Action
...
This allows us to set it automatically in the workflow generator,
simplifying things and reducing the scope for error.
2022-11-16 16:40:30 +00:00
Edoardo Pirovano
bfc56625b0
TRAP Caching: Re-introduce workaround for download timeout
2022-11-16 15:49:52 +00:00
Marco Gario
c939e6615d
Merge pull request #1372 from github/marcogario/prioritize_github_ref
...
Prefer GITHUB_REF to CODE_SCANNING_REF
2022-11-16 12:03:29 +01:00
Henry Mercer
1935d19d61
Merge pull request #1358 from github/henrymercer/require-cli-2.6.3
...
Bump minimum CodeQL bundle version to 2.6.3
2022-11-16 10:37:57 +00:00
Angela P Wen
7484436e5d
Remove Go extraction feature flags ( #1371 )
2022-11-16 10:32:40 +00:00
Marco Gario
0a76b97b28
Prefer GITHUB_REF to CODE_SCANNING_REF
...
Given that the GITHUB_REF is a protected variable, we want to prefer it to
CODE_SCANNING_REF. This should prevent accidentally overwriting these values.
The logic is a bit more involved, as I think it makes sense to raise the error
about GITHUB_REF not being set, rather than mentioning CODE_SCANNING_REF if
both are not set.
2022-11-16 10:49:49 +01:00
Henry Mercer
d48707ce53
Merge branch 'henrymercer/delete-runner-part-2' into henrymercer/require-cli-2.6.3
2022-11-15 20:58:01 +00:00
Henry Mercer
0dea34e91c
Merge branch 'main' into henrymercer/delete-runner-part-2
2022-11-15 19:35:30 +00:00
Henry Mercer
f47c93c5fd
Merge pull request #1363 from github/henrymercer/delete-runner-part-1
...
Delete the runner, part 1
2022-11-15 19:31:28 +00:00
Marco Gario
2bca6af0e5
Read CODE_SCANNING_REF
2022-11-15 15:26:47 +01:00
Henry Mercer
1e2f8f035d
Merge branch 'main' into henrymercer/require-cli-2.6.3
2022-11-14 22:25:31 +00:00
Henry Mercer
0990a34ac8
Merge branch 'main' into henrymercer/delete-runner-part-1
2022-11-14 22:20:41 +00:00
Angela P Wen
5883c13406
Deprecate Go extraction reconciliation feature flag and `CODEQL_EXTRACTOR_GO_BUILD_TRACING` for custom builds ( #1322 )
...
Co-authored-by: Henry Mercer <henry.mercer@me.com>
2022-11-14 13:54:35 -08:00
Henry Mercer
9df773d1a3
Remove unneeded `apiDetails` input to `getApiClient`
2022-11-14 19:55:30 +00:00
Henry Mercer
dac8912e9f
Remove `deriveApiUrl` function only used by runner
2022-11-14 18:59:39 +00:00
Henry Mercer
8ecbaea022
Remove support for empty analysis keys from runner
2022-11-14 18:55:31 +00:00
Henry Mercer
3d46406f3b
Remove runner-only input to `databaseInitCluster`
2022-11-14 18:49:17 +00:00
Henry Mercer
03bb58c07d
Remove note about separation in `actions-util`
...
We could move everything into `util`, but in some ways it is nice having
a file dedicated to Actions related utilities.
2022-11-14 18:46:43 +00:00
Angela P Wen
0eacdb53ad
Support Swift for private beta ( #1350 )
...
Co-authored-by: Henry Mercer <henry.mercer@me.com>
2022-11-14 10:29:05 -08:00
Henry Mercer
8c8a9b1231
Remove auth method only used in runner
2022-11-14 16:39:43 +00:00
Henry Mercer
b498c79130
Remove concept of Actions / runner mode
2022-11-14 16:37:48 +00:00
Henry Mercer
51abddb49b
Delete the runner
2022-11-14 16:23:14 +00:00
Henry Mercer
acbc6ca6e5
Fix a couple of naming nits
2022-11-11 19:00:48 +00:00
Henry Mercer
84e5134df9
Remove lines of code counting in the Action
...
We now only need to support doing this in the CLI.
2022-11-11 19:00:45 +00:00
Henry Mercer
ea990a3118
Remove flags for CLI v2.6.2 and earlier
2022-11-11 18:22:45 +00:00
Henry Mercer
b45e925fe2
Bump minimum version to 2.6.3
2022-11-11 18:00:58 +00:00
Henry Mercer
9452b6b864
Merge branch 'main' into henrymercer/use-codeql-2.11.3
2022-11-11 09:56:50 +00:00
Edoardo Pirovano
d6f6ef4b0b
Force exit of process if a timeout has occurred
2022-11-09 17:28:15 +00:00
Stephan Brandauer
01c4458f0c
use ATM pack v0.4.0 for CLI v2.11.3 and above
2022-11-08 13:53:18 +01:00
Henry Mercer
0e5b04a79a
Merge pull request #1349 from github/henrymercer/improve-focus-when-init-fails
...
Improve experience when init fails before generating a config file
2022-11-08 11:31:43 +00:00
Henry Mercer
f9948ffd0e
Improve experience when init fails before generating a config file
...
Suppose a customer has a run where the init Action failed before saving
a config file.
When the customer opens their Actions logs, the UI currently focuses on
the post init step, since this is the last step that failed.
Demoting the error in the post init Action to a warning means that the
UI will instead focus on the `init` step, which is more useful for
debugging what went wrong.
2022-11-07 18:50:59 +00:00
Henry Mercer
c606252ada
Merge pull request #1329 from github/henrymercer/file-baseline-info-enablement
...
Enable file baseline information behind a feature gate
2022-11-07 18:10:39 +00:00
Henry Mercer
dba70acdb3
Bump default CodeQL version to 2.11.3
2022-11-07 10:40:09 +00:00
Edoardo Pirovano
862a512899
Prune results of Ruby query from SARIF
2022-11-04 14:57:13 +00:00
Henry Mercer
89e18934d3
Forward file baseline information enablement to CLI
2022-11-01 17:10:53 +00:00
Henry Mercer
5da50dc362
Add file baseline information feature
2022-11-01 16:59:38 +00:00
Henry Mercer
cd983e71c6
Merge pull request #1334 from github/henrymercer/better-error-for-glibc
...
Add a better error message for users of CodeQL CLI 2.7.2 and earlier running on `ubuntu-22.04`
2022-11-01 16:51:05 +00:00
Cornelius Riemenschneider
bfcbb093ac
Re-export codeql testing environment variable to subsequent steps, if set.
2022-11-01 13:18:57 +01:00
Cornelius Riemenschneider
4b73c4f99e
Actions status report: Send testing_environment.
...
The testing environment is taken from the environment variable
CODEQL_ACTION_TESTING_ENVIRONMENT.
2022-11-01 13:18:57 +01:00
Henry Mercer
a3141c7a07
Improve error message
2022-10-31 14:19:04 +00:00
Henry Mercer
4b37e17ec1
Check stdout rather than stderr
2022-10-28 18:59:02 +01:00
Henry Mercer
a12a861b82
Add a better error message for users of CodeQL CLI 2.7.2 and earlier
...
Improves the error message for users running (a) CLI 2.7.2 and earlier
and (b) `ubuntu-22.04`, to which `ubuntu-latest` is now being migrated.
Previously this was "undefined symbol: __libc_dlopen_mode, version
GLIBC_PRIVATE".
Now we give some guidance around glibc versions and using the
`ubuntu-20.04` runner image.
2022-10-28 18:38:00 +01:00
Edoardo Pirovano
4b53723d6b
Merge pull request #1320 from github/edoardo/2.11.2-bump
...
Bump default CodeQL version to 2.11.2
2022-10-25 09:41:40 +01:00
Andrew Eisenberg
f1a4ff53b4
Bumps the min version for code scanning config in the cli
...
2.11.1 has a fix in it for parsing query filters.
2022-10-24 09:20:10 -07:00
Edoardo Pirovano
624418cb40
Bump default CodeQL version to 2.11.2
2022-10-24 13:08:52 +01:00
Cornelius Riemenschneider
f3a27d6945
GHES 3.1 has been deprecated end of June 2022.
...
Therefore, we do not need to support the workaround for
action telemetry anymore.
2022-10-18 14:20:52 +02:00
Edoardo Pirovano
2fafb297de
TRAP Caching: Disable on self-hosted runners
2022-10-13 14:31:54 +01:00
Andrew Eisenberg
34d48f825c
Merge remote-tracking branch 'upstream/main' into aeisenberg/ff-refactoring
2022-10-12 08:36:16 -07:00
Edoardo Pirovano
e862e8fc76
Merge pull request #1296 from github/edoardo/improve-docs
...
Improve documentation comment
2022-10-12 08:35:01 +01:00
GitHub
cc00a9d478
Update supported GitHub Enterprise Server versions.
2022-10-12 00:20:41 +00:00
Edoardo Pirovano
082bdf06b5
Improve documentation comment
2022-10-11 22:38:30 +01:00
Edoardo Pirovano
44edb7c4b5
Merge pull request #1293 from github/edoardo/fix-with-timeout
...
Fix `withTimeout` helper function
2022-10-11 21:29:20 +01:00
Henry Mercer
43c3ed9c28
More feature flag renaming
2022-10-11 11:52:55 -07:00
Andrew Eisenberg
701cea34ba
More renaming
2022-10-11 10:39:40 -07:00
Edoardo Pirovano
adb28963c0
Further update to reflect a conversation with @henrymercer
2022-10-11 16:59:48 +01:00
alexet
362f9a2522
Update bundle for 2.11.1
...
This version has the fix applied
2022-10-11 12:05:46 +01:00
Edoardo Pirovano
6e1dab28b6
Fix `withTimeout` helper function
2022-10-11 10:04:21 +01:00
Andrew Eisenberg
6c869f8b03
Fix typos
2022-10-07 16:27:25 -07:00
Andrew Eisenberg
919e4caca1
Merge remote-tracking branch 'upstream/main' into aeisenberg/ff-refactoring
2022-10-07 14:14:09 -07:00
Andrew Eisenberg
1a17c59fb0
More renaming
...
Avoid usage of "Feature Flag" unless we are talking specifically about
the response from github features api. Otherwise, use terms like
"Toggleable features".
Note both "toggleable" and "togglable" appear to be valid spellings of
the word. I chose the first for no good reason.
2022-10-07 11:33:32 -07:00
Andrew Eisenberg
b27aed78f5
Extract GitHubFeatureFlags to a separate class
...
Internal refactoring so that `GitHubFeatureFlags` is
private only. The public facing class is `Features`.
2022-10-06 18:00:40 -07:00
Andrew Eisenberg
5915e70486
Address comments from review
2022-10-06 13:14:06 -07:00
Andrew Eisenberg
6de05e4b24
Rename `FeatureFlag` -> `Feature`
2022-10-06 13:06:10 -07:00
Andrew Eisenberg
b16314e16c
Address comments from review
...
- Change env var name for `MlPoweredQueriesEnabled`
- Throw error if minimumVersion is specified, but CodeQL argument is not
supplied.
- Fix failing tests. Note that I removed a config-utils test because it
is no longer relevant since we handle codeql minimum versions in the
`getValue` function.
2022-10-06 12:29:58 -07:00
Andrew Eisenberg
84dffe700c
Merge pull request #1282 from github/aeisenberg/user-error-source-root
...
Convert "Invalid source root" errors to UserErrors
2022-10-06 10:48:35 -07:00
Andrew Eisenberg
9e044c5432
Convert "Invalid source root" errors to UserErrors
2022-10-06 09:28:29 -07:00
Andrew Eisenberg
e5c3375225
Refactor handling of feature flags
...
This commit centralizes how feature flags are handled. All feature flags
must now add an entry in the `featureFlagConfig` dictionary. This
dictionary associates the flag with an environment variable name and
optionally a minimum version for CodeQL.
The new logic is:
- if the environment variable is set to false: disabled
- if the minimum version requirement specified and met: disabled
- if the environment variable is set to true: enable
- Otherwise check feature flag enablement from the server
2022-10-05 16:40:56 -07:00
Angela P Wen
24c8de16fa
Correctly report CodeQL version when using cache ( #1259 )
...
* Correctly report CodeQL version when using cache
* Add JS generated files
* Add test for return value of `setupCodeQL`
* Fill in missing return value comment
2022-10-05 09:16:42 -07:00
Andrew Eisenberg
5960ce1190
Extract logging statements to separate function
2022-10-03 09:35:40 -07:00
Andrew Eisenberg
6ace05baa3
Add logging statements declaring state of the cli_config_file_enabled
...
It's possible to determine this otherwise, but this makes it easier to
spot.
2022-10-01 12:03:01 -07:00
Edoardo Pirovano
c0641ea1d3
TRAP Caching: Add timeouts to upload/download operations
2022-09-30 13:18:46 +01:00
github-actions[bot]
61b87c69a6
Update supported GitHub Enterprise Server versions. ( #1275 )
...
Co-authored-by: GitHub <noreply@github.com>
2022-09-29 22:37:10 +00:00
Andrew Eisenberg
1ec8ea99ee
Merge branch 'main' into aeisenberg/cli-config-feature-flag
2022-09-28 10:39:05 -07:00
Chuan-kai Lin
a711c7623d
Update default CodeQL version to 2.11.0
2022-09-28 09:04:11 -07:00
Henry Mercer
39064e0f9b
Merge pull request #1272 from github/update-supported-enterprise-server-versions
...
Update supported GitHub Enterprise Server versions.
2022-09-28 10:52:55 +01:00
Edoardo Pirovano
28c63d131f
Merge pull request #1268 from jsoref/rev-parse
...
Correct program name
2022-09-28 09:59:29 +01:00
Josh Soref
a4e4529299
Correct program name
2022-09-27 22:08:31 -04:00
GitHub
cc4ee05a07
Update supported GitHub Enterprise Server versions.
2022-09-28 00:21:45 +00:00
Andrew Eisenberg
cab46c529f
Update src/util.test.ts
2022-09-27 15:49:25 -07:00
Andrew Eisenberg
e37b0d6470
Add the `CliConfigFileEnabled` feature flag
...
Also, wire it up to the `useCodeScanningConfigInCli` function.
2022-09-27 07:58:31 -07:00
Edoardo Pirovano
b96c7546c1
Fix broken unit test
2022-09-26 15:17:36 +01:00
Edoardo Pirovano
b98b2def63
TRAP Caching: Skip uploading of small caches
2022-09-23 15:22:31 +01:00
Henry Mercer
34aa5a554b
Merge pull request #1242 from github/henrymercer/go-more-backwards-compat
...
Go extraction reconciliation: Ensure backwards compatibility for multi-language builds
2022-09-16 11:05:41 +01:00
Henry Mercer
f32e161cdd
Improve warning when using autobuild with multi-language builds
2022-09-13 16:53:02 +01:00
Henry Mercer
4cc95769d4
Improve variable name
2022-09-13 16:50:41 +01:00
Cornelius Riemenschneider
fd4dc5bf31
Merge pull request #1244 from github/criemen/remove-lua-tracer-ff
...
Remove the lua tracer feature flag check from the codeql-action.
2022-09-13 17:49:47 +02:00
Cornelius Riemenschneider
3038e979a8
Remove the lua tracer feature flag check from the codeql-action.
...
Always defer to the CLI on the Lua tracer state from now on.
2022-09-13 11:23:32 +00:00
Henry Mercer
bde5694fb7
Comment why we don't run multiple autobuilders for other languages
2022-09-12 18:25:20 +01:00
Henry Mercer
40e0374c6f
Ensure backwards compat for multi-language builds with Go reconciliation
2022-09-12 18:24:46 +01:00
Henry Mercer
0d2fa3c636
Support autobuilding multiple languages in autobuild Action
2022-09-12 17:35:32 +01:00
Henry Mercer
4a8d26e2bd
Bump CodeQL version to 2.10.5
2022-09-08 18:29:45 +01:00
Andrew Eisenberg
9ba4d500aa
Merge pull request #1221 from github/aeisenberg/ghes-pack-download
...
Add support for downloading packs from GHES
2022-09-08 10:02:41 -07:00
Andrew Eisenberg
6085805a3a
Append `/` to end of registries url
...
Avoids a bug in 2.10.4. Also, add some better handling for invalid
registries blocks.
2022-09-08 08:00:24 -07:00
Andrew Eisenberg
59744464eb
Fix unit tests
2022-09-07 16:10:34 -07:00
Andrew Eisenberg
4fa3e8b483
Gate the new `registries` input behind version constraints
2022-09-07 14:38:44 -07:00
David Verdeguer
063e083705
Fix linting
2022-09-07 22:45:34 +02:00
David Verdeguer
a03f3bd585
Build js
2022-09-07 09:45:19 +02:00
Andrew Eisenberg
376fea671d
Clarify description of `registries` input
2022-09-06 14:06:30 -07:00
Andrew Eisenberg
bf97a6da5b
Apply suggestions from code review
2022-09-06 10:41:32 -07:00
Andrew Eisenberg
7e086b240c
Merge remote-tracking branch 'upstream/main' into aeisenberg/ghes-pack-download
2022-09-06 10:22:00 -07:00
Edoardo Pirovano
299b77421b
TRAP Caching: Be tolerant to not finding the extractor
2022-09-05 10:38:21 +01:00
Andrew Eisenberg
abdf26c28f
Convert from json to yaml for registries input
2022-09-02 15:03:51 -07:00