Merge pull request #737 from github/codeql/upgrade-to-2.15.5

Upgrade `github/codeql` dependency to 2.15.5
2024-10-08 10:55:02 +00:00 · 2024-10-08 10:55:02 +00:00 · 2e8a50376c
--- a/c/cert/src/codeql-pack.lock.yml
+++ b/c/cert/src/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/c/cert/src/qlpack.yml
+++ b/c/cert/src/qlpack.yml
@ -5,4 +5,4 @@ suites: codeql-suites
 license: MIT
 dependencies:
  codeql/common-c-coding-standards: '*'
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
--- a/c/cert/test/codeql-pack.lock.yml
+++ b/c/cert/test/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/c/common/src/codeql-pack.lock.yml
+++ b/c/common/src/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/c/common/src/qlpack.yml
+++ b/c/common/src/qlpack.yml
@ -3,4 +3,4 @@ version: 2.36.0-dev
 license: MIT
 dependencies:
  codeql/common-cpp-coding-standards: '*'
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
--- a/c/common/test/codeql-pack.lock.yml
+++ b/c/common/test/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/c/misra/src/codeql-pack.lock.yml
+++ b/c/misra/src/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/c/misra/src/qlpack.yml
+++ b/c/misra/src/qlpack.yml
@ -6,4 +6,4 @@ license: MIT
 default-suite-file: codeql-suites/misra-c-default.qls
 dependencies:
  codeql/common-c-coding-standards: '*'
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
--- a/c/misra/src/rules/RULE-10-1/OperandsOfAnInappropriateEssentialType.ql
+++ b/c/misra/src/rules/RULE-10-1/OperandsOfAnInappropriateEssentialType.ql
@ -15,7 +15,6 @@
 import cpp
 import codingstandards.c.misra
 import codingstandards.c.misra.EssentialTypes
-import codingstandards.cpp.Bitwise

 /**
 * Holds if the operator `operator` has an operand `child` that is of an inappropriate essential type
@ -179,8 +178,7 @@ predicate isInappropriateEssentialType(
    child =
      [
        operator.(BinaryBitwiseOperation).getAnOperand(),
-        operator.(Bitwise::AssignBitwiseOperation).getAnOperand(),
-        operator.(ComplementExpr).getAnOperand()
+        operator.(AssignBitwiseOperation).getAnOperand(), operator.(ComplementExpr).getAnOperand()
      ] and
    not operator instanceof LShiftExpr and
    not operator instanceof RShiftExpr and
--- a/c/misra/src/rules/RULE-8-2/FunctionTypesNotInPrototypeForm.ql
+++ b/c/misra/src/rules/RULE-8-2/FunctionTypesNotInPrototypeForm.ql
@ -49,11 +49,9 @@ where
    msg = "Function " + f + " does not specify void for no parameters present."
    or
    //parameters declared in declaration list (not in function signature)
-    //have placeholder file location associated only
-    exists(Parameter p |
-      p.getFunction() = f and
-      not p.getFile() = f.getFile() and
-      msg = "Function " + f + " declares parameter in unsupported declaration list."
-    )
+    //have no prototype
+    not f.isPrototyped() and
+    not hasZeroParamDecl(f) and
+    msg = "Function " + f + " declares parameter in unsupported declaration list."
  )
 select f, msg
--- a/c/misra/test/codeql-pack.lock.yml
+++ b/c/misra/test/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/change_notes/2024-10-07-upgrade-to-2.15.5.md
+++ b/change_notes/2024-10-07-upgrade-to-2.15.5.md
@ -0,0 +1 @@
+- Updated the CodeQL version to `2.15.5`.
--- a/cpp/autosar/src/codeql-pack.lock.yml
+++ b/cpp/autosar/src/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/autosar/src/qlpack.yml
+++ b/cpp/autosar/src/qlpack.yml
@ -5,4 +5,4 @@ suites: codeql-suites
 license: MIT
 dependencies:
  codeql/common-cpp-coding-standards: '*'
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
--- a/cpp/autosar/src/rules/M5-0-20/BitwiseOperatorOperandsHaveDifferentUnderlyingType.ql
+++ b/cpp/autosar/src/rules/M5-0-20/BitwiseOperatorOperandsHaveDifferentUnderlyingType.ql
@ -16,7 +16,6 @@

 import cpp
 import codingstandards.cpp.autosar
-import codingstandards.cpp.Bitwise
 import codingstandards.cpp.Conversion

 predicate isBinaryBitwiseOperation(Operation o, VariableAccess l, VariableAccess r) {
@ -24,7 +23,7 @@ predicate isBinaryBitwiseOperation(Operation o, VariableAccess l, VariableAccess
    l = bbo.getLeftOperand() and r = bbo.getRightOperand()
  )
  or
-  exists(Bitwise::AssignBitwiseOperation abo | abo = o |
+  exists(AssignBitwiseOperation abo | abo = o |
    l = abo.getLValue() and
    r = abo.getRValue()
  )
--- a/cpp/autosar/src/rules/M5-0-21/BitwiseOperatorAppliedToSignedTypes.ql
+++ b/cpp/autosar/src/rules/M5-0-21/BitwiseOperatorAppliedToSignedTypes.ql
@ -17,7 +17,6 @@

 import cpp
 import codingstandards.cpp.autosar
-import codingstandards.cpp.Bitwise

 from Operation o, VariableAccess va
 where
@ -25,7 +24,7 @@ where
  (
    o instanceof UnaryBitwiseOperation or
    o instanceof BinaryBitwiseOperation or
-    o instanceof Bitwise::AssignBitwiseOperation
+    o instanceof AssignBitwiseOperation
  ) and
  o.getAnOperand() = va and
  va.getTarget().getUnderlyingType().(IntegralType).isSigned()
--- a/cpp/autosar/src/rules/M5-8-1/RightBitShiftOperandIsNegativeOrTooWide.ql
+++ b/cpp/autosar/src/rules/M5-8-1/RightBitShiftOperandIsNegativeOrTooWide.ql
@ -17,7 +17,6 @@

 import cpp
 import codingstandards.cpp.autosar
-import codingstandards.cpp.Bitwise

 class ShiftOperation extends Operation {
  Expr leftOperand;
@ -34,7 +33,7 @@ class ShiftOperation extends Operation {
      rightOperand = o.getRightOperand()
    )
    or
-    exists(Bitwise::AssignBitwiseOperation o | this = o |
+    exists(AssignBitwiseOperation o | this = o |
      (
        o instanceof AssignLShiftExpr
        or
--- a/cpp/autosar/test/codeql-pack.lock.yml
+++ b/cpp/autosar/test/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/cert/src/codeql-pack.lock.yml
+++ b/cpp/cert/src/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/cert/src/qlpack.yml
+++ b/cpp/cert/src/qlpack.yml
@ -4,5 +4,5 @@ description: CERT C++ 2016
 suites: codeql-suites
 license: MIT
 dependencies:
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
  codeql/common-cpp-coding-standards: '*'
--- a/cpp/cert/src/rules/MEM53-CPP/ManuallyManagedLifetime.qll
+++ b/cpp/cert/src/rules/MEM53-CPP/ManuallyManagedLifetime.qll
@ -14,12 +14,15 @@ module AllocToStaticCastConfig implements DataFlow::ConfigSig {
  predicate isSource(DataFlow::Node source) {
    exists(AllocationExpr ae |
      ae.getType().getUnspecifiedType() instanceof VoidPointerType and
-      source.asExpr() = ae and
-      // Ignore realloc, as that memory may already be partially constructed
-      not ae.(FunctionCall).getTarget().getName().toLowerCase().matches("%realloc%")
+      source.asExpr() = ae
    )
  }

+  predicate isBarrier(DataFlow::Node sanitizer) {
+    // Ignore realloc, as that memory may already be partially constructed
+    sanitizer.asExpr().(FunctionCall).getTarget().getName().toLowerCase().matches("%realloc%")
+  }
+
  predicate isSink(DataFlow::Node sink) {
    exists(StaticOrCStyleCast sc, Class nonTrivialClass |
      sc.getExpr() = sink.asExpr() and
--- a/cpp/cert/test/codeql-pack.lock.yml
+++ b/cpp/cert/test/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/common/src/codeql-pack.lock.yml
+++ b/cpp/common/src/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/common/src/codingstandards/cpp/Bitwise.qll
+++ b/cpp/common/src/codingstandards/cpp/Bitwise.qll
@ -1,20 +0,0 @@
-/**
- * A library for addressing issues in bitwise operator modelling in our database schema.
- */
-
-private import cpp as cpp
-
-module Bitwise {
-  /**
-   * A binary bitwise assign operation, excluding += and -= on pointers, which seem to be erroneously
-   * included.
-   */
-  class AssignBitwiseOperation extends cpp::AssignBitwiseOperation {
-    AssignBitwiseOperation() {
-      // exclude += and -= on pointers, which seem to be erroneously included
-      // in the database schema
-      not this instanceof cpp::AssignPointerAddExpr and
-      not this instanceof cpp::AssignPointerSubExpr
-    }
-  }
-}
--- a/cpp/common/src/qlpack.yml
+++ b/cpp/common/src/qlpack.yml
@ -2,6 +2,6 @@ name: codeql/common-cpp-coding-standards
 version: 2.36.0-dev
 license: MIT
 dependencies:
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
 dataExtensions:
-  - ext/*.model.yml
+- ext/*.model.yml
--- a/cpp/common/test/codeql-pack.lock.yml
+++ b/cpp/common/test/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/misra/src/codeql-pack.lock.yml
+++ b/cpp/misra/src/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/misra/src/qlpack.yml
+++ b/cpp/misra/src/qlpack.yml
@ -5,4 +5,4 @@ default-suite: codeql-suites/misra-cpp-default.qls
 license: MIT
 dependencies:
  codeql/common-cpp-coding-standards: '*'
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
--- a/cpp/misra/test/codeql-pack.lock.yml
+++ b/cpp/misra/test/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/report/src/codeql-pack.lock.yml
+++ b/cpp/report/src/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/cpp/report/src/qlpack.yml
+++ b/cpp/report/src/qlpack.yml
@ -2,4 +2,4 @@ name: codeql/report-cpp-coding-standards
 version: 2.36.0-dev
 license: MIT
 dependencies:
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
--- a/scripts/generate_modules/queries/codeql-pack.lock.yml
+++ b/scripts/generate_modules/queries/codeql-pack.lock.yml
@ -2,13 +2,17 @@
 lockVersion: 1.0.0
 dependencies:
  codeql/cpp-all:
-    version: 0.9.3
+    version: 0.12.2
  codeql/dataflow:
+    version: 0.1.5
+  codeql/rangeanalysis:
    version: 0.0.4
  codeql/ssa:
-    version: 0.1.5
+    version: 0.2.5
  codeql/tutorial:
-    version: 0.1.5
+    version: 0.2.5
+  codeql/typetracking:
+    version: 0.2.5
  codeql/util:
-    version: 0.1.5
+    version: 0.2.5
 compiled: false
--- a/scripts/generate_modules/queries/qlpack.yml
+++ b/scripts/generate_modules/queries/qlpack.yml
@ -2,4 +2,4 @@ name: codeql/standard-library-extraction-cpp-coding-standards
 version: 0.0.0
 license: MIT
 dependencies:
-  codeql/cpp-all: 0.9.3
+  codeql/cpp-all: 0.12.2
--- a/supported_codeql_configs.json
+++ b/supported_codeql_configs.json
@ -1,9 +1,9 @@
 {
  "supported_environment": [
    {
-      "codeql_cli": "2.14.6",
-      "codeql_standard_library": "codeql-cli/v2.14.6",
-      "codeql_cli_bundle": "codeql-bundle-v2.14.6"
+      "codeql_cli": "2.15.5",
+      "codeql_standard_library": "codeql-cli/v2.15.5",
+      "codeql_cli_bundle": "codeql-bundle-v2.15.5"
    }
  ],
  "supported_language": [