зеркало из https://github.com/github/codeql.git
Apply suggestions from code review
Co-Authored-By: Esben Sparre Andreasen <esbena@github.com>
This commit is contained in:
Родитель
75b183bc33
Коммит
2c0bae4937
|
@ -84,7 +84,7 @@ abstract private class CollectionFlowStep extends DataFlow::AdditionalFlowStep {
|
|||
}
|
||||
|
||||
/**
|
||||
* A collection of predicates and clases for type-tracking collections.
|
||||
* Provides predicates and clases for type-tracking collections.
|
||||
*/
|
||||
module CollectionsTypeTracking {
|
||||
/**
|
||||
|
@ -220,9 +220,9 @@ private module CollectionDataFlow {
|
|||
* A call to the `set` method on a Map.
|
||||
*
|
||||
* If the key of the call to `set` has a known string value,
|
||||
* then the value will be saved into a pseudo-property corresponding to the known string value.
|
||||
* Otherwise the value will be saved into a pseudo-property corresponding to values with unknown keys.
|
||||
* The value will additionally be saved into a pseudo-property corresponding to all values.
|
||||
* then the value will be stored into a pseudo-property corresponding to the known string value.
|
||||
* Otherwise the value will be stored into a pseudo-property corresponding to values with unknown keys.
|
||||
* The value will additionally be stored into a pseudo-property corresponding to all values.
|
||||
*/
|
||||
class MapSet extends CollectionFlowStep, DataFlow::MethodCallNode {
|
||||
MapSet() { this.getMethodName() = "set" }
|
||||
|
|
|
@ -611,7 +611,7 @@ module PseudoProperties {
|
|||
/**
|
||||
* Gets a pseudo-property for the location of map values, where the key is unknown.
|
||||
*/
|
||||
string mapValueUnknownKey() { result = pseudoProperty("unknownMapValue") }
|
||||
string mapValueUnknownKey() { result = pseudoProperty("mapValueUnknownKey") }
|
||||
|
||||
/**
|
||||
* Gets a pseudo-property for the location of all the values in a map.
|
||||
|
|
|
@ -66,7 +66,7 @@ class StepSummary extends TStepSummary {
|
|||
exists(string prop | this = CopyStep(prop) | result = "copy " + prop)
|
||||
or
|
||||
exists(string fromProp, string toProp | this = LoadStoreStep(fromProp, toProp) |
|
||||
result = "copy " + fromProp + " to " + toProp
|
||||
result = "load " + fromProp + " and store to " + toProp
|
||||
)
|
||||
}
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче