From 2c0bae4937933fc7a7a78c261c739bcda4881327 Mon Sep 17 00:00:00 2001
From: Erik Krogh Kristensen <erik-krogh@github.com>
Date: Thu, 2 Apr 2020 20:28:04 +0200
Subject: [PATCH] Apply suggestions from code review

Co-Authored-By: Esben Sparre Andreasen <esbena@github.com>
---
 javascript/ql/src/semmle/javascript/Collections.qll       | 8 ++++----
 .../ql/src/semmle/javascript/dataflow/Configuration.qll   | 2 +-
 .../semmle/javascript/dataflow/internal/StepSummary.qll   | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/javascript/ql/src/semmle/javascript/Collections.qll b/javascript/ql/src/semmle/javascript/Collections.qll
index 3f1c8deb864..19a26d7da35 100644
--- a/javascript/ql/src/semmle/javascript/Collections.qll
+++ b/javascript/ql/src/semmle/javascript/Collections.qll
@@ -84,7 +84,7 @@ abstract private class CollectionFlowStep extends DataFlow::AdditionalFlowStep {
 }
 
 /**
- * A collection of predicates and clases for type-tracking collections.
+ * Provides predicates and clases for type-tracking collections.
  */
 module CollectionsTypeTracking {
   /**
@@ -220,9 +220,9 @@ private module CollectionDataFlow {
    * A call to the `set` method on a Map.
    *
    * If the key of the call to `set` has a known string value,
-   * then the value will be saved into a pseudo-property corresponding to the known string value.
-   * Otherwise the value will be saved into a pseudo-property corresponding to values with unknown keys.
-   * The value will additionally be saved into a pseudo-property corresponding to all values.
+   * then the value will be stored into a pseudo-property corresponding to the known string value.
+   * Otherwise the value will be stored into a pseudo-property corresponding to values with unknown keys.
+   * The value will additionally be stored into a pseudo-property corresponding to all values.
    */
   class MapSet extends CollectionFlowStep, DataFlow::MethodCallNode {
     MapSet() { this.getMethodName() = "set" }
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll b/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
index be72d9c1952..5c583c38764 100644
--- a/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
+++ b/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
@@ -611,7 +611,7 @@ module PseudoProperties {
   /**
    * Gets a pseudo-property for the location of map values, where the key is unknown.
    */
-  string mapValueUnknownKey() { result = pseudoProperty("unknownMapValue") }
+  string mapValueUnknownKey() { result = pseudoProperty("mapValueUnknownKey") }
 
   /**
    * Gets a pseudo-property for the location of all the values in a map.
diff --git a/javascript/ql/src/semmle/javascript/dataflow/internal/StepSummary.qll b/javascript/ql/src/semmle/javascript/dataflow/internal/StepSummary.qll
index c4465285109..92e05e4b927 100644
--- a/javascript/ql/src/semmle/javascript/dataflow/internal/StepSummary.qll
+++ b/javascript/ql/src/semmle/javascript/dataflow/internal/StepSummary.qll
@@ -66,7 +66,7 @@ class StepSummary extends TStepSummary {
     exists(string prop | this = CopyStep(prop) | result = "copy " + prop)
     or
     exists(string fromProp, string toProp | this = LoadStoreStep(fromProp, toProp) |
-      result = "copy " + fromProp + " to " + toProp
+      result = "load " + fromProp + " and store to " + toProp
     )
   }
 }