Merge pull request #17560 from hvitved/codegen/remove-cached

Codegen: Do not cache injectors/projectors in `Synth` module

misc/codegen/templates/ql_synth_types.mustache

@@ -7,7 +7,7 @@
 private import {{import_prefix}}.SynthConstructors
 private import {{import_prefix}}.Raw
 
-cached module Synth {
+module Synth {
   /**
    * INTERNAL: Do not use.
    * The synthesized type of all elements.
@@ -37,7 +37,7 @@ cached module Synth {
    * INTERNAL: Do not use.
    * Converts a raw element to a synthesized `T{{name}}`, if possible.
    */
-  cached T{{name}} convert{{name}}FromRaw(Raw::Element e) {
+  T{{name}} convert{{name}}FromRaw(Raw::Element e) {
     {{^is_fresh_synth}}
     result = T{{name}}(e)
     {{/is_fresh_synth}}
@@ -52,7 +52,7 @@ cached module Synth {
    * INTERNAL: Do not use.
    * Converts a raw DB element to a synthesized `T{{name}}`, if possible.
    */
-  cached T{{name}} convert{{name}}FromRaw(Raw::Element e) {
+  T{{name}} convert{{name}}FromRaw(Raw::Element e) {
     {{#derived}}
     {{^first}}
     or
@@ -67,7 +67,7 @@ cached module Synth {
    * INTERNAL: Do not use.
    * Converts a synthesized `T{{name}}` to a raw DB element, if possible.
    */
-  cached Raw::Element convert{{name}}ToRaw(T{{name}} e) {
+  Raw::Element convert{{name}}ToRaw(T{{name}} e) {
     {{^is_fresh_synth}}
     e = T{{name}}(result)
     {{/is_fresh_synth}}
@@ -82,7 +82,7 @@ cached module Synth {
    * INTERNAL: Do not use.
    * Converts a synthesized `T{{name}}` to a raw DB element, if possible.
    */
-  cached Raw::Element convert{{name}}ToRaw(T{{name}} e) {
+  Raw::Element convert{{name}}ToRaw(T{{name}} e) {
     {{#derived}}
     {{^first}}
     or

rust/ql/.generated.list

@@ -569,7 +569,7 @@ lib/codeql/rust/elements/internal/generated/Static.qll cae5313e08e4af44c46b25802
 lib/codeql/rust/elements/internal/generated/Stmt.qll 8473ff532dd5cc9d7decaddcd174b94d610f6ca0aec8e473cc051dad9f3db917 6ef7d2b5237c2dbdcacbf7d8b39109d4dc100229f2b28b5c9e3e4fbf673ba72b
 lib/codeql/rust/elements/internal/generated/StmtList.qll a667193e32341e17400867c6e359878c4e645ef9f5f4d97676afc0283a33a026 a320ed678ee359302e2fc1b70a9476705cd616fcfa44a499d32f0c7715627f73
 lib/codeql/rust/elements/internal/generated/Struct.qll 4d57f0db12dc7ad3e31e750a24172ef1505406b4dab16386af0674bd18bf8f4b 1a73c83df926b996f629316f74c61ea775be04532ab61b56af904223354f033e
-lib/codeql/rust/elements/internal/generated/Synth.qll a5d3868a9c6fef100ef71aed486db8ee3a38b122659531f95270f54dbae087f9 922ac8372f274090881b5ae462af8624f1136864b1f93f3a8de52e47f5cce7b5
+lib/codeql/rust/elements/internal/generated/Synth.qll 2512c0baff641fb9a7eb61c329f02fade7cff8a5c80559658c73425f22d82197 51a376dac98e56a2f15548487055823e7f728f0de955932ccf43488833279bb5
 lib/codeql/rust/elements/internal/generated/SynthConstructors.qll 649e5d313e51e78802c8bc67bfba1aea59bef9a83fc1b17bb558c3cf4aee089a 649e5d313e51e78802c8bc67bfba1aea59bef9a83fc1b17bb558c3cf4aee089a
 lib/codeql/rust/elements/internal/generated/TokenTree.qll 8577c2b097c1be2f0f7daa5acfcf146f78674a424d99563e08a84dd3e6d91b46 d2f30764e84dbfc0a6a5d3d8a5f935cd432413688cb32da9c94e420fbc10665c
 lib/codeql/rust/elements/internal/generated/Trait.qll 32bdbb4dc9f03488195a90320a947013135cd2fae1b9d62b4f71ed9a4e39a967 5dab0fbec64698bf3cdae04879d3d1665cf82386b7b030ed69e6b20776ffa9fc

swift/ql/.generated.list

@@ -713,7 +713,7 @@ lib/codeql/swift/generated/ParentChild.qll d1814f2bad4c2ba9242ce49fe6fb8564ac99f
 lib/codeql/swift/generated/PlatformVersionAvailabilitySpec.qll dc17b49a90a18a8f7607adf2433bc8f0c194fa3e803aa3822f809d4d4fbd6793 be48ea9f8ae17354c8508aaed24337a9e57ce01f288fece3dcecd99776cabcec
 lib/codeql/swift/generated/PureSynthConstructors.qll bc31a6c4d142fa3fbdcae69d5ba6f1cec00eb9ad92b46c8d7b91ebfa7ef6c1f4 bc31a6c4d142fa3fbdcae69d5ba6f1cec00eb9ad92b46c8d7b91ebfa7ef6c1f4
 lib/codeql/swift/generated/Raw.qll 118b43fedd4265b5aa15c33ef01a2f5a5db6e5597f95bef1078a01c3ff8da983 075aec2c8b232f0361ebf63f07ae9b66163f3975e6023583fb0fa2e40b979a33
-lib/codeql/swift/generated/Synth.qll 221f40afbc2bed0f5de1961877fd39dd025574bc72622af0e9f47f278a8324b7 05b8aaa9ac6236b0c08d6afc7a13e58361b90524cff6520a1ac6d422eea4fe40
+lib/codeql/swift/generated/Synth.qll 31e318c6e156848c85a2a2664695b48b5e93c57c9bb22fa29d027069907b3ab0 8655ffcf772f55284b93f1d7f8e1b3d497a9744d5f2e0c17bc322c1fdf8bdba8
 lib/codeql/swift/generated/SynthConstructors.qll 3e53c7853096020219c01dae85681fe80b34938d198a0ff359a209dda41c5ed7 3e53c7853096020219c01dae85681fe80b34938d198a0ff359a209dda41c5ed7
 lib/codeql/swift/generated/UnknownFile.qll 247ddf2ebb49ce5ed4bf7bf91a969ddff37de6c78d43d8affccaf7eb586e06f2 452b29f0465ef45e978ef8b647b75e5a2a1e53f2a568fc003bc8f52f73b3fa4d
 lib/codeql/swift/generated/UnknownLocation.qll d871000b4f53ffca4f67ea23ca5626e5dcce125d62a4d4b9969e08cc974af6fc b05971d7774e60790362fb810fb7086314f40a2de747b8cb1bc823ec6494a4dd