From d55d5cc4ede82615ff58ca78130a95ad42760f48 Mon Sep 17 00:00:00 2001 From: Asger Feldthaus Date: Tue, 7 Jan 2020 10:27:46 +0000 Subject: [PATCH] JS: Address comments from doc review --- change-notes/1.24/analysis-javascript.md | 2 +- javascript/ql/src/RegExp/RegExpAlwaysMatches.qhelp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/change-notes/1.24/analysis-javascript.md b/change-notes/1.24/analysis-javascript.md index 65076c235ff..9c91bc5d396 100644 --- a/change-notes/1.24/analysis-javascript.md +++ b/change-notes/1.24/analysis-javascript.md @@ -17,7 +17,7 @@ | **Query** | **Tags** | **Purpose** | |---------------------------------------------------------------------------------|-------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | Cross-site scripting through exception (`js/xss-through-exception`) | security, external/cwe/cwe-079, external/cwe/cwe-116 | Highlights potential XSS vulnerabilities where an exception is written to the DOM. Results are not shown on LGTM by default. | -| Regular expression always matches (`js/regex/always-matches`) | correctness, regular-expressions | Highlights regular expression checks that trivially succeed by matching an empty substring. | +| Regular expression always matches (`js/regex/always-matches`) | correctness, regular-expressions | Highlights regular expression checks that trivially succeed by matching an empty substring. Results are shown on LGTM by default. | ## Changes to existing queries diff --git a/javascript/ql/src/RegExp/RegExpAlwaysMatches.qhelp b/javascript/ql/src/RegExp/RegExpAlwaysMatches.qhelp index 4c2607dc5c5..d262ce15be1 100644 --- a/javascript/ql/src/RegExp/RegExpAlwaysMatches.qhelp +++ b/javascript/ql/src/RegExp/RegExpAlwaysMatches.qhelp @@ -7,8 +7,8 @@

There are several built-in JavaScript functions that search for a regular expression match within a string, such as RegExp.prototype.test and String.prototype.search. -If the regular expression is not anchored, the regular expression does not need to match the whole string; -it only needs to match a substring. +If the regular expression is not anchored, it only needs to match a substring of the input +and won't necessarily match the whole string.