Remco Vermeulen
54d6c8b5f4
Mark ServletUrlRedirectSink private
2020-07-09 15:03:51 +02:00
Arthur Baars
e183171fea
Java: model Object.clone
2020-07-09 14:50:29 +02:00
Remco Vermeulen
1212feab28
Add file-level qldoc
2020-07-09 14:11:59 +02:00
Remco Vermeulen
99228d8bc2
Optimize imports
2020-07-09 14:09:39 +02:00
Remco Vermeulen
ba9f3e2a1e
Join ServletUrlRedirectSink with UrlRedirectSink
2020-07-09 14:08:43 +02:00
Remco Vermeulen
88f4b224c3
Extend UrlRedirectSink from DataFlow::Node
2020-07-09 14:05:54 +02:00
Remco Vermeulen
f8078f1125
Remove superfluous imports
2020-07-09 13:43:10 +02:00
Arthur Baars
d3d58795f1
Java: ContainerFlow add comments
...
Some method variants are captured by a super class. Added some comments
to indicate where this happens to make review of missing methods easier
in the future.
2020-07-09 12:46:57 +02:00
semmle-qlci
e167b87150
Merge pull request #3932 from max-schaefer/portals-additions
...
Approved by esbena
2020-07-09 11:43:45 +01:00
Remco Vermeulen
9a84abf259
Generalize QueryInjectionSink
...
Extends from the more general DataFlow::Node instead of
DataFlow::ExprNode
2020-07-09 12:32:17 +02:00
Arthur Baars
24c6e506aa
Java: ContainerFlow: RValue -> Expr
...
While most flow for a qualifierToArgumentStep goes through a variable use
this is not always the case. Therefore it is best to remove the restriction
to RValue to allow taint steps to use postupdate nodes.
See also: ba86dea657
2020-07-09 12:20:48 +02:00
Arthur Baars
0bd103ac05
Java: add tests for Container taint steps
2020-07-09 12:15:38 +02:00
Rasmus Wriedt Larsen
e7c89dc24b
Python: Fix grammar
...
Co-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com>
2020-07-09 10:39:58 +02:00
Remco Vermeulen
c01844a39e
Add file-level qldoc
2020-07-09 10:30:31 +02:00
Max Schaefer
7a1410e0d5
JavaScript: Update and expand tests.
2020-07-09 09:25:52 +01:00
Remco Vermeulen
42e261ac02
Move SqlInjectionSink and PersistenceQueryInjectionSink
...
Join SqlInjectionSink and PersistenceQueryInjectionSink with
QueryInjectionSink to make its definition more transparent.
2020-07-09 10:21:24 +02:00
Remco Vermeulen
d07d21c9e2
Fix import
2020-07-09 10:20:53 +02:00
Anders Schack-Mulligen
777dc6305c
Merge pull request #3893 from aibaars/set-map-list-copy-of
...
Java: model some new Set,List,Map methods
2020-07-09 10:18:12 +02:00
Max Schaefer
1c47260bde
JavaScript: Add support for global variables to portals.
2020-07-09 09:12:56 +01:00
Max Schaefer
c40ef0556a
JavaScript: Broaden scope of imports considered relevant to portals.
...
Previously, we only considered an import relevant to portals if the path it imported was declared as a dependency. This falls down for deep imports where a specific module inside the package is imported rather than the default entry point, for imports of built-in modules like `fs`, and in cases where a developer simply forgets to declare a dependency.
So instead we now consider all imports relevant whose path does not start with a dot or a slash.
2020-07-09 09:09:44 +01:00
Max Schaefer
8b4b5781e6
JavaScript: Add utility predicate `getBasePortal(i)`.
...
This iterates the existing `getBasePortal()` predicate `i` times.
2020-07-09 09:08:18 +01:00
Robert Marsh
0e66d0892b
Merge pull request #3785 from MathiasVP/dataflow-operand-nodes
...
C++: Operands as dataflow nodes
2020-07-08 14:50:54 -07:00
Arthur Baars
6367eb9ee8
Address review comments
2020-07-08 22:08:27 +02:00
Ian Lynagh
71b70b4bd0
C++: Give static_assert's an enclosing element
2020-07-08 17:10:43 +01:00
Remco Vermeulen
170be9ffe8
Move `UrlRedirectSink` into importable library
...
- The `UrlRedirect` class is renamed to `ServletUrlRedirect`.
- Abstract class `UrlRedirectSink` is defined that can be imported and
used to customise CWE-601 via Customizations.qll
2020-07-08 16:47:51 +02:00
Jonas Jensen
0bbbfe58cf
Merge pull request #3916 from geoffw0/cc_followup2
...
C++: Add missing constructor taint test
2020-07-08 16:35:47 +02:00
Remco Vermeulen
06517c6f82
Move `QueryInjectionSink` into importable library
...
This enables defining of new sinks to customise the CWE-089 queries.
2020-07-08 16:24:06 +02:00
Arthur Baars
e8f216c761
Merge remote-tracking branch 'upstream/master' into set-map-list-copy-of
2020-07-08 15:11:13 +02:00
Anders Schack-Mulligen
bf5c5297d3
Merge pull request #3897 from aibaars/util-objects
...
Java: data flow for `java.util.Objects`
2020-07-08 15:07:50 +02:00
Anders Schack-Mulligen
528f250af3
Merge pull request #3653 from lcartey/java/improve-spring-support
...
Java: Improve modelling of Spring requests, flow steps and XSS sinks
2020-07-08 15:00:14 +02:00
Luke Cartey
443c13d516
Merge pull request #2 from aschackmull/java/spring-3653-2
...
Java: Fix qltests for https://github.com/github/codeql/pull/3653
2020-07-08 13:19:45 +01:00
Anders Schack-Mulligen
b88ebd69c1
Java: Fix OgnlInjection qltest
2020-07-08 14:12:27 +02:00
Anders Schack-Mulligen
a4fe4f41b9
Java: Fix JndiInjection qltest
2020-07-08 14:09:08 +02:00
Anders Schack-Mulligen
581d496167
Java: Fix LdapInjection qltest
2020-07-08 14:04:01 +02:00
Arthur Baars
72a24972e7
Apply suggestions from code review
...
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
2020-07-08 13:30:24 +02:00
Rasmus Wriedt Larsen
32219e58c0
Python: Add basic call-graph metric queries
...
For use with dist-compare
2020-07-08 13:29:54 +02:00
Anders Schack-Mulligen
48e4759632
Merge branch 'master' into java/spring-3653-2
2020-07-08 13:06:51 +02:00
semmle-qlci
6ef7288848
Merge pull request #3922 from aschackmull/java/stub-cleanup
...
Approved by aibaars
2020-07-08 12:04:39 +01:00
Geoffrey White
61dfebceb9
C++: Add getFullyConverted() as suggested.
2020-07-08 11:28:39 +01:00
Anders Schack-Mulligen
b38839e84e
Merge pull request #3920 from Marcono1234/patch-3
...
Improve VariableAssign.getSource documentation
2020-07-08 10:25:13 +02:00
Anders Schack-Mulligen
6eac8e82a3
Java: Consolidate spring-ldap-2.3.2 stubs.
2020-07-08 10:08:44 +02:00
Anders Schack-Mulligen
40b9d34ab9
Java: Consolidate springframework-5.2.3 stubs
2020-07-08 09:57:48 +02:00
Anders Schack-Mulligen
c166fee198
Merge pull request #3894 from aibaars/util-arrays
...
Java: model taint for java.util.Arrays
2020-07-08 09:06:40 +02:00
Marcono1234
00a61816c0
Improve VariableAssign.getSource documentation
2020-07-07 22:37:58 +02:00
Dave Bartolomeo
6f7a8d029c
C++: Move `.gitignore` into autobuilder directory
...
On second thought, I'm going to make this apply only to the AutoBuilder directory. C# has it in the root of `csharp`, but they need it for their extractor as well.
2020-07-07 16:31:46 -04:00
Dave Bartolomeo
d3bcc1dae4
C++: Add `.gitignore` for autobuilder
...
C# has its own additional `.gitignore` to ignore the output files of the AutoBuilder build. Now that we have our own AutoBuilder in C++, we need the same thing.
2020-07-07 16:27:43 -04:00
Taus
548fceb306
Merge pull request #3917 from RasmusWL/python-fix-experimental-tests
...
Python: Fix experimental tests
2020-07-07 22:05:47 +02:00
Arthur Baars
441bf98ce7
Java: add Vector::copyInto, BlockingQueue::drainTo
2020-07-07 20:35:02 +02:00
Arthur Baars
c9ae2c8b2c
Java: ContainerFlow: organize taintPreservingArgumentToQualifier
2020-07-07 20:32:10 +02:00
Arthur Baars
5d73b99fd1
Java: ContainerFlow: organize taintPreservingQualifierToMethod
2020-07-07 19:53:11 +02:00