From 0597111cb5805791a7e5884f2a45ac7602a0d7c2 Mon Sep 17 00:00:00 2001 From: Peter Bengtsson Date: Tue, 29 Nov 2022 22:55:54 +0100 Subject: [PATCH] remove "External URLs" section from posted comment (#33017) --- .github/actions/rendered-content-link-checker.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/actions/rendered-content-link-checker.js b/.github/actions/rendered-content-link-checker.js index 39d8463192..56690c674f 100755 --- a/.github/actions/rendered-content-link-checker.js +++ b/.github/actions/rendered-content-link-checker.js @@ -430,7 +430,7 @@ async function commentOnPR(core, octokit, flaws, opts) { } } -function flawIssueDisplay(flaws, opts, includeExternalLinkList = true) { +function flawIssueDisplay(flaws, opts, mentionExternalExclusionList = true) { let output = '' let flawsToDisplay = 0 @@ -488,16 +488,10 @@ function flawIssueDisplay(flaws, opts, includeExternalLinkList = true) { } } - if (includeExternalLinkList) { + if (mentionExternalExclusionList) { output += - '\n\n## External URLs\n\nThe following external URLs must be verified manually. If an external URL gives a false negative, add it to the file `lib/excluded-links.js`\n\n' - for (const link of excludedLinks) { - if (typeof link === 'string') { - output += `\n - [${link}](${link})` - } else { - output += `\n - Pattern: \`${link.toString()}\`` - } - } + '\n\n---\n\nIf any link reported in this issue is not actually broken ' + + 'and repeatedly shows up on reports, consider making a PR that adds it as an exception to `lib/excluded-link.js`.' } return `${flawsToDisplay} broken${