make the pattern a string in all-versions so it can be serialized, and regex-ify it during implementation

This commit is contained in:
Sarah Schneider 2022-06-07 18:38:50 -04:00
Родитель f3bd355941
Коммит 56c1531708
3 изменённых файлов: 4 добавлений и 6 удалений

Просмотреть файл

@ -49,8 +49,8 @@ const plans = [
hasNumberedReleases: false,
openApiBaseName: 'github.ae',
miscBaseName: 'ghae',
allowedFrontmatterPattern: /^issue-\d+?(-and-\d+?)?|next$/,
allowedInlinePattern: /^ghae-(issue-\d+?(-and-\d+?)?|next)$/,
allowedFrontmatterPattern: '^issue-\\d+?(-and-\\d+?)?|next$',
allowedInlinePattern: '^ghae-(issue-\\d+?(-and-\\d+?)?|next)$',
},
]

Просмотреть файл

@ -265,9 +265,7 @@ function getValidProps(versionObj) {
// If a version has an exception pattern, both '*' and the exception pattern are valid.
if (versionObj.allowedFrontmatterPattern) {
valid.pattern = new RegExp(
`${asteriskPattern.source}|${versionObj.allowedFrontmatterPattern.source}`
)
valid.pattern = new RegExp(`${asteriskPattern.source}|${versionObj.allowedFrontmatterPattern}`)
valid.message = `Must have a value of '*' or ${versionObj.allowedFrontmatterPattern}`
}

Просмотреть файл

@ -105,7 +105,7 @@ describe('lint Liquid versioning', () => {
function validateVersion(version) {
const isSupported = allowedVersionNames.includes(version)
const isException = Object.values(allVersions).some(
(v) => v.allowedInlinePattern && v.allowedInlinePattern.test(version)
(v) => v.allowedInlinePattern && new RegExp(v.allowedInlinePattern).test(version)
)
const isValid = isSupported || isException