Merge pull request #23502 from github/repo-sync

repo sync

content/issues/planning-and-tracking-with-projects/learning-about-projects/best-practices-for-projects.md

@@ -20,7 +20,7 @@ You can use {% data variables.product.prodname_projects_v2 %} to manage your wor
 
 Breaking a large issue into smaller issues makes the work more manageable and enables team members to work in parallel. It also leads to smaller pull requests, which are easier to review.
 
-To track how smaller issues fit into the larger goal, use task lists, milestones, or labels. For more information, see "[About task lists](/issues/tracking-your-work-with-issues/creating-issues/about-task-lists)", "[About milestones](/issues/using-labels-and-milestones-to-track-work/about-milestones)", and "[Managing labels](/issues/using-labels-and-milestones-to-track-work/managing-labels)."
+To track how smaller issues fit into the larger goal, use task lists, milestones, or labels. For more information, see {% ifversion projects-v2-tasklists %}"[About Tasklists](/issues/tracking-your-work-with-issues/about-tasklists)"{% else %}"[About task lists](/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists)"{% endif %}, "[About milestones](/issues/using-labels-and-milestones-to-track-work/about-milestones)", and "[Managing labels](/issues/using-labels-and-milestones-to-track-work/managing-labels)."
 
 ## Communicate
 

content/issues/planning-and-tracking-with-projects/managing-items-in-your-project/adding-items-to-your-project.md

@@ -67,7 +67,7 @@ You can add multiple issues and pull requests from your project and use filters,
 1. In the bottom row of the project, click {% octicon "plus" aria-label="plus icon" %}.
   ![Screenshot showing + button at the bottom of the project](/assets/images/help/projects-v2/omnibar-add.png)
 1. Click **Add item from repository**.
-  ![Screenshot showing "add item from repository" menu item](/assets/images/help/projects-v2/add-bulk-menu-item.png)
+  {% ifversion projects-v2-create-issue-modal %}![Screenshot showing "add item from repository" menu item](/assets/images/help/projects-v2/add-bulk-menu-item.png){% else %}![Screenshot showing "add item from repository" menu item](/assets/images/help/projects-v2/add-bulk-menu-item-draft-option.png){% endif %}
 {% data reusables.projects.bulk-add %}
 
 #### Adding multiple issues or pull requests from a repository
@@ -105,6 +105,16 @@ You can use the command palette when viewing your project to quickly add items.
 1. Start typing "Add items" and press <kbd>Return</kbd>.
 {% data reusables.projects.bulk-add %}
 
+{% ifversion projects-v2-create-issue-modal %}
+
+### Creating issues
+
+{% data reusables.projects.about-issue-modal %}
+
+{% data reusables.projects.create-issue-modal %}
+
+{% endif %}
+
 ### Creating draft issues
 
 Draft issues are useful to quickly capture ideas. Unlike issues and pull requests that are referenced from your repositories, draft issues exist only in your project.

content/issues/tracking-your-work-with-issues/creating-an-issue.md

@@ -117,9 +117,24 @@ When you create an issue from a discussion, the contents of the discussion post
 
 {% endif %}
 
-## Creating an issue from a project board note
+{% ifversion projects-v2-create-issue-modal %}
 
-If you're using a project board to track and prioritize your work, you can convert project board notes to issues. For more information, see "[About project boards](/github/managing-your-work-on-github/about-project-boards)" and "[Adding notes to a project board](/github/managing-your-work-on-github/adding-notes-to-a-project-board#converting-a-note-to-an-issue)."
+## Creating an issue from a project
+
+{% data reusables.projects.about-issue-modal %} For more information about Projects, see "[About Projects](/issues/planning-and-tracking-with-projects/learning-about-projects/about-projects)."
+
+1. Navigate to your project.
+{% data reusables.projects.create-issue-modal %}
+
+{% endif %}
+
+{% ifversion projects-v1 %}
+
+## Creating an issue from a {% data variables.projects.projects_v1_board %} note
+
+If you're using a {% data variables.projects.projects_v1_board %} to track and prioritize your work, you can convert notes to issues. For more information, see "[About {% data variables.product.prodname_projects_v1 %}](/github/managing-your-work-on-github/about-project-boards)" and "[Adding notes to a {% data variables.projects.projects_v1_board %}](/github/managing-your-work-on-github/adding-notes-to-a-project-board#converting-a-note-to-an-issue)."
+
+{% endif %}
 
 {% ifversion fpt or ghec %}
 

data/features/projects-v2-create-issue-modal.yml

@@ -0,0 +1,6 @@
+# Issue 9065
+# Create issue modal via project
+versions:
+  fpt: '*'
+  ghec: '*'
+  ghes: '>=3.9'

data/reusables/projects/about-issue-modal.md

@@ -0,0 +1 @@
+You can quickly create issues without leaving your project. When using a view that is grouped by a field, creating an issue in that group will automatically set the new issue's field to the group's value. For example, if you group your view by "Status", when you create an issue in the "Todo" group, the new issue's "Status" will automatically be set to "Todo."

data/reusables/projects/create-issue-modal.md

@@ -0,0 +1,31 @@
+1. At the bottom of a table, group of items, or a column in board layout, click {% octicon "plus" aria-label="plus icon" %}.
+
+  ![Screenshot showing + button at the bottom of the project](/assets/images/help/projects-v2/omnibar-add.png)
+
+1. Click **Create new issue**.
+
+  ![Screenshot showing "Create new issue" menu item](/assets/images/help/projects-v2/add-issue-menu-item.png)
+
+1. At the top of the "Create new issue" dialog, select the repository where you want the new issue to be created.
+
+  ![Screenshot showing the repository dropdown menu](/assets/images/help/projects-v2/issue-modal-repo.png)
+
+1. Below the repository dropdown, type a title for the new issue.
+
+  ![Screenshot showing the issue title field](/assets/images/help/projects-v2/issue-modal-title.png)
+  
+1. Optionally, use the fields below the title field to set assignees, labels, and milestones, and add the new issue to other projects. 
+
+  ![Screenshot showing the assignee, label, project, and milestone options](/assets/images/help/projects-v2/issue-modal-menus.png)
+  
+1. Optionally, type a description for your issue. 
+
+  ![Screenshot showing the description field](/assets/images/help/projects-v2/issue-modal-description.png)
+  
+1. Optionally, if you want to create more issues, select **Create more** and the dialog will reopen when you create your issue.
+
+  ![Screenshot showing the create more checkbox](/assets/images/help/projects-v2/issue-modal-more.png)
+  
+1. Click **Create**.
+
+  ![Screenshot showing the create button](/assets/images/help/projects-v2/issue-modal-create.png)

middleware/categories-for-support.js

@@ -2,7 +2,7 @@ import path from 'path'
 
 import { defaultCacheControl } from './cache-control.js'
 
-const renderOpts = { textOnly: true, encodeEntities: true }
+const renderOpts = { textOnly: true }
 
 // This middleware exposes a list of all categories and child articles at /categories.json.
 // GitHub Support uses this for internal ZenDesk search functionality.

middleware/learning-track.js

@@ -101,11 +101,10 @@ export default async function learningTrack(req, res, next) {
 // return -1 if not found.
 async function indexOfLearningTrackGuide(trackGuidePaths, guidePath, context) {
   let guideIndex = -1
-  const renderOpts = { textOnly: true, encodeEntities: true }
 
   for (let i = 0; i < trackGuidePaths.length; i++) {
     // Learning track URLs may have Liquid conditionals.
-    const renderedGuidePath = await renderContent(trackGuidePaths[i], context, renderOpts)
+    const renderedGuidePath = await renderContent(trackGuidePaths[i], context, { textOnly: true })
 
     if (!renderedGuidePath) continue
 

package.json

@@ -100,7 +100,7 @@
     "@babel/preset-env": "^7.18.2",
     "@graphql-inspector/core": "^3.1.2",
     "@graphql-tools/load": "^7.5.14",
-    "@jest/globals": "29.3.1",
+    "@jest/globals": "29.4.1",
     "@octokit/graphql": "5.0.4",
     "@octokit/rest": "^19.0.4",
     "@types/github-slugger": "^2.0.0",
@@ -136,7 +136,7 @@
     "http-status-code": "^2.1.0",
     "husky": "^8.0.1",
     "japanese-characters": "^1.1.0",
-    "jest": "29.3.1",
+    "jest": "29.4.1",
     "jest-environment-puppeteer": "^5.0.4",
     "jest-expect-message": "1.1.3",
     "jest-fail-on-console": "^3.0.1",

tests/unit/anchor-redirect.js

@@ -1,3 +1,5 @@
+import fs from 'fs'
+
 import { describe, expect } from '@jest/globals'
 
 import { get } from '../helpers/e2etest.js'
@@ -5,9 +7,12 @@ import {
   SURROGATE_ENUMS,
   makeLanguageSurrogateKey,
 } from '../../middleware/set-fastly-surrogate-key.js'
-import clientSideRedirects from '../../lib/redirects/static/client-side-rest-api-redirects.json'
 
 describe('anchor-redirect middleware', () => {
+  const clientSideRedirects = JSON.parse(
+    fs.readFileSync('./lib/redirects/static/client-side-rest-api-redirects.json', 'utf-8')
+  )
+
   test('returns correct redirect to url', async () => {
     // test the first entry
     const [key, value] = Object.entries(clientSideRedirects)[0]