From 147aab4428398f16cdb111e3284ada0c26f0133f Mon Sep 17 00:00:00 2001 From: Rob Bos Date: Wed, 24 Aug 2022 19:09:35 +0200 Subject: [PATCH 1/5] Update about-code-owners.md --- .../customizing-your-repository/about-code-owners.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md index 7c7f48b199..678942531b 100644 --- a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md +++ b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md @@ -117,7 +117,7 @@ apps/ @octocat /apps/github ``` ### Syntax exceptions -There are some syntax rules for gitignore files that do not work in CODEOWNERS files: +There are some syntax rules for gitignore files that **do not work** in CODEOWNERS files: - Escaping a pattern starting with `#` using `\` so it is treated as a pattern and not a comment - Using `!` to negate a pattern - Using `[ ]` to define a character range From 10a754f802df8b2186bb8cdc73f36f6a654417ec Mon Sep 17 00:00:00 2001 From: Rob Bos Date: Wed, 24 Aug 2022 19:52:52 +0200 Subject: [PATCH 2/5] Update about-code-owners.md --- .../customizing-your-repository/about-code-owners.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md index 678942531b..c5a8011c39 100644 --- a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md +++ b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md @@ -117,7 +117,7 @@ apps/ @octocat /apps/github ``` ### Syntax exceptions -There are some syntax rules for gitignore files that **do not work** in CODEOWNERS files: +There are some syntax rules for gitignore files that *do not work* in CODEOWNERS files: - Escaping a pattern starting with `#` using `\` so it is treated as a pattern and not a comment - Using `!` to negate a pattern - Using `[ ]` to define a character range From 384473f626f409b0731ca558305c5673453ece30 Mon Sep 17 00:00:00 2001 From: Rob Bos Date: Thu, 8 Sep 2022 17:43:29 +0200 Subject: [PATCH 3/5] Update about-code-owners.md --- .../customizing-your-repository/about-code-owners.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md index c5a8011c39..d0fc46374e 100644 --- a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md +++ b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md @@ -116,11 +116,14 @@ apps/ @octocat /apps/ @octocat /apps/github ``` -### Syntax exceptions + +{% warning %} +**Warning:** Syntax exceptions There are some syntax rules for gitignore files that *do not work* in CODEOWNERS files: - Escaping a pattern starting with `#` using `\` so it is treated as a pattern and not a comment - Using `!` to negate a pattern - Using `[ ]` to define a character range +{% endwarning %} ## CODEOWNERS and branch protection Repository owners can add branch protection rules to ensure that changed code is reviewed by the owners of the changed files. For more information, see "[About protected branches](/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches)." From 40ac14d00d7b4ced3e1d9d1bf5ede55191fa09ca Mon Sep 17 00:00:00 2001 From: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com> Date: Fri, 9 Sep 2022 10:44:52 -0500 Subject: [PATCH 4/5] Update content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md --- .../customizing-your-repository/about-code-owners.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md index d0fc46374e..9545173dbc 100644 --- a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md +++ b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md @@ -118,11 +118,11 @@ apps/ @octocat ``` {% warning %} -**Warning:** Syntax exceptions -There are some syntax rules for gitignore files that *do not work* in CODEOWNERS files: +**Warning:** There are some syntax rules for gitignore files that *do not work* in CODEOWNERS files: - Escaping a pattern starting with `#` using `\` so it is treated as a pattern and not a comment - Using `!` to negate a pattern - Using `[ ]` to define a character range + {% endwarning %} ## CODEOWNERS and branch protection From cd925845ce6809d519080f35397bd377c584547b Mon Sep 17 00:00:00 2001 From: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com> Date: Fri, 9 Sep 2022 11:11:17 -0500 Subject: [PATCH 5/5] Update about-code-owners.md --- .../customizing-your-repository/about-code-owners.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md index 9545173dbc..969a1a3430 100644 --- a/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md +++ b/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md @@ -118,6 +118,7 @@ apps/ @octocat ``` {% warning %} + **Warning:** There are some syntax rules for gitignore files that *do not work* in CODEOWNERS files: - Escaping a pattern starting with `#` using `\` so it is treated as a pattern and not a comment - Using `!` to negate a pattern