### Why:
A lot of content gets mistranslated, some common patterns are: frontmatter date and enums getting translated, liquid tags get translated or go missing during the translation process. These translation errors are tough to catch, especially when they often come in huge PRs.
### What's being changed:
- Frontmatter is also getting linted against schema as part of `lint-files`
- When an environment variable `TEST_TRANSLATION` is passed,
- `lint-files` will run its tests against all files that have been newly translated (by git-diffing between `translations` branch and `main` branch), and
- results are outputted using a custom jest reporter. The output is formatted in a way that makes it easy to exclude the problematic translated files from being merged, and to share the errors with [localization support](https://github.com/github/localization-support/issues/489).
- Run the implemented translation test as part of the existing `Node.js Tests - Translations` workflow
* Write our plugin
* Include it
* Move the RegEx
* Don't rewriteLocalLinks with cheerio anymore
* Process after HTML ast is generated
* Use the same logic as before, just to see if it'll pass
* Don't require languageCode/version
* Only work on local links
* Needs an href
* Only update href if there's a new one to use
* Check for node.properties
* Some links are just mean
* Move use-english-headings to be a plugin
* Bail if no englishHeadings were passed
* Install rehype-wrap
* Wrap ol > li img in div.procedural-image-wrapper
* Test for platform without cheerio
* Use a plugin for rewriteAssetPathsToS3
* Remove cheerio from page.render
* Fix require paths
* SImplify
* Fix some 🐛s
* Use our own rehype-wrap
* Move rewriteAssetPathsToS3 after HTML AST
* Remove some console logs
* Fix check for includesPlatformSpecificContent
* Rename ast => tree
* Uninstall hubdown, install unified deps
* Create create-processor
* Use it
* Update a doc
* Tweak the language
* Use the same versions that hubdown used
* Add Lunr as a site search option
* Use a class like the Algolia option does
* Lint
* Working on showing real content, prep for highlighting
* Move searching to their own files
* Split out ridiculous fn
* Add highlighting
* Less lunr search code
* A little more tidy
* Then chain on write too
* Mark from server too
* Write a batch of indices
* Update compress.js
* Highlighting with fewer calls
* Update lunr-search.js
* Update lunr-search.js
* Update lunr-search.js
* Update lunr-search.js
* Update lunr-search.js
* Update lunr-search.js
* Add markdown parsing dependencies
* Use it for the link test
* Use ast tests for hard-coded language
* Dedupe visiting for links
* Add new mdast utils to check-deps exclusions
* Move site search to use an endpoint
* Update browser.js
* Update search.js
* Update lib/search/versions.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Fix URLs
Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Explicitly set the Redis database number used for rate limiting
* Switch to using ioredis as the Redis client for rate limiting
* Install ioredis-mock as a primary dependency
* Create a Redis BasicAccessor class and tests
* Switch rendered page caching to use Redis for storage
* Add support for additional Redis SET options like TTLs
* Remove currently unused methods
* Rename redis-accessors/basic to redis-accessor and remove extra fluff
* Change default behavior for cache setting to throw if an error occurs
Add option allowSetFailures to facilitate graceful failures
* Allow SET failures to fail gracefully for the rendered page cache
* Remove as-yet unneeded serialization options from RedisAccessor
* Move Redis client construction into RedisAccessor constructor, just pass in databaseNumber as option
* Remove rendered-page-cache in favor of direct RedisAccessor use
* Add tests for RedisAccessor constructor param validations
* Eliminate one roundtrip to Redis for the cached HTML existence check
Are we fast yet?
* Set a rendered page cache TTL of 24 hours
* npm i connect-datadog
* Add connectDatadog middleware
* Add comments
* Use DD_API_KEY to gate
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
* Update README
* create structure for discussions landing page
* is everything broken
* [Universe] Dark mode (#16545)
* Fix title
* Add Discussions product
* Correct title
* Correct title
* Move quickstart article
* Move quickstart back out into article
* Add and incorporate reusables
* Move information about search
* Draft conceptual information
* Draft best practices
* Draft further reading
* Draft product introduction
* Draft introduction
* Add author metadata
* Pluralize
* Fix typos
* Add introduction
* Bump Octicons
* Add some reusables
* Add images
* Revise article
* Draft article
* Change word
* 🔪 the gerund
* Add reusable
* Revise introduction
* Revise list
* Simplify
* Revise reusable
* Fix reusable; add context
* Rename reusable
* Deduplicate conceptual information
* 🔪 gerund
* Add link to further reading
* Move link and dispose of tip
* Delete space
* Add images
* Add conceptual section
* Add word
* Delete newline
* Revert package.json to state on main
* Tweak images
* Draft article
* Add product name
* Remove beta note
* Use product name for future-proofing
* Begin adding search information
* Fix copypasta
* little edits
* build out a bit more of the guides content
* Don't mention integrations for now
* Escape quote
* Remove authorship information for new defaults
* Finish drafting article
* Replace encoded character to match description
* Revise away inline link
* Accommodate 'for more information' in reusable
* Fix links
* Fix one last bit of copypasta
* Update indices
* Temporarily remove heading
* Update introduction
* Add new article 💀
* Remove commits from universe-2020-megabranch
* Add article 💀
* update with a very rough draft
* Add content about collaboration options to "About repositories"
* Add content about discussions to "About issues"
* Reorder content
* Add is:discussion query
* update with a few mmore fleshed out sections
* update with more structure
* Add reusable
* Add screenshots
* Clear way for actual procedural
* Discussions landing page "Communities" section (#16692)
* Make button Overview-able
* Make card filtering more extensible
* Guard for missing attributes
* Use arbitrary dataset attributes
* Add section with discussions-community-card
* Tweak show more button behavior
* Conditionally show "Show more"
* Add beta_product frontmatter/label
* Remove beta callout note
* Hide changelog with no items
* Finish importing community info
* Fix borked markup
* Omit search abr
* Two columns should actually be two columns
* Use org image, change card layout
* Add two more examples
* Fix title
* Escape quote
* Escape another quote
* Draft article
* Lower case
* Relocate conceptual information
* Update qualifier name
* Draft article
* Add conceptual information and links
* Remove duplicative section
* Fix copypasta
* Revise reusable
* Update link
* Add content on categories
* Lint the discussions YAML file
* Update introduction and permissions
* ⚓
* Reusablize; fix link
* more planning content stuff
* Escape quotes
* Align prerequisites
* Soften
* Clean up prerequisites
* Fix titles; version; add screenshot
* Fix links
* Actually fix links
* Use better variable
* Mention pinning
* Update screenshots
* Add screenshot
* forgot to committ
* update with reusable
* add that screenshot
* beef up landing page a bit
* remove extra space
* messed that up
* fix hardcoded linkks weirdo
* fix tests
* update with permissions content
* update with placeholder
* filter out standalone category files from test
* update
* update @becca's ⚡ feedback
* update with more feedback
* so many updates
* fix links
* fix some more tests
* flesh some more things out
* update with further reading blah blah
* fix some things
* remove the gate-features label for beta ship only
* Add discussions video to product landing page (#16759)
* Add discussions video placeholder
* This might work maybe
* fix tests
* apply all of @becca's and @lecoursen's ⚡ feedback ❤️
* rename to fix test
* Revert "Add discussions video to product landing page (#16759)"
This reverts commit 2247e5d0881ca6b36cee421218e8341a7cc12ac7.
* update with test fix
Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
* chore: Move standard to ESLint config
* fix: auto-fix ESLint indent issues
* fix: ESLint prefer-regex-literals
* fix: ESLint array-callback-return
- .filter must return a boolean value
- .map replaced with forEach when the value isn't used
* fix: ESLint no-extra-semi
Kevin Heis
Vanessa Yuen
Jason Etcovitch
Sarah Schneider
James M. Greene
Simran Spiller
Simran
Meg Bird
Octomerger Bot
Robert Mosolgo
Robert Mosolgo
Sarah Schneider
Lucas Costi
Nick Schonning