Граф коммитов

67 Коммитов

Автор SHA1 Сообщение Дата
Kevin Heis 3ea7737a9b
Update scroll-up.js 2021-02-23 08:55:01 -08:00
Kevin Heis bae890e9b3
Update scroll-up.js 2021-02-23 08:51:46 -08:00
Kevin Heis 8b6e1bed8b
Merge branch 'main' into add-button-for-scrolling-to-top 2021-02-22 14:40:16 -08:00
Kevin Heis bcd91a04c6
End survey stars AB test (#17907)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-02-22 18:27:57 +00:00
Kevin Heis 46ccfc5d93
Run AB test on survey stars (#17861)
* Run AB test on survey stars

* Update browser.js

* Use text stars instead of primer ones

* Update experiment.js
2021-02-18 16:29:17 +00:00
Kevin Heis 626bfa5918
Move the one performance metric in page to exit to avoid join (#17784) 2021-02-11 16:28:07 +00:00
kazuhitonakayama 92163877c1 fix conflict 2021-02-11 18:56:41 +09:00
Kevin Heis a3ad549e39
Block a few more things in AIRGAP (#17657)
* Block a few more things in AIRGAP

* Update middleware/context.js

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

* Update product-landing.html

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
2021-02-09 23:07:23 +00:00
Kevin Heis 1918d2ea14
Inline CSRF token in HTML (#17748)
* Inline CSRF token

* Fix tests
2021-02-09 22:08:24 +00:00
Kevin Heis 207c536609
Add `page_event_id` to all successive events (#17738)
* Add `page_event_id` to all successive events

* Update events.js

* Break out event inits into functions so they don't break each other

* Update events.js

* Update events.js

* Update events.js
2021-02-09 15:40:27 +00:00
Kevin Heis e07c603b7d
Remove html-truncate, truncate with CSS instead (#17630)
* Remove html-truncate, truncate with CSS instead

* Update search.js
2021-02-02 17:55:05 +00:00
Vanessa Yuen 4038e9ca85
Add topic property and filter to guides page (#17328)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-29 12:32:31 +00:00
Kevin Heis 8b86fd8fef
Reduce minified JS bundle size from 189kb to 73kb (#17552) 2021-01-28 22:12:04 +00:00
Kevin Heis d9d61f42ef
Add Lunr as a site search option (#17388)
* Add Lunr as a site search option

* Use a class like the Algolia option does

* Lint

* Working on showing real content, prep for highlighting

* Move searching to their own files

* Split out ridiculous fn

* Add highlighting

* Less lunr search code

* A little more tidy

* Then chain on write too

* Mark from server too

* Write a batch of indices

* Update compress.js

* Highlighting with fewer calls

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js
2021-01-28 19:38:22 +00:00
Kevin Heis 99a85ff4ef
Push query string when searching (#17417)
* Push query string when searching

* Update search.js

* Fix browser test, remove querystring dependency (new shiny!)

* Remove language and version from visible URL

* Avoid casting event interface

* Update search.js

* Update browser.js
2021-01-25 11:52:55 -08:00
Kevin Heis c51f5390d4
Move search results to use relative urls (#17411)
* Move search results to use relative urls

* ..and now we have real mark tags instead of em tags

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-21 17:23:16 +00:00
Kevin Heis 526f42d1de
Prevent the search form from the vanilla submit (#17414) 2021-01-21 16:36:12 +00:00
Kevin Heis cdb1e4a849
Convert em to mark in search results (#17391) 2021-01-20 21:33:31 +00:00
Kevin Heis 2fb2e962bc
Move site search to use an endpoint (#17359)
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-01-20 15:37:42 +00:00
Vanessa Yuen b46da8dfc7
Sublanding page all guides section (#16869)
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-18 12:23:23 +00:00
Melanie Yarbrough c2336bb11e
[DO NOT MERGE] GitHub Enterprise Server 3.0 release candidate megabranch (#16479) 2021-01-13 19:16:05 -08:00
Vanessa Yuen 641ed02e81
Actions Guides sublanding page (#16740)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
2021-01-11 18:30:57 +01:00
Kevin Heis d7eb248a10
Fix a bunch of random typos (#17129)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-05 16:07:27 +00:00
kazuhitonakayama 389fde5d93 Place a scrollable button to the top of the page
When a site is viewed from a smartphone or other device, the absence of the relevant button may cause difficulty for users.
2020-12-25 15:28:44 +09:00
Kevin Heis 59f375ab1d
Merge branch 'main' into default-platform 2020-12-16 14:36:46 -08:00
Jason Etcovitch f8074874be
A couple of tweaks to release notes page (#16934)
* Add link

* Allow multiple print buttons

* Fix scrolling for tall sidebar

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-14 22:01:14 +00:00
Simran 2a3fdd43ac
Merge branch 'main' into default-platform 2020-12-09 02:06:46 +01:00
Simran Spiller 4dc1ce1322 Lint 2020-12-09 02:01:54 +01:00
Simran Spiller 64f2d638d5 Add support for defaultPlatform frontmatter
TODO: add 'all' to frontmatter schema enum?
2020-12-09 01:28:09 +01:00
Meg Bird 754ceda517
[Universe] Discussions Public Beta (#16547)
* Update README

* create structure for discussions landing page

* is everything broken

* [Universe] Dark mode (#16545)

* Fix title

* Add Discussions product

* Correct title

* Correct title

* Move quickstart article

* Move quickstart back out into article

* Add and incorporate reusables

* Move information about search

* Draft conceptual information

* Draft best practices

* Draft further reading

* Draft product introduction

* Draft introduction

* Add author metadata

* Pluralize

* Fix typos

* Add introduction

* Bump Octicons

* Add some reusables

* Add images

* Revise article

* Draft article

* Change word

* 🔪 the gerund

* Add reusable

* Revise introduction

* Revise list

* Simplify

* Revise reusable

* Fix reusable; add context

* Rename reusable

* Deduplicate conceptual information

* 🔪 gerund

* Add link to further reading

* Move link and dispose of tip

* Delete space

* Add images

* Add conceptual section

* Add word

* Delete newline

* Revert package.json to state on main

* Tweak images

* Draft article

* Add product name

* Remove beta note

* Use product name for future-proofing

* Begin adding search information

* Fix copypasta

* little edits

* build out a bit more of the guides content

* Don't mention integrations for now

* Escape quote

* Remove authorship information for new defaults

* Finish drafting article

* Replace encoded character to match description

* Revise away inline link

* Accommodate 'for more information' in reusable

* Fix links

* Fix one last bit of copypasta

* Update indices

* Temporarily remove heading

* Update introduction

* Add new article 💀

* Remove commits from universe-2020-megabranch

* Add article 💀

* update with a very rough draft

* Add content about collaboration options to "About repositories"

* Add content about discussions to "About issues"

* Reorder content

* Add is:discussion query

* update with a few mmore fleshed out sections

* update with more structure

* Add reusable

* Add screenshots

* Clear way for actual procedural

* Discussions landing page "Communities" section (#16692)

* Make button Overview-able

* Make card filtering more extensible

* Guard for missing attributes

* Use arbitrary dataset attributes

* Add section with discussions-community-card

* Tweak show more button behavior

* Conditionally show "Show more"

* Add beta_product frontmatter/label

* Remove beta callout note

* Hide changelog with no items

* Finish importing community info

* Fix borked markup

* Omit search abr

* Two columns should actually be two columns

* Use org image, change card layout

* Add two more examples

* Fix title

* Escape quote

* Escape another quote

* Draft article

* Lower case

* Relocate conceptual information

* Update qualifier name

* Draft article

* Add conceptual information and links

* Remove duplicative section

* Fix copypasta

* Revise reusable

* Update link

* Add content on categories

* Lint the discussions YAML file

* Update introduction and permissions

* 

* Reusablize; fix link

* more planning content stuff

* Escape quotes

* Align prerequisites

* Soften

* Clean up prerequisites

* Fix titles; version; add screenshot

* Fix links

* Actually fix links

* Use better variable

* Mention pinning

* Update screenshots

* Add screenshot

* forgot to committ

* update with reusable

* add that screenshot

* beef up landing page a bit

* remove extra space

* messed that up

* fix hardcoded linkks weirdo

* fix tests

* update with permissions content

* update with placeholder

* filter out standalone category files from test

* update

* update @becca's  feedback

* update with more feedback

* so many updates

* fix links

* fix some more tests

* flesh some more things out

* update with further reading blah blah

* fix some things

* remove the gate-features label for beta ship only

* Add discussions video to product landing page (#16759)

* Add discussions video placeholder

* This might work maybe

* fix tests

* apply all of @becca's and @lecoursen's  feedback ❤️

* rename to fix test

* Revert "Add discussions video to product landing page (#16759)"

This reverts commit 2247e5d0881ca6b36cee421218e8341a7cc12ac7.

* update with test fix

Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2020-12-07 15:00:35 -07:00
Kevin Heis 11d8e415da
Check repository references (#16680)
* Check repository references

* Remove "foundRepoNames" that I used to find all the unique names

* A little speed up with Set

* Ignore a few files

* Remove remaining references

* Update README.md
2020-12-03 16:41:03 +00:00
Kevin Heis 685e7a3655
Remove unsafe eval (#16704)
* Remove unsafe eval

* Actually, we're not using this anyways

* Reset package-lock, I have no idea why this keeps changing

* Update csp.js

* Update server.js
2020-12-02 16:19:14 +00:00
Kevin Heis 912ac50034
End AB test on moving helpfulness prompt to bottom (#16552)
* End AB test on moving helpfulness prompt to bottom

* Move helpfulness to bottom of page only

* Update helpfulness.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-11-20 12:24:33 -08:00
Kevin Heis 30b2f8fd1d
Fix chrome not sending exit events (#16488)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-11-19 10:02:53 -05:00
Rachael Sewell 82407992d2
remove inactive sidebar links (#16500) 2020-11-17 14:26:14 -08:00
Kevin Heis 5bd61aa4b8
Experiment with moving Helpfulness Prompt to bottom of the page (#16448)
* Experiment with moving Helpfulness Prompt to bottom of the page

* Update experiment.js

* Update experiment.js
2020-11-17 14:10:03 -08:00
Kevin Heis 08880d9ecb
Sort middleware by categories (#16494) 2020-11-17 09:49:10 -08:00
Sarah Schneider 0df625c7ea
Merge branch 'main' into add-dev-toc-redux 2020-11-17 11:56:32 -05:00
Sarah Schneider e6629a6416 fix Expand and Close toggling 2020-11-17 11:35:19 -05:00
Sarah Schneider 7848e3ce08 return early instead of erroring out on nonstandard page 2020-11-16 20:42:26 -05:00
Sarah Schneider b5dddd4ac9 move deprecation date calculation from client side to server side 2020-11-16 20:06:16 -05:00
Sarah Schneider 9143e5d413 lint 2020-11-16 16:21:28 -05:00
Sarah Schneider 6d8792e43c Merge branch 'main' of github.com:github/docs-internal into add-dev-toc-redux 2020-11-16 16:14:08 -05:00
Sarah Schneider 86678fee34 add dev-toc javascripts 2020-11-16 16:13:42 -05:00
Kevin Heis 714ca0263b
Add `hostname` to events (#16419)
...so that its easier to filter out localhost and herokuapp domains
2020-11-16 09:49:12 -08:00
Kevin Heis db4fad8670
Hide sidebar navigation during AB test (#16447) 2020-11-16 09:43:44 -08:00
Jason Etcovitch 7b31c08e16
"All articles" component of Actions landing page (#16318)
* Spike out all-articles.html

* Use it somewhere

* Do the thing

* Use 3 columns

* Increase space between links

* Hide standalone categories

* Move all-articles to bottom of product-landing

* Add obj_size filter

* Add buttons if numArticles > 10

* Add click event to show

* Add a chevron ^

* Assign maxArticles for some DRY fun

* Add some comments
2020-11-12 12:57:30 -05:00
Jason Etcovitch 9e38a854b9
Filterable code examples on Actions landing page (#16276)
* Add custom hover shadows

* Support avatars

* Add guide-card include

* Use it in product-landing

* Add gradient styles

* Add guides frontmatter

* Use guideArticles instead of full objects

* Add support for authors

* Add support for category header

* Just pass the whole page

* Use it

* guide.url => guide.href

* Use `*.githubusercontent.com`

* Fix mobile card width

* Remove showDescription check

* Use featureLinks.guideCards

* Forgot an if

* Add contextualizers/actions-code-examples

* Use code-example-card include

* Tweak sizing/shadows

* Add a basic filterer

* Some visual tweaks

* labels => tags

* Cleanup some code

* Improve spacing on mobile

* Add "No results!" blurb

* Fix a boog

* Tweak spacing

* Remove support banner

* Improve "No results" state

* Just use login instead of name/avatarUrl

* Change card spacing

* Use circular avatars

* Add "Show more" button

* Add margin beneath "Guides"

* Use smaller font

* Assume github.com for code examples

* Show two columns at small screen

* Make "Show more" a btn

* Use the "repo" octicon

* Link to contributing guide

* Use a YAML file instead of a middleware

* Link straight to the file

* Fix some wonky markuip

* Fix a broken link

* Fix the borked test

* Allow variables that aren't strings

* Fix remaining tests
2020-11-12 11:35:43 -05:00
Cynthia Rich d2d56ee206
Create hello world actions quickstart (#16218)
* create hello world quickstart

* Fix image link

* Apply suggestions from code review

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Add step to merge pull request before triggering workflow

* Add slash in front of file path

* Remove unused reusable

* more explaining in hello world quickstart

* Add invitation to create new repo

* Add experiment code

Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-11-10 17:05:07 +00:00
Sarah Schneider 15f3f14096
Tweak code wrapping in tables (#16406)
* tweak code wrapping

* empty commit to rerun ci
2020-11-09 15:09:42 -05:00