Граф коммитов

361 Коммитов

Автор SHA1 Сообщение Дата
Grace Park 2ae7d02f1a
adding keyboard focus to survey buttons (#24595) 2022-01-24 14:11:53 -08:00
Grace Park a0a24b605c
Keyboard Focus for Guides Page: Learning Paths (#24483)
* remove useEffect on ref

* updating keyboard focus for guides page
2022-01-21 16:33:03 +00:00
Grace Park ddc5e19570
remove useEffect on ref (#24470) 2022-01-20 21:06:24 +00:00
Grace Park eb776f64e4
Small accessibility changes - adding ul to li (#24449)
* adding ul to li

* move ul for just the mobile picker
2022-01-20 17:54:49 +00:00
Peter Bengtsson f2f679550d
display possible search error (#24429)
* display possible search error

* feedbacked
2022-01-19 21:41:17 +00:00
Robert Sese d0db00cd98
a11y: match picker label with current selection (#24321)
* Match label with selection

* defaultText is a better default

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* No longer used

* Also no longer used

* No longer used in the dropdown pickers

* Add translation strings for pickers

* Use translated strings in picker components

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 18:43:31 +00:00
Robert Sese 54af81acd5
a11y: update code example search (#24226)
* Search on submit

* Should be a ul

* Fix broken link

* No search on change event

* Add translation strings

* Add role for the 0 results message

* Update test with new search behavior

* Make search input a controlled component

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Trim whitespace in search text

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Better variable names

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update visible results count in useEffect

* Control the input's value with the typed state

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Inline the submit handler

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 12:53:50 +00:00
Robert Sese 1c768fe9a0
a11y: even more headings adjustments (#24315)
* Adjust Enterprise supported release card heading

* Adjust learning track headings

* Adjust guide list card headings
2022-01-14 20:08:55 +00:00
Robert Sese cc69799558
a11y: landing page headings adjustments (#24295)
* Adjust heading level and only heading with intro text

* Adjust heading level

* Adjust code example and guide card heading levels

* Adjust tests for new heading levels

* Adjust rendering test for new heading levels
2022-01-14 17:23:05 +00:00
Grace Park d5097397c8
underline links on toc pages (#24217) 2022-01-11 20:48:35 +00:00
Grace Park f5c615cbd0
Guides List markup and Link Icon in Permalink Headings (#24211)
* list markup for article cards and learning paths

* adding link icon to section permalinks
2022-01-11 11:38:57 -08:00
Grace Park d2494c3e2d
Keyboard focus on Guides Pages (#24209)
* accessibility: make label autofocus on dropdown when clicked

* update to div element

* fix keyboard focus on X more guides and load more guides

* tabIndex is optional
2022-01-11 19:26:12 +00:00
Grace Park 69543377cb
Accessibility: Guides Pages, types/topics dropdown (#24185)
* accessibility: make label autofocus on dropdown when clicked

* update to div element
2022-01-11 17:53:55 +00:00
Peter Bengtsson 4947218cba
fix React key uniqueness in Breadcrumbs (#24182) 2022-01-11 01:56:30 +00:00
Rachael Sewell a340162d84
reorganize repository apis (#23728)
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 11:53:12 +10:00
Robert Sese d31d6a5b4e
a11y: add title text for view all links (#24193)
* Add optional 'view all' title text in the context

* Use viewAllTitleText in ArticleList

* Set viewAllTitleText for sections with 'view all' links
2022-01-11 01:30:10 +00:00
Robert Sese fcc9b904dd
Comment on why we do manual email validation (#24192)
* Comment on why we do manual email validation

* One 'do'
2022-01-10 22:47:46 +00:00
Grace Park 0b33fbb167
Fix max height for minitocs (#24163)
* update max-height

* set fixed max height for mini tocs to make scrollable from top
2022-01-08 01:48:02 +00:00
dependabot[bot] ce8f21487b
Bump @primer/components from 32.1.0 to 33.1.0 (#24023) 2022-01-08 00:25:04 +00:00
Grace Park e37fc2edd9
Accessibility footer color color contrast ratio (#24158)
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block

* add emphasis color on border to meet accessibility color contrast ratio

* update border for footer buttons to meet accessibility color contrast ratio

* run prettier
2022-01-07 16:20:54 -08:00
Robert Sese 76b0b5ade1
a11y: survey email validation (#24159)
* Add email error state checking

* Clear email error on cancel

* Disable submit if email is invalid

* Add Primer-ized error message

* Add aria attributes

* Better function name
2022-01-08 00:01:42 +00:00
Grace Park 47de433865
Accessibility Search updates and additional minor changes (#24136)
* update to use heading markup

* updating to h3 for accessibility

* increase opactiy to meet 5.5:1 color contrast ratio

* update opacity to meet color contrast ratio

* update styling to match original but use heading markup

* remove aria-hidden for accessibility

* add h1 title search results and update scroll tip colors

* add number of matches

* remove no results since we are showing 0 results

* add overflow to fix border bottom on version search

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* incorporating feedback and update padding

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-07 21:29:49 +00:00
Grace Park a4c5d58507
Accessibility: Breadcrumbs (#24151)
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block
2022-01-07 12:01:52 -08:00
Peter Bengtsson 7d75265b01
hydration fails on CollapsibleSection with hash in URL (#24105) 2022-01-07 02:25:16 +00:00
Robert Sese d2b9b236c4
Add label for search input (#24130) 2022-01-06 22:35:56 +00:00
Peter Bengtsson 5893ae32b3
don't let the href depend on the router hash in client-side rendering (#24106) 2022-01-06 20:59:47 +00:00
Grace Park 124f54eb0c
Accessibility changes for Nav Menu (#24099)
* updating to nav landmark

* support keyboard esc to close mobile menu

* update to ChevronDown to remove nested div
2022-01-06 17:34:19 +00:00
Robert Sese bcb1b3c8bc
Use lang attribute and translate picker aria-label (#24096)
* Translate picker aria-label

* Use lang attribute
2022-01-05 23:28:05 +00:00
Peter Bengtsson 3f9d798037
render same DOM in SSR as client (#24078) 2022-01-05 14:53:43 +00:00
hubwriter 0651660f33
Change "workflow templates" to "starter workflows" (#23823)
Co-authored-by: skedwards88 <skedwards88@github.com>
2021-12-21 18:15:54 +00:00
Robert Sese 5d88ffbef7
Use ol for LearningTracks (#23461)
* Use ol for LearningTracks

* Flip li counter bg/fg colors

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-12-17 13:52:49 -06:00
Robert Sese a2bd8ae67f
Add support for videos to landing pages (#23801)
* Add new video properties frontmatter

* Handle video links in the middleware

* Video links don't have intros, authors, or full titles

* Make videos available from context

* Add default video heading

* Add basic tests for videos

* tmp videos test

* Remove stray test debugging

* more tmp videos testing

* Add videos test fixture

* Revert "more tmp videos testing"

This reverts commit 382946a5603ff217014797f77f37216bb8bb6c9c.

* Revert "tmp videos test"

This reverts commit 8767d0eaf08bd4ca04e2dacd12d476a2506c0367.
2021-12-17 11:09:00 -06:00
Grace Park 65db364ef1
remove avatar for accessibility (#23706) 2021-12-16 17:09:35 +00:00
Peter Bengtsson 53b0484a66
unique keys for RestRepoBanner links (#23764) 2021-12-15 16:08:43 -08:00
Grace Park 9e21836f4d
Revert "Accessibility: Nesting headingLevel 3 mini tocs (#23663)" (#23759)
This reverts commit 41c7f58437.
2021-12-15 12:34:21 -08:00
Robert Sese 5ff7bf2c65
Capitalize and comma outside link (#23723) 2021-12-14 16:57:24 -06:00
Rachael Sewell bf7b2085bd
fix broken links in banner component (#23719) 2021-12-14 14:00:47 -08:00
Rachael Sewell daafb8cb9d
break up large rest pages (#23652) 2021-12-14 20:39:25 +00:00
Grace Park 11a01104b1
update to list mark up for screen readers (#23712) 2021-12-14 11:58:48 -08:00
Grace Park a39f8a16bd
add permanent search code example label (#23709) 2021-12-14 11:14:18 -08:00
Grace Park 41c7f58437
Accessibility: Nesting headingLevel 3 mini tocs (#23663)
* nesting headingLevel 3 mini tocs

* fix tests

* Update components/article/ArticlePage.tsx

Co-authored-by: Robert Sese <robert.sese@gmail.com>

* run prettier

Co-authored-by: Robert Sese <robert.sese@gmail.com>
2021-12-14 04:29:09 +00:00
Kevin Heis 821c1e693b
Release note sticky fixes (#23643) 2021-12-13 18:23:30 +00:00
Grace Park cb4e962ce8
fixing styling of toc pages (#23583) 2021-12-13 18:05:02 +00:00
Grace Park e0c31e09e7
update padding bottom (#23580)
Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
2021-12-13 09:58:53 -08:00
Grace Park 3ce46b9172
move custom tool tip to remain permanent next to scroll to top button (#23551) 2021-12-13 17:40:48 +00:00
Peter Bengtsson 815f9d40c3
only link all enterprise versions if any is enterprise version (#23640) 2021-12-13 17:19:15 +00:00
Peter Bengtsson 9d59f7dc8b
Lack of unique React keys (#23573) 2021-12-11 03:32:45 +00:00
Grace Park 70262789ec
make clear list structure in footer for accessibility (#23549) 2021-12-09 20:31:22 +00:00
Robert Sese 4ce6dd2840
More misc a11y bits (#23542)
* List-ify guide labels

* Use aria-expanded with 🍔 menu
2021-12-09 19:20:04 +00:00
Grace Park 078fdc9a71
Remove bumplink symbol (#23539)
* run prettier

* removing space

* run prettier again
2021-12-09 18:41:35 +00:00
Grace Park f19223503a
Update Search Version Button to Dropdown (#23465)
* adding to view

* updating the portal location

* add new line

* updating font styling to class

* Update components/Search.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Update components/Search.module.scss

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update ItemInput

* using router.replace and import updates

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* run prettier

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-12-09 17:56:24 +00:00
Kevin Heis 86b5a52b3e
Query string abuse causing 5xxs (#23501) 2021-12-08 21:05:32 +00:00
Robert Sese 9dbc44100c
Misc accessibility bits (#23495)
* Fix and make article date format consistent

* Add aria-label to repo icon

* Remove unnecessary title attribute
2021-12-08 19:01:40 +00:00
Peter Bengtsson 7f6f20a73f
run prettier on all code in CI (#23482)
* run prettier on all code in CI

* rename

* test .tsx too

* ignore more

* prettier the stragglers

* minimal permission
2021-12-08 16:11:52 +00:00
Matt Pollard b3e1ff4e89
Update documentation for GitHub AE's December 2021 release (#23405) 2021-12-07 10:36:37 +01:00
Peter Bengtsson 046de169fd
fix TypeScript violation with Overlay in @primer/components@32.1.0 (#23358)
Part of #1311
2021-12-03 19:43:12 +00:00
Grace Park 8931793024
updating table-of-contents pages with actionlist (#23338) 2021-12-02 12:50:04 -08:00
Robert Sese 9d79148aef
ActionList for LearningTracks (#23335)
* ActionList for LearningTracks

* Try to resolve TS error
2021-12-02 19:59:01 +00:00
Grace Park 4ff5167e51
Updating name: sublanding to guides and using DropdownMenu for type/topics filter (#23290)
* updating sublanding to guides page and using DropdownMenu primer component

* fix linting error

* remove unnecessary import

* updating translation files

* move data-testid

* trying to fix test

* fix browser tests

* Update content/README.md

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
2021-12-02 18:43:33 +00:00
Peter Bengtsson 93a11d50f3
prettier release date on enterprise release logs (#23288)
Part of #1291
2021-12-01 23:06:33 +00:00
Peter Bengtsson d98af05017
unbreak React unique key prop warning (#23279) 2021-12-01 22:39:07 +00:00
Robert Sese 37b311dd8f
Actionlist-ify ProductArticleList (#23280)
* WIP: ActionList ProductArticleList

* remove mb

* Put article count in link

* Full width links

* remove indent

* fixing link space for mini tocs

Co-authored-by: Grace Park <gracepark@github.com>
2021-12-01 21:49:52 +00:00
Robert Sese b67bd854c4
Override border-radius (#23271) 2021-12-01 11:00:48 -06:00
Robert Sese ae22e18a9a
Use ActionList for ArticleList (#23252)
* Use ActionList under the hood for ArticleList

* Update components/landing/ArticleList.tsx
2021-12-01 00:16:03 +00:00
Grace Park 29f8e80e71
HomePage Component Updates (#23251)
* separaet out into homepage components

* remove unnecessary translation

* update component names
2021-12-01 00:08:49 +00:00
Grace Park 3ca4b73bc4
update to bold instead of yellow highlighting (#23244) 2021-11-30 22:02:30 +00:00
Mike Surowiec 39cdb0dce6
fix: tool picker update content on currentTool change (#23216) 2021-11-30 17:07:39 +00:00
Kevin Heis e3b2e820fd
React tool picker (#23004)
* Working on tool picker

* Start on react version of tool picker

* Update ToolPicker.tsx

* Update tool-switcher.html

* Get it working

* Update browser.js

* Update browser.js

* Update ToolPicker.tsx
2021-11-29 23:04:06 +00:00
Amy Burns c3bc538cd4
Add 2 pane layout to "Setting up Codespaces" docs and update IA (#21700) 2021-11-24 11:41:30 -08:00
Robert Sese 74c94121be
Use Primer ActionList for sidebar (#22885)
* Initial move to ActionLists nav, handle terminal links

* ActionList-ify map topic items

* Some 🎨

* ActionList-ify homepage sidebar

* More 🎨

* Resolve test failures (and 'better' markup?)

* Properties don't exist on ActionList

* Use ul + li elements for ActionLists

* Workaround for TS error with 'as='

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
2021-11-23 18:33:54 +00:00
Grace Park a3e67be13a
design system request (#23071) 2021-11-23 17:50:26 +00:00
ahdbilal 487c56cb49
update actions docs with setup-python caching (#22990)
* updated the python testing doc with caching

* updated docs with setup-actions caching for node and python

* updaed content with setup-actions cachine

* fix links

* Update content/actions/advanced-guides/caching-dependencies-to-speed-up-workflows.md

Co-authored-by: MaksimZhukov <46996400+MaksimZhukov@users.noreply.github.com>

* Update components/playground/content/building-and-testing/python.tsx

* Update components/playground/content/building-and-testing/python.tsx

* Update content/actions/advanced-guides/caching-dependencies-to-speed-up-workflows.md

* Update content/actions/advanced-guides/caching-dependencies-to-speed-up-workflows.md

* Update content/actions/advanced-guides/caching-dependencies-to-speed-up-workflows.md

* Update content/actions/automating-builds-and-tests/building-and-testing-python.md

* Update content/actions/automating-builds-and-tests/building-and-testing-python.md

Co-authored-by: MaksimZhukov <46996400+MaksimZhukov@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
2021-11-23 17:26:03 +00:00
Mike Surowiec 0c3fa5f80b
fix: use components/Link in Search.tsx (#23019) 2021-11-22 15:08:02 +00:00
Kevin Heis 58fbe1edf5
Move px to rem in scss files (#23009)
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-11-19 21:06:45 +00:00
Grace Park 33c5ce2d36
Updating images styling and accessibility for minitocitems (#22976)
* updating images styling on design systems feedback

* maintaining ul li structure for accessiblity

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
2021-11-19 00:56:51 +00:00
Kevin Heis f17c7a2598
Update search to use rem units where possible (#22970)
* Update search to use rem units where possible

* Use more primer classes

* Move more search to primer classes
2021-11-18 20:43:31 +00:00
Kevin Heis 308aa9cb0c
Fix heading sizes (#22968)
* Align heading sizes with Primer

* Make the headings on other pages match normal pages
2021-11-18 19:45:13 +00:00
Grace Park f5008425ba
Updating ordered lists numbering border (#22972)
* updating ordered lists numbering border

* moving 8px away
2021-11-18 11:12:55 -08:00
Grace Park 75577663e9
bringing back i - thanks rsese (#22969) 2021-11-18 17:41:20 +00:00
Grace Park 5a809be3dc
MiniTocItems: rerender tocs and fix bugs (#22948)
* add key to force rerender tocs

* move up platform specific to properly display none and go back to using contents

* remove i
2021-11-17 22:29:07 -08:00
Robert Sese 98d87bb4f2
Make list key unique (#22946) 2021-11-17 23:30:21 -06:00
Grace Park 130016bd0a
Fix html in tocs (#22936)
* fix html in tocs

* render html
2021-11-17 17:17:10 -08:00
Grace Park 0afdf66a08
Primer Update: Table of Contents (#22933)
* update to ActionList

* fix nested mini tocs

* adding key

* remove li and fix tests

* update font size to 14px

* remove border radius
2021-11-18 00:27:12 +00:00
Peter Bengtsson d605556a80
encode 'query' in 'redirectQuery' (#22913) 2021-11-17 23:08:46 +00:00
Peter Bengtsson eb4a4741ad
refactory getting 'query' with a hook (#22879) 2021-11-17 15:02:50 +00:00
Grace Park 56521881a2
Adding scroll to header search results (#22874)
* adding scroll to header search results

* move search-result

* search-result data test id addition

* forgot s
2021-11-16 21:32:45 +00:00
Kevin Heis 329a8c664e
Create a shared picker component (#22836)
* Unified picker component

* Add picker to storybook

* TS fixes

* Simplify "mobile" header spacing

* Fix a few testid

* Update Picker.tsx

* Update Picker.tsx

* Update Picker.tsx

* Fix unit test

* Fix rendering tests
2021-11-16 19:10:28 +00:00
Peter Bengtsson 07a5edd2ab
rewrite search state from useRouter (take 2) (#22833)
* rewrite search state from useRouter (take 2)

* fix the problem with isHeaderSearch

* cleaning ups

* updating mobile search results ui (#22841)

* remove useCallback

Co-authored-by: Grace Park <gracepark@github.com>
2021-11-16 18:55:48 +00:00
Rachael Sewell e919d5085d
change version within search result window (#22702) 2021-11-12 22:01:08 +00:00
Grace Park 5ac9d72005
styling updates and get all results (#22809) 2021-11-12 21:47:40 +00:00
Grace Park 5bf39459ca
Updating Search using Primer Components (#22677)
* updating search icon

* remove no fill

* update fill color

* using ActionList and Overlay

* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark

* add search-results test data and move header search results to right

* make search results scrollable and fix max-width in header search

* update header search and styling updates

* add highlight

* update styling

* styling and lint errors

* fix lint error and fetch

* Update components/Search.tsx

* update label color

* remove bottom margin

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-11-12 12:25:47 -08:00
Mike Surowiec d6e0485602
fix: platform content initial render (#22802) 2021-11-12 11:15:08 -06:00
Mike Surowiec 7310fc998a
Refactor display-platform-specific-content (#22665)
* refactor display-platform-specific-content

* update PlatformPicker tests and cleanup
2021-11-12 14:40:35 +00:00
Ramya Parimi 9dff265cfd
Merge branch 'main' into i11236-fix-workflow-path 2021-11-11 07:05:52 -06:00
Rachael Sewell 0244fda807
search improvements (#22443) 2021-11-10 11:11:28 -08:00
Peter Bengtsson 0d13379462
fix TS usage around VersionPicker (#22739) 2021-11-10 11:00:34 -08:00
Kevin Heis 6ec20638b5
Version picker combo (#22694)
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
2021-11-10 16:20:34 +00:00
ftnext b987ffd10a fix typo in workflow paths 2021-11-10 22:53:34 +09:00
Grace Park d75bd265eb
Flash updates for deprecation and header notifications (#22632)
* flash updates for deprecation and header notifications

* adding import and updating position
2021-11-09 19:52:20 +00:00
Grace Park 240f5fbafe
Updating breadcrumbs (#22626)
* updating breadcrumbs

* fix tests

* one more
2021-11-08 17:53:19 +00:00