Граф коммитов

240 Коммитов

Автор SHA1 Сообщение Дата
James M. Greene a40ff31b4b
Cache more assets both in browser + Fastly (#17663)
* Cache archived asset JS/CSS for a day

* Don't waste time with ETag calculations

* Add a comment about the expiration length

* Cache images and fonts for a day

* Cache GraphQL data files for a week

* Set Fastly surrogate-key header on all responses

* Update test to account for new response header
2021-02-03 22:16:54 +00:00
Rachael Sewell fc430896cb
add azure to content security policy (#17649) 2021-02-03 10:49:40 -08:00
James M. Greene 0e729d9a75
Cleanup the testing and old code related to Fastly headers (#17643) 2021-02-03 10:43:00 -06:00
James M. Greene 8f133cbf54
Disallow both Fastly AND the browser from caching HTML pages (#17641) 2021-02-02 21:37:41 +00:00
Jason Etcovitch 53d8e60959
Add a test for non-English rendering (#17593)
* Throw in some code that should fail a test

* Remove read-frontmatter behavior

* Unskip the test that would catch this

* Remove the throw to pass the test
2021-02-02 18:14:39 +00:00
Vanessa Yuen a1d93a7619
Lint translation files (#17561)
### Why:

A lot of content gets mistranslated, some common patterns are: frontmatter date and enums getting translated, liquid tags get translated or go missing during the translation process. These translation errors are tough to catch, especially when they often come in huge PRs. 

### What's being changed:

- Frontmatter is also getting linted against schema as part of `lint-files`
- When an environment variable `TEST_TRANSLATION` is passed,
   - `lint-files` will run its tests against all files that have been newly translated (by git-diffing between `translations` branch and `main` branch), and
   - results are outputted using a custom jest reporter. The output is formatted in a way that makes it easy to exclude the problematic translated files from being merged, and to share the errors with [localization support](https://github.com/github/localization-support/issues/489). 
- Run the implemented translation test as part of the existing `Node.js Tests - Translations` workflow
2021-02-01 17:59:33 +01:00
Jason Etcovitch 8d4f3e65fe
Move test & script utils out of `/lib` (#17517)
* Remove an unused file

* Move authenticate-to-aws to scripts/utils

* Move crowdin-config to tests/utils

* Remove add-frontmatter-to-file

* Move find-unused-assets

* Move git-utils to script/utils

* Move lib/github to script/utils

* Revert "Remove an unused file"

This reverts commit cd93ad846a0354e957359f23124eb0724c9147cf.

* Move find-extraneous-translation-files to script/utils

* We already have tests/helpers

* Rename script/utils => helpers for consistency

* Forgot a path

* Fix path to crowdin-config

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-29 10:30:51 -05:00
Vanessa Yuen 4038e9ca85
Add topic property and filter to guides page (#17328)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-29 12:32:31 +00:00
Jason Etcovitch 4a761418a9
Add a test for the WIP language banner link change (#17480)
* Add a test

* Try adding de

* Let's try all languages
2021-01-26 20:06:58 -05:00
Jason Etcovitch 612ec766aa
Add glossaries to lint-files tests (#17481)
* Add glossariesDir to glob

* Actually make the test work

* Fix the (legitimate) failures
2021-01-26 21:19:27 +00:00
Jason Etcovitch 40d604d3c9
Add test to check content files against `liquid.parse` (#17479)
* Add the test

* Don't forget this require
2021-01-26 20:59:19 +00:00
Jason Etcovitch b4171bf0d5
Use AST parsing for lint file checking (#17471)
* Add markdown parsing dependencies

* Use it for the link test

* Use ast tests for hard-coded language

* Dedupe visiting for links

* Add new mdast utils to check-deps exclusions
2021-01-26 17:45:23 +00:00
Sarah Schneider 35e430c96d
Merge branch 'main' into make-developer-redirects-static 2021-01-26 11:30:16 -05:00
mc 4996deb228
Merge branch 'main' into 3059-remove-send-from-author 2021-01-26 14:14:14 +00:00
Kevin Heis 99a85ff4ef
Push query string when searching (#17417)
* Push query string when searching

* Update search.js

* Fix browser test, remove querystring dependency (new shiny!)

* Remove language and version from visible URL

* Avoid casting event interface

* Update search.js

* Update browser.js
2021-01-25 11:52:55 -08:00
Sarah Schneider 0dbfa96b65 add message to test output 2021-01-25 13:10:08 -05:00
Vanessa Yuen 9bc90cd932
Learning Track navigation banner (#17440)
* add middleware to handle `learn` query param

* add exception to query-less cache key

* add querystring to learning track guides
2021-01-25 16:57:32 +00:00
shati-patel d63f25091a Try a new test article in server.js 2021-01-23 13:56:49 +00:00
shati-patel eb7ce2b47b Merge branch 'main' into 3059-remove-send-from-author 2021-01-23 13:39:49 +00:00
shati-patel ba2f1570f6 change from `main` 2021-01-23 13:37:51 +00:00
shati-patel de0a8e2430 Update server.js 2021-01-23 13:34:05 +00:00
Kevin Heis 6ae96188f2
Move 404 and 500 images to local (#17432) 2021-01-22 21:49:45 +00:00
Sarah Schneider 8dcab4d8c5
Merge branch 'main' into use-linkinator-for-internal-link-check 2021-01-22 10:08:42 -05:00
Sarah Schneider 4be15f7b87
account for paths with or without version (#17443) 2021-01-22 15:07:08 +00:00
Sarah Schneider b0677b2442 use script instead of jest, much faster 2021-01-22 09:28:06 -05:00
Sarah Schneider 0c5b78ee3b use linkinator for internal link checking 2021-01-21 16:36:22 -05:00
Kevin Heis 2fb2e962bc
Move site search to use an endpoint (#17359)
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-01-20 15:37:42 +00:00
James M. Greene 9724f763f5
Implement discount fingerprinting without webpack (#17337) 2021-01-19 23:00:54 -06:00
Vanessa Yuen b46da8dfc7
Sublanding page all guides section (#16869)
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-18 12:23:23 +00:00
Sarah Schneider 30f95ce3d2 lint 2021-01-15 11:56:51 -05:00
Sarah Schneider c1bd93f269 Merge branch 'main' of github.com:github/docs-internal into remove-fpt-helper 2021-01-15 11:44:24 -05:00
Laura Coursen 77ee3137ef
Refactor protected branches content (#17277)
* Add new structure to index.md

* Move all conceptual and troubleshooting content

* Add more redirects

* Update links

* Reorganize "About" article

* Tweak some conceptual content

* Rename procedural article

* Fix article title in index.md

* Fix links

* Add more redirects

* Fix more links

* Add redirects for "Managing..." and fix links

* Consolidate procedural information

* Remove duplicate redirect

* Fix indentation

* Add 💅

* Add header

* Add editing and deleting

* 💅 conceptual content

* 💅 conceptual content

* 💅 troubleshooting article

* Clarify default behavior

* 💅 gated feature clarification

* Add 💅

* Add 💅

* update hardcoded links in tests

* Fix gated feature reusable

Co-Authored-By: Matt Pollard <mattpollard@users.noreply.github.com>

* Step out of the way while Matt improves all of the legacy content

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>

* Tweak gated feature reusable

Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
2021-01-15 16:43:14 +00:00
Sarah Schneider 564628799c Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-15 09:39:12 -05:00
Sarah Schneider ffb4e548a0 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-15 09:38:15 -05:00
Vanessa Yuen eaacb54422
small liquid link tag cleanup (#17280)
* remove unnecessary `render` methods
* we don't use `link_with_short_title` anymore
* remove `shortTitle` option
* remove ink_with_short_title tag test
2021-01-15 13:24:39 +00:00
Sarah Schneider a394190ad6 Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-14 17:13:06 -05:00
Sarah Schneider ecaec6e78e Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 17:12:27 -05:00
Sarah Schneider 9809627129 lint 2021-01-14 17:10:12 -05:00
Sarah Schneider affbc80a3c update tests to remove free-pro-team from expected results 2021-01-14 17:08:30 -05:00
Rachael Sewell 80575a2983
move deprecated site policy content to new directory (#17270) 2021-01-14 11:41:38 -08:00
Sarah Schneider 2b31096312
Merge branch 'main' into remove-fpt 2021-01-14 13:44:02 -05:00
Sarah Schneider ed8b46267c Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 12:08:27 -05:00
Sarah Schneider 39fe8cb96c add currentVersion to test context 2021-01-14 12:08:01 -05:00
Sarah Schneider 1dab7c6186
Merge branch 'main' into support-ga-in-deprecated-versions 2021-01-14 11:13:14 -05:00
Jason Etcovitch 0ec47e0246
Only read the frontmatter from files in warm-server (#17222)
* Add read-frontmatter.js

* Use it

* Page static read/init are async now

* Fix some blockers

* I'm confused

* Fix some more bugs

* Use frontmatter schema, ensure end fence exists

* Fix a bug

* Still read full contents for index.md files

* Remove comment

* Only get ToC items for index pages

* Readd frontmatter error and verdadero handling

* Fix some borked tests

* Simplify the code

* Add a comment

* Remove redundant variable

* Re-simplify the Page construction

* End chunk _after_ endline

* Just use Page.init
2021-01-14 10:46:59 -05:00
Sarah Schneider 79a7a7972f Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-13 16:58:05 -05:00
Sarah Schneider e3d0009949 remove no-longer needed tests for removed redirects now that legay /v3 and /v4 links have all been updated 2021-01-13 16:50:54 -05:00
Sarah Schneider e1cb587339 update refs to reinstated findPage() 2021-01-13 16:50:20 -05:00
Sarah Schneider 23170a50e6 lint 2021-01-13 16:50:05 -05:00
Sarah Schneider a8afad4eb9 add test 2021-01-13 14:05:36 -05:00