Граф коммитов

530 Коммитов

Автор SHA1 Сообщение Дата
Grace Park d78f1dfa5a
Fix screen width - release notes (#24881)
* fix screen width

* center items

* set maxwidth

* set back to justify between

* adding overflow auto to default layout

* remove center alignment for release note content

* fix vertically align release candidate button

Co-authored-by: Rachael Sewell <rachmari@github.com>
2022-02-02 21:28:47 +00:00
Laura Coursen 4ede312204
Add early access docs for GEI-CLI (#24592) 2022-02-02 14:25:05 -06:00
Rachael Sewell 0d20dc0972
remove unused variables (#24847)
* remove unused variables

* moving label to center

* update span to h3

Co-authored-by: Grace Park <gracepark@github.com>
2022-01-31 23:50:11 +00:00
Grace Park c7ff324110
Release Notes Primer Update: Remove top navigation buttons convert download link to button (#24844)
* remove navigation buttons at top and convert download link to button

* remove background color
2022-01-31 22:17:23 +00:00
Rachael Sewell bd0cc83d73
use accessible text for view all links (#24747) 2022-01-31 22:02:29 +00:00
Rachael Sewell 845de4f29d
add underline to categories in all docs section (#24818) 2022-01-31 18:22:49 +00:00
Grace Park 934b255119
add keyboard focus to scroll top and remove wording to keep one button (#24817) 2022-01-31 17:45:44 +00:00
Anosike Osifo ec73762b3e
Add GHEC Trial CTA to header of docs.github (#23324)
* Add GHEC Trial CTA to header of docs.github

* use i18n logic

* add signup cta

* add signup cta

* Update the Trial CTA href to allow users choose trial plan

* Update logic to conditionally display signup CTA. Also remove GH EC Trial CTA

* update logic to use && operator

* fix wrapping search bar bug
2022-01-28 20:15:54 +00:00
Peter Bengtsson 9a3adcff9c
lazy highlight json examples on Webhooks page (#24785)
* lazy-highlight JSON examples on Webhooks page

* it works

* using intersectionobserver

* explain in  formatAsJsonCodeBlock

* fix tests
2022-01-28 12:20:56 -05:00
Robert Sese abe3881aa3
a11y: link style updates (#24680)
* Remove opacity classes on REST pages

* Underline links in article page content

* Typo 🔨

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-28 11:11:23 -06:00
Rachael Sewell ef4dee2e7d
Revert "Revert "rest/reference/repos#statuses redirect"" (#24559) 2022-01-27 22:09:20 +00:00
Rachael Sewell f9095482cf
accessible description for learning paths (#24742) 2022-01-27 22:01:49 +00:00
Robert Sese 60aa8347f5
Bold-ify supported release card links (#24736) 2022-01-27 15:46:32 -06:00
Robert Sese 850aa34e05
a11y: set focus after submitting survey (#24666)
* Set focus after submitting survey

* Add role=status to success message
2022-01-26 18:14:39 +00:00
Peter Bengtsson b32df3dfb9
display title if no shortTitle on product landing pages (#24657)
* display 'title' if no 'shortTitle' on product landing pages

* remove pointless shortTitles

* Revert "Fix search sync (#24620)"

This reverts commit 16c9fc3ec5.

* undo

* undo sample changes
2022-01-26 16:30:45 +00:00
Grace Park 8374263842
a11y: Remove redundant banner (#24605)
* remove redundant banner

* adding flex-1
2022-01-25 17:32:34 +00:00
Robert Sese 96118839a9
Make scrollable code blocks focusable (#24607) 2022-01-25 17:26:34 +00:00
Grace Park a3b81bb93c
restructure footer and header (#24601) 2022-01-24 15:19:45 -08:00
Grace Park 66d8e2b15c
skip link for screen readers to main content (#24599) 2022-01-24 14:19:15 -08:00
Grace Park 2ae7d02f1a
adding keyboard focus to survey buttons (#24595) 2022-01-24 14:11:53 -08:00
Grace Park a0a24b605c
Keyboard Focus for Guides Page: Learning Paths (#24483)
* remove useEffect on ref

* updating keyboard focus for guides page
2022-01-21 16:33:03 +00:00
Grace Park ddc5e19570
remove useEffect on ref (#24470) 2022-01-20 21:06:24 +00:00
Grace Park eb776f64e4
Small accessibility changes - adding ul to li (#24449)
* adding ul to li

* move ul for just the mobile picker
2022-01-20 17:54:49 +00:00
Peter Bengtsson f2f679550d
display possible search error (#24429)
* display possible search error

* feedbacked
2022-01-19 21:41:17 +00:00
Robert Sese d0db00cd98
a11y: match picker label with current selection (#24321)
* Match label with selection

* defaultText is a better default

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* No longer used

* Also no longer used

* No longer used in the dropdown pickers

* Add translation strings for pickers

* Use translated strings in picker components

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 18:43:31 +00:00
Robert Sese 54af81acd5
a11y: update code example search (#24226)
* Search on submit

* Should be a ul

* Fix broken link

* No search on change event

* Add translation strings

* Add role for the 0 results message

* Update test with new search behavior

* Make search input a controlled component

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Trim whitespace in search text

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Better variable names

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update visible results count in useEffect

* Control the input's value with the typed state

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Inline the submit handler

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 12:53:50 +00:00
Robert Sese 1c768fe9a0
a11y: even more headings adjustments (#24315)
* Adjust Enterprise supported release card heading

* Adjust learning track headings

* Adjust guide list card headings
2022-01-14 20:08:55 +00:00
Robert Sese cc69799558
a11y: landing page headings adjustments (#24295)
* Adjust heading level and only heading with intro text

* Adjust heading level

* Adjust code example and guide card heading levels

* Adjust tests for new heading levels

* Adjust rendering test for new heading levels
2022-01-14 17:23:05 +00:00
Grace Park d5097397c8
underline links on toc pages (#24217) 2022-01-11 20:48:35 +00:00
Grace Park f5c615cbd0
Guides List markup and Link Icon in Permalink Headings (#24211)
* list markup for article cards and learning paths

* adding link icon to section permalinks
2022-01-11 11:38:57 -08:00
Grace Park d2494c3e2d
Keyboard focus on Guides Pages (#24209)
* accessibility: make label autofocus on dropdown when clicked

* update to div element

* fix keyboard focus on X more guides and load more guides

* tabIndex is optional
2022-01-11 19:26:12 +00:00
Grace Park 69543377cb
Accessibility: Guides Pages, types/topics dropdown (#24185)
* accessibility: make label autofocus on dropdown when clicked

* update to div element
2022-01-11 17:53:55 +00:00
Peter Bengtsson 4947218cba
fix React key uniqueness in Breadcrumbs (#24182) 2022-01-11 01:56:30 +00:00
Rachael Sewell a340162d84
reorganize repository apis (#23728)
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 11:53:12 +10:00
Robert Sese d31d6a5b4e
a11y: add title text for view all links (#24193)
* Add optional 'view all' title text in the context

* Use viewAllTitleText in ArticleList

* Set viewAllTitleText for sections with 'view all' links
2022-01-11 01:30:10 +00:00
Robert Sese fcc9b904dd
Comment on why we do manual email validation (#24192)
* Comment on why we do manual email validation

* One 'do'
2022-01-10 22:47:46 +00:00
Grace Park 0b33fbb167
Fix max height for minitocs (#24163)
* update max-height

* set fixed max height for mini tocs to make scrollable from top
2022-01-08 01:48:02 +00:00
dependabot[bot] ce8f21487b
Bump @primer/components from 32.1.0 to 33.1.0 (#24023) 2022-01-08 00:25:04 +00:00
Grace Park e37fc2edd9
Accessibility footer color color contrast ratio (#24158)
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block

* add emphasis color on border to meet accessibility color contrast ratio

* update border for footer buttons to meet accessibility color contrast ratio

* run prettier
2022-01-07 16:20:54 -08:00
Robert Sese 76b0b5ade1
a11y: survey email validation (#24159)
* Add email error state checking

* Clear email error on cancel

* Disable submit if email is invalid

* Add Primer-ized error message

* Add aria attributes

* Better function name
2022-01-08 00:01:42 +00:00
Grace Park 47de433865
Accessibility Search updates and additional minor changes (#24136)
* update to use heading markup

* updating to h3 for accessibility

* increase opactiy to meet 5.5:1 color contrast ratio

* update opacity to meet color contrast ratio

* update styling to match original but use heading markup

* remove aria-hidden for accessibility

* add h1 title search results and update scroll tip colors

* add number of matches

* remove no results since we are showing 0 results

* add overflow to fix border bottom on version search

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* incorporating feedback and update padding

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-07 21:29:49 +00:00
Grace Park a4c5d58507
Accessibility: Breadcrumbs (#24151)
* programmatically group breadcrumbs

* forgot to commit li
'
'

* adding inline-block
2022-01-07 12:01:52 -08:00
Peter Bengtsson 7d75265b01
hydration fails on CollapsibleSection with hash in URL (#24105) 2022-01-07 02:25:16 +00:00
Robert Sese d2b9b236c4
Add label for search input (#24130) 2022-01-06 22:35:56 +00:00
Peter Bengtsson 5893ae32b3
don't let the href depend on the router hash in client-side rendering (#24106) 2022-01-06 20:59:47 +00:00
Grace Park 124f54eb0c
Accessibility changes for Nav Menu (#24099)
* updating to nav landmark

* support keyboard esc to close mobile menu

* update to ChevronDown to remove nested div
2022-01-06 17:34:19 +00:00
Robert Sese bcb1b3c8bc
Use lang attribute and translate picker aria-label (#24096)
* Translate picker aria-label

* Use lang attribute
2022-01-05 23:28:05 +00:00
Peter Bengtsson 3f9d798037
render same DOM in SSR as client (#24078) 2022-01-05 14:53:43 +00:00
hubwriter 0651660f33
Change "workflow templates" to "starter workflows" (#23823)
Co-authored-by: skedwards88 <skedwards88@github.com>
2021-12-21 18:15:54 +00:00
Robert Sese 5d88ffbef7
Use ol for LearningTracks (#23461)
* Use ol for LearningTracks

* Flip li counter bg/fg colors

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-12-17 13:52:49 -06:00
Robert Sese a2bd8ae67f
Add support for videos to landing pages (#23801)
* Add new video properties frontmatter

* Handle video links in the middleware

* Video links don't have intros, authors, or full titles

* Make videos available from context

* Add default video heading

* Add basic tests for videos

* tmp videos test

* Remove stray test debugging

* more tmp videos testing

* Add videos test fixture

* Revert "more tmp videos testing"

This reverts commit 382946a5603ff217014797f77f37216bb8bb6c9c.

* Revert "tmp videos test"

This reverts commit 8767d0eaf08bd4ca04e2dacd12d476a2506c0367.
2021-12-17 11:09:00 -06:00
Grace Park 65db364ef1
remove avatar for accessibility (#23706) 2021-12-16 17:09:35 +00:00
Peter Bengtsson 53b0484a66
unique keys for RestRepoBanner links (#23764) 2021-12-15 16:08:43 -08:00
Grace Park 9e21836f4d
Revert "Accessibility: Nesting headingLevel 3 mini tocs (#23663)" (#23759)
This reverts commit 41c7f58437.
2021-12-15 12:34:21 -08:00
Robert Sese 5ff7bf2c65
Capitalize and comma outside link (#23723) 2021-12-14 16:57:24 -06:00
Rachael Sewell bf7b2085bd
fix broken links in banner component (#23719) 2021-12-14 14:00:47 -08:00
Rachael Sewell daafb8cb9d
break up large rest pages (#23652) 2021-12-14 20:39:25 +00:00
Grace Park 11a01104b1
update to list mark up for screen readers (#23712) 2021-12-14 11:58:48 -08:00
Grace Park a39f8a16bd
add permanent search code example label (#23709) 2021-12-14 11:14:18 -08:00
Grace Park 41c7f58437
Accessibility: Nesting headingLevel 3 mini tocs (#23663)
* nesting headingLevel 3 mini tocs

* fix tests

* Update components/article/ArticlePage.tsx

Co-authored-by: Robert Sese <robert.sese@gmail.com>

* run prettier

Co-authored-by: Robert Sese <robert.sese@gmail.com>
2021-12-14 04:29:09 +00:00
Kevin Heis 821c1e693b
Release note sticky fixes (#23643) 2021-12-13 18:23:30 +00:00
Grace Park cb4e962ce8
fixing styling of toc pages (#23583) 2021-12-13 18:05:02 +00:00
Grace Park e0c31e09e7
update padding bottom (#23580)
Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
2021-12-13 09:58:53 -08:00
Grace Park 3ce46b9172
move custom tool tip to remain permanent next to scroll to top button (#23551) 2021-12-13 17:40:48 +00:00
Peter Bengtsson 815f9d40c3
only link all enterprise versions if any is enterprise version (#23640) 2021-12-13 17:19:15 +00:00
Peter Bengtsson 9d59f7dc8b
Lack of unique React keys (#23573) 2021-12-11 03:32:45 +00:00
Grace Park 70262789ec
make clear list structure in footer for accessibility (#23549) 2021-12-09 20:31:22 +00:00
Robert Sese 4ce6dd2840
More misc a11y bits (#23542)
* List-ify guide labels

* Use aria-expanded with 🍔 menu
2021-12-09 19:20:04 +00:00
Grace Park 078fdc9a71
Remove bumplink symbol (#23539)
* run prettier

* removing space

* run prettier again
2021-12-09 18:41:35 +00:00
Grace Park f19223503a
Update Search Version Button to Dropdown (#23465)
* adding to view

* updating the portal location

* add new line

* updating font styling to class

* Update components/Search.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Update components/Search.module.scss

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update ItemInput

* using router.replace and import updates

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* run prettier

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-12-09 17:56:24 +00:00
Kevin Heis 86b5a52b3e
Query string abuse causing 5xxs (#23501) 2021-12-08 21:05:32 +00:00
Robert Sese 9dbc44100c
Misc accessibility bits (#23495)
* Fix and make article date format consistent

* Add aria-label to repo icon

* Remove unnecessary title attribute
2021-12-08 19:01:40 +00:00
Peter Bengtsson 7f6f20a73f
run prettier on all code in CI (#23482)
* run prettier on all code in CI

* rename

* test .tsx too

* ignore more

* prettier the stragglers

* minimal permission
2021-12-08 16:11:52 +00:00
Matt Pollard b3e1ff4e89
Update documentation for GitHub AE's December 2021 release (#23405) 2021-12-07 10:36:37 +01:00
Peter Bengtsson 046de169fd
fix TypeScript violation with Overlay in @primer/components@32.1.0 (#23358)
Part of #1311
2021-12-03 19:43:12 +00:00
Grace Park 8931793024
updating table-of-contents pages with actionlist (#23338) 2021-12-02 12:50:04 -08:00
Robert Sese 9d79148aef
ActionList for LearningTracks (#23335)
* ActionList for LearningTracks

* Try to resolve TS error
2021-12-02 19:59:01 +00:00
Grace Park 4ff5167e51
Updating name: sublanding to guides and using DropdownMenu for type/topics filter (#23290)
* updating sublanding to guides page and using DropdownMenu primer component

* fix linting error

* remove unnecessary import

* updating translation files

* move data-testid

* trying to fix test

* fix browser tests

* Update content/README.md

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
2021-12-02 18:43:33 +00:00
Peter Bengtsson 93a11d50f3
prettier release date on enterprise release logs (#23288)
Part of #1291
2021-12-01 23:06:33 +00:00
Peter Bengtsson d98af05017
unbreak React unique key prop warning (#23279) 2021-12-01 22:39:07 +00:00
Robert Sese 37b311dd8f
Actionlist-ify ProductArticleList (#23280)
* WIP: ActionList ProductArticleList

* remove mb

* Put article count in link

* Full width links

* remove indent

* fixing link space for mini tocs

Co-authored-by: Grace Park <gracepark@github.com>
2021-12-01 21:49:52 +00:00
Robert Sese b67bd854c4
Override border-radius (#23271) 2021-12-01 11:00:48 -06:00
Robert Sese ae22e18a9a
Use ActionList for ArticleList (#23252)
* Use ActionList under the hood for ArticleList

* Update components/landing/ArticleList.tsx
2021-12-01 00:16:03 +00:00
Grace Park 29f8e80e71
HomePage Component Updates (#23251)
* separaet out into homepage components

* remove unnecessary translation

* update component names
2021-12-01 00:08:49 +00:00
Grace Park 3ca4b73bc4
update to bold instead of yellow highlighting (#23244) 2021-11-30 22:02:30 +00:00
Mike Surowiec 39cdb0dce6
fix: tool picker update content on currentTool change (#23216) 2021-11-30 17:07:39 +00:00
Kevin Heis e3b2e820fd
React tool picker (#23004)
* Working on tool picker

* Start on react version of tool picker

* Update ToolPicker.tsx

* Update tool-switcher.html

* Get it working

* Update browser.js

* Update browser.js

* Update ToolPicker.tsx
2021-11-29 23:04:06 +00:00
Amy Burns c3bc538cd4
Add 2 pane layout to "Setting up Codespaces" docs and update IA (#21700) 2021-11-24 11:41:30 -08:00
Robert Sese 74c94121be
Use Primer ActionList for sidebar (#22885)
* Initial move to ActionLists nav, handle terminal links

* ActionList-ify map topic items

* Some 🎨

* ActionList-ify homepage sidebar

* More 🎨

* Resolve test failures (and 'better' markup?)

* Properties don't exist on ActionList

* Use ul + li elements for ActionLists

* Workaround for TS error with 'as='

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
2021-11-23 18:33:54 +00:00
Grace Park a3e67be13a
design system request (#23071) 2021-11-23 17:50:26 +00:00
ahdbilal 487c56cb49
update actions docs with setup-python caching (#22990)
* updated the python testing doc with caching

* updated docs with setup-actions caching for node and python

* updaed content with setup-actions cachine

* fix links

* Update content/actions/advanced-guides/caching-dependencies-to-speed-up-workflows.md

Co-authored-by: MaksimZhukov <46996400+MaksimZhukov@users.noreply.github.com>

* Update components/playground/content/building-and-testing/python.tsx

* Update components/playground/content/building-and-testing/python.tsx

* Update content/actions/advanced-guides/caching-dependencies-to-speed-up-workflows.md

* Update content/actions/advanced-guides/caching-dependencies-to-speed-up-workflows.md

* Update content/actions/advanced-guides/caching-dependencies-to-speed-up-workflows.md

* Update content/actions/automating-builds-and-tests/building-and-testing-python.md

* Update content/actions/automating-builds-and-tests/building-and-testing-python.md

Co-authored-by: MaksimZhukov <46996400+MaksimZhukov@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
2021-11-23 17:26:03 +00:00
Mike Surowiec 0c3fa5f80b
fix: use components/Link in Search.tsx (#23019) 2021-11-22 15:08:02 +00:00
Kevin Heis 58fbe1edf5
Move px to rem in scss files (#23009)
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-11-19 21:06:45 +00:00
Grace Park 33c5ce2d36
Updating images styling and accessibility for minitocitems (#22976)
* updating images styling on design systems feedback

* maintaining ul li structure for accessiblity

Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
2021-11-19 00:56:51 +00:00
Kevin Heis f17c7a2598
Update search to use rem units where possible (#22970)
* Update search to use rem units where possible

* Use more primer classes

* Move more search to primer classes
2021-11-18 20:43:31 +00:00
Kevin Heis 308aa9cb0c
Fix heading sizes (#22968)
* Align heading sizes with Primer

* Make the headings on other pages match normal pages
2021-11-18 19:45:13 +00:00
Grace Park f5008425ba
Updating ordered lists numbering border (#22972)
* updating ordered lists numbering border

* moving 8px away
2021-11-18 11:12:55 -08:00
Grace Park 75577663e9
bringing back i - thanks rsese (#22969) 2021-11-18 17:41:20 +00:00
Grace Park 5a809be3dc
MiniTocItems: rerender tocs and fix bugs (#22948)
* add key to force rerender tocs

* move up platform specific to properly display none and go back to using contents

* remove i
2021-11-17 22:29:07 -08:00
Robert Sese 98d87bb4f2
Make list key unique (#22946) 2021-11-17 23:30:21 -06:00
Grace Park 130016bd0a
Fix html in tocs (#22936)
* fix html in tocs

* render html
2021-11-17 17:17:10 -08:00
Grace Park 0afdf66a08
Primer Update: Table of Contents (#22933)
* update to ActionList

* fix nested mini tocs

* adding key

* remove li and fix tests

* update font size to 14px

* remove border radius
2021-11-18 00:27:12 +00:00
Peter Bengtsson d605556a80
encode 'query' in 'redirectQuery' (#22913) 2021-11-17 23:08:46 +00:00
Peter Bengtsson eb4a4741ad
refactory getting 'query' with a hook (#22879) 2021-11-17 15:02:50 +00:00
Grace Park 56521881a2
Adding scroll to header search results (#22874)
* adding scroll to header search results

* move search-result

* search-result data test id addition

* forgot s
2021-11-16 21:32:45 +00:00
Kevin Heis 329a8c664e
Create a shared picker component (#22836)
* Unified picker component

* Add picker to storybook

* TS fixes

* Simplify "mobile" header spacing

* Fix a few testid

* Update Picker.tsx

* Update Picker.tsx

* Update Picker.tsx

* Fix unit test

* Fix rendering tests
2021-11-16 19:10:28 +00:00
Peter Bengtsson 07a5edd2ab
rewrite search state from useRouter (take 2) (#22833)
* rewrite search state from useRouter (take 2)

* fix the problem with isHeaderSearch

* cleaning ups

* updating mobile search results ui (#22841)

* remove useCallback

Co-authored-by: Grace Park <gracepark@github.com>
2021-11-16 18:55:48 +00:00
Rachael Sewell e919d5085d
change version within search result window (#22702) 2021-11-12 22:01:08 +00:00
Grace Park 5ac9d72005
styling updates and get all results (#22809) 2021-11-12 21:47:40 +00:00
Grace Park 5bf39459ca
Updating Search using Primer Components (#22677)
* updating search icon

* remove no fill

* update fill color

* using ActionList and Overlay

* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark

* add search-results test data and move header search results to right

* make search results scrollable and fix max-width in header search

* update header search and styling updates

* add highlight

* update styling

* styling and lint errors

* fix lint error and fetch

* Update components/Search.tsx

* update label color

* remove bottom margin

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-11-12 12:25:47 -08:00
Mike Surowiec d6e0485602
fix: platform content initial render (#22802) 2021-11-12 11:15:08 -06:00
Mike Surowiec 7310fc998a
Refactor display-platform-specific-content (#22665)
* refactor display-platform-specific-content

* update PlatformPicker tests and cleanup
2021-11-12 14:40:35 +00:00
Ramya Parimi 9dff265cfd
Merge branch 'main' into i11236-fix-workflow-path 2021-11-11 07:05:52 -06:00
Rachael Sewell 0244fda807
search improvements (#22443) 2021-11-10 11:11:28 -08:00
Peter Bengtsson 0d13379462
fix TS usage around VersionPicker (#22739) 2021-11-10 11:00:34 -08:00
Kevin Heis 6ec20638b5
Version picker combo (#22694)
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
2021-11-10 16:20:34 +00:00
ftnext b987ffd10a fix typo in workflow paths 2021-11-10 22:53:34 +09:00
Grace Park d75bd265eb
Flash updates for deprecation and header notifications (#22632)
* flash updates for deprecation and header notifications

* adding import and updating position
2021-11-09 19:52:20 +00:00
Grace Park 240f5fbafe
Updating breadcrumbs (#22626)
* updating breadcrumbs

* fix tests

* one more
2021-11-08 17:53:19 +00:00
Robert Sese ad40e86796
Add release notes label and heading colors (#22585) 2021-11-03 22:47:55 +00:00
Ramya Parimi 7db55a6a7e
Merge branch 'main' into main 2021-11-03 06:04:00 -05:00
Kevin Heis 9d53e40612
Make individual learning paths linkable (#22545)
* Make individual learning paths linkable

* Update learning-tracks.js

* Update LearningTrack.module.scss
2021-11-02 21:32:04 +00:00
Grace Park 2969394991
have header span the entire page (#22543) 2021-11-02 13:08:27 -07:00
Grace Park b211776b85
Updating to scroll past header notifications and keep header sticky (#22539)
* updating to scroll past notification and keep header sticky

* Update components/page-header/Header.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-11-02 18:50:31 +00:00
Grace Park f684e7fe82
adding margin top to anchor links (#22515) 2021-11-01 13:57:00 -07:00
Grace Park 3957ffeb1c
fix so mobile menu is sticky when open (#22498) 2021-10-30 09:34:27 -07:00
Grace Park 75d41076a7
Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Peter Bengtsson 453e6340a7
reset survey after route navigation (#22488)
Part of #1115
2021-10-29 15:19:54 +00:00
Grace Park 596207f743
update to color-bg-default (#22482)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-10-29 15:05:48 +00:00
Kevin Heis 567652b0e3
Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Grace Park d2b50026b4
Minor sidebar updates (#22403)
* minor sidebar updates batch

* Update components/sidebar/SidebarNav.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update components/sidebar/SidebarProduct.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* changing back to bg-primary since we are on primer 17

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-10-28 17:07:10 +00:00
Mike Surowiec b223df9a8d
fix: includeGuides should always include topics array (#22455) 2021-10-28 16:14:30 +00:00
Mike Surowiec 3fbda10305
fix html encoded entity in code example and article cards (#22328) 2021-10-25 20:40:02 +00:00
Edward Thomson 0fee9aedcd
Landing page: groups of features (#22313)
* homepage: reduce padding below search area

Bring as much useful content up "above the fold".

* homepage: add groups for the front page sections

Group the homepage links into sections that map to the GitHub features
page (`/features`) plus two groups that are bespoke to the docs ("Get
started" and "Developers").

* homepage: update group design

Group the feature list area using the design exploration work by
@arisacoba.  Remove the description.

* homepage: remove ungrouped items from main area

Remove ungrouped items (like the external links) from the main feature
area.  Users can still navigate to ungrouped items in the sidebar.

* fix tsc error, use Link component

* homepage: support empty icon in group

Don't assume that we have icons everywhere on the landing page groups.

* homepage: drop octocat/invertocat

Looks weird with the modern icons, looks bad in dark mode.  Drop them
for now.

* homepage: document the childGroups frontmatter property

* homepage: don't test that sidebar == main content

We're reducing the links on the homepage in the main content area, but
the sidebar should be the complete list of products.  Remove the tests
that ensure that the main content area has all the sidebar content.  But
keep the tests that ensure that the sidebar content has all the links in
the main content area.

* homepage: remove "GitHub" doc set

The "GitHub" doc set "will be removed soon as we keep moving more content
out of it, so let's not include it here to keep the page more
evergreen."

* homepage: don't test that `/github` is linked on the main page

We're removing the `/github` doc set, and it's now not in the main page
grouped links.  Remove the test that `/github` exists, now look for
`/get-started`.

* homepage: use octicons instead of images

The images from https://github.com/features will be updated 🔜 - in
the meantime, let's use octicons which are consistent and give visual
interest.

* homepage: use octicons from @primer/octicons-react

Using the react components adds `<svg>` elements instead of `<img>`
elements, which lets the element use the current fill color, supporting
both light and dark themes.

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-10-22 17:58:16 +00:00
Mike Surowiec 567879365f
fix: grid blowout due to missing min width (#22352) 2021-10-21 20:25:23 +00:00
Kevin Heis 83804c7114
Create search result event (#22307)
* Create search result event

* Update Search.tsx

* actually send it

* remove comment

* Apply suggestions from code review

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* add 'required' to schema

Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-10-21 00:37:39 +00:00
Grace Park 884556eb02
Adding effectiveDate frontmatter property (#22317)
* adding effectiveDate frontmatter property

* Update components/article/ArticlePage.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* adding validation for correct date

* update to dateTime

* update to year month day

* update error date validation

* moving validation to getArticleContextFromRequest and moving id to div

* remove enteredDate

* Update content/README.md

Co-authored-by: Laura Coursen <lecoursen@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-10-20 19:40:13 +00:00
Peter Bengtsson 3994797e81
indicate 0 search results as a result (#22262)
* indicate 0 search results as a result

fixes https://github.com/github/docs-engineering/issues/955

* correct logic

* refactored into own component
2021-10-19 22:23:36 +00:00
Anil Seervi c183d07491 Update footer help link 2021-10-19 03:07:24 +00:00
Anil Seervi 4fcd2b4d1c use Link tag and relative url 2021-10-19 02:13:46 +00:00
Anil Seervi 8189f38035 Make internal footer links dynamic to language picker : Fixes #11274 2021-10-18 15:13:47 +00:00
Anil Seervi 06a3a7b91c
Link to developers page 2021-10-17 11:10:01 +05:30
Grace Park 4727433baa
Community redirect update to camel case and adding documentation (#21979)
* update to camel case

* add documentation on communityRedirect
2021-10-07 15:02:58 -07:00
Grace Park 9dd8ed7398
Bring back community redirect (#21971)
* add back

* adding community_redirect to page context based on parent

* update to use parentProduct

* bring back the link-secondary and text-bold
2021-10-07 18:58:31 +00:00
Amy Burns e82f64f642
Add `vscode` as an option for the application selector (#21798)
* adding switcher to creating a codespace guide

* adding additional switcher for vscode and updating codespaces name

* using webui in codespaces coontext

* updating internal documentation

* remove default tool

Co-authored-by: hubwriter <hubwriter@github.com>
2021-10-07 14:57:45 +01:00
Jennie Steshenko 3938d02687
New DPA and SCCs (#21838) 2021-10-07 13:51:25 +00:00
Mike Surowiec b279482cf9
Footer styling (#21877) 2021-10-06 18:09:11 +00:00
Steve Guntrip 32f59ee7b0
add ShieldLockIcon octicon to permissions statement (#21829) 2021-10-06 09:07:58 +00:00
Jeroen Rietveld 24e4c3407b
Make guide filter accessible (#21380)
* Make guide filter accessible

Explain that the fields will filter a list.
Display a status message indicating the number of results found.

* update no guides found display, fix yaml issue

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-10-04 18:11:11 +00:00
Mike Surowiec 85f6a43502
Mini TOC semantic rendering (#21836)
* semantic rendering of miniTocItems

* feat: create nested mini toc structure to simplify semantic rendering

* remove className usage of indentationLevel in miniToc rendering

* manually run script/graphql/update-files.js to update pre-rendered files

* use less brittle regex method to extract number
2021-10-04 10:48:42 -04:00
Grace Park 1211a3a92c
Remove community_redirect and update all footer links for Codespaces, Discussions, and Sponsors (#21815)
* remove community_redirect and update all footer links to redirect to discussions for Codespaces, Sponsors, and Discussions

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect
2021-09-30 23:07:51 +00:00
Grace Park bfe529c40a
Fixing index page body text rendering (#21811)
* fixing index page body text rendering

* always use renderedPage
2021-09-30 21:37:49 +00:00
Robert Sese 000799df17
Handle learning track paths from a different product (#21776)
* Add trackProduct property

* Fall back to learning track product URL param

* Add product URL param to learning track banner

* Add product URL param to featured track links

* Fix typo :(

* Add product URL param to learning track

* Add multi-product learning track tests

* Re-enable tests with a Code Security learning track

* Re-enable more tests with Code Security learning tracks

* Add more multi-product testing

* Update components/sublanding/LearningTrack.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 21:17:02 +00:00
Mike Surowiec d81f51ebf7
Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Rachael Sewell f346096897
move playground loading indicator image (#21816) 2021-09-29 22:00:37 +00:00
Kevin Heis 12356c5bbb
More client routing fixes (#21793)
* More client routing fixes

* Update index.tsx

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-09-29 16:08:31 -05:00
Mike Surowiec 3125579983
remove currentLanguage from mainContext, use router.locale instead (#21716) 2021-09-27 14:40:43 +00:00
Kevin Heis 5fb28d1c9a
Skip tracking page events when searching (#21726)
* Skip tracking page events when searching

* Update events.ts
2021-09-27 13:46:36 +00:00
Kevin Heis ceb2106cab
Update analytics to handle client side routing (#21719)
* Update analytics to handle client side routing

* Update events.ts
2021-09-24 17:21:52 +00:00
Martin Lopes 83dc407ada
Restructure Actions guides (#21577)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-09-22 16:49:41 +10:00
Robert Sese 2f6af3fe20
Render learning track banner on ToC landing page (#21634)
* Add learning track info to ToC landing page context

* Render learning track banner on ToC landing page
2021-09-22 01:02:29 -05:00
Mike Surowiec d2199e3deb
Use Doctocat link header style (#21615)
* update autolinkHeadings to use Doctocat link header style

* fix header link test

* update graphql/rest rendering to use doctocat header link

* fix: miniToc issue with stray anchor

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-09-21 18:14:38 -04:00
Kevin Heis 29ebc555cb
Add btn-primary-matte, ScrollButton, TruncateLines to storybook (#21611)
* Update create-processor.js

* Use built in semibold

* Preparing articlelist

* Add blue button to storybook

* Scope fade styles

* Add truncate component

* Add scroll button to storybook

* Update storybook.tsx

* Update DefaultLayout.tsx
2021-09-20 23:21:29 +00:00
Mike Surowiec 5eb5f7650c
enable client-side routing by default (#21593)
* enable client-side routing by default

* add prefetchSrc 'self' to csp
2021-09-17 19:38:20 +00:00
Kevin Heis cdbbc63219
Send new analytics fields for path_language, path_version, path_product, path_article (#21562)
* Send new analytics fields for path_language, path_version, path_product, path_article

* Update DefaultLayout.tsx

* Update events.js
2021-09-17 19:22:54 +00:00
Mike Surowiec 046a586c06
fix: primer/components use resolvedColorMode (#21569) 2021-09-16 20:00:26 +00:00
Kevin Heis 504155926d
Create a lead component (#21311)
* Create a lead component

* Update to remove markdown-body from Lead, copy over <code> styles

* ...so I can read the test output

* Update Lead.tsx

* Update Lead.tsx
2021-09-16 19:02:56 +00:00
Kevin Heis 498f02c6ef
(bottom|top|right|left)-\d (#21505) 2021-09-14 17:27:52 +00:00
Lee Dohm b500fd07d0
Use titlePlainText attribute since the title will be used for rendered text 2021-09-09 13:50:54 -07:00
Mike Surowiec d8b4383dc6
Improve Search styling (#21295)
* fix: improve search highlight contrast
2021-09-03 16:20:23 +00:00
Ramya Parimi 1c478ca75c
Merge branch 'main' into ramyaparimi/survey-cancel-bug 2021-09-03 07:35:02 -05:00
Kevin Heis 57621df550
Rm print button (#21237)
* Remove print button

* Found another print button
2021-09-01 18:20:42 +00:00
Kevin Heis 6eec270335
Add MarkdownContent to storybook (#21222)
* Add MarkdownContent to storybook

* Update MarkdownContent.tsx

* Update storybook.tsx
2021-09-01 15:10:47 +00:00
Kevin Heis 9f7c20dae8
Upgrade Primer CSS to version 17, removing marketing styles (#20965)
* Package updates

* Fix up things that look broken

* Add to utils

* Lead now just sets font size, just use f3 where needed

* Update package-lock.json

* Update index.tsx

* Delete bump-link.scss

* Update trigger-error.js

* Update components/GenericError.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update ArticlePage.tsx

* Update ActionBar.tsx

* Changes from meeting

* Found a few more monos

* Fix from a merge conflict

* Missed a few f3s

* Update SubLandingHero.tsx

* Bye gradients

* Match up breadcrumbs

* Update SubLandingHero.tsx

* Update lists.scss

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-08-31 14:49:39 -07:00
Ramya Parimi fa1ace2395 fixed radio check overwrite 2021-08-31 13:25:34 -05:00
Kevin Heis aef81ac477
Readd print tracking (#21180)
* Readd print button tracking

* Record all print events, not just button ones
2021-08-30 21:27:10 +00:00
Kevin Heis d431e86dec
Storybook lite (#21040)
* Remove storybook

* Update index.js

* Start a storybook outline

* Start a storybook outline

* Start showing errors

* Update storybook.tsx

* Typescript lint

* Name field

* Responsive

* Update storybook.tsx

* Update storybook.tsx

* Update storybook.tsx

* Add BumpLink to storybook

* Update storybook.tsx
2021-08-30 20:34:14 +00:00
Grace Park d4e3614676
same minWidth as you scroll down article (#21182) 2021-08-30 16:44:59 +00:00
Mike Surowiec d76c16da19
Scope markdown body (#21082)
* update article content to markdown ui component

* decouple lunr indexing from class name

* remove summary outline none rule, apply utility class instead

* improve typing

* scope more styles down to markdown-body/extended-markdown

* move all markdown-body style overrides to MarkdownContent component

* fix class targeting within css module

* clean up MarkdownContent header style

* rename data-lunr to data-search

* fix: inline code color issue

* fix: update article markdown to work with MarkdownContent
2021-08-30 14:24:49 +00:00
Kevin Heis 4d0e9c70a3
Add new fields to analytics event context: status, page_type, page_document_type (#21115)
* Add new fields to analytics event context: status, page-type, page-document-type

* Update schema-event.js

* Typescript

* Add status meta to error pages

* Update DefaultLayout.tsx

* Update DefaultLayout.tsx

* Update building-and-testing-nodejs-or-python.tsx
2021-08-26 14:58:45 -07:00
Mike Surowiec 529629ddec
Fix: editor border and theme (#21172)
* fix: set theme based on colorMode

* fix border issue
2021-08-26 15:35:32 -04:00
Mike Surowiec 06d8f81401
Two-pane Experiment (#21092)
* pull changes from docs-playground

* cleanup, add callout banner

* cleanup linting and test fixes

* add discussion link

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-08-26 14:19:40 -04:00
Kevin Heis 1cb2da024d
Add opengraph tags to articles (#21089)
* Add opengraph tags to articles

* Update MainContext.tsx

* Update DefaultLayout.tsx
2021-08-26 14:18:58 +00:00
Rachael Sewell c7ac98304a
allow use of full titles on landing page (#20327) 2021-08-25 12:31:16 -07:00
Mike Surowiec 5f5aa0b0d1
BumpLink component (#21033)
* create BumpLink component, re-org components/ui
2021-08-24 11:25:38 -04:00
Grace Park 80c979c228
removing codespaces temporary banner (#21050) 2021-08-24 04:06:50 +00:00
Robert Sese f2106f33c3
Apply markdown-body styles to intros (#21046) 2021-08-23 21:28:43 +00:00
Kevin Heis 86b6b1ad6f
Remove storybook (#21037)
* Remove storybook

* Update index.js
2021-08-23 12:07:54 -07:00
Mike Surowiec 2a25efcd8e
Scope Search scss (#20964)
* scope Search scss, reduce custom styling

* use translation for loading and no results found

* remove unnescessary test
2021-08-23 09:15:39 -04:00
Mike Surowiec 953746d944
fix: clean up getThemeProps, use better fallbacks for unknown themes (#20929)
* fix: clean up getThemeProps, use better fallbacks for unknown themes

* fix: fallback to unsupported theme color_mode, pass theme props into <ThemeProvider />
2021-08-19 16:56:46 -04:00
Kevin Heis dc952b9dcf
Upgrade minor packages (#20960)
* Upgrade minor packages

* Add dockerfile syntax back

* Update create-processor.js

* Update create-processor.js
2021-08-19 12:57:39 -07:00
Robert Sese d565050584
Account for overlapping paths (#20957) 2021-08-18 20:11:01 +00:00
Grace Park 5bf7cca35d
remove liquid tags (#20937) 2021-08-18 15:52:44 +00:00
Robert Sese af895337cd
Fix release notes bullet point rendering (#20938) 2021-08-18 15:01:51 +00:00
Robert Sese ced55e2675
Add back bullet points and heading color (#20933) 2021-08-17 16:07:46 -05:00
Kevin Heis ae7b652463
Create a storybook with callout component (#20902)
* Create a storybook with callout component

* Add to dist/storybook

* Remove references to dist dir, storybook takes place

* Update Callout.stories.tsx

* Update Dockerfile

* Update Dockerfile
2021-08-17 20:28:59 +00:00
Kevin Heis b1374fd8ee
Remove extraneous sentence on survey (#20895) 2021-08-17 11:20:56 -07:00
Mike Surowiec 4b9a6912b9
Scope sub-landing scss and remove some custom styles (#20893)
* scope sub-landing scss and remove some custom styles
2021-08-16 17:22:21 +00:00
Mike Surowiec ccbb92ab87
scope release-notes scss to component and reduce custom styles (#20847) 2021-08-16 14:10:58 +00:00
Mike Surowiec c433c43019
Sidebar refactor: scope css + more (#20837)
* refactor sidebar, scope css, wire up nav events to link component, update tests

* remove link onClick analytics event

* fix: missing key on breadcrumbs
2021-08-12 15:28:32 -04:00
Mike Surowiec a988da3bee
fix anonymous function warning (#20810) 2021-08-12 18:55:49 +00:00
Mike Surowiec 23f4681b42
Scope product-callout and contributor-callout css to component (#20801)
* remove custom css for product-callout and contributor-callout

* create callout component, update existing test

* use Callout in more places
2021-08-11 17:50:20 +00:00
Grace Park 5b59619d68
Adding Product feedback redirect (#20785)
* adding product feedback redirect for community on sponsors, discussions, and actions community link

* remove community redirect from actions and add to codespaces and add tests

* update wording for these links

* updating to add name of the button to frontmatter
2021-08-11 10:37:41 -07:00
Amy Burns acabc37604
[MERGE 8/11 @ 8:45am PT] Codespaces Megabranch (#20378)
Adding Codespaces docs
2021-08-11 11:46:35 -04:00
Rachael Sewell a92853e40d
reapply some classes for lunr indexing (#20765) 2021-08-11 15:06:01 +00:00
Robert Sese 6f6cf56c20
Add os preference tracking (#20740)
* Set cookie on os switch

* Set os based on cookie value

* Add os preference schema details

* Send os preference on page request

* Send os preference on os switch
2021-08-09 22:07:27 +00:00
Grace Park 2dbea3737a
Removing algolia (#20633) 2021-08-05 13:10:51 -04:00
Kevin Heis 0a91fcf482
Fix a few ampersands (#20681)
* Fix a few ampersands

* Update GuideCard.tsx
2021-08-04 11:48:44 -07:00
Robert Sese e387e79f16
Add color mode tracking (#20608)
* Add color_mode for event tracking

* Grab color_mode info from body and media queries

* Make color_mode schema more specific

* Get color mode preference in its own function

* Add 'auto' for potential future color modes
2021-08-02 22:21:00 +00:00
Mike Surowiec a511c95c7f
SCSS and Component cleanup (pt 1) (#20572)
* turn article.scss into a module + componentized

* Update Survey to use only component styles, add cancel button

* Update GenericError + 404 page to use only standard classes

* update LearningTrack to not use markdown-body

* remove / consolidate stylesheets

* cleanup Graphiql explorer page and scss

* Componentize Breadcrumb styles

* Componentize DeprecationBanner styles

* scope h2 a link style to markdown-body

* cleanup nav, organize page-header and page-footer components

* remove unused scroll-button.scss

* organize LanguagePicker and ProductPicker

* add declarations file

* remove featured-links.scss, update tests

* update list utility and toc test

* fix bad merge resolution

* update breadcrumbs test
2021-07-29 17:27:20 +00:00
Mike Surowiec a9a19ef6da
Move languages out of MainContext (#20503)
* move languages off of MainContext

* load languages from request to workaround sharing the languages file
2021-07-29 13:36:11 +00:00
Kevin Heis c00196f60e
Remove toggle images (#20573) 2021-07-28 21:23:49 +00:00
Grace Park 8ba413cabc
React Cleanup: Documentation (#20517)
* initial documentation changes

* editing layouts terminology

* update to match other files

* move javascripts to components/lib

* fix: dockerfile

* update based on Mikes updates to the javascripts directory

* update components/README.md

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-07-27 09:07:18 -07:00
Mike Surowiec 24ecb4f4d9
hide wip languages from LanguagePicker (#20512)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-07-26 18:19:35 +00:00
Mike Surowiec 85b48a3795
Rename hooks/lib files to .ts (#20488)
* rename hooks to .ts

* rename lib files to ts
2021-07-26 14:37:21 +00:00
Mike Surowiec 9386571aa4
fix: use named export for all-versions (#20478)
* fix: use named export for all-versions

* run prettier
2021-07-22 19:29:00 +00:00
Grace Park e79baebae8
updating to childNode to fix articles number (#20486) 2021-07-22 11:50:40 -07:00
Mike Surowiec 1f3509b018
fix rendering of release notes patch on firefox (#20477) 2021-07-22 11:05:14 -04:00
Mike Surowiec df38087aed
Update 404/500 pages to no longer use liquid templates (#20450)
* Update 404/500 page rendering to no longer use liquid templates

* updating tests

* remove unused path

Co-authored-by: Grace Park <gracepark@github.com>
2021-07-21 12:22:30 -07:00
Mike Surowiec 57b0a959c1
fix rendering of html entities (#20451) 2021-07-21 18:10:49 +00:00
Rachael Sewell dc33e61345
Update Survey.tsx (#20452) 2021-07-21 17:47:15 +00:00
Mike Surowiec 6bc50f7e30
fix: filter hidden pages from the currentProductTree (SidebarProduct) (#20404)
* fix some async test things

* allow eslint to parse top-level awaits

* fix: filter out hidden pages closer to SidebarProduct usage
2021-07-20 12:32:35 -04:00
Mike Surowiec e501dd66d4
fixes #704, ES actions landing page not rendering (#20399)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-07-19 16:39:41 -04:00
Robert Sese 3d7a7f2c89
Add language name to notice (#20286) 2021-07-19 15:59:02 +00:00
Grace Park 27aa5d92ea
Remove FEATURE_NEXTJS Flag Part 1 (#20176)
* cleanup FEATURE_NEXTJS

* fixing some server tests

* updating article a for server tests

* update h2 to h4 map topic tests

* data off on TOCs

* updating dropdown article versions links

* Update so markdown renders in intros

* updating typo and all server tests are now passing

* remove nextjs feature flag

* head.js tests pass

* updating article-version-picker

* remove nextjs feature flag browser test

* update header.js tests

* fix page-titles.js test

* fix deprecated-enterprise versions

* adding early access

* testing

* getting childTocItem

* fixing table of contents to show child toc items

* updated to 2 because the sidebar article also has the same link

* remove comment

* updating pick

* Update TocLandingContext.tsx

* update package.json and change className to h4 for h2

* updating with mikes feedback

* remove a.active test

* React clean up: Delete unnecessary layouts/includes Part 2 (#20143)

* Delete unnecessary layouts

* setting back tests failing :(

* update layouts

* delete unnecessary includes

* remove github-ae-release-notes and updating layouts

* remove a.active test
2021-07-16 14:54:25 -07:00
Rachael Sewell defa1b1426
prevent scroll to top when URL fragment exists (#20326) 2021-07-14 21:46:01 +00:00
Kevin Heis 8a56437c93
Pretty format (#20352)
* Update prettier flow to include JS

* Run prettier

* ...run prettier
2021-07-14 14:35:01 -07:00
Grace Park d3cc64a6bc adding rendered page to early access index 2021-06-29 12:04:34 -07:00
Mike Surowiec 9471394406
Disable client-side link transitions (#20141)
* add prop to disable client-side transition

* fix: disableClientTransition by default until we can figure out caching issue

* skip the next/link test
2021-06-24 14:35:23 -07:00
Rachael Sewell 6d248082b5
sidebar style updates (#19929) 2021-06-24 11:15:24 -07:00
Sarah Schneider 118747974e fix bugs in React 2021-06-23 12:54:17 -04:00
Sarah Schneider 15e33f05e7 Revert "Revert "Fix homepage versions dropdown" (#20087)"
This reverts commit f9f0b2ce86.
2021-06-23 10:12:36 -04:00
Matt Pollard f9f0b2ce86
Revert "Fix homepage versions dropdown" (#20087) 2021-06-23 09:11:51 +02:00
Sarah Schneider 43c04966e5 update React components that use the homepage version 2021-06-22 15:16:01 -04:00
Mike Surowiec a24d01f78a
Fix NextJS 500s (#20048)
* feat: allow server to contextualize request when on a /_next/data path

* add client side routing test, run lint

* enable nextjs client side routing
2021-06-22 17:30:40 +00:00
Mike Surowiec e377d74419
React: import necessary javascripts directly (#20001)
* import javascript files directly

* move globally required js to _app

* fix: js initialization

* set next env for tests
2021-06-21 21:55:49 +00:00
Mike Surowiec b084dbc23d
React: Enable all remaining pages (#20012)
* enable all remaining pages

* update tests for survey, filter card dropdowns

* fix search test

* fix: mobile search layout

* update sidebar test

* fix: learning track page is optional

* fix broken links
2021-06-21 19:52:58 +00:00
Mike Surowiec f19d695cef
fix: enterprise guide type was sometimes undefined (#20015) 2021-06-18 12:31:22 -07:00
Grace Park 86306460f5
Merge branch 'main' into fix-zh-links 2021-06-17 11:25:30 -07:00
Mike Surowiec 5396f5f9e4
React: All landing pages (#19943)
* default all remaining landing pages to react, update tests
2021-06-17 10:04:53 -07:00
Grace Park 3b92e01a79
Merge branch 'main' into fix-zh-links 2021-06-16 13:27:20 -07:00
Grace Park 8899f30911 adding to 2nd return 2021-06-16 13:24:05 -07:00
Grace Park a20f56deaf updating LanguagePicker to use language code instead of hreflang 2021-06-16 13:14:35 -07:00
Mike Surowiec 70256b0e6a
fix: sometimes there are no childPages, such as /es/github-ae@latest/admin (#19944) 2021-06-15 22:19:25 +00:00
Mike Surowiec 5635c2dba4
fix codespaces (#19941) 2021-06-15 14:05:33 -07:00
Mike Surowiec 306f6fc75e
Enable more react pages (#19935)
* enable more react landing pages

* move nextjs page logic to separate middleware

* enable codespaces landing page + fixes

* enable /education

* enable /admin

* use pathToRegexp to match routes for react rendering

* run lint

* fix: typo in url

* update sidebar test
2021-06-15 13:31:17 -07:00
Mike Surowiec ae3d8916c6
Cleanup featuredLinks usage, fix insights page, better ArticleList (#19872)
* cleanup featuredLinks usage, fix insights page, better ArticleList component
2021-06-15 18:22:43 +00:00
Mike Surowiec e26a3446a7
SubLanding page filter (#19918)
* sub-landing: implement filtering in react, other cleanup
2021-06-15 18:16:24 +00:00
Mike Surowiec bf21cd1104
fix header styling, add missing sectionLinks (#19915) 2021-06-15 16:35:19 +00:00
Mike Surowiec 6172262be7
fix: sometimes the page doesn't have children (#19919) 2021-06-15 01:06:58 +00:00