Граф коммитов

39 Коммитов

Автор SHA1 Сообщение Дата
Mike Surowiec f3fc80cf05
Upgrade primer/components -> primer/react (#25591)
* upgrade primer/components -> primer/react

* fix jest failure
2022-02-24 00:30:14 +00:00
Peter Bengtsson 53796d44ac
make octicon search svgs cached longer (#25421)
* make octicon search svgs cached longer

* not an orphan exception
2022-02-16 17:11:43 +00:00
Mike Surowiec e1a2860adb
add shallow true to search to avoid triggering page data requests (#25184) 2022-02-09 16:23:10 +00:00
Peter Bengtsson f2f679550d
display possible search error (#24429)
* display possible search error

* feedbacked
2022-01-19 21:41:17 +00:00
Grace Park 47de433865
Accessibility Search updates and additional minor changes (#24136)
* update to use heading markup

* updating to h3 for accessibility

* increase opactiy to meet 5.5:1 color contrast ratio

* update opacity to meet color contrast ratio

* update styling to match original but use heading markup

* remove aria-hidden for accessibility

* add h1 title search results and update scroll tip colors

* add number of matches

* remove no results since we are showing 0 results

* add overflow to fix border bottom on version search

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* incorporating feedback and update padding

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-07 21:29:49 +00:00
Robert Sese d2b9b236c4
Add label for search input (#24130) 2022-01-06 22:35:56 +00:00
Grace Park e0c31e09e7
update padding bottom (#23580)
Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
2021-12-13 09:58:53 -08:00
Grace Park f19223503a
Update Search Version Button to Dropdown (#23465)
* adding to view

* updating the portal location

* add new line

* updating font styling to class

* Update components/Search.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Update components/Search.module.scss

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update ItemInput

* using router.replace and import updates

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* run prettier

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-12-09 17:56:24 +00:00
Peter Bengtsson 046de169fd
fix TypeScript violation with Overlay in @primer/components@32.1.0 (#23358)
Part of #1311
2021-12-03 19:43:12 +00:00
Mike Surowiec 0c3fa5f80b
fix: use components/Link in Search.tsx (#23019) 2021-11-22 15:08:02 +00:00
Kevin Heis f17c7a2598
Update search to use rem units where possible (#22970)
* Update search to use rem units where possible

* Use more primer classes

* Move more search to primer classes
2021-11-18 20:43:31 +00:00
Peter Bengtsson d605556a80
encode 'query' in 'redirectQuery' (#22913) 2021-11-17 23:08:46 +00:00
Peter Bengtsson eb4a4741ad
refactory getting 'query' with a hook (#22879) 2021-11-17 15:02:50 +00:00
Grace Park 56521881a2
Adding scroll to header search results (#22874)
* adding scroll to header search results

* move search-result

* search-result data test id addition

* forgot s
2021-11-16 21:32:45 +00:00
Peter Bengtsson 07a5edd2ab
rewrite search state from useRouter (take 2) (#22833)
* rewrite search state from useRouter (take 2)

* fix the problem with isHeaderSearch

* cleaning ups

* updating mobile search results ui (#22841)

* remove useCallback

Co-authored-by: Grace Park <gracepark@github.com>
2021-11-16 18:55:48 +00:00
Rachael Sewell e919d5085d
change version within search result window (#22702) 2021-11-12 22:01:08 +00:00
Grace Park 5ac9d72005
styling updates and get all results (#22809) 2021-11-12 21:47:40 +00:00
Grace Park 5bf39459ca
Updating Search using Primer Components (#22677)
* updating search icon

* remove no fill

* update fill color

* using ActionList and Overlay

* update to ActionList, Overlay, add Label to Breadcrumbs, and change Mark

* add search-results test data and move header search results to right

* make search results scrollable and fix max-width in header search

* update header search and styling updates

* add highlight

* update styling

* styling and lint errors

* fix lint error and fetch

* Update components/Search.tsx

* update label color

* remove bottom margin

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-11-12 12:25:47 -08:00
Rachael Sewell 0244fda807
search improvements (#22443) 2021-11-10 11:11:28 -08:00
Kevin Heis 567652b0e3
Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Kevin Heis 83804c7114
Create search result event (#22307)
* Create search result event

* Update Search.tsx

* actually send it

* remove comment

* Apply suggestions from code review

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* add 'required' to schema

Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-10-21 00:37:39 +00:00
Peter Bengtsson 3994797e81
indicate 0 search results as a result (#22262)
* indicate 0 search results as a result

fixes https://github.com/github/docs-engineering/issues/955

* correct logic

* refactored into own component
2021-10-19 22:23:36 +00:00
Mike Surowiec d81f51ebf7
Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Kevin Heis 29ebc555cb
Add btn-primary-matte, ScrollButton, TruncateLines to storybook (#21611)
* Update create-processor.js

* Use built in semibold

* Preparing articlelist

* Add blue button to storybook

* Scope fade styles

* Add truncate component

* Add scroll button to storybook

* Update storybook.tsx

* Update DefaultLayout.tsx
2021-09-20 23:21:29 +00:00
Mike Surowiec d8b4383dc6
Improve Search styling (#21295)
* fix: improve search highlight contrast
2021-09-03 16:20:23 +00:00
Kevin Heis 9f7c20dae8
Upgrade Primer CSS to version 17, removing marketing styles (#20965)
* Package updates

* Fix up things that look broken

* Add to utils

* Lead now just sets font size, just use f3 where needed

* Update package-lock.json

* Update index.tsx

* Delete bump-link.scss

* Update trigger-error.js

* Update components/GenericError.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update ArticlePage.tsx

* Update ActionBar.tsx

* Changes from meeting

* Found a few more monos

* Fix from a merge conflict

* Missed a few f3s

* Update SubLandingHero.tsx

* Bye gradients

* Match up breadcrumbs

* Update SubLandingHero.tsx

* Update lists.scss

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-08-31 14:49:39 -07:00
Mike Surowiec 2a25efcd8e
Scope Search scss (#20964)
* scope Search scss, reduce custom styling

* use translation for loading and no results found

* remove unnescessary test
2021-08-23 09:15:39 -04:00
Grace Park 2dbea3737a
Removing algolia (#20633) 2021-08-05 13:10:51 -04:00
Mike Surowiec a9a19ef6da
Move languages out of MainContext (#20503)
* move languages off of MainContext

* load languages from request to workaround sharing the languages file
2021-07-29 13:36:11 +00:00
Grace Park 8ba413cabc
React Cleanup: Documentation (#20517)
* initial documentation changes

* editing layouts terminology

* update to match other files

* move javascripts to components/lib

* fix: dockerfile

* update based on Mikes updates to the javascripts directory

* update components/README.md

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-07-27 09:07:18 -07:00
Mike Surowiec b084dbc23d
React: Enable all remaining pages (#20012)
* enable all remaining pages

* update tests for survey, filter card dropdowns

* fix search test

* fix: mobile search layout

* update sidebar test

* fix: learning track page is optional

* fix broken links
2021-06-21 19:52:58 +00:00
Mike Surowiec 5396f5f9e4
React: All landing pages (#19943)
* default all remaining landing pages to react, update tests
2021-06-17 10:04:53 -07:00
Kevin Heis 75f90c9487
Update current JavaScripts to use Typescript (#19824)
* Update index to make it clear what has hasn't updated to Next/React yet

* Typescriptify events and experiments

* Typescript the old JS for easier integration

* Update release-notes.ts

* Lint

* Run npm i

* Fix a few lint issues

* Update airgap-links.ts

* Update airgap-links.ts

* Update set-next-env to ts

* Update airgap-links.ts

* Update package-lock.json

* Update set-next-env.ts

* Update package-lock.json

* Revert "Update package-lock.json"

This reverts commit b45e8250beeb700719d3b44e1092b0bbd093baba.

* readd fsevents

* Revert "readd fsevents"

This reverts commit 419f3c35080ac4a9072f0b4e8e291e1712ce3639.

* Update openapi-schema-check.yml

* Revert "Update openapi-schema-check.yml"

This reverts commit 5e9f4a29ea11ee343ca17291a40a751920c5b923.

* Update package-lock.json

* Update package-lock.json
2021-06-14 18:07:39 +00:00
Kevin Heis ef48759cb0
React: remove expose (#19771)
* React: remove expose

* Update context.js

* More changes

* fix: scripts check for IS_NEXTJS_PAGE so there's no timing issue

* run lint

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-06-10 16:53:43 +00:00
Kate Higa 982b8bfa53 disable rules until ready to be addressed so we can have it enabled right away 2021-06-09 09:41:15 -07:00
Kate Higa d578acf8f6 add necessary eslint/prettier/typescript plugins 2021-06-09 09:37:15 -07:00
Kevin Heis 26a8e61d3a
Update survey to use React/TS (#19728)
* Update survey to use React/TS

* Working survey form in react land

* A little cleanup

* Update Search.tsx

* Update Survey.tsx

* Remove token field from schema entirely, just let it fail validation

* Update events.js

* Update survey.html

* use Link component

* Use enum for state

* Update old to match new
2021-06-08 17:34:45 +00:00
Mike Surowiec 75e5d2e2e1
Reactify: main landing page (#19724)
* update Search to allow mounting input and results in different places
2021-06-07 15:56:09 +00:00
Kevin Heis 5b5354d02f
React search component (#19659)
* React search component

* Update Search.tsx

* Update Search.tsx

* Standalone mode, start on search with your keyboard

* Update Search.tsx

* Update Search.tsx

* Yay typescript

* Update search.js

* Update events.js
2021-06-04 19:48:56 +00:00