Граф коммитов

743 Коммитов

Автор SHA1 Сообщение Дата
mc fd0ff51c33
Update rendering test - remove hardcoded links to Dependabot article (#26765)
* update the article the tests use to something a bit more stable
2022-04-11 07:29:04 +00:00
Peter Bengtsson 5e609df1bc
more patience in CI tests for downloading static assets (#26748)
* more patience in CI tests for downloading static assets

* oops

Co-authored-by: Robert Sese <rsese@github.com>
2022-04-07 15:36:26 +00:00
Keith Cirkel a594f4027d
Update supported-browsers.md (#26701) 2022-04-06 16:00:12 +00:00
Peter Bengtsson 68400c52a8
don't test external early-access in unit tests (#26612)
* don't test external early-access in unit tests

* make the rendering tests less weird && gg push
2022-04-04 21:00:14 +00:00
Robert Sese 33c05d81ce
Change product landing page `introLinks` to a general map of link titles to links (#26360)
* Add cta button to frontmatter and context

* Add cta to Page

* Render cta button in product landing hero

* Handle external links

* Add simple unit test for cta link

* Address feedback

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* Actually push condition update

* Show it's an external link

* Refactor FullLink so we use Link once

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* Custom link can also be null

* Rename 'cta' to 'custom' and make it the last introLink

* Update tests with 'cta' to 'custom' change

* Filter once

* Revert "Filter once"

This reverts commit a3f9a8a06b505d77fed47ca96a66c187c86c3c91.

* Update introLinks to a map of titles and URLs

* No more custom introLink in LandingHero

* Simplify introLinks processing

* introLinks can also be null

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* more concise

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* No longer necessary with the a plain introLinks map

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* '.entries()` is simpler

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* 'link' could be false depending on what version you're on

* Update test for new introLinks

Co-authored-by: Peter Bengtsson <mail@peterbe.com>
2022-04-01 11:01:37 -05:00
Peter Bengtsson 0a0c83db5b
refactor early access breadcrumbs (#26558)
* refactor early access breadcrumbs

* Update permissions metadata to include users and teams with explicit access

* Inform users of permission requirement for dependabot alerts

* Apply suggestions from code review

* version previews (#26571)

* update search indexes

* New translation batch for pt (#26591)

* Add crowdin translations

* Run script/i18n/homogenize-frontmatter.js

* Run script/i18n/fix-translation-errors.js

* Run script/i18n/lint-translation-files.js --check rendering

* run script/i18n/reset-files-with-broken-liquid-tags.js --language=pt

* run script/i18n/reset-known-broken-translation-files.js

* Update subcategories for Codespaces (#25812)

* Version actions for GHES, use reusables (#26004)

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sarah Edwards <skedwards88@github.com>

* New translation batch for ja (#26599)

* Add crowdin translations

* Run script/i18n/homogenize-frontmatter.js

* Run script/i18n/lint-translation-files.js --check rendering

* run script/i18n/reset-files-with-broken-liquid-tags.js --language=ja

* run script/i18n/reset-known-broken-translation-files.js

* Check in ja CSV report

Co-authored-by: Grace Park <gracepark@github.com>

* New translation batch for cn (#26598)

* Add crowdin translations

* Run script/i18n/homogenize-frontmatter.js

* Run script/i18n/lint-translation-files.js --check rendering

* run script/i18n/reset-files-with-broken-liquid-tags.js --language=cn

* run script/i18n/reset-known-broken-translation-files.js

* Check in cn CSV report

Co-authored-by: Grace Park <gracepark@github.com>

* New translation batch for es (#26597)

* Add crowdin translations

* Run script/i18n/homogenize-frontmatter.js

* Run script/i18n/fix-translation-errors.js

* Run script/i18n/lint-translation-files.js --check rendering

* run script/i18n/reset-files-with-broken-liquid-tags.js --language=es

* run script/i18n/reset-known-broken-translation-files.js

* Check in es CSV report

Co-authored-by: Grace Park <gracepark@github.com>

* update search indexes

* Rename xxtest-devcontainer.json to devcontainer.json

* Delete .devcontainer/java-environment directory

* Delete .devcontainer/ruby-environment directory

* Update development.md

* Update CONTRIBUTING.md

* Add link to troubleshooting (#26514)

* update search indexes

* fix old tests

Co-authored-by: Anthony Swierkosz <anthony@swierkosz.dev>
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: GitHub Actions <action@github.com>
Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
Co-authored-by: Brian McManus <bdmac@github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
2022-04-01 10:25:07 -04:00
Lucas Costi b49c768777
Version actions for GHES, use reusables (#26004)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sarah Edwards <skedwards88@github.com>
2022-04-01 09:36:17 +10:00
Peter Bengtsson 72c291bcc0
more patience for signup-button rendering tests (#26560)
* more patience for signup-button rendering tests

* fix the import
2022-03-30 15:42:03 +00:00
Peter Bengtsson 347a17097a
sitedata per translation (#26496)
* sitedata per translation

* be safer

* remove test that no longer makes sense
2022-03-30 14:51:29 +00:00
Peter Bengtsson 43f0e5270c
remove GHEC signup button for dotcom_user cookied users (#26521) 2022-03-29 20:21:38 +00:00
Peter Bengtsson 4fcd3ae25f
automatically start server for jest (#26206)
* reinstate

* start server manually

* routing tests too

* skip more

* sleep more and fail if not 200

* use e2etest for content/ too

* automatically start server for jest

* does this work?

* feedbacked

* rename things

* getting it to work

* add dev dependency

* install the right version

* don't need to start that

* fix package lock

* update readme about it

* feedbacked
2022-03-18 21:46:07 +00:00
Peter Bengtsson 8362602503
do rendering end-to-end tests with a real server (#26169)
* reinstate

* start server manually

* routing tests too

* skip more

* sleep more and fail if not 200

* use e2etest for content/ too

* feedbacked
2022-03-18 17:06:12 -04:00
Peter Bengtsson 67b6d9a60b
don't test graphql type object validation repeatedly (#26197) 2022-03-15 15:48:32 -04:00
literarytea 1c203bf2c1
Site policy content re-org (#26112)
* Site policy reorg
2022-03-15 13:35:02 +00:00
Brian Evans bb23efed69
Update footer.js 2022-03-14 09:08:43 -07:00
Brian Evans ea49b45ec4
Update footer.js
removed unnecessary tests
2022-03-14 08:59:29 -07:00
Kevin Heis 9901f999d2
Merge branch 'main' into enterprise-support-link 2022-03-12 08:47:49 -08:00
Brian Evans 1ba55397c8
update enterprise contact link 2022-03-11 20:45:46 +00:00
Rachael Sewell 67360f5ad5
refactor rest code (#25879) 2022-03-11 20:23:38 +00:00
Peter Bengtsson 01baeda3c0
sync serialize sitedata to disk (#25749)
* sync serialize sitedata to disk

* use os.tmpdir

* refactor tests

* debugging

* use log

* debugging

* louder about syntax errors

* warn-before-tests

* louder about disk-caching redirects

* less loud

* only in development again
2022-03-09 20:57:40 -05:00
Peter Bengtsson 5d5c3e971b
add context to liquid rendering in linting tests (#26055)
* HACK

* back

* remove consolelog

* remove debugging

* remove more debugging
2022-03-09 16:45:18 +00:00
Peter Bengtsson fcda086e13
make enterprise 3.0 redirects work (#26041)
* make enterprise 3.0 redirects work

* improve tests and better variable name
2022-03-09 16:32:05 +00:00
Peter Bengtsson 95297c3c9d
Simplify getBreadcrumbs (#26015)
* fix getBreadcrumbs

* don't go too deep

* remove commented out code
2022-03-09 01:14:49 +00:00
Peter Bengtsson e18396c7fd
avoid mocking in robots.txt testing (#26018)
* avoid mocking in robots.txt testing

* remove package
2022-03-09 01:08:49 +00:00
Peter Bengtsson 9d4b913bdc
language redirects without cache (#25872)
* redirect to your preferred language (#25664)

* redirect to your preferred language

* refactorings

* use js-cookies

* make sure no cache when language is involved in the redirect

* fix tests
2022-03-07 16:25:22 +00:00
Peter Bengtsson 881a6d2212
Revert "redirect to your preferred language (#25664)" (#25869)
This reverts commit a9947c086c.
2022-03-04 21:56:57 +00:00
Rachael Sewell 9fd4fe0a6c
remove prerendered response rest docs (#25652) 2022-03-04 21:24:46 +00:00
Peter Bengtsson a9947c086c
redirect to your preferred language (#25664)
* redirect to your preferred language

* refactorings

* use js-cookies
2022-03-04 16:29:11 +00:00
Peter Bengtsson d75c49b1c6
loadPages by 'en' only (#25846) 2022-03-04 16:24:24 +00:00
Peter Bengtsson c4489e6fa4
Throw an error if a 'data' Liquid tag fails (#25730) 2022-03-04 12:16:32 +00:00
Peter Bengtsson 22cd55f3e3
cache changelog feed in CI (#25759)
* cache changelog feed in CI

* unbreak unit tests

* feedbacked

Co-authored-by: Robert Sese <rsese@github.com>
2022-03-03 20:32:34 +00:00
Robert Sese 876b3d4d67
Don't hardcode version (#25808) 2022-03-03 14:26:59 -06:00
Robert Sese 79c48070c4
Deprecate 3.0 (#25646)
* Deprecate 3.0

* 3.0 deprecation: remove 3.0 markup (#25647)

* Remove liquid conditionals and content for 3.0 deprecation

* Remove manually, no longer versioned in a supported version

* Remove translations manually, no longer versioned in a supported version

* Remove 'if', now in all supported versions

* Remove dangling 'elseif', now in all supported versions

* Remove dangling 'elseif' and 3.0 screenshot reference, now in all supported versions

* Nudge to latest supported GHES version

* Nudge to latest supported release GHES version

* Bump all the version for the liquid tests

* Bump first deprecated version for linting tests

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Don't depend on hardcoded versions

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove static files for 3.0 deprecation (#25649)

Co-authored-by: Laura Coursen <lecoursen@github.com>
2022-03-03 13:08:24 -06:00
Peter Bengtsson 693fb35bc6
links on /rest/overview/endpoints (#25771)
* links on /rest/overview/endpoints-available-for-github-apps

* tests

* remove unused code
2022-03-03 17:45:37 +00:00
Peter Bengtsson e69144b51f
temporarily re-introduct includes/rest_operations_at_current_path.html (#25719) 2022-03-01 08:32:30 -05:00
Peter Bengtsson eef77058ab
throw if no value not found in indented_data_reference (#25711)
* throw if no value not found in indented_data_reference

* better comment

* deliberate writer-error saple

* all strings are truthy'ish

* undo

* fix tests
2022-02-28 20:40:06 +00:00
Rachael Sewell 2ade7d8489
reactify rest pages (#25005) 2022-02-28 18:30:54 +00:00
Peter Bengtsson d0524e5124
make sure req.ip becomes correct (#25628)
* make sure req.ip becomes correct

* feedbacked
2022-02-24 17:54:09 +00:00
Peter Bengtsson 6bc2600b3b
renable backfills missing translation site data test (#25303)
* renable backfills missing translation site data test

* adding a code comment to explain how finally relates to jest
2022-02-24 13:42:49 +00:00
Peter Bengtsson 16113fd23a
don't check the productMap for translations (#25589)
* don't check the productMap for translations

* fix breaking test
2022-02-24 13:05:35 +00:00
Peter Bengtsson c976b9da6a
formate /_ip with JSON instead (#25574) 2022-02-23 17:58:39 +00:00
Peter Bengtsson 177e197d8d
soft rate limit all requests (#25556)
* rate limit all requests

* set IP in tags to statsd

* expose _ip route for assuring we get the right IP

* remove old unit test

* nit
2022-02-23 16:46:29 +00:00
Peter Bengtsson 96701946ae
delete .frontmatterErrors after it has been used (#25389) 2022-02-22 21:03:14 +00:00
Sarita Iyer 9913717066 Update repository-references.js 2022-02-22 12:38:57 -05:00
Robert Sese ef9b6ebd0e
Test that categories all have the same child type (#25392)
* Track category child types

* Test that category children are all of the same type

* Add custom error message

Co-authored-by: Grace Park <gracepark@github.com>

Co-authored-by: Grace Park <gracepark@github.com>
2022-02-16 19:02:31 +00:00
Peter Bengtsson 19b246022a
handle search with colon (#25128)
* handle search with colon

* nicer 400 errors

* split up by words first to avoid dangerous regex

* code comment
2022-02-15 21:56:50 +00:00
Peter Bengtsson 95a3e82ac5
remove 'redirects versioned category page' test (#25304) 2022-02-15 21:44:34 +00:00
Peter Bengtsson a867973876
serve /apple-touch-icon.png (#25371)
* serve apple-touch-icon.png

* rename

* 'directives'

* use a lazy but caching pattern

* update code comment
2022-02-15 21:35:08 +00:00
Peter Bengtsson 0d01c5b7b6
refactor developer-site-redirects test code (#25376) 2022-02-15 21:22:50 +00:00
Grace Park d3cb224cc9
Testing moving the setTimeout outside describe block (#25362)
* testing moving the setTimeout outside describe block

* Revert "testing moving the setTimeout outside describe block"

This reverts commit 60ddb42ce6f27b729f4db70d2dece39b1d71d59a.

* update setTimeout

* increase timeout

* move settimeout
2022-02-15 20:38:46 +00:00