Граф коммитов

42 Коммитов

Автор SHA1 Сообщение Дата
Ali-Akber Saifee c0df717317 Fix collection item order test for new collection 2022-09-01 18:28:52 -07:00
Justin Kenyon 254c16b4d2
Update collections_test.rb 2022-06-30 10:58:12 +02:00
Justin Kenyon f0f4ad252b
add collection sorting error annotation 2022-06-17 22:48:48 +02:00
Justin Kenyon 5b8c2fe609
Add line error annotations 2022-06-17 21:50:05 +02:00
Justin Kenyon 86eca0577c
cache orgs too 2022-06-17 17:02:09 +02:00
Justin Kenyon 433bc87de6
wrap line 2022-06-17 16:22:03 +02:00
Lint Action 18889f1188 Fix code style issues with RuboCop 2022-06-17 14:20:13 +00:00
Justin Kenyon 70491038c2
Skip tests when autocorrecting 2022-06-17 16:18:31 +02:00
Justin Kenyon 6ed6f66627
merge main 2022-06-17 16:01:43 +02:00
Justin Kenyon e4ebf5b9df
Update 2022-06-17 16:00:14 +02:00
Justin Kenyon e7c3a687f2
fix test 2022-06-17 14:56:50 +02:00
Justin Kenyon 890b4297b8
update test docstring 2022-06-17 14:53:26 +02:00
Lint Action 0971d89292 Fix code style issues with RuboCop 2022-06-17 12:42:35 +00:00
Justin Kenyon 869962a669
Update 2022-06-17 14:41:54 +02:00
Lint Action 80cae90770 Fix code style issues with RuboCop 2022-06-17 10:03:14 +00:00
Justin Kenyon 6c37e2caec
make batched graphql api calls 2022-06-17 12:01:26 +02:00
Lint Action ab29f2dad4 Fix code style issues with RuboCop 2022-06-16 09:00:02 +00:00
Justin Kenyon 8fe95bef38
Test the order of collection items 2022-06-13 16:46:27 +02:00
Justin Kenyon 056e01d7ed
redo everything 2020-04-07 14:41:02 -04:00
Justin Kenyon 556de44a9d
cache results 2020-04-06 21:28:56 -04:00
Justin Kenyon 594e5b549d
clean up 2020-03-25 23:40:12 -04:00
Justin Kenyon 85988bc387
Add octokit and update tests 2020-03-25 23:34:28 -04:00
Mike McQuaid 674078dd76 Update gems
And, because we're updating RuboCop, fix everything needed for the
checks in the latest version.
2018-03-14 14:51:15 +00:00
Mike McQuaid 8f2c2cc854 Enforce the maximum of 40 items in a collection.
We're only display 40 now (was 20) so enforce this to avoid confusion.
2018-03-14 14:38:35 +00:00
Tal Safran 66649f7514 Make repository/user tests more clear
* Remove double-negative from test message
* Remove valid HTTP status constant, since 301 is no longer valid
* Include collection name in error message
2018-03-12 14:46:21 -07:00
Tal Safran d90e216039 Add test for collection item renames
If a user, organization, or repository has been renamed, we should get a test failure so we can rename the item.
2018-03-12 13:24:18 -07:00
Tal Safran 290f7cdee1 Query repos and users via github.com, not API
Using the GitHub API adds an additional dependency as far as setting up an API key, configuring travis, Octokit, etc.

We can just as effectively check for the existence of users, orgs, and repos by querying their github.com pages directly and checking the HTTP status code.

h/t @mikemcquaid for the suggestion
2018-03-09 16:47:07 -08:00
Tal Safran 5341e4416d Woops, was referencing the wrong variable to output 2018-03-07 17:20:57 -08:00
Tal Safran 29ee976a1b Woops this assert was in the wrong block 2018-03-06 21:43:54 -08:00
Tal Safran f2721cfb65 Include invalid username in failure message
... makes the failure a little bit easier to understand.
2018-03-06 17:46:52 -08:00
Tal Safran ef6c88792b Query using Octokit 2018-03-06 17:44:12 -08:00
Tal Safran 41e4961136 Add test to ensure repositories exist 2018-03-06 16:39:32 -08:00
Tal Safran 0012629489 Add test to ensure users and organizations exist 2018-03-06 16:37:06 -08:00
Tal Safran 5d2282cfd4 Extract items_for_collection into a helper method 2018-03-06 15:40:02 -08:00
Tal Safran 22d008da7a Add messages for display name assertions 2018-02-14 16:20:46 -08:00
Tal Safran c0cae4e2ca Add check for display_name maximum length 2018-02-14 16:12:20 -08:00
Damon Maneice d3e5c25ce9 Fixed broken test that verifies items are present 2018-02-09 16:57:24 -05:00
Damon Maneice b7d54e619f Added test to ensure items are present in a collections 2018-02-09 16:28:44 -05:00
Damon Maneice b7fc0f598a Renamed test from 'expected only index.md and a single image' to 'expected only index.md and valid images' 2018-02-08 15:40:26 -05:00
Damon Maneice 845b94dfef Renamed MAX_COLLECTION_LENGTH to MAX_COLLECTION_SLUG_LENGTH 2018-02-08 15:37:44 -05:00
Damon Maneice f2dbb38a04 Refactored test helper methods for reuse 2018-02-07 08:50:33 -05:00
Damon Maneice d0360071f0 Added tests for collection validation and changed items markdown format. 2018-02-06 16:59:21 -05:00