fsync loose objects before moving into place

When we write a loose object to disk, we simply close the
file object before moving it into place. If the machine
crashes shortly after our write, the contents may not have
been committed to disk (depending your filesystem, usually
the metadata is, and you end up with a corrupt, zero-length
loose object file).

This is especially bad because we report that the object is
successfully written, which means we may have updated refs
to point to it. A corrupt object at that point means not
only does the operation fail, but the repository is left in
a corrupted and unusable state.

We can fix this by calling fsync on the object file before
linking it into place. Between this and the previous commit,
our object writing should now behave exactly like git's
internal routines.
This commit is contained in:
Jeff King 2013-02-21 21:50:07 -05:00 коммит произвёл Ryan Tomayko
Родитель 9df3589359
Коммит 13d5737ee6
1 изменённых файлов: 1 добавлений и 0 удалений

Просмотреть файл

@ -66,6 +66,7 @@ module Grit
def safe_write(path, content)
Tempfile.open("tmp_obj_", File.dirname(path), :opt => "wb") do |f|
f.write content
f.fsync
f.close
begin
File.link(f.path, path)