With "hub checkout" you had to write the complete URL to the PR, which
made it possible to type the wrong owner/repo there. This check covers
that case.

Nowadays, when you only enter the PR number you can't mess up that way
any more, and this test lacks meaning.
This commit is contained in:
Johan Walles 2017-04-07 14:49:45 +02:00 коммит произвёл Johan Walles
Родитель f9e49847c6
Коммит 1aa529397f
1 изменённых файлов: 9 добавлений и 20 удалений

Просмотреть файл

@ -31,26 +31,15 @@ Feature: hub pr checkout <PULLREQ-NUMBER>
And "git checkout mislav-fixes" should be run And "git checkout mislav-fixes" should be run
And "mislav-fixes" should merge "refs/pull/77/head" from remote "origin" And "mislav-fixes" should merge "refs/pull/77/head" from remote "origin"
Scenario: No matching remotes for pull request base # Scenario: No matching remotes for pull request base
Given the GitHub API server: #
""" # This scenario was removed.
get('/repos/mislav/jekyll/pulls/77') { #
json :base => { # With "hub checkout" you had to write the complete PR URL, which made it
:repo => { # possible to type the wrong owner/repo there. This check covered that case.
:name => 'jekyll', #
:html_url => 'https://github.com/mislav/jekyll', # With "hub pr checkout" you only enter the PR number and you can't mess up
:owner => { :login => "mislav" }, # that way any more. Thus, this test lost its meaning and was removed.
}
},
:html_url => 'https://github.com/mojombo/jekyll/pull/77'
}
"""
When I run `hub pr checkout 77`
Then the exit status should be 1
And the stderr should contain exactly:
"""
could not find git remote for mislav/jekyll\n
"""
Scenario: Custom name for new branch Scenario: Custom name for new branch
Given the GitHub API server: Given the GitHub API server: