Граф коммитов

3110 Коммитов

Автор SHA1 Сообщение Дата
Mislav Marohnić 8d50944b2f Leverage `run_command_and_stop` from Aruba 2019-08-21 19:17:46 +02:00
Mislav Marohnić a64f9d5939 Switch to "the output should not contain anything" built-in step 2019-08-21 18:23:50 +02:00
Mislav Marohnić 09285c4872 Fix matching variable output such as `$HOME` for new Aruba 2019-08-21 18:22:48 +02:00
Mislav Marohnić dbef9c5425 🔥 `in_current_directory` 2019-08-21 17:54:23 +02:00
Mislav Marohnić 613f964a6b Update Aruba to 1.0.0 prerelease 2019-08-21 17:53:25 +02:00
Mislav Marohnić 28f18d099e Update Cucumber 2019-08-21 17:33:11 +02:00
Mislav Marohnić a770e967c6 Timeout::Error 2019-08-21 17:29:55 +02:00
Mislav Marohnić 9589d6142c Fix `submodule add` cukes
No idea how this was suddenly broken! :/
2019-08-21 17:29:33 +02:00
Mislav Marohnić 11c6418747 Misc. Aruba compatibility 2019-08-21 17:29:00 +02:00
Mislav Marohnić 9a8bf6c881 Aruba compatibility re: current dir and subcommands 2019-08-21 17:27:57 +02:00
Mislav Marohnić 48f8c34ebd Aruba compatibility for environment variables 2019-08-21 17:21:53 +02:00
Mislav Marohnić 7c0f244e19 Bump dependencies 2019-08-21 17:19:09 +02:00
Mislav Marohnić 29d99d0412 Retry starting up local API server before failing
Attempts to address intermittent "Rack application timed out during boot"
https://travis-ci.org/github/hub/jobs/574770004
2019-08-21 12:07:44 +02:00
Mislav Marohnić 32e2de369b
Merge pull request #2237 from JPry/bug/branch_quoting
Change quotes in Sync command to be consistent with Git style
2019-08-21 11:34:22 +02:00
Jeremy Pry 4e903f801f
Add quotes around branch name in warning 2019-08-20 10:48:28 -04:00
Jeremy Pry 2da382e555
Use consistent quotes around branch names
Fixes #2233.
2019-08-20 10:44:54 -04:00
Mislav Marohnić 1787dd9de1
Merge pull request #2225 from whuang8/pr-list-comments-removal
Remove NC/Nc from pr list formatting
2019-08-20 09:42:59 +02:00
whuang8 6a7b8c7a60 Remove added whitespace 2019-08-19 20:40:44 -05:00
whuang8 858d487006 Remove unnecessary function 2019-08-19 20:39:29 -05:00
Mislav Marohnić eb5401b585
Merge pull request #2211 from vilmibm/modules-note
Tweak Makefile to support older Go versions' backported module support
2019-08-19 23:20:38 +02:00
Nate Smith ad1986b281 tweak Makefile settings for module support 2019-08-19 14:16:08 -04:00
Mislav Marohnić 3edbd86fab
Merge pull request #2218 from tpope/empty-alias-error
Fix error message on hub --paginate
2019-08-19 15:41:56 +02:00
Mislav Marohnić be6c61191f
Merge pull request #2216 from issyl0/linuxbrew_update_readme
README: Replace "Linuxbrew" with "Homebrew on macOS or Linux"
2019-08-19 15:36:28 +02:00
Mislav Marohnić 151776ea0b
Merge pull request #2208 from muesli/conversion-fixes
Avoid unnecessary conversions
2019-08-19 15:33:42 +02:00
Mislav Marohnić bbd8216401
Merge pull request #2207 from muesli/static-analysis
Trap syscall.SIGTERM instead of os.Kill
2019-08-19 15:32:26 +02:00
Mislav Marohnić 55f886ccb2
Merge pull request #2206 from muesli/assignment-fixes
Fixed ineffectual assignments in tests
2019-08-19 15:27:51 +02:00
Mislav Marohnić fc67655b55
Merge pull request #2205 from muesli/simplify
Simplify code
2019-08-19 15:27:08 +02:00
whuang8 8d74db79c3 Remove NC/Nc from pr list formatting 2019-08-13 23:06:59 -05:00
Tim Pope cf4772eed0 Fix error message on hub --paginate
Calling hub with one or more options but no subcommand resulted in the
following error message trying to expand an empty string as an alias:

	error: key does not contain variable name: alias.

This fixes the root cause: attempting to retrieve an invalid config key.
2019-08-03 18:25:56 -04:00
Issy Long 8e8df805ad
README: Replace "Linuxbrew" with "Homebrew on macOS or Linux"
- We're (slowly) moving away from the Linuxbrew name, now Linux is
  officially supported.
2019-08-03 19:34:54 +01:00
Christian Muehlhaeuser 12c49c633a
Avoid unnecessary conversions
No need to covert these types.
2019-07-23 09:36:19 +02:00
Christian Muehlhaeuser 7af5d4092b
Trap syscall.SIGTERM instead of os.Kill
os.Kill can not be signal trapped. I assume we want to trap syscall.SIGTERM
instead?
2019-07-23 09:34:10 +02:00
Christian Muehlhaeuser 2fdb738a9d
Fixed ineffectual assignments in tests
Don't assign values we don't end up checking.
2019-07-23 09:31:17 +02:00
Christian Muehlhaeuser f0c3ce9fb3
Simplify code
- Use bytes.Equal instead of bytes.Compare
- Use time.Since instead of manual timestamp subtracting
- Use sort.Strings instead of sort.StringSlice
- No need to specify the len of the slice
2019-07-23 09:28:32 +02:00
Mislav Marohnić 2cf4d7b5b0 hub 2.12.3 2019-07-19 14:30:07 +02:00
Mislav Marohnić 878f196790 Merge pull request #2198 from github/actions-auth
Allow hub used in Actions by specifying GITHUB_USER
2019-07-19 14:28:43 +02:00
Mislav Marohnić 2aef00312c [auth] Allow hub used in Actions by specifying GITHUB_USER
When supplied with GITHUB_TOKEN, hub will attempt to request the `user`
API resource which isn't available in the context of Actions.

To work around this, scripts may now set GITHUB_USER to avoid hitting
the unavailable API resource.
2019-07-19 14:12:08 +02:00
Mislav Marohnić 954c3c3432 [auth] Show friendlier error message when fetching current user fails
Hub is impossible to use from within GitHub Actions because specifying
GITHUB_TOKEN will trigger the code path where the `user` resource is
requested from the GitHub API to get the current login name, but this
resource is not available for that token.

This failure message was cryptic and misleading before as it was
sometimes presented as HTTP 401. This change ensures that the correct
HTTP 403 "Resource not accessible by integration" message is shown.
2019-07-19 14:11:08 +02:00
Mislav Marohnić 64771fb592 hub 2.12.2 2019-07-09 17:36:50 -05:00
Mislav Marohnić 2c940a8936
Merge pull request #2190 from github/upstream-no-tracking
Improve push target detection for `push.default=upstream`
2019-07-09 17:36:10 -05:00
Mislav Marohnić 18d72a0eb1 [pull-request] Improve push target detection for `push.default=upstream`
When `git config push.default` is "upstream" or "tracking", but the
current branch is pushed to a remote without having upstream
configuration set up (for example, via `git push <REMOTE> HEAD` without
`-u`), this change makes it so that the remote tracking branch (the push
target) is still discovered via the same mechanism as if `push.default`
wasn't set (i.e. iterating through all the remotes).
2019-07-07 18:06:05 +02:00
Mislav Marohnić 2e002395b6 [pull-request] Test `push.default=upstream` + no upstream config
https://github.com/github/hub/issues/189#issuecomment-507639770
2019-07-02 16:57:57 +02:00
Mislav Marohnić 12083a5931 hub 2.12.1 2019-06-28 22:19:41 +02:00
Mislav Marohnić 312ccd8c88 [cmd] Stop the surprising behavior of shell-splitting in `cmd.New()`
`cmd.New(programWithSpaces)` will now work for executables that have
spaces in the path. The only place where we relied on shell-splitting
was in openTextEditor, which now performs its own splitting.
2019-06-28 22:15:23 +02:00
Mislav Marohnić 6a13adf2cc [help] Enable `man` appearing in path that has spaces
Avoids shell-splitting manProgram unless the value was read from the
$PAGER environment variable.
2019-06-28 21:41:26 +02:00
Mislav Marohnić ce213d7c8f [env] Enable quoted values with spaces in $BROWSER
Makes possible:

    BROWSER='"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" --extra --flag' hub browse

Fixes #2178
2019-06-28 21:41:17 +02:00
Mislav Marohnić de6f95cc07 Merge pull request #1952 from OliverJAsh/patch-1
Docs: mention that comma-separated lists must not have spaces
2019-06-25 18:07:42 +02:00
Mislav Marohnić 4b1055d89b Merge branch 'non-github-remote-crash'
Fixes #2176
2019-06-25 17:43:45 +02:00
Mislav Marohnić 9cb62f9ffc [pull-request] Avoid crash when branch is pushed to a non-GitHub remote 2019-06-25 17:35:31 +02:00
Mislav Marohnić 936f704c62
Merge pull request #2142 from eli-schwartz/mod-vendor
build: pass mod vendoring flag on newer versions of go
2019-06-17 11:43:43 +02:00