Mislav Marohnić
57b8337db1
Merge pull request #2432 from jfahrer/master
...
Add the ability to edit issues
Fixes #1686 , fixes #1151 , ref. #1523
2020-01-21 12:55:00 +01:00
Mislav Marohnić
f988235f74
Allow updating issue state
2020-01-21 12:48:56 +01:00
Mislav Marohnić
b0db79dbf3
Allow nulifying existing issue's labels, assignees, & milestone
2020-01-21 12:42:55 +01:00
Mislav Marohnić
c175488aa8
Avoid fetching issue unless necessary
2020-01-21 12:34:55 +01:00
Mislav Marohnić
d6a74bfb1e
Remove URL output from successful `issue update`
...
This made sense for `issue create`, where a person would want to obtain
the URL to the new issue, but it makes less sense for `issue update`,
where the user already knows the issue number (which will not change).
This makes it so that the successful run has no output, but since I
don't know what a better confirmation behavior would be, I think this is
fine for now.
2020-01-21 11:46:43 +01:00
Julian Fahrer
ab374d9860
Fail when running issue update without specifying fields to update
2020-01-19 10:03:48 -08:00
Mislav Marohnić
ddecc72b3f
Ensure `response.Request` is populated for responses from cache
...
https://github.com/github/hub/runs/397657829
2020-01-19 15:47:17 +01:00
Mislav Marohnić
a6389b3a81
Print token authorization URL on HTTP 403 due to `X-Github-Sso` challenge
2020-01-19 14:58:49 +01:00
Mislav Marohnić
bf6e236835
Detect and report insufficient OAuth scopes leading to 40x response
2020-01-19 14:58:48 +01:00
Julian Fahrer
5df6b31923
Use `update` instead of `edit` to update issues
2020-01-18 16:52:30 -08:00
Mislav Marohnić
ff6b131d93
Refuse to follow HTTP 301, 302 redirects for non-GET requests
...
Go's `net/http` will intentionally change the HTTP method being used
after a 301, 302, or 303 redirect for a non-GET request.
When encountering a 301 or 302 response codes, fail any non-GET request
with an tip that 308 and 307 should be used, respectively.
2020-01-16 19:40:28 +01:00
Julian Fahrer
ae70177ac9
Extract applying common params into functions
2020-01-06 11:42:43 -08:00
Julian Fahrer
fc2b4461ed
Add the ability to edit issues
2020-01-03 18:37:34 -08:00
Mislav Marohnić
c8e26daa2c
Merge remote-tracking branch 'origin/master' into transfer-issue
2019-12-15 20:49:24 +01:00
Mislav Marohnić
d147a422d4
[issue] Add `transfer` tests
2019-12-15 20:48:45 +01:00
Mislav Marohnić
4b4843b331
Improve `color.ui` config support
...
- Query `Config` instead of `GlobalConfig` to respect per-repo and
per-invocation configuration too.
- Support "never" (synonym for "false") and "always" values.
2019-12-03 04:30:34 +01:00
Mislav Marohnić
121d04ed93
Avoid executing `git web--browse` in tests
2019-11-14 23:15:19 +01:00
Mislav Marohnić
ad927ebab4
Nullify GITHUB_REPOSITORY while testing
2019-11-14 23:15:04 +01:00
Mislav Marohnić
4d562bb538
Merge pull request #2317 from mdaniel/api-rate-limit
...
Honor the rate limit headers in "hub api"
2019-11-06 16:05:31 +01:00
Mislav Marohnić
7d191a929b
[help] Have `hub <cmd> --help` open the man page
...
This is for git compatibility, which seems to be doing the same.
2019-10-31 03:07:47 +01:00
Mislav Marohnić
875d4288bf
[help] Enable `hub help --web <command>`
...
- `share/man/man1/*.html` now live in `share/doc/hub-doc/*.html`
- `help.format` git config values "web" & "html" now supported
2019-10-31 01:58:47 +01:00
Mislav Marohnić
8b5f6fe6ac
[help] Support compressed man pages
...
On systems that have `man`, simply delegate to `man hub-<cmd>` rather
than trying to look up the `hub-<cmd>.1` file and passing a full path.
2019-10-31 00:40:28 +01:00
Mislav Marohnić
d6d4b67167
[api] Rename to `--obey-ratelimit`
2019-10-30 22:26:51 +01:00
Mislav Marohnić
d54a1c2513
[api] Add scenario for 403 unrelated to rate limit
2019-10-30 22:26:50 +01:00
Mislav Marohnić
e1f2e41e2b
[api] Use "exceeded" to match GitHub API terminology
2019-10-30 22:26:50 +01:00
Mislav Marohnić
0a4f3b801e
[api] Honor rate limit for HTTP 403 responses
2019-10-30 22:26:50 +01:00
Mislav Marohnić
ea016182de
[api] Clean up `--rate-limit` implementation
2019-10-30 22:26:50 +01:00
Matthew L Daniel
11e81b000b
Honor X-Ratelimit headers for hub api
...
Previously, calling `hub api --paginate` with any substantial list of results would exhaust the Ratelimit allocation, since `hub api` did not pause before requesting the next page. With this change, `hub api` will check the rate limit headers and sleep until "Reset" if calling for the next page would exceed the limit.
2019-10-30 22:26:50 +01:00
Mislav Marohnić
03b2981631
[release] Retry attaching release assets on 5xx server errors
...
Fixes #2197
2019-10-30 14:33:33 +01:00
Mislav Marohnić
adaa53e438
[release] Fail fast when attempting to attach unavailable files
...
Fixes #2315
2019-10-30 13:57:48 +01:00
Mislav Marohnić
b623d94f1a
Merge branch 'pr/2326'
2019-10-30 12:09:49 +01:00
Mislav Marohnić
05076370c8
[release] Dedent cukes
2019-10-30 12:07:40 +01:00
Mislav Marohnić
94aa61d088
[release] Compress cukes
2019-10-30 12:06:14 +01:00
Mislav Marohnić
8d8f723e3c
[release] Tweak `release download -i` behavior
2019-10-30 12:05:12 +01:00
Tom Lazar
9059b59f81
add message when no matches are found + unit test
2019-10-29 19:37:12 -05:00
Mislav Marohnić
bac731a13c
[docs] Improve CONTRIBUTING documentation
...
[ci skip]
2019-10-29 11:47:43 +01:00
Mislav Marohnić
9238e0b57f
[test] Fix localization under Docker
2019-10-29 11:06:16 +01:00
Mislav Marohnić
595856c483
[test] Ensure that cukes do write operations outside of project dir
2019-10-29 11:06:16 +01:00
Mislav Marohnić
ba47de35c1
[test] Have `git bundle` tests run in a pristine environment
2019-10-29 11:06:16 +01:00
Mislav Marohnić
a909f2630f
[test] Clear cache between `hub api` tests
2019-10-29 11:06:16 +01:00
Tom Lazar
75604f333b
change to use glob, update docs, more tests
2019-10-25 18:21:17 -05:00
Tom Lazar
39d7697169
add support for hub download --include flag
2019-10-24 18:43:23 -05:00
Mislav Marohnić
6dc2d7945a
[checkout] Avoid overriding existing branch merge config
2019-10-22 17:56:07 +02:00
Mislav Marohnić
9170180900
[checkout] Handle case when PR matches the current branch
2019-10-22 17:48:58 +02:00
Mislav Marohnić
cd81a7bada
Merge pull request #2313 from sinisterstuf/no-coauthor
...
Strip co-author from PR descriptions
2019-10-21 23:56:42 +02:00
Mislav Marohnić
87a31b093b
Merge branch 'gist'
2019-10-21 22:25:25 +02:00
Siôn le Roux
334c4e56b1
Include "Co-authored-by" in pull request feature test case
2019-10-18 23:54:39 +02:00
Phil Dibowitz
1d64937256
Various fixes
...
* Fix formatting of long-help
* Print out files in alphabetical order
* Allow not specifying file if there's only one
2019-10-18 09:10:11 -07:00
Mislav Marohnić
6650b0cb0f
[gist] Test that error message lists available filenames
2019-10-18 13:29:54 +02:00
Mislav Marohnić
3567669852
[gist] Add test for reading from stdin
2019-10-18 13:20:21 +02:00