Part of #10576
First (and the biggest of the series of commits to introduce
Google Shell Conventions in our bash scripts.
This is about the biggest and the most complex breeze script
so it is rather huge but it is difficult to split it into
smaller pieces.
The rules implemented (from the conventions):
* constants and exported variables are CAPITALIZED, where
local/temporary variables are lowercase
* following the shell guide, once all the variables are set to their
final values (either from exported variables, calculation or --switches
) I have a single function that makes all the variables read-only. That
helped to clean-up a lot of places where same functions was called
several times, or where variables were defined in a few places. Now the
behavior should be rather consistent and we should easily catch some
duplications
* function headers (following the guide) explaining arguments,
variables expected, variables modified in the functions used.
* setting the variables as read-only also helped to clean-up the "ifs"
where we often had ":=}" in variables and != "" or == "". Those are
replaced with `=}` and tests are replaced with `-n` and `-z` - also
following the shell guide (readonly helped to detect and clean all
such cases). This also should be much more robust in the future.
* reorganized initialization of those constants and variables - simplified
a few places where initialization was overlapping. It should be much more
straightforward and clean now
* a number of internal function breeze variables are "local" - this is
helpful in accidental variables overwriting and keeping stuff localized
* trap_add function is separated out to help in cases where we had
several traps handling the same signals.
* feat: add initial roles, committers and contributors
* refactor: move roles to after contributions
* fix: remove extra spaces
* fix: fix text according to PR discussion
* refactor: move roles to 2nd point
* Update CONTRIBUTING.rst
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
With recent refactors, nightly tag was not pushed on
scheduled event because it was depending on pushing images
to github registry. Pushing images to github registry is
skipped on scheduled builds, so pushing tag was also skipped.
eladkal
Ephraim Anierobi
Marco Aguiar
Jarek Potiuk
QP Hou
Diego Lopes
Masato Ohba
Vikram Koka
Kamil Breguła
João Marques
Xiaodong DENG
gardnerdev
Michał Słowikowski
flvndh
Tomek Urbaszek
Kaxil Naik
Alex Begg
Anton Bryzgalov
Omair Khan
Ryan McCormack
Theodor
Beni Ben zikry
Sanjana Gupta
Ry Walker
mattiagiupponi
Marcus Levine
Ping Zhang
王清山