now incr returns the new numerical value as its first return value.

src/ngx_http_lua_shdict.c

@@ -823,12 +823,6 @@ ngx_http_lua_shdict_incr(lua_State *L)
 
     value = luaL_checknumber(L, 3);
 
-    if (value == 0) {
-        lua_pushboolean(L, 1);
-        lua_pushnil(L);
-        return 2;
-    }
-
     dd("looking up key %s in shared dict %s", key.data, name.data);
 
     ngx_shmtx_lock(&ctx->shpool->mutex);
@@ -845,7 +839,7 @@ ngx_http_lua_shdict_incr(lua_State *L)
     if (rc == NGX_DECLINED || rc == NGX_DONE) {
         ngx_shmtx_unlock(&ctx->shpool->mutex);
 
-        lua_pushboolean(L, 0);
+        lua_pushnil(L);
         lua_pushliteral(L, "not found");
         return 2;
     }
@@ -855,7 +849,7 @@ ngx_http_lua_shdict_incr(lua_State *L)
     if (sd->value_type != LUA_TNUMBER || sd->value_len != sizeof(lua_Number)) {
         ngx_shmtx_unlock(&ctx->shpool->mutex);
 
-        lua_pushboolean(L, 0);
+        lua_pushnil(L);
         lua_pushliteral(L, "not a number");
         return 2;
     }
@@ -875,7 +869,7 @@ ngx_http_lua_shdict_incr(lua_State *L)
 
     ngx_shmtx_unlock(&ctx->shpool->mutex);
 
-    lua_pushboolean(L, 1);
+    lua_pushnumber(L, num);
     lua_pushnil(L);
     return 2;
 }

t/043-shdict.t

@@ -851,14 +851,14 @@ foo = nil
             local dogs = ngx.shared.dogs
             dogs:set("foo", 32)
             local res, err = dogs:incr("foo", 10502)
-            ngx.say("replace: ", res, " ", err)
+            ngx.say("incr: ", res, " ", err)
             ngx.say("foo = ", dogs:get("foo"))
         ';
     }
 --- request
 GET /test
 --- response_body
-replace: true nil
+incr: 10534 nil
 foo = 10534
 
 
@@ -872,14 +872,14 @@ foo = 10534
             local dogs = ngx.shared.dogs
             dogs:set("bah", 32)
             local res, err = dogs:incr("foo", 2)
-            ngx.say("replace: ", res, " ", err)
+            ngx.say("incr: ", res, " ", err)
             ngx.say("foo = ", dogs:get("foo"))
         ';
     }
 --- request
 GET /test
 --- response_body
-replace: false not found
+incr: nil not found
 foo = nil
 
 
@@ -896,7 +896,7 @@ foo = nil
             dogs:set("foo", 32, 0.001)
             ngx.location.capture("/sleep/0.002")
             local res, err = dogs:incr("foo", 10502)
-            ngx.say("replace: ", res, " ", err)
+            ngx.say("incr: ", res, " ", err)
             ngx.say("foo = ", dogs:get("foo"))
         ';
     }
@@ -906,7 +906,7 @@ foo = nil
 --- request
 GET /test
 --- response_body
-replace: false not found
+incr: nil not found
 foo = nil
 
 
@@ -920,14 +920,14 @@ foo = nil
             local dogs = ngx.shared.dogs
             dogs:set("foo", 32)
             local res, err = dogs:incr("foo", 0)
-            ngx.say("replace: ", res, " ", err)
+            ngx.say("incr: ", res, " ", err)
             ngx.say("foo = ", dogs:get("foo"))
         ';
     }
 --- request
 GET /test
 --- response_body
-replace: true nil
+incr: 32 nil
 foo = 32
 
 
@@ -941,14 +941,14 @@ foo = 32
             local dogs = ngx.shared.dogs
             dogs:set("foo", 32)
             local res, err = dogs:incr("foo", 0.14)
-            ngx.say("replace: ", res, " ", err)
+            ngx.say("incr: ", res, " ", err)
             ngx.say("foo = ", dogs:get("foo"))
         ';
     }
 --- request
 GET /test
 --- response_body
-replace: true nil
+incr: 32.14 nil
 foo = 32.14
 
 
@@ -962,14 +962,14 @@ foo = 32.14
             local dogs = ngx.shared.dogs
             dogs:set("foo", 32)
             local res, err = dogs:incr("foo", -0.14)
-            ngx.say("replace: ", res, " ", err)
+            ngx.say("incr: ", res, " ", err)
             ngx.say("foo = ", dogs:get("foo"))
         ';
     }
 --- request
 GET /test
 --- response_body
-replace: true nil
+incr: 31.86 nil
 foo = 31.86
 
 
@@ -983,13 +983,13 @@ foo = 31.86
             local dogs = ngx.shared.dogs
             dogs:set("foo", true)
             local res, err = dogs:incr("foo", -0.14)
-            ngx.say("replace: ", res, " ", err)
+            ngx.say("incr: ", res, " ", err)
             ngx.say("foo = ", dogs:get("foo"))
         ';
     }
 --- request
 GET /test
 --- response_body
-replace: false not a number
+incr: nil not a number
 foo = true