Make rubocop happy

.rubocop.yml

@@ -3,7 +3,6 @@ inherit_gem:
     - config/default.yml
 
 AllCops:
+  NewCops: enable
   DisplayCopNames: true
-
-AllCops:
   TargetRubyVersion: 2.6

Rakefile

@@ -1,9 +1,11 @@
+#frozen_string_literal: true
+
 require "rake"
 require "rspec/core/rake_task"
 require_relative "rake/gem"
 
 namespace :octofacts do
-  task :default => [ ":octofacts:spec:octofacts", ":octofacts:spec:octofacts_updater", ":octofacts:spec:octofacts_integration" ] do
+  task default: [":octofacts:spec:octofacts", ":octofacts:spec:octofacts_updater", ":octofacts:spec:octofacts_integration"] do
   end
 end
 

lib/octofacts/backends/index.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "yaml"
 require "set"
 
@@ -7,7 +8,6 @@ module Octofacts
     class Index < Base
       attr_reader :index_path, :fixture_path, :options
       attr_writer :facts
-      attr_accessor :nodes
 
       def initialize(args = {})
         index_path = Octofacts::Util::Config.fetch(:octofacts_index_path, args)

spec/integration/modules/test/spec/classes/test_one_spec.rb

@@ -8,7 +8,7 @@ describe "test::one" do
     let(:facts) do
       {
         ec2: true,
-        ec2_metadata: { placement: { :"availability-zone" : "us-foo-1a" } },
+        ec2_metadata: { placement: { "availability-zone": "us-foo-1a" } },
         gid: "root",
         id: "root"
       }
@@ -72,7 +72,7 @@ describe "test::one" do
   end
 
   context "using straight octofacts from file with manipulation of symbol converted to hash" do
-    let(:facts) { Octofacts.from_file("basic.yaml").replace(:"ec2_metadata::placement::availability-zone" => "us-hats-1a").facts }
+    let(:facts) { Octofacts.from_file("basic.yaml").replace("ec2_metadata::placement::availability-zone": "us-hats-1a").facts }
 
     it "should contain the file resource" do
       is_expected.to contain_file("/tmp/system-info.txt").with(

spec/octofacts_updater/service/base_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe OctofactsUpdater::Service::Base do

spec/octofacts_updater/service/enc_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "ostruct"

spec/octofacts_updater/service/puppetdb_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "octocatalog-diff"