Make log messages look slightly nicer.

I'd rather see the cipher and MAC named separately, with a hint that
the two are linked together in some way, than see the cipher called by
a name including the MAC and the MAC init message have an ugly
'<implicit>' in it.
This commit is contained in:
Simon Tatham 2015-06-07 12:46:33 +01:00
Родитель b0823fc5be
Коммит d0c74a115a
2 изменённых файлов: 8 добавлений и 6 удалений

10
ssh.c
Просмотреть файл

@ -7139,9 +7139,10 @@ static void do_ssh2_transport(Ssh ssh, const void *vin, int inlen,
logeventf(ssh, "Initialised %.200s client->server encryption", logeventf(ssh, "Initialised %.200s client->server encryption",
ssh->cscipher->text_name); ssh->cscipher->text_name);
logeventf(ssh, "Initialised %.200s client->server MAC algorithm%s", logeventf(ssh, "Initialised %.200s client->server MAC algorithm%s%s",
ssh->csmac->text_name, ssh->csmac->text_name,
ssh->csmac_etm ? " (in ETM mode)" : ""); ssh->csmac_etm ? " (in ETM mode)" : "",
ssh->cscipher->required_mac ? " (required by cipher)" : "");
if (ssh->cscomp->text_name) if (ssh->cscomp->text_name)
logeventf(ssh, "Initialised %s compression", logeventf(ssh, "Initialised %s compression",
ssh->cscomp->text_name); ssh->cscomp->text_name);
@ -7206,9 +7207,10 @@ static void do_ssh2_transport(Ssh ssh, const void *vin, int inlen,
} }
logeventf(ssh, "Initialised %.200s server->client encryption", logeventf(ssh, "Initialised %.200s server->client encryption",
ssh->sccipher->text_name); ssh->sccipher->text_name);
logeventf(ssh, "Initialised %.200s server->client MAC algorithm%s", logeventf(ssh, "Initialised %.200s server->client MAC algorithm%s%s",
ssh->scmac->text_name, ssh->scmac->text_name,
ssh->scmac_etm ? " (in ETM mode)" : ""); ssh->scmac_etm ? " (in ETM mode)" : "",
ssh->sccipher->required_mac ? " (required by cipher)" : "");
if (ssh->sccomp->text_name) if (ssh->sccomp->text_name)
logeventf(ssh, "Initialised %s decompression", logeventf(ssh, "Initialised %s decompression",
ssh->sccomp->text_name); ssh->sccomp->text_name);

Просмотреть файл

@ -438,7 +438,7 @@ static const struct ssh_mac ssh2_poly1305 = {
poly_start, poly_bytes, poly_genresult, poly_verresult, poly_start, poly_bytes, poly_genresult, poly_verresult,
"", "", /* Not selectable individually, just part of ChaCha20-Poly1305 */ "", "", /* Not selectable individually, just part of ChaCha20-Poly1305 */
16, "<implicit>" 16, "Poly1305"
}; };
static void *ccp_make_context(void) static void *ccp_make_context(void)
@ -527,7 +527,7 @@ static const struct ssh2_cipher ssh2_chacha20_poly1305 = {
ccp_decrypt_length, ccp_decrypt_length,
"chacha20-poly1305@openssh.com", "chacha20-poly1305@openssh.com",
1, 512, SSH_CIPHER_SEPARATE_LENGTH, "ChaCha20 Poly1305", 1, 512, SSH_CIPHER_SEPARATE_LENGTH, "ChaCha20",
&ssh2_poly1305 &ssh2_poly1305
}; };