2022-05-12 17:20:56 +03:00
|
|
|
# frozen_string_literal: true
|
2011-05-22 06:27:09 +04:00
|
|
|
# Timeout long-running blocks
|
1999-08-13 09:45:20 +04:00
|
|
|
#
|
2011-05-22 06:27:09 +04:00
|
|
|
# == Synopsis
|
2005-11-22 02:58:10 +03:00
|
|
|
#
|
2006-12-31 18:02:22 +03:00
|
|
|
# require 'timeout'
|
|
|
|
# status = Timeout::timeout(5) {
|
2011-05-22 06:27:09 +04:00
|
|
|
# # Something that should be interrupted if it takes more than 5 seconds...
|
2006-12-31 18:02:22 +03:00
|
|
|
# }
|
1999-08-13 09:45:20 +04:00
|
|
|
#
|
2011-05-22 06:27:09 +04:00
|
|
|
# == Description
|
1999-08-13 09:45:20 +04:00
|
|
|
#
|
2011-05-22 06:27:09 +04:00
|
|
|
# Timeout provides a way to auto-terminate a potentially long-running
|
|
|
|
# operation if it hasn't finished in a fixed amount of time.
|
1999-08-13 09:45:20 +04:00
|
|
|
#
|
2011-05-22 06:27:09 +04:00
|
|
|
# Previous versions didn't use a module for namespacing, however
|
|
|
|
# #timeout is provided for backwards compatibility. You
|
2017-11-17 18:08:03 +03:00
|
|
|
# should prefer Timeout.timeout instead.
|
2003-07-03 15:02:53 +04:00
|
|
|
#
|
2011-05-22 06:27:09 +04:00
|
|
|
# == Copyright
|
2003-07-03 15:02:53 +04:00
|
|
|
#
|
2006-12-31 18:02:22 +03:00
|
|
|
# Copyright:: (C) 2000 Network Applied Communication Laboratory, Inc.
|
|
|
|
# Copyright:: (C) 2000 Information-technology Promotion Agency, Japan
|
1999-08-13 09:45:20 +04:00
|
|
|
|
2003-07-03 15:02:53 +04:00
|
|
|
module Timeout
|
2023-06-23 06:51:31 +03:00
|
|
|
VERSION = "0.4.0"
|
2020-07-28 18:31:52 +03:00
|
|
|
|
[ruby/timeout] Raise exception instead of throw/catch for timeouts
(https://github.com/ruby/timeout/pull/30)
throw/catch is used for non-local control flow, not for exceptional situations.
For exceptional situations, raise should be used instead. A timeout is an
exceptional situation, so it should use raise, not throw/catch.
Timeout's implementation that uses throw/catch internally causes serious problems.
Consider the following code:
```ruby
def handle_exceptions
yield
rescue Exception => exc
handle_error # e.g. ROLLBACK for databases
raise
ensure
handle_exit unless exc # e.g. COMMIT for databases
end
Timeout.timeout(1) do
handle_exceptions do
do_something
end
end
```
This kind of design ensures that all exceptions are handled as errors, and
ensures that all exits (normal exit, early return, throw/catch) are not
handled as errors. With Timeout's throw/catch implementation, this type of
code does not work, since a timeout triggers the normal exit path.
See https://github.com/rails/rails/pull/29333 for an example of the damage
Timeout's design has caused the Rails ecosystem.
This switches Timeout.timeout to use raise/rescue internally. It adds a
Timeout::ExitException subclass of exception for the internal raise/rescue,
which Timeout.timeout will convert to Timeout::Error for backwards
compatibility. Timeout::Error remains a subclass of RuntimeError.
This is how timeout used to work in Ruby 2.0. It was changed in Ruby 2.1,
after discussion in [Bug #8730] (commit
https://github.com/ruby/timeout/commit/238c003c921e in the timeout repository). I
think the change from using raise/rescue to using throw/catch has caused
significant harm to the Ruby ecosystem at large, and reverting it is
the most sensible choice.
From the translation of [Bug #8730], it appears the issue was that
someone could rescue Exception and not reraise the exception, causing
timeout errors to be swallowed. However, such code is broken anyway.
Using throw/catch causes far worse problems, because then it becomes
impossible to differentiate between normal control flow and exceptional
control flow.
Also related to this is [Bug #11344], which changed how
Thread.handle_interrupt interacted with Timeout.
https://github.com/ruby/timeout/commit/f16545abe6
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
2023-06-22 21:24:40 +03:00
|
|
|
# Internal error raised to when a timeout is triggered.
|
|
|
|
class ExitException < Exception
|
|
|
|
def exception(*)
|
|
|
|
self
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-11-17 18:08:03 +03:00
|
|
|
# Raised by Timeout.timeout when the block times out.
|
2008-02-13 19:43:18 +03:00
|
|
|
class Error < RuntimeError
|
[ruby/timeout] Raise exception instead of throw/catch for timeouts
(https://github.com/ruby/timeout/pull/30)
throw/catch is used for non-local control flow, not for exceptional situations.
For exceptional situations, raise should be used instead. A timeout is an
exceptional situation, so it should use raise, not throw/catch.
Timeout's implementation that uses throw/catch internally causes serious problems.
Consider the following code:
```ruby
def handle_exceptions
yield
rescue Exception => exc
handle_error # e.g. ROLLBACK for databases
raise
ensure
handle_exit unless exc # e.g. COMMIT for databases
end
Timeout.timeout(1) do
handle_exceptions do
do_something
end
end
```
This kind of design ensures that all exceptions are handled as errors, and
ensures that all exits (normal exit, early return, throw/catch) are not
handled as errors. With Timeout's throw/catch implementation, this type of
code does not work, since a timeout triggers the normal exit path.
See https://github.com/rails/rails/pull/29333 for an example of the damage
Timeout's design has caused the Rails ecosystem.
This switches Timeout.timeout to use raise/rescue internally. It adds a
Timeout::ExitException subclass of exception for the internal raise/rescue,
which Timeout.timeout will convert to Timeout::Error for backwards
compatibility. Timeout::Error remains a subclass of RuntimeError.
This is how timeout used to work in Ruby 2.0. It was changed in Ruby 2.1,
after discussion in [Bug #8730] (commit
https://github.com/ruby/timeout/commit/238c003c921e in the timeout repository). I
think the change from using raise/rescue to using throw/catch has caused
significant harm to the Ruby ecosystem at large, and reverting it is
the most sensible choice.
From the translation of [Bug #8730], it appears the issue was that
someone could rescue Exception and not reraise the exception, causing
timeout errors to be swallowed. However, such code is broken anyway.
Using throw/catch causes far worse problems, because then it becomes
impossible to differentiate between normal control flow and exceptional
control flow.
Also related to this is [Bug #11344], which changed how
Thread.handle_interrupt interacted with Timeout.
https://github.com/ruby/timeout/commit/f16545abe6
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
2023-06-22 21:24:40 +03:00
|
|
|
def self.handle_timeout(message)
|
|
|
|
exc = ExitException.new(message)
|
2013-08-26 10:27:48 +04:00
|
|
|
|
[ruby/timeout] Raise exception instead of throw/catch for timeouts
(https://github.com/ruby/timeout/pull/30)
throw/catch is used for non-local control flow, not for exceptional situations.
For exceptional situations, raise should be used instead. A timeout is an
exceptional situation, so it should use raise, not throw/catch.
Timeout's implementation that uses throw/catch internally causes serious problems.
Consider the following code:
```ruby
def handle_exceptions
yield
rescue Exception => exc
handle_error # e.g. ROLLBACK for databases
raise
ensure
handle_exit unless exc # e.g. COMMIT for databases
end
Timeout.timeout(1) do
handle_exceptions do
do_something
end
end
```
This kind of design ensures that all exceptions are handled as errors, and
ensures that all exits (normal exit, early return, throw/catch) are not
handled as errors. With Timeout's throw/catch implementation, this type of
code does not work, since a timeout triggers the normal exit path.
See https://github.com/rails/rails/pull/29333 for an example of the damage
Timeout's design has caused the Rails ecosystem.
This switches Timeout.timeout to use raise/rescue internally. It adds a
Timeout::ExitException subclass of exception for the internal raise/rescue,
which Timeout.timeout will convert to Timeout::Error for backwards
compatibility. Timeout::Error remains a subclass of RuntimeError.
This is how timeout used to work in Ruby 2.0. It was changed in Ruby 2.1,
after discussion in [Bug #8730] (commit
https://github.com/ruby/timeout/commit/238c003c921e in the timeout repository). I
think the change from using raise/rescue to using throw/catch has caused
significant harm to the Ruby ecosystem at large, and reverting it is
the most sensible choice.
From the translation of [Bug #8730], it appears the issue was that
someone could rescue Exception and not reraise the exception, causing
timeout errors to be swallowed. However, such code is broken anyway.
Using throw/catch causes far worse problems, because then it becomes
impossible to differentiate between normal control flow and exceptional
control flow.
Also related to this is [Bug #11344], which changed how
Thread.handle_interrupt interacted with Timeout.
https://github.com/ruby/timeout/commit/f16545abe6
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
2023-06-22 21:24:40 +03:00
|
|
|
begin
|
|
|
|
yield exc
|
|
|
|
rescue ExitException => e
|
|
|
|
raise new(message) if exc.equal?(e)
|
|
|
|
raise
|
2014-01-08 08:12:39 +04:00
|
|
|
end
|
2013-08-26 10:27:48 +04:00
|
|
|
end
|
2008-02-13 19:43:18 +03:00
|
|
|
end
|
|
|
|
|
2011-05-16 22:34:41 +04:00
|
|
|
# :stopdoc:
|
2022-05-12 17:20:56 +03:00
|
|
|
CONDVAR = ConditionVariable.new
|
|
|
|
QUEUE = Queue.new
|
|
|
|
QUEUE_MUTEX = Mutex.new
|
|
|
|
TIMEOUT_THREAD_MUTEX = Mutex.new
|
|
|
|
@timeout_thread = nil
|
|
|
|
private_constant :CONDVAR, :QUEUE, :QUEUE_MUTEX, :TIMEOUT_THREAD_MUTEX
|
|
|
|
|
|
|
|
class Request
|
|
|
|
attr_reader :deadline
|
|
|
|
|
|
|
|
def initialize(thread, timeout, exception_class, message)
|
|
|
|
@thread = thread
|
2022-06-08 16:44:32 +03:00
|
|
|
@deadline = GET_TIME.call(Process::CLOCK_MONOTONIC) + timeout
|
2022-05-12 17:20:56 +03:00
|
|
|
@exception_class = exception_class
|
|
|
|
@message = message
|
|
|
|
|
|
|
|
@mutex = Mutex.new
|
2022-05-15 14:49:31 +03:00
|
|
|
@done = false # protected by @mutex
|
2022-05-12 17:20:56 +03:00
|
|
|
end
|
|
|
|
|
|
|
|
def done?
|
2022-05-15 14:49:31 +03:00
|
|
|
@mutex.synchronize do
|
|
|
|
@done
|
|
|
|
end
|
2022-05-12 17:20:56 +03:00
|
|
|
end
|
|
|
|
|
|
|
|
def expired?(now)
|
2022-05-15 14:51:57 +03:00
|
|
|
now >= @deadline
|
2022-05-12 17:20:56 +03:00
|
|
|
end
|
|
|
|
|
|
|
|
def interrupt
|
|
|
|
@mutex.synchronize do
|
|
|
|
unless @done
|
|
|
|
@thread.raise @exception_class, @message
|
|
|
|
@done = true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def finished
|
|
|
|
@mutex.synchronize do
|
|
|
|
@done = true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
private_constant :Request
|
|
|
|
|
2022-05-15 14:43:29 +03:00
|
|
|
def self.create_timeout_thread
|
2022-05-25 13:50:36 +03:00
|
|
|
watcher = Thread.new do
|
2022-05-15 14:43:29 +03:00
|
|
|
requests = []
|
|
|
|
while true
|
|
|
|
until QUEUE.empty? and !requests.empty? # wait to have at least one request
|
|
|
|
req = QUEUE.pop
|
|
|
|
requests << req unless req.done?
|
|
|
|
end
|
|
|
|
closest_deadline = requests.min_by(&:deadline).deadline
|
|
|
|
|
|
|
|
now = 0.0
|
|
|
|
QUEUE_MUTEX.synchronize do
|
2022-06-08 16:44:32 +03:00
|
|
|
while (now = GET_TIME.call(Process::CLOCK_MONOTONIC)) < closest_deadline and QUEUE.empty?
|
2022-05-15 14:43:29 +03:00
|
|
|
CONDVAR.wait(QUEUE_MUTEX, closest_deadline - now)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
requests.each do |req|
|
|
|
|
req.interrupt if req.expired?(now)
|
|
|
|
end
|
|
|
|
requests.reject!(&:done?)
|
|
|
|
end
|
|
|
|
end
|
2023-02-12 17:23:37 +03:00
|
|
|
ThreadGroup::Default.add(watcher) unless watcher.group.enclosed?
|
2022-07-13 14:48:21 +03:00
|
|
|
watcher.name = "Timeout stdlib thread"
|
2022-05-25 13:50:36 +03:00
|
|
|
watcher.thread_variable_set(:"\0__detached_thread__", true)
|
|
|
|
watcher
|
2022-05-15 14:43:29 +03:00
|
|
|
end
|
|
|
|
private_class_method :create_timeout_thread
|
|
|
|
|
2022-05-12 17:20:56 +03:00
|
|
|
def self.ensure_timeout_thread_created
|
2022-05-15 14:43:29 +03:00
|
|
|
unless @timeout_thread and @timeout_thread.alive?
|
2022-05-12 17:20:56 +03:00
|
|
|
TIMEOUT_THREAD_MUTEX.synchronize do
|
2022-05-15 14:43:29 +03:00
|
|
|
unless @timeout_thread and @timeout_thread.alive?
|
|
|
|
@timeout_thread = create_timeout_thread
|
2022-05-12 17:20:56 +03:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2022-06-08 16:44:32 +03:00
|
|
|
|
|
|
|
# We keep a private reference so that time mocking libraries won't break
|
|
|
|
# Timeout.
|
|
|
|
GET_TIME = Process.method(:clock_gettime)
|
|
|
|
private_constant :GET_TIME
|
|
|
|
|
2011-05-16 22:34:41 +04:00
|
|
|
# :startdoc:
|
1999-08-13 09:45:20 +04:00
|
|
|
|
2013-03-31 06:01:17 +04:00
|
|
|
# Perform an operation in a block, raising an error if it takes longer than
|
|
|
|
# +sec+ seconds to complete.
|
2011-05-22 06:27:09 +04:00
|
|
|
#
|
2011-06-16 09:24:12 +04:00
|
|
|
# +sec+:: Number of seconds to wait for the block to terminate. Any number
|
2013-03-31 06:01:17 +04:00
|
|
|
# may be used, including Floats to specify fractional seconds. A
|
|
|
|
# value of 0 or +nil+ will execute the block without any timeout.
|
2011-05-22 06:27:09 +04:00
|
|
|
# +klass+:: Exception Class to raise if the block fails to terminate
|
|
|
|
# in +sec+ seconds. Omitting will use the default, Timeout::Error
|
2016-09-07 15:32:02 +03:00
|
|
|
# +message+:: Error message to raise with Exception Class.
|
2016-09-07 11:21:56 +03:00
|
|
|
# Omitting will use the default, "execution expired"
|
2011-05-22 06:27:09 +04:00
|
|
|
#
|
|
|
|
# Returns the result of the block *if* the block completed before
|
|
|
|
# +sec+ seconds, otherwise throws an exception, based on the value of +klass+.
|
* array.c: replace rb_protect_inspect() and rb_inspecting_p() by
rb_exec_recursive() in eval.c.
* eval.c (rb_exec_recursive): new function.
* array.c (rb_ary_join): use rb_exec_recursive().
* array.c (rb_ary_inspect, rb_ary_hash): ditto.
* file.c (rb_file_join): ditto.
* hash.c (rb_hash_inspect, rb_hash_to_s, rb_hash_hash): ditto.
* io.c (rb_io_puts): ditto.
* object.c (rb_obj_inspect): ditto
* struct.c (rb_struct_inspect): ditto.
* lib/set.rb (SortedSet::setup): a hack to shut up warning.
[ruby-talk:132866]
* lib/time.rb (Time::strptime): add new function. inspired by
[ruby-talk:132815].
* lib/parsedate.rb (ParseDate::strptime): ditto.
* regparse.c: move st_*_strend() functions from st.c. fixed some
potential memory leaks.
* exception error messages updated. [ruby-core:04497]
* ext/socket/socket.c (Init_socket): add bunch of Socket
constants. Patch from Sam Roberts <sroberts@uniserve.com>.
[ruby-core:04409]
* array.c (rb_ary_s_create): no need for negative argc check.
[ruby-core:04463]
* array.c (rb_ary_unshift_m): ditto.
* lib/xmlrpc/parser.rb (XMLRPC::FaultException): make it subclass
of StandardError class, not Exception class. [ruby-core:04429]
* parse.y (fcall_gen): lvar(arg) will be evaluated as
lvar.call(arg) when lvar is a defined local variable. [new]
* object.c (rb_class_initialize): call inherited method before
calling initializing block.
* eval.c (rb_thread_start_1): initialize newly pushed frame.
* lib/open3.rb (Open3::popen3): $? should not be EXIT_FAILURE.
fixed: [ruby-core:04444]
* eval.c (is_defined): NODE_IASGN is an assignment.
* ext/readline/readline.c (Readline.readline): use rl_outstream
and rl_instream. [ruby-dev:25699]
* ext/etc/etc.c (Init_etc): sGroup needs HAVE_ST_GR_PASSWD check
[ruby-dev:25675]
* misc/ruby-mode.el: [ruby-core:04415]
* lib/rdoc/generators/html_generator.rb: [ruby-core:04412]
* lib/rdoc/generators/ri_generator.rb: ditto.
* struct.c (make_struct): fixed: [ruby-core:04402]
* ext/curses/curses.c (window_color_set): [ruby-core:04393]
* ext/socket/socket.c (Init_socket): SO_REUSEPORT added.
[ruby-talk:130092]
* object.c: [ruby-doc:818]
* parse.y (open_args): fix too verbose warnings for the space
before argument parentheses. [ruby-dev:25492]
* parse.y (parser_yylex): ditto.
* parse.y (parser_yylex): the first expression in the parentheses
should not be a command. [ruby-dev:25492]
* lib/irb/context.rb (IRB::Context::initialize): [ruby-core:04330]
* object.c (Init_Object): remove Object#type. [ruby-core:04335]
* st.c (st_foreach): report success/failure by return value.
[ruby-Bugs-1396]
* parse.y: forgot to initialize parser struct. [ruby-dev:25492]
* parse.y (parser_yylex): no tLABEL on EXPR_BEG.
[ruby-talk:127711]
* document updates - [ruby-core:04296], [ruby-core:04301],
[ruby-core:04302], [ruby-core:04307]
* dir.c (rb_push_glob): should work for NUL delimited patterns.
* dir.c (rb_glob2): should aware of offset in the pattern.
* string.c (rb_str_new4): should propagate taintedness.
* env.h: rename member names in struct FRAME; last_func -> callee,
orig_func -> this_func, last_class -> this_class.
* struct.c (rb_struct_set): use original method name, not callee
name, to retrieve member slot. [ruby-core:04268]
* time.c (time_strftime): protect from format modification from GC
finalizers.
* object.c (Init_Object): remove rb_obj_id_obsolete()
* eval.c (rb_mod_define_method): incomplete subclass check.
[ruby-dev:25464]
* gc.c (rb_data_object_alloc): klass may be NULL.
[ruby-list:40498]
* bignum.c (rb_big_rand): should return positive random number.
[ruby-dev:25401]
* bignum.c (rb_big_rand): do not use rb_big_modulo to generate
random bignums. [ruby-dev:25396]
* variable.c (rb_autoload): [ruby-dev:25373]
* eval.c (svalue_to_avalue): [ruby-dev:25366]
* string.c (rb_str_justify): [ruby-dev:25367]
* io.c (rb_f_select): [ruby-dev:25312]
* ext/socket/socket.c (sock_s_getservbyport): [ruby-talk:124072]
* struct.c (make_struct): [ruby-dev:25249]
* dir.c (dir_open_dir): new function. [ruby-dev:25242]
* io.c (rb_f_open): add type check for return value from to_open.
* lib/pstore.rb (PStore#transaction): Use the empty content when a
file is not found. [ruby-dev:24561]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@8068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2005-03-04 09:47:45 +03:00
|
|
|
#
|
2013-11-10 20:05:04 +04:00
|
|
|
# The exception thrown to terminate the given block cannot be rescued inside
|
2019-06-05 05:19:37 +03:00
|
|
|
# the block unless +klass+ is given explicitly. However, the block can use
|
|
|
|
# ensure to prevent the handling of the exception. For that reason, this
|
|
|
|
# method cannot be relied on to enforce timeouts for untrusted blocks.
|
2013-11-10 20:05:04 +04:00
|
|
|
#
|
2020-12-26 12:09:49 +03:00
|
|
|
# If a scheduler is defined, it will be used to handle the timeout by invoking
|
|
|
|
# Scheduler#timeout_after.
|
|
|
|
#
|
2011-05-22 06:27:09 +04:00
|
|
|
# Note that this is both a method of module Timeout, so you can <tt>include
|
|
|
|
# Timeout</tt> into your classes so they have a #timeout method, as well as
|
|
|
|
# a module method, so you can call it directly as Timeout.timeout().
|
2021-02-11 09:17:54 +03:00
|
|
|
def timeout(sec, klass = nil, message = nil, &block) #:yield: +sec+
|
2012-12-05 19:48:11 +04:00
|
|
|
return yield(sec) if sec == nil or sec.zero?
|
2021-02-11 09:17:54 +03:00
|
|
|
|
2022-05-12 17:20:56 +03:00
|
|
|
message ||= "execution expired"
|
2021-02-11 09:17:54 +03:00
|
|
|
|
2021-05-03 18:38:54 +03:00
|
|
|
if Fiber.respond_to?(:current_scheduler) && (scheduler = Fiber.current_scheduler)&.respond_to?(:timeout_after)
|
2020-12-26 12:09:49 +03:00
|
|
|
return scheduler.timeout_after(sec, klass || Error, message, &block)
|
2021-02-11 09:17:54 +03:00
|
|
|
end
|
|
|
|
|
2022-05-12 17:20:56 +03:00
|
|
|
Timeout.ensure_timeout_thread_created
|
|
|
|
perform = Proc.new do |exc|
|
|
|
|
request = Request.new(Thread.current, sec, exc, message)
|
|
|
|
QUEUE_MUTEX.synchronize do
|
|
|
|
QUEUE << request
|
|
|
|
CONDVAR.signal
|
|
|
|
end
|
2012-12-07 14:36:59 +04:00
|
|
|
begin
|
|
|
|
return yield(sec)
|
|
|
|
ensure
|
2022-05-12 17:20:56 +03:00
|
|
|
request.finished
|
2011-05-18 15:31:58 +04:00
|
|
|
end
|
2003-07-03 15:02:53 +04:00
|
|
|
end
|
2022-05-12 17:20:56 +03:00
|
|
|
|
2014-01-07 07:43:08 +04:00
|
|
|
if klass
|
2022-05-12 17:20:56 +03:00
|
|
|
perform.call(klass)
|
2014-01-07 07:43:08 +04:00
|
|
|
else
|
[ruby/timeout] Raise exception instead of throw/catch for timeouts
(https://github.com/ruby/timeout/pull/30)
throw/catch is used for non-local control flow, not for exceptional situations.
For exceptional situations, raise should be used instead. A timeout is an
exceptional situation, so it should use raise, not throw/catch.
Timeout's implementation that uses throw/catch internally causes serious problems.
Consider the following code:
```ruby
def handle_exceptions
yield
rescue Exception => exc
handle_error # e.g. ROLLBACK for databases
raise
ensure
handle_exit unless exc # e.g. COMMIT for databases
end
Timeout.timeout(1) do
handle_exceptions do
do_something
end
end
```
This kind of design ensures that all exceptions are handled as errors, and
ensures that all exits (normal exit, early return, throw/catch) are not
handled as errors. With Timeout's throw/catch implementation, this type of
code does not work, since a timeout triggers the normal exit path.
See https://github.com/rails/rails/pull/29333 for an example of the damage
Timeout's design has caused the Rails ecosystem.
This switches Timeout.timeout to use raise/rescue internally. It adds a
Timeout::ExitException subclass of exception for the internal raise/rescue,
which Timeout.timeout will convert to Timeout::Error for backwards
compatibility. Timeout::Error remains a subclass of RuntimeError.
This is how timeout used to work in Ruby 2.0. It was changed in Ruby 2.1,
after discussion in [Bug #8730] (commit
https://github.com/ruby/timeout/commit/238c003c921e in the timeout repository). I
think the change from using raise/rescue to using throw/catch has caused
significant harm to the Ruby ecosystem at large, and reverting it is
the most sensible choice.
From the translation of [Bug #8730], it appears the issue was that
someone could rescue Exception and not reraise the exception, causing
timeout errors to be swallowed. However, such code is broken anyway.
Using throw/catch causes far worse problems, because then it becomes
impossible to differentiate between normal control flow and exceptional
control flow.
Also related to this is [Bug #11344], which changed how
Thread.handle_interrupt interacted with Timeout.
https://github.com/ruby/timeout/commit/f16545abe6
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
2023-06-22 21:24:40 +03:00
|
|
|
Error.handle_timeout(message, &perform)
|
2014-01-07 07:43:08 +04:00
|
|
|
end
|
1999-08-13 09:45:20 +04:00
|
|
|
end
|
2003-07-03 15:02:53 +04:00
|
|
|
module_function :timeout
|
|
|
|
end
|