2023-09-27 19:39:53 +03:00
|
|
|
#include "prism.h"
|
2023-08-28 23:55:58 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
#define OLD_ISEQ NEW_ISEQ
|
|
|
|
#undef NEW_ISEQ
|
|
|
|
|
|
|
|
#define NEW_ISEQ(node, name, type, line_no) \
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_new_child_iseq(iseq, (node), parser, rb_fstring(name), 0, (type), (line_no))
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
#define OLD_CHILD_ISEQ NEW_CHILD_ISEQ
|
|
|
|
#undef NEW_CHILD_ISEQ
|
|
|
|
|
|
|
|
#define NEW_CHILD_ISEQ(node, name, type, line_no) \
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_new_child_iseq(iseq, (node), parser, rb_fstring(name), iseq, (type), (line_no))
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-11-03 02:29:20 +03:00
|
|
|
#define PM_COMPILE(node) \
|
|
|
|
pm_compile_node(iseq, (node), ret, src, popped, scope_node)
|
|
|
|
|
|
|
|
#define PM_COMPILE_INTO_ANCHOR(_ret, node) \
|
2023-11-02 01:26:40 +03:00
|
|
|
pm_compile_node(iseq, (node), _ret, src, popped, scope_node)
|
2023-09-08 23:33:05 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
#define PM_COMPILE_POPPED(node) \
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_node(iseq, (node), ret, src, true, scope_node)
|
2023-09-08 23:33:05 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
#define PM_COMPILE_NOT_POPPED(node) \
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_node(iseq, (node), ret, src, false, scope_node)
|
2023-09-08 23:33:05 +03:00
|
|
|
|
2023-10-24 23:08:50 +03:00
|
|
|
#define PM_POP \
|
2024-01-22 23:22:12 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, pop)
|
2023-10-24 23:08:50 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
#define PM_POP_IF_POPPED \
|
2024-01-22 23:22:12 +03:00
|
|
|
if (popped) PM_POP
|
2023-09-21 22:28:08 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
#define PM_POP_UNLESS_POPPED \
|
2024-01-22 23:22:12 +03:00
|
|
|
if (!popped) PM_POP
|
2023-09-21 22:28:08 +03:00
|
|
|
|
2023-10-26 18:03:18 +03:00
|
|
|
#define PM_DUP \
|
2024-01-22 23:22:12 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, dup)
|
2023-10-26 18:03:18 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
#define PM_DUP_UNLESS_POPPED \
|
2024-01-22 23:22:12 +03:00
|
|
|
if (!popped) PM_DUP
|
2023-09-21 22:28:08 +03:00
|
|
|
|
2023-10-30 19:56:30 +03:00
|
|
|
#define PM_PUTSELF \
|
2024-01-22 23:22:12 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, putself)
|
2023-10-30 19:56:30 +03:00
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
#define PM_PUTNIL \
|
2024-01-22 23:22:12 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil)
|
2023-10-23 16:46:37 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
#define PM_PUTNIL_UNLESS_POPPED \
|
2024-01-22 23:22:12 +03:00
|
|
|
if (!popped) PM_PUTNIL
|
2023-09-21 22:28:08 +03:00
|
|
|
|
2023-10-25 18:34:03 +03:00
|
|
|
#define PM_SWAP \
|
2024-01-22 23:22:12 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, swap)
|
2023-10-25 18:34:03 +03:00
|
|
|
|
2023-10-26 18:03:18 +03:00
|
|
|
#define PM_SWAP_UNLESS_POPPED \
|
2024-01-22 23:22:12 +03:00
|
|
|
if (!popped) PM_SWAP
|
2023-10-26 18:03:18 +03:00
|
|
|
|
2023-12-06 17:45:04 +03:00
|
|
|
#define PM_NOP \
|
2024-01-22 23:22:12 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, nop)
|
2023-12-06 17:45:04 +03:00
|
|
|
|
2024-01-23 22:43:53 +03:00
|
|
|
#define PM_SPECIAL_CONSTANT_FLAG ((pm_constant_id_t)(1 << 31))
|
|
|
|
#define PM_CONSTANT_AND ((pm_constant_id_t)(idAnd | PM_SPECIAL_CONSTANT_FLAG))
|
2024-01-24 21:43:26 +03:00
|
|
|
#define PM_CONSTANT_DOT3 ((pm_constant_id_t)(idDot3 | PM_SPECIAL_CONSTANT_FLAG))
|
2024-01-24 00:13:18 +03:00
|
|
|
#define PM_CONSTANT_MULT ((pm_constant_id_t)(idMULT | PM_SPECIAL_CONSTANT_FLAG))
|
2024-01-24 18:22:46 +03:00
|
|
|
#define PM_CONSTANT_POW ((pm_constant_id_t)(idPow | PM_SPECIAL_CONSTANT_FLAG))
|
2023-10-20 12:59:02 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
rb_iseq_t *
|
2023-10-19 00:53:02 +03:00
|
|
|
pm_iseq_new_with_opt(pm_scope_node_t *scope_node, pm_parser_t *parser, VALUE name, VALUE path, VALUE realpath,
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
int first_lineno, const rb_iseq_t *parent, int isolated_depth,
|
|
|
|
enum rb_iseq_type type, const rb_compile_option_t *option);
|
|
|
|
|
2023-08-29 19:27:00 +03:00
|
|
|
static VALUE
|
2023-09-27 19:39:53 +03:00
|
|
|
parse_integer(const pm_integer_node_t *node)
|
2023-09-08 22:33:51 +03:00
|
|
|
{
|
2023-12-12 21:40:05 +03:00
|
|
|
char *start = (char *) node->base.location.start;
|
|
|
|
char *end = (char *) node->base.location.end;
|
2023-09-22 21:53:55 +03:00
|
|
|
|
2023-09-08 22:33:51 +03:00
|
|
|
size_t length = end - start;
|
2023-09-22 21:53:55 +03:00
|
|
|
int base = -10;
|
2023-09-08 22:33:51 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
switch (node->base.flags & (PM_INTEGER_BASE_FLAGS_BINARY | PM_INTEGER_BASE_FLAGS_DECIMAL | PM_INTEGER_BASE_FLAGS_OCTAL | PM_INTEGER_BASE_FLAGS_HEXADECIMAL)) {
|
|
|
|
case PM_INTEGER_BASE_FLAGS_BINARY:
|
2023-09-22 21:53:55 +03:00
|
|
|
base = 2;
|
|
|
|
break;
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTEGER_BASE_FLAGS_DECIMAL:
|
2023-09-22 21:53:55 +03:00
|
|
|
base = 10;
|
|
|
|
break;
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTEGER_BASE_FLAGS_OCTAL:
|
2023-09-22 21:53:55 +03:00
|
|
|
base = 8;
|
|
|
|
break;
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTEGER_BASE_FLAGS_HEXADECIMAL:
|
2023-09-22 21:53:55 +03:00
|
|
|
base = 16;
|
|
|
|
break;
|
|
|
|
default:
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Unreachable");
|
2023-09-22 21:53:55 +03:00
|
|
|
}
|
|
|
|
|
2023-12-12 21:40:05 +03:00
|
|
|
return rb_int_parse_cstr(start, length, &end, NULL, base, RB_INT_PARSE_DEFAULT);
|
2023-09-08 22:33:51 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static VALUE
|
2023-09-27 19:39:53 +03:00
|
|
|
parse_float(const pm_node_t *node)
|
2023-09-08 22:33:51 +03:00
|
|
|
{
|
2023-08-30 21:32:52 +03:00
|
|
|
const uint8_t *start = node->location.start;
|
|
|
|
const uint8_t *end = node->location.end;
|
2023-08-29 19:27:00 +03:00
|
|
|
size_t length = end - start;
|
|
|
|
|
|
|
|
char *buffer = malloc(length + 1);
|
|
|
|
memcpy(buffer, start, length);
|
|
|
|
|
|
|
|
buffer[length] = '\0';
|
2023-09-08 22:33:51 +03:00
|
|
|
VALUE number = DBL2NUM(rb_cstr_to_dbl(buffer, 0));
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
free(buffer);
|
|
|
|
return number;
|
|
|
|
}
|
|
|
|
|
2023-09-08 22:33:51 +03:00
|
|
|
static VALUE
|
2023-09-27 19:39:53 +03:00
|
|
|
parse_rational(const pm_node_t *node)
|
2023-09-08 22:33:51 +03:00
|
|
|
{
|
|
|
|
const uint8_t *start = node->location.start;
|
|
|
|
const uint8_t *end = node->location.end - 1;
|
|
|
|
size_t length = end - start;
|
|
|
|
|
|
|
|
VALUE res;
|
2023-09-27 19:39:53 +03:00
|
|
|
if (PM_NODE_TYPE_P(((pm_rational_node_t *)node)->numeric, PM_FLOAT_NODE)) {
|
2023-09-08 22:33:51 +03:00
|
|
|
char *buffer = malloc(length + 1);
|
|
|
|
memcpy(buffer, start, length);
|
|
|
|
|
|
|
|
buffer[length] = '\0';
|
|
|
|
|
|
|
|
char *decimal = memchr(buffer, '.', length);
|
|
|
|
RUBY_ASSERT(decimal);
|
|
|
|
size_t seen_decimal = decimal - buffer;
|
|
|
|
size_t fraclen = length - seen_decimal - 1;
|
|
|
|
memmove(decimal, decimal + 1, fraclen + 1);
|
|
|
|
|
|
|
|
VALUE v = rb_cstr_to_inum(buffer, 10, false);
|
|
|
|
res = rb_rational_new(v, rb_int_positive_pow(10, fraclen));
|
|
|
|
|
|
|
|
free(buffer);
|
|
|
|
}
|
|
|
|
else {
|
2023-09-27 19:39:53 +03:00
|
|
|
RUBY_ASSERT(PM_NODE_TYPE_P(((pm_rational_node_t *)node)->numeric, PM_INTEGER_NODE));
|
2023-09-08 22:33:51 +03:00
|
|
|
VALUE number = rb_int_parse_cstr((const char *)start, length, NULL, NULL, -10, RB_INT_PARSE_DEFAULT);
|
|
|
|
res = rb_rational_raw(number, INT2FIX(1));
|
|
|
|
}
|
|
|
|
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
static VALUE
|
2023-09-27 19:39:53 +03:00
|
|
|
parse_imaginary(pm_imaginary_node_t *node)
|
2023-09-08 22:33:51 +03:00
|
|
|
{
|
|
|
|
VALUE imaginary_part;
|
2023-09-27 19:39:53 +03:00
|
|
|
switch (PM_NODE_TYPE(node->numeric)) {
|
|
|
|
case PM_FLOAT_NODE: {
|
2023-09-08 22:33:51 +03:00
|
|
|
imaginary_part = parse_float(node->numeric);
|
|
|
|
break;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTEGER_NODE: {
|
|
|
|
imaginary_part = parse_integer((pm_integer_node_t *) node->numeric);
|
2023-09-08 22:33:51 +03:00
|
|
|
break;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_RATIONAL_NODE: {
|
2023-09-08 22:33:51 +03:00
|
|
|
imaginary_part = parse_rational(node->numeric);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Unexpected numeric type on imaginary number %s\n", pm_node_type_to_str(PM_NODE_TYPE(node->numeric)));
|
2023-09-08 22:33:51 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return rb_complex_raw(INT2FIX(0), imaginary_part);
|
|
|
|
}
|
|
|
|
|
2023-08-29 19:27:00 +03:00
|
|
|
static inline VALUE
|
2023-10-24 20:17:18 +03:00
|
|
|
parse_string(pm_string_t *string, const pm_parser_t *parser)
|
2023-09-08 22:33:51 +03:00
|
|
|
{
|
2023-12-06 20:54:16 +03:00
|
|
|
rb_encoding *enc = rb_enc_from_index(rb_enc_find_index(parser->encoding->name));
|
2023-10-19 23:50:21 +03:00
|
|
|
return rb_enc_str_new((const char *) pm_string_source(string), pm_string_length(string), enc);
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
|
2023-12-06 20:54:16 +03:00
|
|
|
/**
|
|
|
|
* Certain strings can have their encoding differ from the parser's encoding due
|
|
|
|
* to bytes or escape sequences that have the top bit set. This function handles
|
|
|
|
* creating those strings based on the flags set on the owning node.
|
|
|
|
*/
|
|
|
|
static inline VALUE
|
|
|
|
parse_string_encoded(const pm_node_t *node, const pm_string_t *string, const pm_parser_t *parser) {
|
|
|
|
rb_encoding *encoding;
|
|
|
|
|
|
|
|
if (node->flags & PM_ENCODING_FLAGS_FORCED_BINARY_ENCODING) {
|
|
|
|
encoding = rb_ascii8bit_encoding();
|
|
|
|
} else if (node->flags & PM_ENCODING_FLAGS_FORCED_UTF8_ENCODING) {
|
|
|
|
encoding = rb_utf8_encoding();
|
|
|
|
} else {
|
|
|
|
encoding = rb_enc_from_index(rb_enc_find_index(parser->encoding->name));
|
|
|
|
}
|
|
|
|
|
|
|
|
return rb_enc_str_new((const char *) pm_string_source(string), pm_string_length(string), encoding);
|
|
|
|
}
|
|
|
|
|
2023-08-29 19:27:00 +03:00
|
|
|
static inline ID
|
2024-01-26 23:18:21 +03:00
|
|
|
parse_symbol(const uint8_t *start, const uint8_t *end, const char *encoding)
|
2023-09-08 22:33:51 +03:00
|
|
|
{
|
2024-01-26 23:18:21 +03:00
|
|
|
rb_encoding *enc = rb_enc_from_index(rb_enc_find_index(encoding));
|
2023-10-19 23:50:21 +03:00
|
|
|
return rb_intern3((const char *) start, end - start, enc);
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline ID
|
2024-01-26 23:18:21 +03:00
|
|
|
parse_string_symbol(const pm_symbol_node_t *symbol, const pm_parser_t *parser)
|
2023-09-27 19:39:53 +03:00
|
|
|
{
|
2024-01-26 23:56:30 +03:00
|
|
|
const char *encoding = parser->encoding->name;
|
|
|
|
if (symbol->base.flags & PM_SYMBOL_FLAGS_FORCED_UTF8_ENCODING) {
|
|
|
|
encoding = "UTF-8";
|
|
|
|
}
|
|
|
|
else if (symbol->base.flags & PM_SYMBOL_FLAGS_FORCED_BINARY_ENCODING) {
|
|
|
|
encoding = "ASCII-8BIT";
|
|
|
|
}
|
2024-01-27 00:13:04 +03:00
|
|
|
else if (symbol->base.flags & PM_SYMBOL_FLAGS_FORCED_US_ASCII_ENCODING) {
|
|
|
|
encoding = "US-ASCII";
|
|
|
|
}
|
2024-01-26 23:18:21 +03:00
|
|
|
const uint8_t *start = pm_string_source(&symbol->unescaped);
|
|
|
|
return parse_symbol(start, start + pm_string_length(&symbol->unescaped), encoding);
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
|
2023-10-16 22:00:01 +03:00
|
|
|
static inline ID
|
2024-01-12 01:05:42 +03:00
|
|
|
parse_location_symbol(const pm_location_t *location, const pm_parser_t *parser)
|
2023-10-16 22:00:01 +03:00
|
|
|
{
|
2024-01-26 23:18:21 +03:00
|
|
|
return parse_symbol(location->start, location->end, parser->encoding->name);
|
2023-10-16 22:00:01 +03:00
|
|
|
}
|
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
static int
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_optimizable_range_item_p(pm_node_t *node)
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
{
|
2023-09-27 19:39:53 +03:00
|
|
|
return (!node || PM_NODE_TYPE_P(node, PM_INTEGER_NODE) || PM_NODE_TYPE_P(node, PM_NIL_NODE));
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
|
2023-10-24 20:17:18 +03:00
|
|
|
#define RE_OPTION_ENCODING_SHIFT 8
|
|
|
|
|
2023-09-28 22:19:56 +03:00
|
|
|
/**
|
|
|
|
* Check the prism flags of a regular expression-like node and return the flags
|
|
|
|
* that are expected by the CRuby VM.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
pm_reg_flags(const pm_node_t *node) {
|
|
|
|
int flags = 0;
|
2023-10-24 20:17:18 +03:00
|
|
|
int dummy = 0;
|
|
|
|
|
|
|
|
// Check "no encoding" first so that flags don't get clobbered
|
|
|
|
// We're calling `rb_char_to_option_kcode` in this case so that
|
|
|
|
// we don't need to have access to `ARG_ENCODING_NONE`
|
|
|
|
if (node->flags & PM_REGULAR_EXPRESSION_FLAGS_ASCII_8BIT) {
|
|
|
|
rb_char_to_option_kcode('n', &flags, &dummy);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->flags & PM_REGULAR_EXPRESSION_FLAGS_EUC_JP) {
|
|
|
|
rb_char_to_option_kcode('e', &flags, &dummy);
|
|
|
|
flags |= ('e' << RE_OPTION_ENCODING_SHIFT);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->flags & PM_REGULAR_EXPRESSION_FLAGS_WINDOWS_31J) {
|
|
|
|
rb_char_to_option_kcode('s', &flags, &dummy);
|
|
|
|
flags |= ('s' << RE_OPTION_ENCODING_SHIFT);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->flags & PM_REGULAR_EXPRESSION_FLAGS_UTF_8) {
|
|
|
|
rb_char_to_option_kcode('u', &flags, &dummy);
|
|
|
|
flags |= ('u' << RE_OPTION_ENCODING_SHIFT);
|
|
|
|
}
|
2023-09-28 22:19:56 +03:00
|
|
|
|
|
|
|
if (node->flags & PM_REGULAR_EXPRESSION_FLAGS_IGNORE_CASE) {
|
|
|
|
flags |= ONIG_OPTION_IGNORECASE;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->flags & PM_REGULAR_EXPRESSION_FLAGS_MULTI_LINE) {
|
|
|
|
flags |= ONIG_OPTION_MULTILINE;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->flags & PM_REGULAR_EXPRESSION_FLAGS_EXTENDED) {
|
|
|
|
flags |= ONIG_OPTION_EXTEND;
|
|
|
|
}
|
|
|
|
|
|
|
|
return flags;
|
|
|
|
}
|
|
|
|
|
2023-10-24 20:17:18 +03:00
|
|
|
static rb_encoding *
|
|
|
|
pm_reg_enc(const pm_regular_expression_node_t *node, const pm_parser_t *parser) {
|
|
|
|
if (node->base.flags & PM_REGULAR_EXPRESSION_FLAGS_ASCII_8BIT) {
|
|
|
|
return rb_ascii8bit_encoding();
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->base.flags & PM_REGULAR_EXPRESSION_FLAGS_EUC_JP) {
|
|
|
|
return rb_enc_get_from_index(ENCINDEX_EUC_JP);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->base.flags & PM_REGULAR_EXPRESSION_FLAGS_WINDOWS_31J) {
|
|
|
|
return rb_enc_get_from_index(ENCINDEX_Windows_31J);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (node->base.flags & PM_REGULAR_EXPRESSION_FLAGS_UTF_8) {
|
|
|
|
return rb_utf8_encoding();
|
|
|
|
}
|
|
|
|
|
2023-12-06 20:54:16 +03:00
|
|
|
return rb_enc_from_index(rb_enc_find_index(parser->encoding->name));
|
2023-10-24 20:17:18 +03:00
|
|
|
}
|
|
|
|
|
2023-09-19 18:35:22 +03:00
|
|
|
/**
|
|
|
|
* Certain nodes can be compiled literally, which can lead to further
|
2023-09-27 19:39:53 +03:00
|
|
|
* optimizations. These nodes will all have the PM_NODE_FLAG_STATIC_LITERAL flag
|
2023-09-19 18:35:22 +03:00
|
|
|
* set.
|
|
|
|
*/
|
|
|
|
static inline bool
|
2023-09-28 22:19:56 +03:00
|
|
|
pm_static_literal_p(const pm_node_t *node)
|
2023-09-27 19:39:53 +03:00
|
|
|
{
|
|
|
|
return node->flags & PM_NODE_FLAG_STATIC_LITERAL;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
|
2023-10-24 20:17:18 +03:00
|
|
|
static VALUE
|
|
|
|
pm_new_regex(pm_regular_expression_node_t * cast, const pm_parser_t * parser) {
|
|
|
|
VALUE regex_str = parse_string(&cast->unescaped, parser);
|
|
|
|
rb_encoding * enc = pm_reg_enc(cast, parser);
|
|
|
|
|
2024-01-22 18:29:09 +03:00
|
|
|
VALUE regex = rb_enc_reg_new(RSTRING_PTR(regex_str), RSTRING_LEN(regex_str), enc, pm_reg_flags((const pm_node_t *)cast));
|
|
|
|
rb_obj_freeze(regex);
|
|
|
|
|
|
|
|
return regex;
|
2023-10-24 20:17:18 +03:00
|
|
|
}
|
|
|
|
|
2023-09-28 22:19:56 +03:00
|
|
|
/**
|
|
|
|
* Certain nodes can be compiled literally. This function returns the literal
|
|
|
|
* value described by the given node. For example, an array node with all static
|
|
|
|
* literal values can be compiled into a literal array.
|
|
|
|
*/
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
static inline VALUE
|
2024-01-12 01:05:42 +03:00
|
|
|
pm_static_literal_value(const pm_node_t *node, const pm_scope_node_t *scope_node, const pm_parser_t *parser)
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
{
|
2023-09-28 22:19:56 +03:00
|
|
|
// Every node that comes into this function should already be marked as
|
|
|
|
// static literal. If it's not, then we have a bug somewhere.
|
|
|
|
assert(pm_static_literal_p(node));
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(node)) {
|
|
|
|
case PM_ARRAY_NODE: {
|
|
|
|
pm_array_node_t *cast = (pm_array_node_t *) node;
|
|
|
|
pm_node_list_t *elements = &cast->elements;
|
|
|
|
|
|
|
|
VALUE value = rb_ary_hidden_new(elements->size);
|
|
|
|
for (size_t index = 0; index < elements->size; index++) {
|
2023-10-19 23:50:21 +03:00
|
|
|
rb_ary_push(value, pm_static_literal_value(elements->nodes[index], scope_node, parser));
|
2023-09-28 22:19:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
OBJ_FREEZE(value);
|
|
|
|
return value;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_FALSE_NODE:
|
2023-09-18 16:29:52 +03:00
|
|
|
return Qfalse;
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_FLOAT_NODE:
|
2023-09-18 16:29:52 +03:00
|
|
|
return parse_float(node);
|
2023-09-28 22:19:56 +03:00
|
|
|
case PM_HASH_NODE: {
|
|
|
|
pm_hash_node_t *cast = (pm_hash_node_t *) node;
|
|
|
|
pm_node_list_t *elements = &cast->elements;
|
|
|
|
|
|
|
|
VALUE array = rb_ary_hidden_new(elements->size * 2);
|
|
|
|
for (size_t index = 0; index < elements->size; index++) {
|
|
|
|
assert(PM_NODE_TYPE_P(elements->nodes[index], PM_ASSOC_NODE));
|
|
|
|
pm_assoc_node_t *cast = (pm_assoc_node_t *) elements->nodes[index];
|
2023-10-19 23:50:21 +03:00
|
|
|
VALUE pair[2] = { pm_static_literal_value(cast->key, scope_node, parser), pm_static_literal_value(cast->value, scope_node, parser) };
|
2023-09-28 22:19:56 +03:00
|
|
|
rb_ary_cat(array, pair, 2);
|
|
|
|
}
|
|
|
|
|
|
|
|
VALUE value = rb_hash_new_with_size(elements->size);
|
|
|
|
rb_hash_bulk_insert(RARRAY_LEN(array), RARRAY_CONST_PTR(array), value);
|
|
|
|
|
|
|
|
value = rb_obj_hide(value);
|
|
|
|
OBJ_FREEZE(value);
|
|
|
|
return value;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_IMAGINARY_NODE:
|
2023-09-28 22:19:56 +03:00
|
|
|
return parse_imaginary((pm_imaginary_node_t *) node);
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTEGER_NODE:
|
|
|
|
return parse_integer((pm_integer_node_t *) node);
|
|
|
|
case PM_NIL_NODE:
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return Qnil;
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_RATIONAL_NODE:
|
2023-09-18 16:29:52 +03:00
|
|
|
return parse_rational(node);
|
2023-09-28 22:19:56 +03:00
|
|
|
case PM_REGULAR_EXPRESSION_NODE: {
|
|
|
|
pm_regular_expression_node_t *cast = (pm_regular_expression_node_t *) node;
|
|
|
|
|
2023-10-24 20:17:18 +03:00
|
|
|
return pm_new_regex(cast, parser);
|
2023-09-28 22:19:56 +03:00
|
|
|
}
|
|
|
|
case PM_SOURCE_ENCODING_NODE: {
|
2024-01-02 19:34:04 +03:00
|
|
|
const char *name = scope_node->parser->encoding->name;
|
|
|
|
rb_encoding *encoding = rb_find_encoding(rb_str_new_cstr(name));
|
|
|
|
if (!encoding) rb_bug("Encoding not found %s!", name);
|
2023-09-28 22:19:56 +03:00
|
|
|
return rb_enc_from_encoding(encoding);
|
|
|
|
}
|
|
|
|
case PM_SOURCE_FILE_NODE: {
|
|
|
|
pm_source_file_node_t *cast = (pm_source_file_node_t *)node;
|
2023-10-19 23:50:21 +03:00
|
|
|
return cast->filepath.length ? parse_string(&cast->filepath, parser) : rb_fstring_lit("<compiled>");
|
2023-09-28 22:19:56 +03:00
|
|
|
}
|
2023-10-23 18:29:48 +03:00
|
|
|
case PM_SOURCE_LINE_NODE: {
|
|
|
|
int source_line = (int) pm_newline_list_line_column(&scope_node->parser->newline_list, node->location.start).line;
|
|
|
|
// TODO: Incorporate options which allow for passing a line number
|
|
|
|
return INT2FIX(source_line);
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_STRING_NODE:
|
2023-10-19 23:50:21 +03:00
|
|
|
return parse_string(&((pm_string_node_t *) node)->unescaped, parser);
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SYMBOL_NODE:
|
2024-01-26 23:18:21 +03:00
|
|
|
return ID2SYM(parse_string_symbol((pm_symbol_node_t *)node, parser));
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_TRUE_NODE:
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return Qtrue;
|
|
|
|
default:
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Don't have a literal value for node type %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
2023-09-07 17:59:51 +03:00
|
|
|
return Qfalse;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-13 19:34:05 +03:00
|
|
|
/**
|
|
|
|
* Currently, the ADD_INSN family of macros expects a NODE as the second
|
|
|
|
* parameter. It uses this node to determine the line number and the node ID for
|
|
|
|
* the instruction.
|
|
|
|
*
|
|
|
|
* Because prism does not use the NODE struct (or have node IDs for that matter)
|
|
|
|
* we need to generate a dummy node to pass to these macros. We also need to use
|
|
|
|
* the line number from the node to generate labels.
|
|
|
|
*
|
|
|
|
* We use this struct to store the dummy node and the line number together so
|
|
|
|
* that we can use it while we're compiling code.
|
|
|
|
*
|
|
|
|
* In the future, we'll need to eventually remove this dependency and figure out
|
|
|
|
* a more permanent solution. For the line numbers, this shouldn't be too much
|
|
|
|
* of a problem, we can redefine the ADD_INSN family of macros. For the node ID,
|
|
|
|
* we can probably replace it directly with the column information since we have
|
|
|
|
* that at the time that we're generating instructions. In theory this could
|
|
|
|
* make node ID unnecessary.
|
|
|
|
*/
|
|
|
|
typedef struct {
|
|
|
|
NODE node;
|
|
|
|
int lineno;
|
|
|
|
} pm_line_node_t;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* The function generates a dummy node and stores the line number after it looks
|
|
|
|
* it up for the given scope and node. (The scope in this case is just used
|
|
|
|
* because it holds a reference to the parser, which holds a reference to the
|
|
|
|
* newline list that we need to look up the line numbers.)
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
pm_line_node(pm_line_node_t *line_node, const pm_scope_node_t *scope_node, const pm_node_t *node)
|
|
|
|
{
|
|
|
|
// First, clear out the pointer.
|
|
|
|
memset(line_node, 0, sizeof(pm_line_node_t));
|
|
|
|
|
|
|
|
// Next, retrieve the line and column information from prism.
|
|
|
|
pm_line_column_t line_column = pm_newline_list_line_column(&scope_node->parser->newline_list, node->location.start);
|
|
|
|
|
|
|
|
// Next, use the line number for the dummy node.
|
|
|
|
int lineno = (int) line_column.line;
|
|
|
|
|
|
|
|
nd_set_line(&line_node->node, lineno);
|
|
|
|
nd_set_node_id(&line_node->node, lineno);
|
|
|
|
line_node->lineno = lineno;
|
|
|
|
}
|
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
static void
|
2023-10-23 20:49:39 +03:00
|
|
|
pm_compile_branch_condition(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const pm_node_t *cond,
|
2023-10-17 01:36:25 +03:00
|
|
|
LABEL *then_label, LABEL *else_label, const uint8_t *src, bool popped, pm_scope_node_t *scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
static void
|
2023-10-23 20:49:39 +03:00
|
|
|
pm_compile_logical(rb_iseq_t *iseq, LINK_ANCHOR *const ret, pm_node_t *cond,
|
2023-10-17 01:36:25 +03:00
|
|
|
LABEL *then_label, LABEL *else_label, const uint8_t *src, bool popped, pm_scope_node_t *scope_node)
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
{
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_parser_t *parser = scope_node->parser;
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_newline_list_t newline_list = parser->newline_list;
|
|
|
|
int lineno = (int)pm_newline_list_line_column(&newline_list, cond->location.start).line;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
DECL_ANCHOR(seq);
|
|
|
|
INIT_ANCHOR(seq);
|
|
|
|
LABEL *label = NEW_LABEL(lineno);
|
|
|
|
if (!then_label) then_label = label;
|
|
|
|
else if (!else_label) else_label = label;
|
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_branch_condition(iseq, seq, cond, then_label, else_label, src, popped, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
if (LIST_INSN_SIZE_ONE(seq)) {
|
|
|
|
INSN *insn = (INSN *)ELEM_FIRST_INSN(FIRST_ELEMENT(seq));
|
|
|
|
if (insn->insn_id == BIN(jump) && (LABEL *)(insn->operands[0]) == label)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (!label->refcnt) {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_LABEL(seq, label);
|
|
|
|
}
|
|
|
|
ADD_SEQ(ret, seq);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-10-23 20:49:39 +03:00
|
|
|
static void pm_compile_node(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-10-20 18:03:02 +03:00
|
|
|
static void
|
|
|
|
pm_compile_flip_flop(pm_flip_flop_node_t *flip_flop_node, LABEL *else_label, LABEL *then_label, rb_iseq_t *iseq, const int lineno, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node)
|
|
|
|
{
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(ISEQ_BODY(iseq)->location.first_lineno, -1);
|
|
|
|
LABEL *lend = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
int again = !(flip_flop_node->base.flags & PM_RANGE_FLAGS_EXCLUDE_END);
|
|
|
|
|
|
|
|
rb_num_t count = ISEQ_FLIP_CNT_INCREMENT(ISEQ_BODY(iseq)->local_iseq) + VM_SVAR_FLIPFLOP_START;
|
|
|
|
VALUE key = INT2FIX(count);
|
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getspecial, key, INT2FIX(0));
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, lend);
|
|
|
|
|
|
|
|
if (flip_flop_node->left) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(flip_flop_node->left);
|
2023-10-20 18:03:02 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-10-24 23:08:50 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-20 18:03:02 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, else_label);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setspecial, key);
|
|
|
|
if (!again) {
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, then_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, lend);
|
|
|
|
if (flip_flop_node->right) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(flip_flop_node->right);
|
2023-10-20 18:03:02 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-10-24 23:08:50 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-20 18:03:02 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, then_label);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qfalse);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setspecial, key);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, then_label);
|
|
|
|
}
|
|
|
|
|
2023-10-27 00:54:38 +03:00
|
|
|
void pm_compile_defined_expr(rb_iseq_t *iseq, const pm_node_t *defined_node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, NODE dummy_line_node, int lineno, bool in_condition);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
static void
|
2023-10-23 20:49:39 +03:00
|
|
|
pm_compile_branch_condition(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const pm_node_t *cond,
|
2023-10-17 01:36:25 +03:00
|
|
|
LABEL *then_label, LABEL *else_label, const uint8_t *src, bool popped, pm_scope_node_t *scope_node)
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
{
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_parser_t *parser = scope_node->parser;
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_newline_list_t newline_list = parser->newline_list;
|
|
|
|
int lineno = (int) pm_newline_list_line_column(&newline_list, cond->location.start).line;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
again:
|
2023-09-27 19:39:53 +03:00
|
|
|
switch (PM_NODE_TYPE(cond)) {
|
|
|
|
case PM_AND_NODE: {
|
|
|
|
pm_and_node_t *and_node = (pm_and_node_t *)cond;
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_logical(iseq, ret, and_node->left, NULL, else_label, src, popped, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
cond = and_node->right;
|
|
|
|
goto again;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_OR_NODE: {
|
|
|
|
pm_or_node_t *or_node = (pm_or_node_t *)cond;
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_logical(iseq, ret, or_node->left, then_label, NULL, src, popped, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
cond = or_node->right;
|
|
|
|
goto again;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_FALSE_NODE:
|
|
|
|
case PM_NIL_NODE:
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, else_label);
|
|
|
|
return;
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_FLOAT_NODE:
|
|
|
|
case PM_IMAGINARY_NODE:
|
|
|
|
case PM_INTEGER_NODE:
|
|
|
|
case PM_LAMBDA_NODE:
|
|
|
|
case PM_RATIONAL_NODE:
|
|
|
|
case PM_REGULAR_EXPRESSION_NODE:
|
|
|
|
case PM_STRING_NODE:
|
|
|
|
case PM_SYMBOL_NODE:
|
|
|
|
case PM_TRUE_NODE:
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, then_label);
|
|
|
|
return;
|
2023-10-20 18:03:02 +03:00
|
|
|
case PM_FLIP_FLOP_NODE:
|
|
|
|
pm_compile_flip_flop((pm_flip_flop_node_t *)cond, else_label, then_label, iseq, lineno, ret, src, popped, scope_node);
|
|
|
|
return;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
// TODO: Several more nodes in this case statement
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_DEFINED_NODE: {
|
|
|
|
pm_defined_node_t *defined_node = (pm_defined_node_t *)cond;
|
2023-10-27 00:54:38 +03:00
|
|
|
pm_compile_defined_expr(iseq, defined_node->value, ret, src, popped, scope_node, dummy_line_node, lineno, true);
|
2023-10-25 11:07:26 +03:00
|
|
|
break;
|
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
default: {
|
|
|
|
DECL_ANCHOR(cond_seq);
|
|
|
|
INIT_ANCHOR(cond_seq);
|
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_node(iseq, cond, cond_seq, src, false, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_SEQ(ret, cond_seq);
|
|
|
|
break;
|
2023-09-28 16:47:46 +03:00
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, else_label);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, then_label);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2023-10-23 20:49:39 +03:00
|
|
|
pm_compile_if(rb_iseq_t *iseq, const int line, pm_statements_node_t *node_body, pm_node_t *node_else, pm_node_t *predicate, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node)
|
2023-09-27 19:39:53 +03:00
|
|
|
{
|
2023-09-21 22:28:08 +03:00
|
|
|
NODE dummy_line_node = generate_dummy_line_node(line, line);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
DECL_ANCHOR(cond_seq);
|
|
|
|
|
|
|
|
LABEL *then_label, *else_label, *end_label;
|
|
|
|
|
|
|
|
INIT_ANCHOR(cond_seq);
|
|
|
|
then_label = NEW_LABEL(line);
|
|
|
|
else_label = NEW_LABEL(line);
|
|
|
|
end_label = 0;
|
|
|
|
|
2023-10-20 18:03:02 +03:00
|
|
|
pm_compile_branch_condition(iseq, cond_seq, predicate, then_label, else_label, src, false, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_SEQ(ret, cond_seq);
|
|
|
|
|
|
|
|
if (then_label->refcnt) {
|
|
|
|
ADD_LABEL(ret, then_label);
|
|
|
|
|
|
|
|
DECL_ANCHOR(then_seq);
|
|
|
|
INIT_ANCHOR(then_seq);
|
|
|
|
if (node_body) {
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_node(iseq, (pm_node_t *)node_body, then_seq, src, popped, scope_node);
|
2023-09-28 17:18:43 +03:00
|
|
|
} else {
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (else_label->refcnt) {
|
|
|
|
end_label = NEW_LABEL(line);
|
2023-09-21 22:28:08 +03:00
|
|
|
ADD_INSNL(then_seq, &dummy_line_node, jump, end_label);
|
2023-10-20 18:03:02 +03:00
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN(then_seq, &dummy_line_node, pop);
|
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
ADD_SEQ(ret, then_seq);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (else_label->refcnt) {
|
|
|
|
ADD_LABEL(ret, else_label);
|
|
|
|
|
|
|
|
DECL_ANCHOR(else_seq);
|
|
|
|
INIT_ANCHOR(else_seq);
|
|
|
|
if (node_else) {
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_node(iseq, (pm_node_t *)node_else, else_seq, src, popped, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_SEQ(ret, else_seq);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (end_label) {
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-08-30 00:17:08 +03:00
|
|
|
static void
|
2023-10-23 20:49:39 +03:00
|
|
|
pm_compile_while(rb_iseq_t *iseq, int lineno, pm_node_flags_t flags, enum pm_node_type type, pm_statements_node_t *statements, pm_node_t *predicate, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node)
|
2023-08-30 00:17:08 +03:00
|
|
|
{
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
LABEL *prev_start_label = ISEQ_COMPILE_DATA(iseq)->start_label;
|
|
|
|
LABEL *prev_end_label = ISEQ_COMPILE_DATA(iseq)->end_label;
|
|
|
|
LABEL *prev_redo_label = ISEQ_COMPILE_DATA(iseq)->redo_label;
|
|
|
|
|
|
|
|
// TODO: Deal with ensures in here
|
2023-08-31 00:27:08 +03:00
|
|
|
LABEL *next_label = ISEQ_COMPILE_DATA(iseq)->start_label = NEW_LABEL(lineno); /* next */
|
|
|
|
LABEL *redo_label = ISEQ_COMPILE_DATA(iseq)->redo_label = NEW_LABEL(lineno); /* redo */
|
|
|
|
LABEL *break_label = ISEQ_COMPILE_DATA(iseq)->end_label = NEW_LABEL(lineno); /* break */
|
2023-08-30 00:17:08 +03:00
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *adjust_label = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
LABEL *next_catch_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *tmp_label = NULL;
|
|
|
|
|
|
|
|
// begin; end while true
|
2023-09-27 19:39:53 +03:00
|
|
|
if (flags & PM_LOOP_FLAGS_BEGIN_MODIFIER) {
|
2023-08-31 00:27:08 +03:00
|
|
|
tmp_label = NEW_LABEL(lineno);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, tmp_label);
|
2023-08-30 00:17:08 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
// while true; end
|
2023-08-31 00:27:08 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, next_label);
|
2023-08-30 00:17:08 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, adjust_label);
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-08-30 00:17:08 +03:00
|
|
|
ADD_LABEL(ret, next_catch_label);
|
2023-10-24 23:08:50 +03:00
|
|
|
PM_POP;
|
2023-08-30 00:17:08 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, next_label);
|
|
|
|
if (tmp_label) ADD_LABEL(ret, tmp_label);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, redo_label);
|
|
|
|
if (statements) {
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_POPPED((pm_node_t *)statements);
|
2023-08-30 00:17:08 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, next_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
if (type == PM_WHILE_NODE) {
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_branch_condition(iseq, ret, predicate, redo_label, end_label, src, popped, scope_node);
|
2023-09-27 19:39:53 +03:00
|
|
|
} else if (type == PM_UNTIL_NODE) {
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_branch_condition(iseq, ret, predicate, end_label, redo_label, src, popped, scope_node);
|
2023-08-30 00:17:08 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
ADD_ADJUST_RESTORE(ret, adjust_label);
|
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-08-30 00:17:08 +03:00
|
|
|
|
|
|
|
ADD_LABEL(ret, break_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-08-30 00:17:08 +03:00
|
|
|
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_BREAK, redo_label, break_label, NULL,
|
|
|
|
break_label);
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_NEXT, redo_label, break_label, NULL,
|
|
|
|
next_catch_label);
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_REDO, redo_label, break_label, NULL,
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->redo_label);
|
|
|
|
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->start_label = prev_start_label;
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->end_label = prev_end_label;
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->redo_label = prev_redo_label;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-12-16 00:28:29 +03:00
|
|
|
static int
|
2023-11-14 03:03:24 +03:00
|
|
|
pm_interpolated_node_compile(pm_node_list_t *parts, rb_iseq_t *iseq, NODE dummy_line_node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, pm_parser_t *parser)
|
2023-09-08 17:40:07 +03:00
|
|
|
{
|
2023-12-16 00:28:29 +03:00
|
|
|
int number_of_items_pushed = 0;
|
2023-11-14 03:03:24 +03:00
|
|
|
size_t parts_size = parts->size;
|
2023-09-08 17:40:07 +03:00
|
|
|
|
|
|
|
if (parts_size > 0) {
|
2023-12-16 00:28:29 +03:00
|
|
|
VALUE current_string = Qnil;
|
2023-09-08 17:40:07 +03:00
|
|
|
for (size_t index = 0; index < parts_size; index++) {
|
2023-11-14 03:03:24 +03:00
|
|
|
pm_node_t *part = parts->nodes[index];
|
2023-09-08 17:40:07 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
if (PM_NODE_TYPE_P(part, PM_STRING_NODE)) {
|
2023-12-16 00:28:29 +03:00
|
|
|
pm_string_node_t *string_node = (pm_string_node_t *)part;
|
2024-01-29 17:11:34 +03:00
|
|
|
VALUE string_value = parse_string_encoded((pm_node_t *)string_node, &string_node->unescaped, parser);
|
2023-12-16 00:28:29 +03:00
|
|
|
if (RTEST(current_string)) {
|
|
|
|
current_string = rb_str_concat(current_string, string_value);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
current_string = string_value;
|
|
|
|
}
|
2023-09-08 17:40:07 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-12-16 00:28:29 +03:00
|
|
|
if (RTEST(current_string)) {
|
|
|
|
if (parser->frozen_string_literal) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_freeze(current_string));
|
|
|
|
}
|
|
|
|
else {
|
2024-01-09 00:32:35 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putstring, rb_str_freeze(current_string));
|
2023-12-16 00:28:29 +03:00
|
|
|
}
|
|
|
|
current_string = Qnil;
|
|
|
|
number_of_items_pushed++;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(part);
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-09-08 17:40:07 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, objtostring, new_callinfo(iseq, idTo_s, 0, VM_CALL_FCALL | VM_CALL_ARGS_SIMPLE , NULL, FALSE));
|
|
|
|
ADD_INSN(ret, &dummy_line_node, anytostring);
|
2023-12-16 00:28:29 +03:00
|
|
|
|
|
|
|
number_of_items_pushed++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (RTEST(current_string)) {
|
|
|
|
if (parser->frozen_string_literal) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_freeze(current_string));
|
|
|
|
}
|
|
|
|
else {
|
2024-01-09 00:32:35 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putstring, rb_str_freeze(current_string));
|
2023-09-08 17:40:07 +03:00
|
|
|
}
|
2023-12-16 00:28:29 +03:00
|
|
|
current_string = Qnil;
|
|
|
|
number_of_items_pushed++;
|
2023-09-08 17:40:07 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-08 17:40:07 +03:00
|
|
|
}
|
2023-12-16 00:28:29 +03:00
|
|
|
return number_of_items_pushed;
|
2023-09-08 17:40:07 +03:00
|
|
|
}
|
2023-11-08 20:49:58 +03:00
|
|
|
|
2023-11-29 22:12:31 +03:00
|
|
|
// This recurses through scopes and finds the local index at any scope level
|
|
|
|
// It also takes a pointer to depth, and increments depth appropriately
|
|
|
|
// according to the depth of the local
|
2024-01-16 00:32:17 +03:00
|
|
|
static pm_local_index_t
|
2024-01-24 18:39:40 +03:00
|
|
|
pm_lookup_local_index(rb_iseq_t *iseq, const pm_scope_node_t *scope_node, pm_constant_id_t constant_id, int start_depth)
|
2023-11-20 23:40:35 +03:00
|
|
|
{
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t lindex = { 0 };
|
2023-11-20 23:40:35 +03:00
|
|
|
st_data_t local_index;
|
|
|
|
|
2024-01-23 23:33:45 +03:00
|
|
|
int level;
|
|
|
|
for (level = 0; level < start_depth; level++) {
|
|
|
|
scope_node = scope_node->previous;
|
|
|
|
}
|
|
|
|
|
|
|
|
while (!st_lookup(scope_node->index_lookup_table, constant_id, &local_index)) {
|
2024-01-16 00:42:16 +03:00
|
|
|
level++;
|
2024-01-16 19:06:18 +03:00
|
|
|
if (scope_node->previous) {
|
|
|
|
scope_node = scope_node->previous;
|
|
|
|
} else {
|
|
|
|
// We have recursed up all scope nodes
|
|
|
|
// and have not found the local yet
|
2024-01-23 23:33:45 +03:00
|
|
|
rb_bug("Local with constant_id %u does not exist", (unsigned int) constant_id);
|
2024-01-16 19:06:18 +03:00
|
|
|
}
|
2023-11-20 23:40:35 +03:00
|
|
|
}
|
|
|
|
|
2024-01-16 00:32:17 +03:00
|
|
|
lindex.level = level;
|
2024-01-23 23:33:45 +03:00
|
|
|
lindex.index = scope_node->local_table_for_iseq_size - (int) local_index;
|
2024-01-16 00:32:17 +03:00
|
|
|
return lindex;
|
2023-11-20 23:40:35 +03:00
|
|
|
}
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
// This returns the CRuby ID which maps to the pm_constant_id_t
|
2023-09-06 17:28:29 +03:00
|
|
|
//
|
2023-09-27 19:39:53 +03:00
|
|
|
// Constant_ids in prism are indexes of the constants in prism's constant pool.
|
2023-10-17 01:36:25 +03:00
|
|
|
// We add a constants mapping on the scope_node which is a mapping from
|
2023-09-06 17:28:29 +03:00
|
|
|
// these constant_id indexes to the CRuby IDs that they represent.
|
|
|
|
// This helper method allows easy access to those IDs
|
|
|
|
static ID
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_constant_id_lookup(pm_scope_node_t *scope_node, pm_constant_id_t constant_id)
|
2023-09-06 17:28:29 +03:00
|
|
|
{
|
2023-11-09 10:39:49 +03:00
|
|
|
if (constant_id < 1 || constant_id > scope_node->parser->constant_pool.size) {
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("constant_id out of range: %u", (unsigned int)constant_id);
|
2023-11-09 10:39:49 +03:00
|
|
|
}
|
2023-11-09 10:29:49 +03:00
|
|
|
return scope_node->constants[constant_id - 1];
|
2023-09-06 17:28:29 +03:00
|
|
|
}
|
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
static rb_iseq_t *
|
2024-01-18 19:38:53 +03:00
|
|
|
pm_new_child_iseq(rb_iseq_t *iseq, pm_scope_node_t *node, pm_parser_t *parser,
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
VALUE name, const rb_iseq_t *parent, enum rb_iseq_type type, int line_no)
|
|
|
|
{
|
|
|
|
debugs("[new_child_iseq]> ---------------------------------------\n");
|
|
|
|
int isolated_depth = ISEQ_COMPILE_DATA(iseq)->isolated_depth;
|
2024-01-18 19:38:53 +03:00
|
|
|
rb_iseq_t *ret_iseq = pm_iseq_new_with_opt(node, parser, name,
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
rb_iseq_path(iseq), rb_iseq_realpath(iseq),
|
|
|
|
line_no, parent,
|
|
|
|
isolated_depth ? isolated_depth + 1 : 0,
|
|
|
|
type, ISEQ_COMPILE_DATA(iseq)->option);
|
|
|
|
debugs("[new_child_iseq]< ---------------------------------------\n");
|
|
|
|
return ret_iseq;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2023-10-23 20:49:39 +03:00
|
|
|
pm_compile_class_path(LINK_ANCHOR *const ret, rb_iseq_t *iseq, const pm_node_t *constant_path_node, const NODE *line_node, const uint8_t * src, bool popped, pm_scope_node_t *scope_node)
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
{
|
2023-09-27 19:39:53 +03:00
|
|
|
if (PM_NODE_TYPE_P(constant_path_node, PM_CONSTANT_PATH_NODE)) {
|
|
|
|
pm_node_t *parent = ((pm_constant_path_node_t *)constant_path_node)->parent;
|
2023-08-31 00:26:22 +03:00
|
|
|
if (parent) {
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
/* Bar::Foo */
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(parent);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return VM_DEFINECLASS_FLAG_SCOPED;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
/* toplevel class ::Foo */
|
|
|
|
ADD_INSN1(ret, line_node, putobject, rb_cObject);
|
|
|
|
return VM_DEFINECLASS_FLAG_SCOPED;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
/* class at cbase Foo */
|
|
|
|
ADD_INSN1(ret, line_node, putspecialobject,
|
|
|
|
INT2FIX(VM_SPECIAL_OBJECT_CONST_BASE));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-10-25 18:34:03 +03:00
|
|
|
static void
|
2023-12-15 00:44:38 +03:00
|
|
|
pm_compile_call_and_or_write_node(bool and_node, pm_node_t *receiver, pm_node_t *value, pm_constant_id_t write_name, pm_constant_id_t read_name, bool safe_nav, LINK_ANCHOR *const ret, rb_iseq_t *iseq, int lineno, const uint8_t * src, bool popped, pm_scope_node_t *scope_node)
|
2023-10-25 18:34:03 +03:00
|
|
|
{
|
|
|
|
LABEL *call_end_label = NEW_LABEL(lineno);
|
2023-12-15 00:44:38 +03:00
|
|
|
LABEL *else_label = NEW_LABEL(lineno);
|
2023-10-25 18:34:03 +03:00
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
int flag = 0;
|
|
|
|
|
|
|
|
if (PM_NODE_TYPE_P(receiver, PM_SELF_NODE)) {
|
|
|
|
flag = VM_CALL_FCALL;
|
|
|
|
}
|
|
|
|
|
2023-11-02 21:07:00 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(receiver);
|
2023-10-25 18:34:03 +03:00
|
|
|
|
2023-12-15 00:44:38 +03:00
|
|
|
if (safe_nav) {
|
|
|
|
PM_DUP;
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchnil, else_label);
|
|
|
|
}
|
|
|
|
|
2023-10-25 18:34:03 +03:00
|
|
|
ID write_name_id = pm_constant_id_lookup(scope_node, write_name);
|
|
|
|
ID read_name_id = pm_constant_id_lookup(scope_node, read_name);
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-10-25 18:34:03 +03:00
|
|
|
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, read_name_id, INT2FIX(0), INT2FIX(flag));
|
|
|
|
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
|
|
|
|
|
|
|
if (and_node) {
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, call_end_label);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
// or_node
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, call_end_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
PM_POP_UNLESS_POPPED;
|
|
|
|
|
2023-11-02 21:07:00 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(value);
|
2023-10-25 18:34:03 +03:00
|
|
|
if (!popped) {
|
|
|
|
PM_SWAP;
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(1));
|
|
|
|
}
|
|
|
|
ID aid = rb_id_attrset(write_name_id);
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, aid, INT2FIX(1), INT2FIX(flag));
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, end_label);
|
|
|
|
ADD_LABEL(ret, call_end_label);
|
|
|
|
|
|
|
|
if (!popped) {
|
|
|
|
PM_SWAP;
|
|
|
|
}
|
|
|
|
|
2023-12-15 00:44:38 +03:00
|
|
|
if (safe_nav) {
|
|
|
|
ADD_LABEL(ret, else_label);
|
|
|
|
}
|
|
|
|
|
2023-10-25 18:34:03 +03:00
|
|
|
ADD_LABEL(ret, end_label);
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_POP;
|
2023-10-25 18:34:03 +03:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-11-27 23:55:15 +03:00
|
|
|
static void
|
2024-01-22 18:46:12 +03:00
|
|
|
pm_compile_index_write_nodes_add_send(bool popped, LINK_ANCHOR *const ret, rb_iseq_t *iseq, NODE dummy_line_node, VALUE argc, int flag, int block_offset, struct rb_callinfo_kwarg *keywords)
|
2023-11-27 23:55:15 +03:00
|
|
|
{
|
|
|
|
if (!popped) {
|
2024-01-22 18:46:12 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, setn, FIXNUM_INC(argc, 2 + block_offset + (keywords ? keywords->keyword_len : 0)));
|
2023-11-27 23:55:15 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (flag & VM_CALL_ARGS_SPLAT) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(1));
|
|
|
|
if (block_offset > 0) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, dupn, INT2FIX(3));
|
|
|
|
PM_SWAP;
|
|
|
|
PM_POP;
|
|
|
|
}
|
|
|
|
ADD_INSN(ret, &dummy_line_node, concatarray);
|
|
|
|
if (block_offset > 0) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setn, INT2FIX(3));
|
|
|
|
PM_POP;
|
|
|
|
}
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, idASET, argc, INT2FIX(flag));
|
|
|
|
}
|
2024-01-22 19:43:00 +03:00
|
|
|
else if (flag & VM_CALL_KW_SPLAT) {
|
|
|
|
if (block_offset > 0) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(2));
|
|
|
|
PM_SWAP;
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setn, INT2FIX(3));
|
|
|
|
PM_POP;
|
|
|
|
}
|
|
|
|
|
2024-01-22 23:21:09 +03:00
|
|
|
PM_SWAP;
|
2024-01-22 19:43:00 +03:00
|
|
|
ADD_SEND_R(ret, &dummy_line_node, idASET, FIXNUM_INC(argc, 1), NULL, INT2FIX(flag), keywords);
|
|
|
|
}
|
2024-01-22 18:46:12 +03:00
|
|
|
else if (keywords && keywords->keyword_len) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, opt_reverse, INT2FIX(keywords->keyword_len + block_offset + 1));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, opt_reverse, INT2FIX(keywords->keyword_len + block_offset + 0));
|
|
|
|
ADD_SEND_R(ret, &dummy_line_node, idASET, FIXNUM_INC(argc, 1), NULL, INT2FIX(flag), keywords);
|
|
|
|
}
|
2023-11-27 23:55:15 +03:00
|
|
|
else {
|
|
|
|
if (block_offset > 0) {
|
|
|
|
PM_SWAP;
|
|
|
|
}
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, idASET, FIXNUM_INC(argc, 1), INT2FIX(flag));
|
|
|
|
}
|
|
|
|
|
|
|
|
PM_POP;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2024-01-17 23:29:37 +03:00
|
|
|
static void
|
|
|
|
pm_arg_compile_keyword_hash_node(pm_keyword_hash_node_t *node, rb_iseq_t *iseq, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, NODE dummy_line_node)
|
|
|
|
{
|
|
|
|
size_t len = node->elements.size;
|
|
|
|
int cur_hash_size = 0;
|
|
|
|
|
|
|
|
bool new_hash_emitted = false;
|
|
|
|
for (size_t i = 0; i < len; i++) {
|
|
|
|
pm_node_t *cur_node = node->elements.nodes[i];
|
|
|
|
pm_node_type_t cur_type = PM_NODE_TYPE(cur_node);
|
|
|
|
|
|
|
|
switch (cur_type) {
|
|
|
|
case PM_ASSOC_NODE: {
|
|
|
|
pm_assoc_node_t *assoc = (pm_assoc_node_t *)cur_node;
|
|
|
|
|
|
|
|
PM_COMPILE(assoc->key);
|
|
|
|
PM_COMPILE(assoc->value);
|
|
|
|
cur_hash_size++;
|
|
|
|
|
|
|
|
// If we're at the last keyword arg, or the last assoc node of this "set",
|
|
|
|
// then we want to either construct a newhash or merge onto previous hashes
|
|
|
|
if (i == (len - 1) || !PM_NODE_TYPE_P(node->elements.nodes[i + 1], cur_type)) {
|
|
|
|
if (new_hash_emitted) {
|
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_hash_merge_ptr, INT2FIX(cur_hash_size * 2 + 1));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newhash, INT2FIX(cur_hash_size * 2));
|
|
|
|
cur_hash_size = 0;
|
|
|
|
new_hash_emitted = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_ASSOC_SPLAT_NODE: {
|
|
|
|
if (len > 1) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
if (i == 0) {
|
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newhash, INT2FIX(0));
|
|
|
|
new_hash_emitted = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_SWAP;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pm_assoc_splat_node_t *assoc_splat = (pm_assoc_splat_node_t *)cur_node;
|
2024-01-24 18:22:46 +03:00
|
|
|
if (assoc_splat->value != NULL) {
|
|
|
|
PM_COMPILE(assoc_splat->value);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, PM_CONSTANT_POW, 0);
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
|
|
|
}
|
2024-01-17 23:29:37 +03:00
|
|
|
|
|
|
|
if (len > 1) {
|
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_hash_merge_kwd, INT2FIX(2));
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((i < len - 1) && !PM_NODE_TYPE_P(node->elements.nodes[i + 1], cur_type)) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
PM_SWAP;
|
|
|
|
}
|
|
|
|
|
|
|
|
cur_hash_size = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default: {
|
|
|
|
rb_bug("Unknown type in keyword argument %s\n", pm_node_type_to_str(PM_NODE_TYPE(cur_node)));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-11-27 19:12:24 +03:00
|
|
|
static int
|
|
|
|
pm_setup_args(pm_arguments_node_t *arguments_node, int *flags, struct rb_callinfo_kwarg **kw_arg, rb_iseq_t *iseq, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, NODE dummy_line_node, pm_parser_t *parser)
|
|
|
|
{
|
|
|
|
int orig_argc = 0;
|
[Prism] Fix more method call argumnents
In #2087 it was noted that there was a bug in the number of arguments in
`SplatNode` and `KeywordHashNode`. I looked into this with Aaron before
the linked PR was merged and we found a bunch of cases that weren't
working quite right. This PR aims to fix some of those cases, but there
may be more.
A splat argument followed by a positional argument will concat the array
until the end or unless the argument is a kwarg or splat kwarg. For
example
```
foo(a, *b, c, *d, e)
```
Will have an `argc` of 2, because `b`, `c`, `d`, and `e` will be
concatenated together.
```
foo(a, *b, c, *d, **e)
```
Will have an `argc` of 3, because `b`, `c`, and `d` will be concatenated
together and `e` is a separate argument.
2024-01-03 22:23:44 +03:00
|
|
|
bool has_splat = false;
|
|
|
|
bool has_keyword_splat = false;
|
|
|
|
|
2023-11-27 19:12:24 +03:00
|
|
|
if (arguments_node == NULL) {
|
|
|
|
if (*flags & VM_CALL_FCALL) {
|
|
|
|
*flags |= VM_CALL_VCALL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_node_list_t arguments_node_list = arguments_node->arguments;
|
|
|
|
|
[Prism] Fix more method call argumnents
In #2087 it was noted that there was a bug in the number of arguments in
`SplatNode` and `KeywordHashNode`. I looked into this with Aaron before
the linked PR was merged and we found a bunch of cases that weren't
working quite right. This PR aims to fix some of those cases, but there
may be more.
A splat argument followed by a positional argument will concat the array
until the end or unless the argument is a kwarg or splat kwarg. For
example
```
foo(a, *b, c, *d, e)
```
Will have an `argc` of 2, because `b`, `c`, `d`, and `e` will be
concatenated together.
```
foo(a, *b, c, *d, **e)
```
Will have an `argc` of 3, because `b`, `c`, and `d` will be concatenated
together and `e` is a separate argument.
2024-01-03 22:23:44 +03:00
|
|
|
has_keyword_splat = (arguments_node->base.flags & PM_ARGUMENTS_NODE_FLAGS_CONTAINS_KEYWORD_SPLAT);
|
2023-11-27 19:12:24 +03:00
|
|
|
|
|
|
|
// We count the number of elements post the splat node that are not keyword elements to
|
|
|
|
// eventually pass as an argument to newarray
|
|
|
|
int post_splat_counter = 0;
|
|
|
|
|
|
|
|
for (size_t index = 0; index < arguments_node_list.size; index++) {
|
|
|
|
pm_node_t *argument = arguments_node_list.nodes[index];
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(argument)) {
|
2024-01-17 22:45:05 +03:00
|
|
|
// A keyword hash node contains all keyword arguments as AssocNodes and AssocSplatNodes
|
2023-11-27 19:12:24 +03:00
|
|
|
case PM_KEYWORD_HASH_NODE: {
|
2024-01-17 22:45:05 +03:00
|
|
|
pm_keyword_hash_node_t *keyword_arg = (pm_keyword_hash_node_t *)argument;
|
2023-11-27 19:12:24 +03:00
|
|
|
|
2024-01-17 22:45:05 +03:00
|
|
|
if (has_keyword_splat || has_splat) {
|
|
|
|
*flags |= VM_CALL_KW_SPLAT;
|
|
|
|
|
|
|
|
has_keyword_splat = true;
|
2023-11-27 19:12:24 +03:00
|
|
|
|
2024-01-17 23:29:37 +03:00
|
|
|
pm_arg_compile_keyword_hash_node(keyword_arg, iseq, ret, src, false, scope_node, dummy_line_node);
|
2024-01-17 22:45:05 +03:00
|
|
|
}
|
|
|
|
else {
|
2024-01-17 23:29:37 +03:00
|
|
|
size_t len = keyword_arg->elements.size;
|
|
|
|
|
2023-12-07 02:36:00 +03:00
|
|
|
// We need to first figure out if all elements of the KeywordHashNode are AssocNodes
|
2023-12-14 21:15:30 +03:00
|
|
|
// with symbol keys.
|
|
|
|
if (PM_NODE_FLAG_P(keyword_arg, PM_KEYWORD_HASH_NODE_FLAGS_SYMBOL_KEYS)) {
|
|
|
|
// If they are all symbol keys then we can pass them as keyword arguments.
|
2023-12-07 02:36:00 +03:00
|
|
|
*kw_arg = rb_xmalloc_mul_add(len, sizeof(VALUE), sizeof(struct rb_callinfo_kwarg));
|
2023-12-14 21:15:30 +03:00
|
|
|
*flags |= VM_CALL_KWARG;
|
2023-12-07 02:36:00 +03:00
|
|
|
VALUE *keywords = (*kw_arg)->keywords;
|
|
|
|
(*kw_arg)->references = 0;
|
|
|
|
(*kw_arg)->keyword_len = (int)len;
|
|
|
|
|
|
|
|
for (size_t i = 0; i < len; i++) {
|
|
|
|
pm_assoc_node_t *assoc = (pm_assoc_node_t *)keyword_arg->elements.nodes[i];
|
|
|
|
pm_node_t *key = assoc->key;
|
|
|
|
keywords[i] = pm_static_literal_value(key, scope_node, parser);
|
|
|
|
PM_COMPILE_NOT_POPPED(assoc->value);
|
|
|
|
}
|
|
|
|
} else {
|
2023-12-14 21:15:30 +03:00
|
|
|
// If they aren't all symbol keys then we need to construct a new hash
|
2023-12-07 02:36:00 +03:00
|
|
|
// and pass that as an argument.
|
|
|
|
orig_argc++;
|
2023-12-14 21:15:30 +03:00
|
|
|
*flags |= VM_CALL_KW_SPLAT;
|
|
|
|
if (len > 1) {
|
|
|
|
// A new hash will be created for the keyword arguments in this case,
|
|
|
|
// so mark the method as passing mutable keyword splat.
|
|
|
|
*flags |= VM_CALL_KW_SPLAT_MUT;
|
|
|
|
}
|
2023-12-07 02:36:00 +03:00
|
|
|
|
|
|
|
for (size_t i = 0; i < len; i++) {
|
|
|
|
pm_assoc_node_t *assoc = (pm_assoc_node_t *)keyword_arg->elements.nodes[i];
|
|
|
|
PM_COMPILE_NOT_POPPED(assoc->key);
|
|
|
|
PM_COMPILE_NOT_POPPED(assoc->value);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newhash, INT2FIX(len * 2));
|
|
|
|
}
|
2024-01-17 22:45:05 +03:00
|
|
|
}
|
|
|
|
break;
|
2023-11-27 19:12:24 +03:00
|
|
|
}
|
|
|
|
case PM_SPLAT_NODE: {
|
2024-01-17 22:45:05 +03:00
|
|
|
*flags |= VM_CALL_ARGS_SPLAT;
|
|
|
|
pm_splat_node_t *splat_node = (pm_splat_node_t *)argument;
|
|
|
|
if (splat_node->expression) {
|
|
|
|
PM_COMPILE_NOT_POPPED(splat_node->expression);
|
|
|
|
}
|
2024-01-24 00:13:18 +03:00
|
|
|
else {
|
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, PM_CONSTANT_MULT, 0);
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
|
|
|
}
|
2024-01-17 22:45:05 +03:00
|
|
|
|
|
|
|
bool first_splat = !has_splat;
|
|
|
|
|
|
|
|
if (first_splat) {
|
|
|
|
// If this is the first splat array seen and it's not the
|
|
|
|
// last parameter, we want splatarray to dup it.
|
|
|
|
//
|
|
|
|
// foo(a, *b, c)
|
|
|
|
// ^^
|
|
|
|
if (index + 1 < arguments_node_list.size) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, splatarray, Qtrue);
|
2024-01-25 18:33:48 +03:00
|
|
|
*flags |= VM_CALL_ARGS_SPLAT_MUT;
|
2024-01-17 22:45:05 +03:00
|
|
|
}
|
|
|
|
// If this is the first spalt array seen and it's the last
|
|
|
|
// parameter, we don't want splatarray to dup it.
|
|
|
|
//
|
|
|
|
// foo(a, *b)
|
|
|
|
// ^^
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, splatarray, Qfalse);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
// If this is not the first splat array seen and it is also
|
2024-01-22 19:36:55 +03:00
|
|
|
// the last parameter, we don't want splatarray to dup it
|
2024-01-17 22:45:05 +03:00
|
|
|
// and we need to concat the array.
|
|
|
|
//
|
|
|
|
// foo(a, *b, *c)
|
|
|
|
// ^^
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, splatarray, Qfalse);
|
|
|
|
ADD_INSN(ret, &dummy_line_node, concatarray);
|
|
|
|
}
|
|
|
|
|
|
|
|
has_splat = true;
|
|
|
|
post_splat_counter = 0;
|
|
|
|
|
|
|
|
break;
|
2023-11-27 19:12:24 +03:00
|
|
|
}
|
|
|
|
case PM_FORWARDING_ARGUMENTS_NODE: {
|
2024-01-17 22:45:05 +03:00
|
|
|
orig_argc++;
|
|
|
|
*flags |= VM_CALL_ARGS_BLOCKARG | VM_CALL_ARGS_SPLAT;
|
2024-01-24 21:43:26 +03:00
|
|
|
|
|
|
|
pm_local_index_t mult_index = pm_lookup_local_index(iseq, scope_node, PM_CONSTANT_MULT, 0);
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, mult_index.index, mult_index.level);
|
|
|
|
|
2024-01-17 22:45:05 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, splatarray, RBOOL(arguments_node_list.size > 1));
|
2024-01-24 21:43:26 +03:00
|
|
|
|
2024-01-25 01:01:16 +03:00
|
|
|
pm_local_index_t and_index = pm_lookup_local_index(iseq, scope_node, PM_CONSTANT_AND, 0);
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getblockparamproxy, INT2FIX(and_index.index + VM_ENV_DATA_SIZE - 1), INT2FIX(and_index.level));
|
2024-01-24 21:43:26 +03:00
|
|
|
|
2024-01-17 22:45:05 +03:00
|
|
|
break;
|
2023-11-27 19:12:24 +03:00
|
|
|
}
|
|
|
|
default: {
|
2024-01-17 22:45:05 +03:00
|
|
|
post_splat_counter++;
|
|
|
|
PM_COMPILE_NOT_POPPED(argument);
|
|
|
|
|
|
|
|
// If we have a splat and we've seen a splat, we need to process
|
|
|
|
// everything after the splat.
|
|
|
|
if (has_splat) {
|
|
|
|
// Stack items are turned into an array and concatenated in
|
|
|
|
// the following cases:
|
|
|
|
//
|
|
|
|
// If the next node is a splat:
|
|
|
|
//
|
|
|
|
// foo(*a, b, *c)
|
|
|
|
//
|
|
|
|
// If the next node is a kwarg or kwarg splat:
|
|
|
|
//
|
|
|
|
// foo(*a, b, c: :d)
|
|
|
|
// foo(*a, b, **c)
|
|
|
|
//
|
|
|
|
// If the next node is NULL (we have hit the end):
|
|
|
|
//
|
|
|
|
// foo(*a, b)
|
|
|
|
if (index == arguments_node_list.size - 1) {
|
|
|
|
RUBY_ASSERT(post_splat_counter > 0);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(post_splat_counter));
|
|
|
|
ADD_INSN(ret, &dummy_line_node, concatarray);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_node_t *next_arg = arguments_node_list.nodes[index + 1];
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(next_arg)) {
|
|
|
|
// A keyword hash node contains all keyword arguments as AssocNodes and AssocSplatNodes
|
|
|
|
case PM_KEYWORD_HASH_NODE: {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(post_splat_counter));
|
|
|
|
ADD_INSN(ret, &dummy_line_node, concatarray);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_SPLAT_NODE: {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(post_splat_counter));
|
|
|
|
ADD_INSN(ret, &dummy_line_node, concatarray);
|
|
|
|
break;
|
2023-11-29 22:58:26 +03:00
|
|
|
}
|
2024-01-17 22:45:05 +03:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
orig_argc++;
|
|
|
|
}
|
2023-11-27 19:12:24 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
[Prism] Fix more method call argumnents
In #2087 it was noted that there was a bug in the number of arguments in
`SplatNode` and `KeywordHashNode`. I looked into this with Aaron before
the linked PR was merged and we found a bunch of cases that weren't
working quite right. This PR aims to fix some of those cases, but there
may be more.
A splat argument followed by a positional argument will concat the array
until the end or unless the argument is a kwarg or splat kwarg. For
example
```
foo(a, *b, c, *d, e)
```
Will have an `argc` of 2, because `b`, `c`, `d`, and `e` will be
concatenated together.
```
foo(a, *b, c, *d, **e)
```
Will have an `argc` of 3, because `b`, `c`, and `d` will be concatenated
together and `e` is a separate argument.
2024-01-03 22:23:44 +03:00
|
|
|
|
|
|
|
if (has_splat) {
|
|
|
|
orig_argc++;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_keyword_splat) {
|
|
|
|
orig_argc++;
|
|
|
|
}
|
|
|
|
|
2023-11-27 19:12:24 +03:00
|
|
|
return orig_argc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pm_compile_index_and_or_write_node(bool and_node, pm_node_t *receiver, pm_node_t *value, pm_arguments_node_t *arguments, pm_node_t *block, LINK_ANCHOR *const ret, rb_iseq_t *iseq, int lineno, const uint8_t * src, bool popped, pm_scope_node_t *scope_node, pm_parser_t *parser)
|
|
|
|
{
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
|
|
|
|
PM_COMPILE_NOT_POPPED(receiver);
|
|
|
|
|
|
|
|
int flag = 0;
|
|
|
|
int argc_int = 0;
|
|
|
|
|
2024-01-22 18:46:12 +03:00
|
|
|
struct rb_callinfo_kwarg *keywords = NULL;
|
2023-11-27 19:12:24 +03:00
|
|
|
if (arguments) {
|
2023-11-27 22:07:27 +03:00
|
|
|
// Get any arguments, and set the appropriate values for flag
|
2024-01-22 18:46:12 +03:00
|
|
|
argc_int = pm_setup_args(arguments, &flag, &keywords, iseq, ret, src, popped, scope_node, dummy_line_node, parser);
|
2023-11-27 19:12:24 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
VALUE argc = INT2FIX(argc_int);
|
2023-11-27 22:07:27 +03:00
|
|
|
int block_offset = 0;
|
2023-11-27 19:12:24 +03:00
|
|
|
|
|
|
|
if (block) {
|
|
|
|
PM_COMPILE_NOT_POPPED(block);
|
|
|
|
flag |= VM_CALL_ARGS_BLOCKARG;
|
2023-11-27 22:07:27 +03:00
|
|
|
block_offset = 1;
|
2023-11-27 19:12:24 +03:00
|
|
|
}
|
|
|
|
|
2024-01-22 18:46:12 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, dupn, FIXNUM_INC(argc, 1 + block_offset + (keywords ? keywords->keyword_len : 0)));
|
2023-11-27 19:12:24 +03:00
|
|
|
|
2024-01-22 18:46:12 +03:00
|
|
|
ADD_SEND_R(ret, &dummy_line_node, idAREF, argc, NULL, INT2FIX(flag), keywords);
|
2023-11-27 19:12:24 +03:00
|
|
|
|
|
|
|
LABEL *label = NEW_LABEL(lineno);
|
|
|
|
LABEL *lfin = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
PM_DUP;
|
|
|
|
|
|
|
|
if (and_node) {
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, label);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
// ornode
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, label);
|
|
|
|
}
|
|
|
|
|
|
|
|
PM_POP;
|
|
|
|
|
|
|
|
PM_COMPILE_NOT_POPPED(value);
|
|
|
|
|
2024-01-22 18:46:12 +03:00
|
|
|
pm_compile_index_write_nodes_add_send(popped, ret, iseq, dummy_line_node, argc, flag, block_offset, keywords);
|
2023-11-27 20:48:51 +03:00
|
|
|
|
2023-11-27 19:12:24 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, lfin);
|
|
|
|
ADD_LABEL(ret, label);
|
|
|
|
if (!popped) {
|
2024-01-22 21:52:41 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, setn, FIXNUM_INC(argc, 2 + block_offset + (keywords ? keywords->keyword_len : 0)));
|
2023-11-27 19:12:24 +03:00
|
|
|
}
|
2024-01-22 21:52:41 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, adjuststack, FIXNUM_INC(argc, 2 + block_offset + (keywords ? keywords->keyword_len : 0)));
|
2023-11-27 19:12:24 +03:00
|
|
|
ADD_LABEL(ret, lfin);
|
2023-11-27 22:07:27 +03:00
|
|
|
|
2023-11-27 19:12:24 +03:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-12-13 19:34:05 +03:00
|
|
|
// When we compile a pattern matching expression, we use the stack as a scratch
|
|
|
|
// space to store lots of different values (consider it like we have a pattern
|
|
|
|
// matching function and we need space for a bunch of different local
|
|
|
|
// variables). The "base index" refers to the index on the stack where we
|
|
|
|
// started compiling the pattern matching expression. These offsets from that
|
|
|
|
// base index indicate the location of the various locals we need.
|
|
|
|
#define PM_PATTERN_BASE_INDEX_OFFSET_DECONSTRUCTED_CACHE 0
|
|
|
|
#define PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING 1
|
|
|
|
#define PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P 2
|
|
|
|
#define PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_MATCHEE 3
|
|
|
|
#define PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_KEY 4
|
|
|
|
|
|
|
|
// A forward declaration because this is the recursive function that handles
|
|
|
|
// compiling a pattern. It can be reentered by nesting patterns, as in the case
|
|
|
|
// of arrays or hashes.
|
|
|
|
static int pm_compile_pattern(rb_iseq_t *iseq, pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, LABEL *matched_label, LABEL *unmatched_label, bool in_single_pattern, bool in_alternation_pattern, bool use_deconstructed_cache, unsigned int base_index);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This function generates the code to set up the error string and error_p
|
|
|
|
* locals depending on whether or not the pattern matched.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
pm_compile_pattern_generic_error(rb_iseq_t *iseq, pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, VALUE message, unsigned int base_index)
|
|
|
|
{
|
|
|
|
pm_line_node_t line;
|
|
|
|
pm_line_node(&line, scope_node, node);
|
|
|
|
|
|
|
|
LABEL *match_succeeded_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSNL(ret, &line.node, branchif, match_succeeded_label);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, message);
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_sprintf, INT2FIX(2));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING + 1));
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, Qfalse);
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P + 2));
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_LABEL(ret, match_succeeded_label);
|
|
|
|
|
|
|
|
return COMPILE_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This function generates the code to set up the error string and error_p
|
|
|
|
* locals depending on whether or not the pattern matched when the value needs
|
|
|
|
* to match a specific deconstructed length.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
pm_compile_pattern_length_error(rb_iseq_t *iseq, pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, VALUE message, VALUE length, unsigned int base_index)
|
|
|
|
{
|
|
|
|
pm_line_node_t line;
|
|
|
|
pm_line_node(&line, scope_node, node);
|
|
|
|
|
|
|
|
LABEL *match_succeeded_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSNL(ret, &line.node, branchif, match_succeeded_label);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, message);
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_SEND(ret, &line.node, idLength, INT2FIX(0));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, length);
|
|
|
|
ADD_SEND(ret, &line.node, id_core_sprintf, INT2FIX(4));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING + 1));
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, Qfalse);
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P + 2));
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_LABEL(ret, match_succeeded_label);
|
|
|
|
|
|
|
|
return COMPILE_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This function generates the code to set up the error string and error_p
|
|
|
|
* locals depending on whether or not the pattern matched when the value needs
|
|
|
|
* to pass a specific #=== method call.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
pm_compile_pattern_eqq_error(rb_iseq_t *iseq, pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, unsigned int base_index)
|
|
|
|
{
|
|
|
|
pm_line_node_t line;
|
|
|
|
pm_line_node(&line, scope_node, node);
|
|
|
|
|
|
|
|
LABEL *match_succeeded_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSNL(ret, &line.node, branchif, match_succeeded_label);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_fstring_lit("%p === %p does not return true"));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(5));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_sprintf, INT2FIX(3));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING + 1));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, Qfalse);
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P + 2));
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, match_succeeded_label);
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(2));
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
|
|
|
|
return COMPILE_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This is a variation on compiling a pattern matching expression that is used
|
|
|
|
* to have the pattern matching instructions fall through to immediately after
|
|
|
|
* the pattern if it passes. Otherwise it jumps to the given unmatched_label
|
|
|
|
* label.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
pm_compile_pattern_match(rb_iseq_t *iseq, pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, LABEL *unmatched_label, bool in_single_pattern, bool in_alternation_pattern, bool use_deconstructed_cache, unsigned int base_index)
|
|
|
|
{
|
|
|
|
LABEL *matched_label = NEW_LABEL(nd_line(node));
|
|
|
|
CHECK(pm_compile_pattern(iseq, scope_node, node, ret, src, matched_label, unmatched_label, in_single_pattern, in_alternation_pattern, use_deconstructed_cache, base_index));
|
|
|
|
ADD_LABEL(ret, matched_label);
|
|
|
|
return COMPILE_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This function compiles in the code necessary to call #deconstruct on the
|
|
|
|
* value to match against. It raises appropriate errors if the method does not
|
|
|
|
* exist or if it returns the wrong type.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
pm_compile_pattern_deconstruct(rb_iseq_t *iseq, pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, LABEL *deconstruct_label, LABEL *match_failed_label, LABEL *deconstructed_label, LABEL *type_error_label, bool in_single_pattern, bool use_deconstructed_cache, unsigned int base_index)
|
|
|
|
{
|
|
|
|
pm_line_node_t line;
|
|
|
|
pm_line_node(&line, scope_node, node);
|
|
|
|
|
|
|
|
if (use_deconstructed_cache) {
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_DECONSTRUCTED_CACHE));
|
|
|
|
ADD_INSNL(ret, &line.node, branchnil, deconstruct_label);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_DECONSTRUCTED_CACHE));
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_DECONSTRUCTED_CACHE - 1));
|
|
|
|
ADD_INSNL(ret, &line.node, jump, deconstructed_label);
|
|
|
|
} else {
|
|
|
|
ADD_INSNL(ret, &line.node, jump, deconstruct_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, deconstruct_label);
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, ID2SYM(rb_intern("deconstruct")));
|
|
|
|
ADD_SEND(ret, &line.node, idRespond_to, INT2FIX(1));
|
|
|
|
|
|
|
|
if (use_deconstructed_cache) {
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_DECONSTRUCTED_CACHE + 1));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (in_single_pattern) {
|
|
|
|
CHECK(pm_compile_pattern_generic_error(iseq, scope_node, node, ret, rb_fstring_lit("%p does not respond to #deconstruct"), base_index + 1));
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
ADD_SEND(ret, &line.node, rb_intern("deconstruct"), INT2FIX(0));
|
|
|
|
|
|
|
|
if (use_deconstructed_cache) {
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_DECONSTRUCTED_CACHE));
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, checktype, INT2FIX(T_ARRAY));
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, type_error_label);
|
|
|
|
ADD_LABEL(ret, deconstructed_label);
|
|
|
|
|
|
|
|
return COMPILE_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This function compiles in the code necessary to match against the optional
|
|
|
|
* constant path that is attached to an array, find, or hash pattern.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
pm_compile_pattern_constant(rb_iseq_t *iseq, pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, LABEL *match_failed_label, bool in_single_pattern, unsigned int base_index)
|
|
|
|
{
|
|
|
|
pm_line_node_t line;
|
|
|
|
pm_line_node(&line, scope_node, node);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
PM_COMPILE_NOT_POPPED(node);
|
|
|
|
|
|
|
|
if (in_single_pattern) {
|
|
|
|
ADD_INSN1(ret, &line.node, dupn, INT2FIX(2));
|
|
|
|
}
|
|
|
|
ADD_INSN1(ret, &line.node, checkmatch, INT2FIX(VM_CHECKMATCH_TYPE_CASE));
|
|
|
|
if (in_single_pattern) {
|
|
|
|
CHECK(pm_compile_pattern_eqq_error(iseq, scope_node, node, ret, base_index + 3));
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
return COMPILE_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* When matching fails, an appropriate error must be raised. This function is
|
|
|
|
* responsible for compiling in those error raising instructions.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
pm_compile_pattern_error_handler(rb_iseq_t *iseq, const pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, LABEL *done_label, bool popped)
|
|
|
|
{
|
|
|
|
pm_line_node_t line;
|
|
|
|
pm_line_node(&line, scope_node, node);
|
|
|
|
|
|
|
|
LABEL *key_error_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *cleanup_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
struct rb_callinfo_kwarg *kw_arg = rb_xmalloc_mul_add(2, sizeof(VALUE), sizeof(struct rb_callinfo_kwarg));
|
|
|
|
kw_arg->references = 0;
|
|
|
|
kw_arg->keyword_len = 2;
|
|
|
|
kw_arg->keywords[0] = ID2SYM(rb_intern("matchee"));
|
|
|
|
kw_arg->keywords[1] = ID2SYM(rb_intern("key"));
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P + 2));
|
|
|
|
ADD_INSNL(ret, &line.node, branchif, key_error_label);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_eNoMatchingPatternError);
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_fstring_lit("%p: %s"));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(4));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING + 6));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_sprintf, INT2FIX(3));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_raise, INT2FIX(2));
|
|
|
|
ADD_INSNL(ret, &line.node, jump, cleanup_label);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, key_error_label);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_eNoMatchingPatternKeyError);
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_fstring_lit("%p: %s"));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(4));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING + 6));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_sprintf, INT2FIX(3));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_MATCHEE + 4));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_KEY + 5));
|
|
|
|
ADD_SEND_R(ret, &line.node, rb_intern("new"), INT2FIX(1), NULL, INT2FIX(VM_CALL_KWARG), kw_arg);
|
|
|
|
ADD_SEND(ret, &line.node, id_core_raise, INT2FIX(1));
|
|
|
|
ADD_LABEL(ret, cleanup_label);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, adjuststack, INT2FIX(7));
|
|
|
|
if (!popped) ADD_INSN(ret, &line.node, putnil);
|
|
|
|
ADD_INSNL(ret, &line.node, jump, done_label);
|
|
|
|
ADD_INSN1(ret, &line.node, dupn, INT2FIX(5));
|
|
|
|
if (popped) ADD_INSN(ret, &line.node, putnil);
|
|
|
|
}
|
|
|
|
|
2023-09-28 19:14:38 +03:00
|
|
|
/**
|
|
|
|
* Compile a pattern matching expression.
|
|
|
|
*/
|
2023-09-28 19:36:17 +03:00
|
|
|
static int
|
2023-12-13 19:34:05 +03:00
|
|
|
pm_compile_pattern(rb_iseq_t *iseq, pm_scope_node_t *scope_node, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, LABEL *matched_label, LABEL *unmatched_label, bool in_single_pattern, bool in_alternation_pattern, bool use_deconstructed_cache, unsigned int base_index)
|
2023-09-28 19:14:38 +03:00
|
|
|
{
|
2023-12-13 19:34:05 +03:00
|
|
|
pm_line_node_t line;
|
|
|
|
pm_line_node(&line, scope_node, node);
|
2023-09-28 19:14:38 +03:00
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(node)) {
|
2023-12-13 19:34:05 +03:00
|
|
|
case PM_ARRAY_PATTERN_NODE: {
|
|
|
|
// Array patterns in pattern matching are triggered by using commas in
|
|
|
|
// a pattern or wrapping it in braces. They are represented by a
|
|
|
|
// ArrayPatternNode. This looks like:
|
|
|
|
//
|
|
|
|
// foo => [1, 2, 3]
|
|
|
|
//
|
|
|
|
// It can optionally have a splat in the middle of it, which can
|
|
|
|
// optionally have a name attached.
|
|
|
|
const pm_array_pattern_node_t *cast = (const pm_array_pattern_node_t *) node;
|
|
|
|
|
|
|
|
const size_t requireds_size = cast->requireds.size;
|
|
|
|
const size_t posts_size = cast->posts.size;
|
|
|
|
const size_t minimum_size = requireds_size + posts_size;
|
|
|
|
|
|
|
|
bool use_rest_size = (
|
|
|
|
cast->rest != NULL &&
|
|
|
|
PM_NODE_TYPE_P(cast->rest, PM_SPLAT_NODE) &&
|
|
|
|
((((const pm_splat_node_t *) cast->rest)->expression != NULL) || posts_size > 0)
|
|
|
|
);
|
|
|
|
|
|
|
|
LABEL *match_failed_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *type_error_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *deconstruct_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *deconstructed_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
if (use_rest_size) {
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(0));
|
|
|
|
ADD_INSN(ret, &line.node, swap);
|
|
|
|
base_index++;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (cast->constant != NULL) {
|
|
|
|
CHECK(pm_compile_pattern_constant(iseq, scope_node, cast->constant, ret, src, match_failed_label, in_single_pattern, base_index));
|
|
|
|
}
|
|
|
|
|
|
|
|
CHECK(pm_compile_pattern_deconstruct(iseq, scope_node, node, ret, src, deconstruct_label, match_failed_label, deconstructed_label, type_error_label, in_single_pattern, use_deconstructed_cache, base_index));
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_SEND(ret, &line.node, idLength, INT2FIX(0));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(minimum_size));
|
|
|
|
ADD_SEND(ret, &line.node, cast->rest == NULL ? idEq : idGE, INT2FIX(1));
|
|
|
|
if (in_single_pattern) {
|
|
|
|
VALUE message = cast->rest == NULL ? rb_fstring_lit("%p length mismatch (given %p, expected %p)") : rb_fstring_lit("%p length mismatch (given %p, expected %p+)");
|
|
|
|
CHECK(pm_compile_pattern_length_error(iseq, scope_node, node, ret, message, INT2FIX(minimum_size), base_index + 1));
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
|
|
|
|
for (size_t index = 0; index < requireds_size; index++) {
|
|
|
|
const pm_node_t *required = cast->requireds.nodes[index];
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(index));
|
|
|
|
ADD_SEND(ret, &line.node, idAREF, INT2FIX(1));
|
|
|
|
CHECK(pm_compile_pattern_match(iseq, scope_node, required, ret, src, match_failed_label, in_single_pattern, in_alternation_pattern, false, base_index + 1));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (cast->rest != NULL) {
|
|
|
|
if (((const pm_splat_node_t *) cast->rest)->expression != NULL) {
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(requireds_size));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(1));
|
|
|
|
ADD_SEND(ret, &line.node, idLength, INT2FIX(0));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(minimum_size));
|
|
|
|
ADD_SEND(ret, &line.node, idMINUS, INT2FIX(1));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(4));
|
|
|
|
ADD_SEND(ret, &line.node, idAREF, INT2FIX(2));
|
|
|
|
CHECK(pm_compile_pattern_match(iseq, scope_node, ((const pm_splat_node_t *) cast->rest)->expression, ret, src, match_failed_label, in_single_pattern, in_alternation_pattern, false, base_index + 1));
|
|
|
|
} else if (posts_size > 0) {
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_SEND(ret, &line.node, idLength, INT2FIX(0));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(minimum_size));
|
|
|
|
ADD_SEND(ret, &line.node, idMINUS, INT2FIX(1));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(2));
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (size_t index = 0; index < posts_size; index++) {
|
|
|
|
const pm_node_t *post = cast->posts.nodes[index];
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(requireds_size + index));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_SEND(ret, &line.node, idPLUS, INT2FIX(1));
|
|
|
|
ADD_SEND(ret, &line.node, idAREF, INT2FIX(1));
|
|
|
|
CHECK(pm_compile_pattern_match(iseq, scope_node, post, ret, src, match_failed_label, in_single_pattern, in_alternation_pattern, false, base_index + 1));
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
if (use_rest_size) {
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &line.node, jump, matched_label);
|
|
|
|
ADD_INSN(ret, &line.node, putnil);
|
|
|
|
if (use_rest_size) {
|
|
|
|
ADD_INSN(ret, &line.node, putnil);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, type_error_label);
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_eTypeError);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_fstring_lit("deconstruct must return Array"));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_raise, INT2FIX(2));
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, match_failed_label);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
if (use_rest_size) {
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &line.node, jump, unmatched_label);
|
2023-09-28 19:19:50 +03:00
|
|
|
break;
|
2023-12-13 19:34:05 +03:00
|
|
|
}
|
|
|
|
case PM_FIND_PATTERN_NODE: {
|
|
|
|
// Find patterns in pattern matching are triggered by using commas in
|
|
|
|
// a pattern or wrapping it in braces and using a splat on both the left
|
|
|
|
// and right side of the pattern. This looks like:
|
|
|
|
//
|
|
|
|
// foo => [*, 1, 2, 3, *]
|
|
|
|
//
|
|
|
|
// There can be any number of requireds in the middle. The splats on
|
|
|
|
// both sides can optionally have names attached.
|
|
|
|
const pm_find_pattern_node_t *cast = (const pm_find_pattern_node_t *) node;
|
|
|
|
const size_t size = cast->requireds.size;
|
|
|
|
|
|
|
|
LABEL *match_failed_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *type_error_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *deconstruct_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *deconstructed_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
if (cast->constant) {
|
|
|
|
CHECK(pm_compile_pattern_constant(iseq, scope_node, cast->constant, ret, src, match_failed_label, in_single_pattern, base_index));
|
|
|
|
}
|
|
|
|
|
|
|
|
CHECK(pm_compile_pattern_deconstruct(iseq, scope_node, node, ret, src, deconstruct_label, match_failed_label, deconstructed_label, type_error_label, in_single_pattern, use_deconstructed_cache, base_index));
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_SEND(ret, &line.node, idLength, INT2FIX(0));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(size));
|
|
|
|
ADD_SEND(ret, &line.node, idGE, INT2FIX(1));
|
|
|
|
if (in_single_pattern) {
|
|
|
|
CHECK(pm_compile_pattern_length_error(iseq, scope_node, node, ret, rb_fstring_lit("%p length mismatch (given %p, expected %p+)"), INT2FIX(size), base_index + 1));
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
|
|
|
|
{
|
|
|
|
LABEL *while_begin_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *next_loop_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *find_succeeded_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *find_failed_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_SEND(ret, &line.node, idLength, INT2FIX(0));
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(size));
|
|
|
|
ADD_SEND(ret, &line.node, idMINUS, INT2FIX(1));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(0));
|
|
|
|
ADD_LABEL(ret, while_begin_label);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(2));
|
|
|
|
ADD_SEND(ret, &line.node, idLE, INT2FIX(1));
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, find_failed_label);
|
|
|
|
|
|
|
|
for (size_t index = 0; index < size; index++) {
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(1));
|
|
|
|
|
|
|
|
if (index != 0) {
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(index));
|
|
|
|
ADD_SEND(ret, &line.node, idPLUS, INT2FIX(1));
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_SEND(ret, &line.node, idAREF, INT2FIX(1));
|
|
|
|
CHECK(pm_compile_pattern_match(iseq, scope_node, cast->requireds.nodes[index], ret, src, next_loop_label, in_single_pattern, in_alternation_pattern, false, base_index + 4));
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(PM_NODE_TYPE_P(cast->left, PM_SPLAT_NODE));
|
|
|
|
const pm_splat_node_t *left = (const pm_splat_node_t *) cast->left;
|
|
|
|
|
|
|
|
if (left->expression != NULL) {
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(0));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(2));
|
|
|
|
ADD_SEND(ret, &line.node, idAREF, INT2FIX(2));
|
|
|
|
CHECK(pm_compile_pattern_match(iseq, scope_node, left->expression, ret, src, find_failed_label, in_single_pattern, in_alternation_pattern, false, base_index + 4));
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(PM_NODE_TYPE_P(cast->right, PM_SPLAT_NODE));
|
|
|
|
const pm_splat_node_t *right = (const pm_splat_node_t *) cast->right;
|
|
|
|
|
|
|
|
if (right->expression != NULL) {
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(1));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(size));
|
|
|
|
ADD_SEND(ret, &line.node, idPLUS, INT2FIX(1));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_SEND(ret, &line.node, idAREF, INT2FIX(2));
|
|
|
|
pm_compile_pattern_match(iseq, scope_node, right->expression, ret, src, find_failed_label, in_single_pattern, in_alternation_pattern, false, base_index + 4);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &line.node, jump, find_succeeded_label);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, next_loop_label);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, INT2FIX(1));
|
|
|
|
ADD_SEND(ret, &line.node, idPLUS, INT2FIX(1));
|
|
|
|
ADD_INSNL(ret, &line.node, jump, while_begin_label);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, find_failed_label);
|
|
|
|
ADD_INSN1(ret, &line.node, adjuststack, INT2FIX(3));
|
|
|
|
if (in_single_pattern) {
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_fstring_lit("%p does not match to find pattern"));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(2));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_sprintf, INT2FIX(2));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING + 1));
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, Qfalse);
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P + 2));
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &line.node, jump, match_failed_label);
|
|
|
|
ADD_INSN1(ret, &line.node, dupn, INT2FIX(3));
|
|
|
|
|
|
|
|
ADD_LABEL(ret, find_succeeded_label);
|
|
|
|
ADD_INSN1(ret, &line.node, adjuststack, INT2FIX(3));
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSNL(ret, &line.node, jump, matched_label);
|
|
|
|
ADD_INSN(ret, &line.node, putnil);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, type_error_label);
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_eTypeError);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_fstring_lit("deconstruct must return Array"));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_raise, INT2FIX(2));
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, match_failed_label);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSNL(ret, &line.node, jump, unmatched_label);
|
|
|
|
|
2023-09-28 19:36:17 +03:00
|
|
|
break;
|
2023-12-13 19:34:05 +03:00
|
|
|
}
|
|
|
|
case PM_HASH_PATTERN_NODE: {
|
|
|
|
// Hash patterns in pattern matching are triggered by using labels and
|
|
|
|
// values in a pattern or by using the ** operator. They are represented
|
|
|
|
// by the HashPatternNode. This looks like:
|
2023-09-28 19:51:33 +03:00
|
|
|
//
|
2023-12-13 19:34:05 +03:00
|
|
|
// foo => { a: 1, b: 2, **bar }
|
2023-09-28 19:51:33 +03:00
|
|
|
//
|
2023-12-13 19:34:05 +03:00
|
|
|
// It can optionally have an assoc splat in the middle of it, which can
|
|
|
|
// optionally have a name.
|
|
|
|
const pm_hash_pattern_node_t *cast = (const pm_hash_pattern_node_t *) node;
|
2023-09-28 19:51:33 +03:00
|
|
|
|
2023-12-13 19:34:05 +03:00
|
|
|
// We don't consider it a "rest" parameter if it's a ** that is unnamed.
|
|
|
|
bool has_rest = cast->rest != NULL && !(PM_NODE_TYPE_P(cast->rest, PM_ASSOC_SPLAT_NODE) && ((const pm_assoc_splat_node_t *) cast->rest)->value == NULL);
|
|
|
|
bool has_keys = cast->elements.size > 0 || cast->rest != NULL;
|
|
|
|
|
|
|
|
LABEL *match_failed_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *type_error_label = NEW_LABEL(line.lineno);
|
|
|
|
VALUE keys = Qnil;
|
|
|
|
|
|
|
|
if (has_keys && !has_rest) {
|
|
|
|
keys = rb_ary_new_capa(cast->elements.size);
|
|
|
|
|
|
|
|
for (size_t index = 0; index < cast->elements.size; index++) {
|
|
|
|
const pm_node_t *element = cast->elements.nodes[index];
|
|
|
|
assert(PM_NODE_TYPE_P(element, PM_ASSOC_NODE));
|
|
|
|
|
|
|
|
const pm_node_t *key = ((const pm_assoc_node_t *) element)->key;
|
|
|
|
assert(PM_NODE_TYPE_P(key, PM_SYMBOL_NODE));
|
|
|
|
|
2024-01-26 23:18:21 +03:00
|
|
|
VALUE symbol = ID2SYM(parse_string_symbol((const pm_symbol_node_t *)key, scope_node->parser));
|
2023-12-13 19:34:05 +03:00
|
|
|
rb_ary_push(keys, symbol);
|
|
|
|
}
|
|
|
|
}
|
2023-09-28 19:51:33 +03:00
|
|
|
|
2023-12-13 19:34:05 +03:00
|
|
|
if (cast->constant) {
|
|
|
|
CHECK(pm_compile_pattern_constant(iseq, scope_node, cast->constant, ret, src, match_failed_label, in_single_pattern, base_index));
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, ID2SYM(rb_intern("deconstruct_keys")));
|
|
|
|
ADD_SEND(ret, &line.node, idRespond_to, INT2FIX(1));
|
|
|
|
if (in_single_pattern) {
|
|
|
|
CHECK(pm_compile_pattern_generic_error(iseq, scope_node, node, ret, rb_fstring_lit("%p does not respond to #deconstruct_keys"), base_index + 1));
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
|
|
|
|
if (NIL_P(keys)) {
|
|
|
|
ADD_INSN(ret, &line.node, putnil);
|
|
|
|
} else {
|
|
|
|
ADD_INSN1(ret, &line.node, duparray, keys);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, rb_obj_hide(keys));
|
|
|
|
}
|
|
|
|
ADD_SEND(ret, &line.node, rb_intern("deconstruct_keys"), INT2FIX(1));
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, checktype, INT2FIX(T_HASH));
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, type_error_label);
|
|
|
|
|
|
|
|
if (has_rest) {
|
|
|
|
ADD_SEND(ret, &line.node, rb_intern("dup"), INT2FIX(0));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_keys) {
|
|
|
|
DECL_ANCHOR(match_values);
|
|
|
|
INIT_ANCHOR(match_values);
|
|
|
|
|
|
|
|
for (size_t index = 0; index < cast->elements.size; index++) {
|
|
|
|
const pm_node_t *element = cast->elements.nodes[index];
|
|
|
|
assert(PM_NODE_TYPE_P(element, PM_ASSOC_NODE));
|
|
|
|
|
|
|
|
const pm_assoc_node_t *assoc = (const pm_assoc_node_t *) element;
|
|
|
|
const pm_node_t *key = assoc->key;
|
|
|
|
assert(PM_NODE_TYPE_P(key, PM_SYMBOL_NODE));
|
|
|
|
|
2024-01-26 23:18:21 +03:00
|
|
|
VALUE symbol = ID2SYM(parse_string_symbol((const pm_symbol_node_t *)key, scope_node->parser));
|
2023-12-13 19:34:05 +03:00
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, symbol);
|
|
|
|
ADD_SEND(ret, &line.node, rb_intern("key?"), INT2FIX(1));
|
|
|
|
|
|
|
|
if (in_single_pattern) {
|
|
|
|
LABEL *match_succeeded_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_INSNL(ret, &line.node, branchif, match_succeeded_label);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_str_freeze(rb_sprintf("key not found: %+"PRIsVALUE, symbol)));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING + 2));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, Qtrue);
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P + 3));
|
|
|
|
ADD_INSN1(ret, &line.node, topn, INT2FIX(3));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_MATCHEE + 4));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, symbol);
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_KEY + 5));
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, adjuststack, INT2FIX(4));
|
|
|
|
ADD_LABEL(ret, match_succeeded_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
ADD_INSN(match_values, &line.node, dup);
|
|
|
|
ADD_INSN1(match_values, &line.node, putobject, symbol);
|
|
|
|
ADD_SEND(match_values, &line.node, has_rest ? rb_intern("delete") : idAREF, INT2FIX(1));
|
|
|
|
|
2024-01-24 21:43:04 +03:00
|
|
|
const pm_node_t *value = assoc->value;
|
|
|
|
if (PM_NODE_TYPE_P(value, PM_IMPLICIT_NODE)) {
|
|
|
|
value = ((const pm_implicit_node_t *) value)->value;
|
|
|
|
}
|
|
|
|
|
|
|
|
CHECK(pm_compile_pattern_match(iseq, scope_node, value, match_values, src, match_failed_label, in_single_pattern, in_alternation_pattern, false, base_index + 1));
|
2023-12-13 19:34:05 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_SEQ(ret, match_values);
|
|
|
|
} else {
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_SEND(ret, &line.node, idEmptyP, INT2FIX(0));
|
|
|
|
if (in_single_pattern) {
|
|
|
|
CHECK(pm_compile_pattern_generic_error(iseq, scope_node, node, ret, rb_fstring_lit("%p is not empty"), base_index + 1));
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_rest) {
|
|
|
|
switch (PM_NODE_TYPE(cast->rest)) {
|
|
|
|
case PM_NO_KEYWORDS_PARAMETER_NODE: {
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
ADD_SEND(ret, &line.node, idEmptyP, INT2FIX(0));
|
|
|
|
if (in_single_pattern) {
|
|
|
|
pm_compile_pattern_generic_error(iseq, scope_node, node, ret, rb_fstring_lit("rest of %p is not empty"), base_index + 1);
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_failed_label);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_ASSOC_SPLAT_NODE: {
|
|
|
|
const pm_assoc_splat_node_t *splat = (const pm_assoc_splat_node_t *) cast->rest;
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
pm_compile_pattern_match(iseq, scope_node, splat->value, ret, src, match_failed_label, in_single_pattern, in_alternation_pattern, false, base_index + 1);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
rb_bug("unreachable");
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSNL(ret, &line.node, jump, matched_label);
|
|
|
|
ADD_INSN(ret, &line.node, putnil);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, type_error_label);
|
|
|
|
ADD_INSN1(ret, &line.node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_eTypeError);
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_fstring_lit("deconstruct_keys must return Hash"));
|
|
|
|
ADD_SEND(ret, &line.node, id_core_raise, INT2FIX(2));
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, match_failed_label);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSNL(ret, &line.node, jump, unmatched_label);
|
2023-09-28 19:51:33 +03:00
|
|
|
break;
|
|
|
|
}
|
2023-12-13 19:34:05 +03:00
|
|
|
case PM_CAPTURE_PATTERN_NODE: {
|
|
|
|
// Capture patterns allow you to pattern match against an element in a
|
|
|
|
// pattern and also capture the value into a local variable. This looks
|
|
|
|
// like:
|
2023-09-28 19:51:33 +03:00
|
|
|
//
|
2023-12-13 19:34:05 +03:00
|
|
|
// [1] => [Integer => foo]
|
2023-09-28 19:51:33 +03:00
|
|
|
//
|
2023-12-13 19:34:05 +03:00
|
|
|
// In this case the `Integer => foo` will be represented by a
|
|
|
|
// CapturePatternNode, which has both a value (the pattern to match
|
|
|
|
// against) and a target (the place to write the variable into).
|
|
|
|
const pm_capture_pattern_node_t *cast = (const pm_capture_pattern_node_t *) node;
|
2023-09-28 19:51:33 +03:00
|
|
|
|
2023-12-13 19:34:05 +03:00
|
|
|
LABEL *match_failed_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
CHECK(pm_compile_pattern_match(iseq, scope_node, cast->value, ret, src, match_failed_label, in_single_pattern, in_alternation_pattern, use_deconstructed_cache, base_index + 1));
|
|
|
|
CHECK(pm_compile_pattern(iseq, scope_node, cast->target, ret, src, matched_label, match_failed_label, in_single_pattern, in_alternation_pattern, false, base_index));
|
|
|
|
ADD_INSN(ret, &line.node, putnil);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, match_failed_label);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSNL(ret, &line.node, jump, unmatched_label);
|
2023-09-28 19:51:33 +03:00
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
2023-09-28 19:36:17 +03:00
|
|
|
case PM_LOCAL_VARIABLE_TARGET_NODE: {
|
|
|
|
// Local variables can be targetted by placing identifiers in the place
|
|
|
|
// of a pattern. For example, foo in bar. This results in the value
|
|
|
|
// being matched being written to that local variable.
|
|
|
|
pm_local_variable_target_node_t *cast = (pm_local_variable_target_node_t *) node;
|
2024-01-12 23:23:47 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, cast->name, cast->depth);
|
2023-09-28 19:36:17 +03:00
|
|
|
|
|
|
|
// If this local variable is being written from within an alternation
|
|
|
|
// pattern, then it cannot actually be added to the local table since
|
|
|
|
// it's ambiguous which value should be used. So instead we indicate
|
|
|
|
// this with a compile error.
|
|
|
|
if (in_alternation_pattern) {
|
2023-10-17 01:36:25 +03:00
|
|
|
ID id = pm_constant_id_lookup(scope_node, cast->name);
|
2023-09-28 19:51:33 +03:00
|
|
|
const char *name = rb_id2name(id);
|
|
|
|
|
2023-09-28 19:36:17 +03:00
|
|
|
if (name && strlen(name) > 0 && name[0] != '_') {
|
2023-09-28 19:51:33 +03:00
|
|
|
COMPILE_ERROR(ERROR_ARGS "illegal variable in alternative pattern (%"PRIsVALUE")", rb_id2str(id));
|
2023-09-28 19:36:17 +03:00
|
|
|
return COMPILE_NG;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &line.node, index.index, index.level);
|
2023-12-13 19:34:05 +03:00
|
|
|
ADD_INSNL(ret, &line.node, jump, matched_label);
|
2023-09-28 19:36:17 +03:00
|
|
|
break;
|
|
|
|
}
|
2023-09-28 19:27:04 +03:00
|
|
|
case PM_ALTERNATION_PATTERN_NODE: {
|
|
|
|
// Alternation patterns allow you to specify multiple patterns in a
|
|
|
|
// single expression using the | operator.
|
|
|
|
pm_alternation_pattern_node_t *cast = (pm_alternation_pattern_node_t *) node;
|
|
|
|
|
2023-12-13 19:34:05 +03:00
|
|
|
LABEL *matched_left_label = NEW_LABEL(line.lineno);
|
|
|
|
LABEL *unmatched_left_label = NEW_LABEL(line.lineno);
|
2023-09-28 19:27:04 +03:00
|
|
|
|
|
|
|
// First, we're going to attempt to match against the left pattern. If
|
|
|
|
// that pattern matches, then we'll skip matching the right pattern.
|
2023-12-13 19:34:05 +03:00
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
CHECK(pm_compile_pattern(iseq, scope_node, cast->left, ret, src, matched_left_label, unmatched_left_label, in_single_pattern, true, true, base_index + 1));
|
2023-09-28 19:27:04 +03:00
|
|
|
|
|
|
|
// If we get here, then we matched on the left pattern. In this case we
|
|
|
|
// should pop out the duplicate value that we preemptively added to
|
|
|
|
// match against the right pattern and then jump to the match label.
|
|
|
|
ADD_LABEL(ret, matched_left_label);
|
2023-12-13 19:34:05 +03:00
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSNL(ret, &line.node, jump, matched_label);
|
|
|
|
ADD_INSN(ret, &line.node, putnil);
|
2023-09-28 19:27:04 +03:00
|
|
|
|
|
|
|
// If we get here, then we didn't match on the left pattern. In this
|
|
|
|
// case we attempt to match against the right pattern.
|
|
|
|
ADD_LABEL(ret, unmatched_left_label);
|
2023-12-13 19:34:05 +03:00
|
|
|
CHECK(pm_compile_pattern(iseq, scope_node, cast->right, ret, src, matched_label, unmatched_label, in_single_pattern, true, true, base_index));
|
2023-09-28 19:19:50 +03:00
|
|
|
break;
|
2023-09-28 19:27:04 +03:00
|
|
|
}
|
2024-01-24 22:24:13 +03:00
|
|
|
case PM_PINNED_EXPRESSION_NODE:
|
|
|
|
// Pinned expressions are a way to match against the value of an
|
|
|
|
// expression that should be evaluated at runtime. This looks like:
|
|
|
|
// foo in ^(bar). To compile these, we compile the expression as if it
|
|
|
|
// were a literal value by falling through to the literal case.
|
|
|
|
node = ((pm_pinned_expression_node_t *) node)->expression;
|
|
|
|
/* fallthrough */
|
2023-09-28 19:14:38 +03:00
|
|
|
case PM_ARRAY_NODE:
|
|
|
|
case PM_CLASS_VARIABLE_READ_NODE:
|
|
|
|
case PM_CONSTANT_PATH_NODE:
|
|
|
|
case PM_CONSTANT_READ_NODE:
|
|
|
|
case PM_FALSE_NODE:
|
|
|
|
case PM_FLOAT_NODE:
|
|
|
|
case PM_GLOBAL_VARIABLE_READ_NODE:
|
|
|
|
case PM_IMAGINARY_NODE:
|
|
|
|
case PM_INSTANCE_VARIABLE_READ_NODE:
|
|
|
|
case PM_INTEGER_NODE:
|
|
|
|
case PM_INTERPOLATED_REGULAR_EXPRESSION_NODE:
|
|
|
|
case PM_INTERPOLATED_STRING_NODE:
|
|
|
|
case PM_INTERPOLATED_SYMBOL_NODE:
|
|
|
|
case PM_INTERPOLATED_X_STRING_NODE:
|
|
|
|
case PM_LAMBDA_NODE:
|
|
|
|
case PM_LOCAL_VARIABLE_READ_NODE:
|
|
|
|
case PM_NIL_NODE:
|
2024-01-24 22:24:13 +03:00
|
|
|
case PM_SOURCE_ENCODING_NODE:
|
|
|
|
case PM_SOURCE_FILE_NODE:
|
|
|
|
case PM_SOURCE_LINE_NODE:
|
2023-09-28 19:14:38 +03:00
|
|
|
case PM_RANGE_NODE:
|
|
|
|
case PM_RATIONAL_NODE:
|
|
|
|
case PM_REGULAR_EXPRESSION_NODE:
|
|
|
|
case PM_SELF_NODE:
|
|
|
|
case PM_STRING_NODE:
|
|
|
|
case PM_SYMBOL_NODE:
|
|
|
|
case PM_TRUE_NODE:
|
2023-12-13 19:34:05 +03:00
|
|
|
case PM_X_STRING_NODE: {
|
2023-09-28 19:58:19 +03:00
|
|
|
// These nodes are all simple patterns, which means we'll use the
|
|
|
|
// checkmatch instruction to match against them, which is effectively a
|
|
|
|
// VM-level === operator.
|
2023-09-28 19:14:38 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(node);
|
2023-12-13 19:34:05 +03:00
|
|
|
if (in_single_pattern) {
|
|
|
|
ADD_INSN1(ret, &line.node, dupn, INT2FIX(2));
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, checkmatch, INT2FIX(VM_CHECKMATCH_TYPE_CASE));
|
|
|
|
|
|
|
|
if (in_single_pattern) {
|
|
|
|
pm_compile_pattern_eqq_error(iseq, scope_node, node, ret, base_index + 2);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &line.node, branchif, matched_label);
|
|
|
|
ADD_INSNL(ret, &line.node, jump, unmatched_label);
|
2023-09-28 19:14:38 +03:00
|
|
|
break;
|
2023-12-13 19:34:05 +03:00
|
|
|
}
|
2023-09-28 19:14:38 +03:00
|
|
|
case PM_PINNED_VARIABLE_NODE: {
|
2023-09-28 19:58:19 +03:00
|
|
|
// Pinned variables are a way to match against the value of a variable
|
|
|
|
// without it looking like you're trying to write to the variable. This
|
|
|
|
// looks like: foo in ^@bar. To compile these, we compile the variable
|
|
|
|
// that they hold.
|
2023-09-28 19:14:38 +03:00
|
|
|
pm_pinned_variable_node_t *cast = (pm_pinned_variable_node_t *) node;
|
2023-12-13 19:34:05 +03:00
|
|
|
CHECK(pm_compile_pattern(iseq, scope_node, cast->variable, ret, src, matched_label, unmatched_label, in_single_pattern, in_alternation_pattern, true, base_index));
|
2023-09-28 19:14:38 +03:00
|
|
|
break;
|
|
|
|
}
|
2023-12-13 19:34:05 +03:00
|
|
|
case PM_IF_NODE:
|
|
|
|
case PM_UNLESS_NODE: {
|
|
|
|
// If and unless nodes can show up here as guards on `in` clauses. This
|
|
|
|
// looks like:
|
|
|
|
//
|
|
|
|
// case foo
|
|
|
|
// in bar if baz?
|
|
|
|
// qux
|
|
|
|
// end
|
|
|
|
//
|
|
|
|
// Because we know they're in the modifier form and they can't have any
|
|
|
|
// variation on this pattern, we compile them differently (more simply)
|
|
|
|
// here than we would in the normal compilation path.
|
|
|
|
const pm_node_t *predicate;
|
|
|
|
const pm_node_t *statement;
|
|
|
|
|
|
|
|
if (PM_NODE_TYPE_P(node, PM_IF_NODE)) {
|
|
|
|
const pm_if_node_t *cast = (const pm_if_node_t *) node;
|
|
|
|
predicate = cast->predicate;
|
|
|
|
|
|
|
|
assert(cast->statements != NULL && cast->statements->body.size == 1);
|
|
|
|
statement = cast->statements->body.nodes[0];
|
|
|
|
} else {
|
|
|
|
const pm_unless_node_t *cast = (const pm_unless_node_t *) node;
|
|
|
|
predicate = cast->predicate;
|
|
|
|
|
|
|
|
assert(cast->statements != NULL && cast->statements->body.size == 1);
|
|
|
|
statement = cast->statements->body.nodes[0];
|
|
|
|
}
|
|
|
|
|
|
|
|
CHECK(pm_compile_pattern_match(iseq, scope_node, statement, ret, src, unmatched_label, in_single_pattern, in_alternation_pattern, use_deconstructed_cache, base_index));
|
|
|
|
PM_COMPILE_NOT_POPPED(predicate);
|
|
|
|
|
|
|
|
if (in_single_pattern) {
|
|
|
|
LABEL *match_succeeded_label = NEW_LABEL(line.lineno);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, dup);
|
|
|
|
if (PM_NODE_TYPE_P(node, PM_IF_NODE)) {
|
|
|
|
ADD_INSNL(ret, &line.node, branchif, match_succeeded_label);
|
|
|
|
} else {
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, match_succeeded_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, rb_fstring_lit("guard clause does not return true"));
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING + 1));
|
|
|
|
ADD_INSN1(ret, &line.node, putobject, Qfalse);
|
|
|
|
ADD_INSN1(ret, &line.node, setn, INT2FIX(base_index + PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P + 2));
|
|
|
|
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
ADD_INSN(ret, &line.node, pop);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, match_succeeded_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (PM_NODE_TYPE_P(node, PM_IF_NODE)) {
|
|
|
|
ADD_INSNL(ret, &line.node, branchunless, unmatched_label);
|
|
|
|
} else {
|
|
|
|
ADD_INSNL(ret, &line.node, branchif, unmatched_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &line.node, jump, matched_label);
|
2023-09-28 19:14:38 +03:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
2023-09-28 19:58:19 +03:00
|
|
|
// If we get here, then we have a node type that should not be in this
|
|
|
|
// position. This would be a bug in the parser, because a different node
|
|
|
|
// type should never have been created in this position in the tree.
|
2023-09-28 19:14:38 +03:00
|
|
|
rb_bug("Unexpected node type in pattern matching expression: %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
|
|
|
break;
|
|
|
|
}
|
2023-09-28 19:51:33 +03:00
|
|
|
|
|
|
|
return COMPILE_OK;
|
2023-09-28 19:14:38 +03:00
|
|
|
}
|
|
|
|
|
2023-12-13 19:34:05 +03:00
|
|
|
#undef PM_PATTERN_BASE_INDEX_OFFSET_DECONSTRUCTED_CACHE
|
|
|
|
#undef PM_PATTERN_BASE_INDEX_OFFSET_ERROR_STRING
|
|
|
|
#undef PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_P
|
|
|
|
#undef PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_MATCHEE
|
|
|
|
#undef PM_PATTERN_BASE_INDEX_OFFSET_KEY_ERROR_KEY
|
|
|
|
|
2023-10-24 22:54:44 +03:00
|
|
|
// Generate a scope node from the given node.
|
|
|
|
void
|
|
|
|
pm_scope_node_init(const pm_node_t *node, pm_scope_node_t *scope, pm_scope_node_t *previous, pm_parser_t *parser)
|
|
|
|
{
|
|
|
|
scope->base.type = PM_SCOPE_NODE;
|
|
|
|
scope->base.location.start = node->location.start;
|
|
|
|
scope->base.location.end = node->location.end;
|
|
|
|
|
|
|
|
scope->previous = previous;
|
|
|
|
scope->parser = parser;
|
|
|
|
scope->ast_node = (pm_node_t *)node;
|
|
|
|
scope->parameters = NULL;
|
|
|
|
scope->body = NULL;
|
|
|
|
scope->constants = NULL;
|
2023-12-06 18:05:14 +03:00
|
|
|
scope->local_table_for_iseq_size = 0;
|
|
|
|
|
2023-10-24 22:54:44 +03:00
|
|
|
if (previous) {
|
|
|
|
scope->constants = previous->constants;
|
|
|
|
}
|
|
|
|
scope->index_lookup_table = NULL;
|
|
|
|
|
|
|
|
pm_constant_id_list_init(&scope->locals);
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(node)) {
|
|
|
|
case PM_BLOCK_NODE: {
|
|
|
|
pm_block_node_t *cast = (pm_block_node_t *) node;
|
|
|
|
scope->body = cast->body;
|
|
|
|
scope->locals = cast->locals;
|
2023-12-06 18:05:14 +03:00
|
|
|
scope->parameters = cast->parameters;
|
2023-10-24 22:54:44 +03:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_CLASS_NODE: {
|
|
|
|
pm_class_node_t *cast = (pm_class_node_t *) node;
|
|
|
|
scope->body = cast->body;
|
|
|
|
scope->locals = cast->locals;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_DEF_NODE: {
|
|
|
|
pm_def_node_t *cast = (pm_def_node_t *) node;
|
2023-12-06 18:05:14 +03:00
|
|
|
scope->parameters = (pm_node_t *)cast->parameters;
|
2023-10-24 22:54:44 +03:00
|
|
|
scope->body = cast->body;
|
|
|
|
scope->locals = cast->locals;
|
|
|
|
break;
|
|
|
|
}
|
2023-11-03 02:29:20 +03:00
|
|
|
case PM_ENSURE_NODE: {
|
2023-12-07 13:24:33 +03:00
|
|
|
scope->body = (pm_node_t *)node;
|
2023-11-03 02:29:20 +03:00
|
|
|
break;
|
|
|
|
}
|
2023-10-24 22:54:44 +03:00
|
|
|
case PM_FOR_NODE: {
|
|
|
|
pm_for_node_t *cast = (pm_for_node_t *)node;
|
|
|
|
scope->body = (pm_node_t *)cast->statements;
|
|
|
|
break;
|
|
|
|
}
|
2023-11-14 02:52:03 +03:00
|
|
|
case PM_INTERPOLATED_REGULAR_EXPRESSION_NODE: {
|
|
|
|
RUBY_ASSERT(node->flags & PM_REGULAR_EXPRESSION_FLAGS_ONCE);
|
|
|
|
scope->body = (pm_node_t *)node;
|
|
|
|
break;
|
|
|
|
}
|
2023-10-24 22:54:44 +03:00
|
|
|
case PM_LAMBDA_NODE: {
|
|
|
|
pm_lambda_node_t *cast = (pm_lambda_node_t *) node;
|
2023-12-06 18:05:14 +03:00
|
|
|
scope->parameters = cast->parameters;
|
2023-10-24 22:54:44 +03:00
|
|
|
scope->body = cast->body;
|
|
|
|
scope->locals = cast->locals;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_MODULE_NODE: {
|
|
|
|
pm_module_node_t *cast = (pm_module_node_t *) node;
|
|
|
|
scope->body = cast->body;
|
|
|
|
scope->locals = cast->locals;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_POST_EXECUTION_NODE: {
|
|
|
|
pm_post_execution_node_t *cast = (pm_post_execution_node_t *) node;
|
|
|
|
scope->body = (pm_node_t *) cast->statements;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_PROGRAM_NODE: {
|
|
|
|
pm_program_node_t *cast = (pm_program_node_t *) node;
|
|
|
|
scope->body = (pm_node_t *) cast->statements;
|
|
|
|
scope->locals = cast->locals;
|
|
|
|
break;
|
|
|
|
}
|
2023-11-10 17:51:14 +03:00
|
|
|
case PM_RESCUE_NODE: {
|
|
|
|
pm_rescue_node_t *cast = (pm_rescue_node_t *)node;
|
|
|
|
scope->body = (pm_node_t *)cast->statements;
|
|
|
|
break;
|
|
|
|
}
|
2023-12-01 17:37:10 +03:00
|
|
|
case PM_RESCUE_MODIFIER_NODE: {
|
|
|
|
pm_rescue_modifier_node_t *cast = (pm_rescue_modifier_node_t *)node;
|
|
|
|
scope->body = (pm_node_t *)cast->rescue_expression;
|
|
|
|
break;
|
|
|
|
}
|
2023-10-24 22:54:44 +03:00
|
|
|
case PM_SINGLETON_CLASS_NODE: {
|
|
|
|
pm_singleton_class_node_t *cast = (pm_singleton_class_node_t *) node;
|
|
|
|
scope->body = cast->body;
|
|
|
|
scope->locals = cast->locals;
|
|
|
|
break;
|
|
|
|
}
|
2023-10-30 23:57:27 +03:00
|
|
|
case PM_STATEMENTS_NODE: {
|
|
|
|
pm_statements_node_t *cast = (pm_statements_node_t *) node;
|
|
|
|
scope->body = (pm_node_t *)cast;
|
|
|
|
break;
|
|
|
|
}
|
2023-10-24 22:54:44 +03:00
|
|
|
default:
|
|
|
|
assert(false && "unreachable");
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-01-18 19:55:31 +03:00
|
|
|
void
|
|
|
|
pm_scope_node_destroy(pm_scope_node_t *scope_node)
|
|
|
|
{
|
|
|
|
if (scope_node->index_lookup_table) {
|
|
|
|
st_free_table(scope_node->index_lookup_table);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-12 01:35:13 +03:00
|
|
|
static void pm_compile_call(rb_iseq_t *iseq, const pm_call_node_t *call_node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, ID method_id, LABEL *start);
|
2023-12-06 01:07:50 +03:00
|
|
|
|
2023-10-25 11:07:26 +03:00
|
|
|
void
|
2023-12-06 01:07:50 +03:00
|
|
|
pm_compile_defined_expr0(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, NODE dummy_line_node, int lineno, bool in_condition, LABEL **lfinish, bool explicit_receiver)
|
2023-10-25 11:07:26 +03:00
|
|
|
{
|
|
|
|
// in_condition is the same as compile.c's needstr
|
|
|
|
enum defined_type dtype = DEFINED_NOT_DEFINED;
|
2023-10-27 00:54:38 +03:00
|
|
|
switch (PM_NODE_TYPE(node)) {
|
2023-12-06 01:07:50 +03:00
|
|
|
case PM_ARGUMENTS_NODE: {
|
|
|
|
const pm_arguments_node_t *cast = (pm_arguments_node_t *) node;
|
|
|
|
const pm_node_list_t *arguments = &cast->arguments;
|
|
|
|
for (size_t idx = 0; idx < arguments->size; idx++) {
|
|
|
|
const pm_node_t *argument = arguments->nodes[idx];
|
|
|
|
pm_compile_defined_expr0(iseq, argument, ret, src, popped, scope_node, dummy_line_node, lineno, in_condition, lfinish, explicit_receiver);
|
|
|
|
|
|
|
|
if (!lfinish[1]) {
|
|
|
|
lfinish[1] = NEW_LABEL(lineno);
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, lfinish[1]);
|
|
|
|
}
|
|
|
|
dtype = DEFINED_TRUE;
|
|
|
|
break;
|
|
|
|
}
|
2023-12-01 22:52:38 +03:00
|
|
|
case PM_NIL_NODE:
|
2023-10-25 11:07:26 +03:00
|
|
|
dtype = DEFINED_NIL;
|
|
|
|
break;
|
2023-12-04 23:01:51 +03:00
|
|
|
case PM_PARENTHESES_NODE: {
|
|
|
|
pm_parentheses_node_t *parentheses_node = (pm_parentheses_node_t *) node;
|
|
|
|
|
|
|
|
if (parentheses_node->body == NULL) {
|
|
|
|
dtype = DEFINED_NIL;
|
|
|
|
} else {
|
|
|
|
dtype = DEFINED_EXPR;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_SELF_NODE:
|
|
|
|
dtype = DEFINED_SELF;
|
|
|
|
break;
|
|
|
|
case PM_TRUE_NODE:
|
|
|
|
dtype = DEFINED_TRUE;
|
|
|
|
break;
|
|
|
|
case PM_FALSE_NODE:
|
|
|
|
dtype = DEFINED_FALSE;
|
|
|
|
break;
|
2023-10-27 20:44:41 +03:00
|
|
|
case PM_ARRAY_NODE: {
|
2023-12-06 01:07:50 +03:00
|
|
|
pm_array_node_t *array_node = (pm_array_node_t *) node;
|
|
|
|
if (!(array_node->base.flags & PM_ARRAY_NODE_FLAGS_CONTAINS_SPLAT)) {
|
|
|
|
for (size_t index = 0; index < array_node->elements.size; index++) {
|
|
|
|
pm_compile_defined_expr0(iseq, array_node->elements.nodes[index], ret, src, popped, scope_node, dummy_line_node, lineno, true, lfinish, false);
|
|
|
|
if (!lfinish[1]) {
|
|
|
|
lfinish[1] = NEW_LABEL(lineno);
|
|
|
|
}
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, lfinish[1]);
|
2023-12-05 21:47:46 +03:00
|
|
|
}
|
2023-12-06 01:07:50 +03:00
|
|
|
}
|
2023-10-27 20:44:41 +03:00
|
|
|
}
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_AND_NODE:
|
2024-01-16 23:50:45 +03:00
|
|
|
case PM_BEGIN_NODE:
|
2024-01-16 23:16:31 +03:00
|
|
|
case PM_BREAK_NODE:
|
2024-01-17 18:37:14 +03:00
|
|
|
case PM_CASE_NODE:
|
2024-01-17 18:38:33 +03:00
|
|
|
case PM_CASE_MATCH_NODE:
|
2024-01-17 18:40:57 +03:00
|
|
|
case PM_CLASS_NODE:
|
2024-01-17 18:42:22 +03:00
|
|
|
case PM_DEF_NODE:
|
2024-01-16 23:24:55 +03:00
|
|
|
case PM_DEFINED_NODE:
|
2023-12-01 22:28:54 +03:00
|
|
|
case PM_FLOAT_NODE:
|
2024-01-17 18:44:01 +03:00
|
|
|
case PM_FOR_NODE:
|
2023-12-01 22:28:54 +03:00
|
|
|
case PM_HASH_NODE:
|
2024-01-17 18:45:48 +03:00
|
|
|
case PM_IF_NODE:
|
2023-12-05 20:04:56 +03:00
|
|
|
case PM_IMAGINARY_NODE:
|
2023-12-01 22:28:54 +03:00
|
|
|
case PM_INTEGER_NODE:
|
2023-12-04 23:22:10 +03:00
|
|
|
case PM_INTERPOLATED_REGULAR_EXPRESSION_NODE:
|
2023-12-04 23:10:12 +03:00
|
|
|
case PM_INTERPOLATED_STRING_NODE:
|
2024-01-16 23:31:24 +03:00
|
|
|
case PM_INTERPOLATED_SYMBOL_NODE:
|
2024-01-16 23:40:54 +03:00
|
|
|
case PM_INTERPOLATED_X_STRING_NODE:
|
[PRISM] Implement `PM_KEYWORD_HASH_NODE` for `defined?`
Ruby code:
```ruby
defined? [a: [:b, :c]]
```
Instructions (without optimizations):
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(0,23)>
== catch table
| catch type: rescue st: 0001 ed: 0007 sp: 0000 cont: 0009
| == disasm: #<ISeq:defined guard in <compiled>@<compiled>:0 (0,0)-(-1,-1)>
| local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
| [ 1] "$!"@0
| 0000 putnil
| 0001 leave
|------------------------------------------------------------------------
0000 putnil
0001 putobject true
0003 branchunless 9
0005 putobject "expression"
0007 swap
0008 pop
0009 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(0,23)>
== catch table
| catch type: rescue st: 0000 ed: 0009 sp: 0000 cont: 0009
| == disasm: #<ISeq:defined guard in <compiled>@<compiled>:0 (0,0)-(-1,-1)>
| local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
| [ 1] "$!"@0
| 0000 putnil
| 0001 leave
|------------------------------------------------------------------------
0000 putnil
0001 putobject true
0003 branchunless 9
0005 putobject "expression"
0007 swap
0008 pop
0009 leave
```
Instructions (with optimizations):
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(0,23)>
== catch table
| catch type: rescue st: 0001 ed: 0003 sp: 0000 cont: 0005
| == disasm: #<ISeq:defined guard in <compiled>@<compiled>:0 (0,0)-(-1,-1)>
| local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
| [ 1] "$!"@0
| 0000 putnil
| 0001 leave
|------------------------------------------------------------------------
0000 putnil
0001 putobject "expression"
0003 swap
0004 pop
0005 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(0,23)>
== catch table
| catch type: rescue st: 0000 ed: 0005 sp: 0000 cont: 0005
| == disasm: #<ISeq:defined guard in <compiled>@<compiled>:0 (0,0)-(-1,-1)>
| local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
| [ 1] "$!"@0
| 0000 putnil
| 0001 leave
|------------------------------------------------------------------------
0000 putnil
0001 putobject "expression"
0003 swap
0004 pop
0005 leave
```
2023-12-05 22:06:01 +03:00
|
|
|
case PM_KEYWORD_HASH_NODE:
|
2023-12-01 22:28:54 +03:00
|
|
|
case PM_LAMBDA_NODE:
|
2023-12-05 22:08:21 +03:00
|
|
|
case PM_MATCH_PREDICATE_NODE:
|
2024-01-17 18:49:29 +03:00
|
|
|
case PM_MATCH_REQUIRED_NODE:
|
[Prism] Implement defined? for PM_MATCH_WRITE_NODE
Ruby code:
```ruby
defined?(/(?<foo>bar)/ =~ 'barbar')
```
Instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(59,35)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] foo@0
0000 putobject "expression" ( 59)[Li]
0002 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:58 (58,0)-(58,35)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] foo@0
0000 putobject "expression" ( 58)[Li]
0002 leave
```
Related: ruby/prism#2188
2024-01-17 18:47:50 +03:00
|
|
|
case PM_MATCH_WRITE_NODE:
|
2024-01-17 18:50:58 +03:00
|
|
|
case PM_MODULE_NODE:
|
2024-01-16 23:10:39 +03:00
|
|
|
case PM_NEXT_NODE:
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_OR_NODE:
|
2023-12-01 22:28:54 +03:00
|
|
|
case PM_RANGE_NODE:
|
2024-01-17 19:00:08 +03:00
|
|
|
case PM_RATIONAL_NODE:
|
2024-01-16 23:43:24 +03:00
|
|
|
case PM_REDO_NODE:
|
2023-12-01 22:28:54 +03:00
|
|
|
case PM_REGULAR_EXPRESSION_NODE:
|
2024-01-16 23:47:10 +03:00
|
|
|
case PM_RETRY_NODE:
|
2024-01-16 23:44:58 +03:00
|
|
|
case PM_RETURN_NODE:
|
2024-01-17 19:03:28 +03:00
|
|
|
case PM_SINGLETON_CLASS_NODE:
|
2023-12-05 20:07:26 +03:00
|
|
|
case PM_SOURCE_ENCODING_NODE:
|
2023-12-05 20:12:44 +03:00
|
|
|
case PM_SOURCE_FILE_NODE:
|
2023-12-05 20:14:41 +03:00
|
|
|
case PM_SOURCE_LINE_NODE:
|
2023-12-01 22:28:54 +03:00
|
|
|
case PM_STRING_NODE:
|
|
|
|
case PM_SYMBOL_NODE:
|
2024-01-17 19:40:01 +03:00
|
|
|
case PM_UNLESS_NODE:
|
2024-01-17 19:38:02 +03:00
|
|
|
case PM_UNTIL_NODE:
|
2024-01-17 19:36:45 +03:00
|
|
|
case PM_WHILE_NODE:
|
2023-12-04 23:40:43 +03:00
|
|
|
case PM_X_STRING_NODE:
|
2023-10-25 11:07:26 +03:00
|
|
|
dtype = DEFINED_EXPR;
|
|
|
|
break;
|
|
|
|
case PM_LOCAL_VARIABLE_READ_NODE:
|
|
|
|
dtype = DEFINED_LVAR;
|
|
|
|
break;
|
|
|
|
#define PUSH_VAL(type) (in_condition ? Qtrue : rb_iseq_defined_string(type))
|
|
|
|
case PM_INSTANCE_VARIABLE_READ_NODE: {
|
2023-10-27 00:54:38 +03:00
|
|
|
pm_instance_variable_read_node_t *instance_variable_read_node = (pm_instance_variable_read_node_t *)node;
|
2023-10-25 11:07:26 +03:00
|
|
|
ID id = pm_constant_id_lookup(scope_node, instance_variable_read_node->name);
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, definedivar,
|
|
|
|
ID2SYM(id), get_ivar_ic_value(iseq, id), PUSH_VAL(DEFINED_IVAR));
|
|
|
|
return;
|
|
|
|
}
|
[Prism] Implement backref and numbered reference for `defined?`
This PR implements `PM_BACK_REFERENCE_READ_NODE` and
`PM_NUMBERED_REFERENCE_READ_NODE` for `defined?`. The following now
works:
* `PM_NUMBERED_REFERENCE_READ_NODE`
```
defined? $1
defined? $2
```
Instructions:
```
"********* RUBY *************"
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(0,12)>
0000 putnil
0001 defined ref, :$1, "global-variable"
0005 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(0,12)>
0000 putnil
0001 defined ref, :$1, "global-variable"
0005 leave
```
* `PM_BACK_REFERENCE_READ_NODE`
```
defined? $'
defined? $`
defined? $&
```
Instructions:
```
"********* RUBY *************"
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(0,12)>
0000 putnil
0001 defined ref, :$`, "global-variable"
0005 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(0,12)>
0000 putnil
0001 defined ref, :$`, "global-variable"
0005 leave
```
2023-12-04 19:45:42 +03:00
|
|
|
case PM_BACK_REFERENCE_READ_NODE: {
|
|
|
|
char *char_ptr = (char *)(node->location.start) + 1;
|
|
|
|
ID backref_val = INT2FIX(rb_intern2(char_ptr, 1)) << 1 | 1;
|
|
|
|
|
|
|
|
PM_PUTNIL;
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_REF),
|
|
|
|
backref_val,
|
|
|
|
PUSH_VAL(DEFINED_GVAR));
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
case PM_NUMBERED_REFERENCE_READ_NODE: {
|
|
|
|
uint32_t reference_number = ((pm_numbered_reference_read_node_t *)node)->number;
|
|
|
|
|
|
|
|
PM_PUTNIL;
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_REF),
|
|
|
|
INT2FIX(reference_number << 1),
|
|
|
|
PUSH_VAL(DEFINED_GVAR));
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_GLOBAL_VARIABLE_READ_NODE: {
|
2023-10-27 00:54:38 +03:00
|
|
|
pm_global_variable_read_node_t *glabal_variable_read_node = (pm_global_variable_read_node_t *)node;
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-25 11:07:26 +03:00
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_GVAR),
|
|
|
|
ID2SYM(pm_constant_id_lookup(scope_node, glabal_variable_read_node->name)), PUSH_VAL(DEFINED_GVAR));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
case PM_CLASS_VARIABLE_READ_NODE: {
|
2023-10-27 00:54:38 +03:00
|
|
|
pm_class_variable_read_node_t *class_variable_read_node = (pm_class_variable_read_node_t *)node;
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-25 11:07:26 +03:00
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_CVAR),
|
|
|
|
ID2SYM(pm_constant_id_lookup(scope_node, class_variable_read_node->name)), PUSH_VAL(DEFINED_CVAR));
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
case PM_CONSTANT_READ_NODE: {
|
2023-10-27 00:54:38 +03:00
|
|
|
pm_constant_read_node_t *constant_node = (pm_constant_read_node_t *)node;
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-25 11:07:26 +03:00
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_CONST),
|
|
|
|
ID2SYM(pm_constant_id_lookup(scope_node, constant_node->name)), PUSH_VAL(DEFINED_CONST));
|
|
|
|
return;
|
|
|
|
}
|
2023-10-27 00:54:38 +03:00
|
|
|
case PM_CONSTANT_PATH_NODE: {
|
|
|
|
pm_constant_path_node_t *constant_path_node = ((pm_constant_path_node_t *)node);
|
|
|
|
if (constant_path_node->parent) {
|
|
|
|
if (!lfinish[1]) {
|
|
|
|
lfinish[1] = NEW_LABEL(lineno);
|
|
|
|
}
|
2023-12-06 01:07:50 +03:00
|
|
|
pm_compile_defined_expr0(iseq, constant_path_node->parent, ret, src, popped, scope_node, dummy_line_node, lineno, true, lfinish, false);
|
2023-10-27 00:54:38 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, lfinish[1]);
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(constant_path_node->parent);
|
2023-12-06 01:07:50 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-10-27 00:54:38 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_cObject);
|
|
|
|
}
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_CONST_FROM),
|
|
|
|
ID2SYM(pm_constant_id_lookup(scope_node, ((pm_constant_read_node_t *)constant_path_node->child)->name)), PUSH_VAL(DEFINED_CONST));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-12-06 01:07:50 +03:00
|
|
|
case PM_CALL_NODE: {
|
|
|
|
pm_call_node_t *call_node = ((pm_call_node_t *)node);
|
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, call_node->name);
|
|
|
|
|
|
|
|
if (call_node->receiver || call_node->arguments) {
|
|
|
|
if (!lfinish[1]) {
|
|
|
|
lfinish[1] = NEW_LABEL(lineno);
|
|
|
|
}
|
|
|
|
if (!lfinish[2]) {
|
|
|
|
lfinish[2] = NEW_LABEL(lineno);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (call_node->arguments) {
|
|
|
|
pm_compile_defined_expr0(iseq, (const pm_node_t *)call_node->arguments, ret, src, popped, scope_node, dummy_line_node, lineno, true, lfinish, false);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, lfinish[1]);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (call_node->receiver) {
|
|
|
|
pm_compile_defined_expr0(iseq, call_node->receiver, ret, src, popped, scope_node, dummy_line_node, lineno, true, lfinish, true);
|
|
|
|
if (PM_NODE_TYPE_P(call_node->receiver, PM_CALL_NODE)) {
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, lfinish[2]);
|
2024-01-15 23:08:39 +03:00
|
|
|
|
|
|
|
const pm_call_node_t *receiver = (const pm_call_node_t *)call_node->receiver;
|
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, receiver->name);
|
|
|
|
pm_compile_call(iseq, receiver, ret, src, popped, scope_node, method_id, NULL);
|
2023-12-06 01:07:50 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, lfinish[1]);
|
|
|
|
PM_COMPILE(call_node->receiver);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (explicit_receiver) {
|
|
|
|
PM_DUP;
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_METHOD), rb_id2sym(method_id), PUSH_VAL(DEFINED_METHOD));
|
|
|
|
}
|
|
|
|
else {
|
2023-12-12 19:08:40 +03:00
|
|
|
PM_PUTSELF;
|
2023-12-06 01:07:50 +03:00
|
|
|
if (explicit_receiver) {
|
|
|
|
PM_DUP;
|
|
|
|
}
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_FUNC), rb_id2sym(method_id), PUSH_VAL(DEFINED_METHOD));
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_YIELD_NODE:
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-25 11:07:26 +03:00
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_YIELD), 0,
|
|
|
|
PUSH_VAL(DEFINED_YIELD));
|
|
|
|
return;
|
|
|
|
case PM_SUPER_NODE:
|
|
|
|
case PM_FORWARDING_SUPER_NODE:
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-25 11:07:26 +03:00
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_ZSUPER), 0,
|
|
|
|
PUSH_VAL(DEFINED_ZSUPER));
|
|
|
|
return;
|
2024-01-17 00:11:24 +03:00
|
|
|
case PM_CALL_AND_WRITE_NODE:
|
2024-01-17 18:01:38 +03:00
|
|
|
case PM_CALL_OPERATOR_WRITE_NODE:
|
2024-01-17 18:03:36 +03:00
|
|
|
case PM_CALL_OR_WRITE_NODE:
|
2024-01-17 18:01:38 +03:00
|
|
|
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_CONSTANT_WRITE_NODE:
|
|
|
|
case PM_CONSTANT_OPERATOR_WRITE_NODE:
|
|
|
|
case PM_CONSTANT_AND_WRITE_NODE:
|
|
|
|
case PM_CONSTANT_OR_WRITE_NODE:
|
|
|
|
|
2024-01-17 18:05:58 +03:00
|
|
|
case PM_CONSTANT_PATH_AND_WRITE_NODE:
|
2024-01-17 18:09:18 +03:00
|
|
|
case PM_CONSTANT_PATH_OPERATOR_WRITE_NODE:
|
2024-01-17 18:12:49 +03:00
|
|
|
case PM_CONSTANT_PATH_OR_WRITE_NODE:
|
2024-01-17 18:18:02 +03:00
|
|
|
case PM_CONSTANT_PATH_WRITE_NODE:
|
2024-01-17 18:05:58 +03:00
|
|
|
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_GLOBAL_VARIABLE_WRITE_NODE:
|
|
|
|
case PM_GLOBAL_VARIABLE_OPERATOR_WRITE_NODE:
|
|
|
|
case PM_GLOBAL_VARIABLE_AND_WRITE_NODE:
|
|
|
|
case PM_GLOBAL_VARIABLE_OR_WRITE_NODE:
|
|
|
|
|
|
|
|
case PM_CLASS_VARIABLE_WRITE_NODE:
|
|
|
|
case PM_CLASS_VARIABLE_OPERATOR_WRITE_NODE:
|
|
|
|
case PM_CLASS_VARIABLE_AND_WRITE_NODE:
|
|
|
|
case PM_CLASS_VARIABLE_OR_WRITE_NODE:
|
|
|
|
|
2024-01-17 18:22:01 +03:00
|
|
|
case PM_INDEX_AND_WRITE_NODE:
|
2024-01-17 18:23:23 +03:00
|
|
|
case PM_INDEX_OPERATOR_WRITE_NODE:
|
2024-01-17 18:24:34 +03:00
|
|
|
case PM_INDEX_OR_WRITE_NODE:
|
2024-01-17 18:22:01 +03:00
|
|
|
|
2023-10-25 11:07:26 +03:00
|
|
|
case PM_INSTANCE_VARIABLE_WRITE_NODE:
|
|
|
|
case PM_INSTANCE_VARIABLE_OPERATOR_WRITE_NODE:
|
|
|
|
case PM_INSTANCE_VARIABLE_AND_WRITE_NODE:
|
|
|
|
case PM_INSTANCE_VARIABLE_OR_WRITE_NODE:
|
|
|
|
|
|
|
|
case PM_LOCAL_VARIABLE_WRITE_NODE:
|
|
|
|
case PM_LOCAL_VARIABLE_OPERATOR_WRITE_NODE:
|
|
|
|
case PM_LOCAL_VARIABLE_AND_WRITE_NODE:
|
|
|
|
case PM_LOCAL_VARIABLE_OR_WRITE_NODE:
|
|
|
|
|
|
|
|
case PM_MULTI_WRITE_NODE:
|
|
|
|
dtype = DEFINED_ASGN;
|
|
|
|
break;
|
|
|
|
default:
|
2023-11-30 01:39:26 +03:00
|
|
|
rb_bug("Unsupported node %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
2023-10-25 11:07:26 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
assert(dtype != DEFINED_NOT_DEFINED);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, PUSH_VAL(dtype));
|
|
|
|
#undef PUSH_VAL
|
|
|
|
}
|
|
|
|
|
2023-12-06 01:07:50 +03:00
|
|
|
static void
|
|
|
|
pm_defined_expr(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, NODE dummy_line_node, int lineno, bool in_condition, LABEL **lfinish, bool explicit_receiver)
|
2023-10-27 00:54:38 +03:00
|
|
|
{
|
2023-12-06 01:07:50 +03:00
|
|
|
LINK_ELEMENT *lcur = ret->last;
|
2023-10-27 00:54:38 +03:00
|
|
|
|
2023-12-06 01:07:50 +03:00
|
|
|
pm_compile_defined_expr0(iseq, node, ret, src, popped, scope_node, dummy_line_node, lineno, in_condition, lfinish, false);
|
2023-10-27 00:54:38 +03:00
|
|
|
|
|
|
|
if (lfinish[1]) {
|
2023-11-30 01:39:26 +03:00
|
|
|
LABEL *lstart = NEW_LABEL(lineno);
|
|
|
|
LABEL *lend = NEW_LABEL(lineno);
|
|
|
|
|
2023-12-06 01:07:50 +03:00
|
|
|
struct rb_iseq_new_with_callback_callback_func *ifunc =
|
|
|
|
rb_iseq_new_with_callback_new_callback(build_defined_rescue_iseq, NULL);
|
|
|
|
|
2023-11-30 01:39:26 +03:00
|
|
|
const rb_iseq_t *rescue = new_child_iseq_with_callback(iseq, ifunc,
|
|
|
|
rb_str_concat(rb_str_new2("defined guard in "),
|
|
|
|
ISEQ_BODY(iseq)->location.label),
|
|
|
|
iseq, ISEQ_TYPE_RESCUE, 0);
|
|
|
|
|
|
|
|
lstart->rescued = LABEL_RESCUE_BEG;
|
|
|
|
lend->rescued = LABEL_RESCUE_END;
|
|
|
|
|
2023-12-06 01:07:50 +03:00
|
|
|
APPEND_LABEL(ret, lcur, lstart);
|
|
|
|
ADD_LABEL(ret, lend);
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_RESCUE, lstart, lend, rescue, lfinish[1]);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
pm_compile_defined_expr(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, NODE dummy_line_node, int lineno, bool in_condition)
|
|
|
|
{
|
|
|
|
LABEL *lfinish[3];
|
|
|
|
LINK_ELEMENT *last = ret->last;
|
|
|
|
|
|
|
|
lfinish[0] = NEW_LABEL(lineno);
|
|
|
|
lfinish[1] = 0;
|
|
|
|
lfinish[2] = 0;
|
|
|
|
|
|
|
|
if (!popped) {
|
|
|
|
pm_defined_expr(iseq, node, ret, src, popped, scope_node, dummy_line_node, lineno, in_condition, lfinish, false);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (lfinish[1]) {
|
2023-10-27 00:54:38 +03:00
|
|
|
ELEM_INSERT_NEXT(last, &new_insn_body(iseq, &dummy_line_node, BIN(putnil), 0)->link);
|
2023-12-12 19:08:40 +03:00
|
|
|
PM_SWAP;
|
2023-12-06 01:07:50 +03:00
|
|
|
if (lfinish[2]) {
|
|
|
|
ADD_LABEL(ret, lfinish[2]);
|
|
|
|
}
|
2023-12-12 19:08:40 +03:00
|
|
|
PM_POP;
|
2023-10-27 00:54:38 +03:00
|
|
|
ADD_LABEL(ret, lfinish[1]);
|
2023-12-06 01:07:50 +03:00
|
|
|
|
2023-10-27 00:54:38 +03:00
|
|
|
}
|
|
|
|
ADD_LABEL(ret, lfinish[0]);
|
|
|
|
}
|
|
|
|
|
2023-12-06 01:07:50 +03:00
|
|
|
static void
|
2023-12-12 01:35:13 +03:00
|
|
|
pm_compile_call(rb_iseq_t *iseq, const pm_call_node_t *call_node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node, ID method_id, LABEL *start)
|
2023-12-06 01:07:50 +03:00
|
|
|
{
|
|
|
|
pm_parser_t *parser = scope_node->parser;
|
|
|
|
pm_newline_list_t newline_list = parser->newline_list;
|
|
|
|
int lineno = (int)pm_newline_list_line_column(&newline_list, ((pm_node_t *)call_node)->location.start).line;
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
2023-12-15 00:44:38 +03:00
|
|
|
LABEL *else_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
2023-12-06 01:07:50 +03:00
|
|
|
|
2023-12-12 22:24:00 +03:00
|
|
|
pm_node_t *pm_node = (pm_node_t *)call_node;
|
|
|
|
|
2023-12-15 00:44:38 +03:00
|
|
|
if (call_node->base.flags & PM_CALL_NODE_FLAGS_SAFE_NAVIGATION) {
|
|
|
|
PM_DUP;
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchnil, else_label);
|
|
|
|
}
|
|
|
|
|
2023-12-06 01:07:50 +03:00
|
|
|
int flags = 0;
|
|
|
|
struct rb_callinfo_kwarg *kw_arg = NULL;
|
|
|
|
|
|
|
|
int orig_argc = pm_setup_args(call_node->arguments, &flags, &kw_arg, iseq, ret, src, popped, scope_node, dummy_line_node, parser);
|
|
|
|
|
|
|
|
const rb_iseq_t *block_iseq = NULL;
|
|
|
|
if (call_node->block != NULL && PM_NODE_TYPE_P(call_node->block, PM_BLOCK_NODE)) {
|
|
|
|
// Scope associated with the block
|
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init(call_node->block, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
block_iseq = NEW_CHILD_ISEQ(&next_scope_node, make_name_for_block(iseq), ISEQ_TYPE_BLOCK, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
|
|
|
|
2023-12-12 01:35:13 +03:00
|
|
|
if (ISEQ_BODY(block_iseq)->catch_table) {
|
2023-12-15 00:44:38 +03:00
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_BREAK, start, end_label, block_iseq, end_label);
|
2023-12-12 01:35:13 +03:00
|
|
|
}
|
2023-12-06 01:07:50 +03:00
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = block_iseq;
|
|
|
|
}
|
|
|
|
else {
|
2023-12-12 22:24:00 +03:00
|
|
|
if (pm_node->flags & PM_CALL_NODE_FLAGS_VARIABLE_CALL) {
|
2023-12-06 01:07:50 +03:00
|
|
|
flags |= VM_CALL_VCALL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (call_node->block != NULL) {
|
|
|
|
PM_COMPILE_NOT_POPPED(call_node->block);
|
|
|
|
flags |= VM_CALL_ARGS_BLOCKARG;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!flags) {
|
|
|
|
flags |= VM_CALL_ARGS_SIMPLE;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-12 23:56:03 +03:00
|
|
|
if (call_node->receiver == NULL || PM_NODE_TYPE_P(call_node->receiver, PM_SELF_NODE)) {
|
2023-12-06 01:07:50 +03:00
|
|
|
flags |= VM_CALL_FCALL;
|
|
|
|
}
|
|
|
|
|
2023-12-12 22:24:00 +03:00
|
|
|
if (pm_node->flags & PM_CALL_NODE_FLAGS_ATTRIBUTE_WRITE) {
|
2024-01-22 23:00:36 +03:00
|
|
|
if (flags & VM_CALL_ARGS_BLOCKARG) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(1));
|
2024-01-22 23:13:33 +03:00
|
|
|
if (flags & VM_CALL_ARGS_SPLAT) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, INT2FIX(-1));
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, idAREF, INT2FIX(1), INT2FIX(0));
|
|
|
|
}
|
2024-01-22 23:00:36 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, setn, INT2FIX(orig_argc + 3));
|
|
|
|
PM_POP;
|
|
|
|
}
|
|
|
|
else if (flags & VM_CALL_ARGS_SPLAT) {
|
2024-01-11 20:27:50 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, dup);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, INT2FIX(-1));
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, idAREF, INT2FIX(1), INT2FIX(0));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setn, INT2FIX(orig_argc + 2));
|
2024-01-22 23:16:14 +03:00
|
|
|
PM_POP;
|
2024-01-11 20:27:50 +03:00
|
|
|
}
|
|
|
|
else if (!popped) {
|
[PRISM] Fix incorrect instructions for `default_proc=`
This is kind of specific and was found via debugging ruby/prism#2061 but
does not actually fix that issue.
The change here checks for `!popped` for the additional instructions
that are normally added for nodes with the `attribute_write` flag.
I also removed the extra catch table by deleting the
`ISEQ_COMPILE_DATA(iseq)->catch_except_p = true;` line. I'm...not
entirely sure why it was added but it doesn't match the upstream
compiler
[code](https://github.com/ruby/ruby/blob/92b10f5be7453aceb5863e46ac775a4ddbf83b97/compile.c#L887-L892).
The changes here unfortunately don't improve the test failures mentioned in
the linked issue so we still have other issues with instructions for
hashes.
Instructions before:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(34,8)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] h@0
0000 putnil ( 32)[Li]
0001 putobject true
0003 getconstant :Hash
0005 send <calldata!mid:new, argc:0, ARGS_SIMPLE>, nil
0008 setlocal h@0, 0
0011 getlocal h@0, 0 ( 33)[Li]
0014 putspecialobject 1
0016 send <calldata!mid:lambda, argc:0, FCALL>, block in <compiled>
0019 send <calldata!mid:default_proc=, argc:1, ARGS_SIMPLE>, nil
0022 pop
0023 getlocal h@0, 0 ( 34)[Li]
0026 putobject :nope
0028 send <calldata!mid:[], argc:1, ARGS_SIMPLE>, nil
0031 leave
== disasm: #<ISeq:block in <compiled>@<compiled>:33 (33,19)-(33,32)>
local table (size: 2, argc: 2 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 2] _@0<Arg> [ 1] _@1<Arg>
0000 putobject true ( 33)[LiBc]
0002 leave [Br]
true
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:31 (31,0)-(33,8)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] h@0
0000 putnil ( 31)[Li]
0001 putobject true
0003 getconstant :Hash
0005 send <calldata!mid:new, argc:0, ARGS_SIMPLE>, nil
0008 setlocal h@0, 0
0011 putnil ( 32)[Li]
0012 getlocal h@0, 0
0015 putspecialobject 1
0017 send <calldata!mid:lambda, argc:0, FCALL>, block in <compiled>
0020 setn 2
0022 send <calldata!mid:default_proc=, argc:1, ARGS_SIMPLE>, nil
0025 pop
0026 pop
0027 getlocal h@0, 0 ( 33)[Li]
0030 putobject :nope
0032 send <calldata!mid:[], argc:1, ARGS_SIMPLE>, nil
0035 leave ( 31)
== disasm: #<ISeq:block in <compiled>@<compiled>:32 (32,17)-(32,32)>
== catch table
| catch type: redo st: 0000 ed: 0002 sp: 0000 cont: 0000
| catch type: next st: 0000 ed: 0002 sp: 0000 cont: 0002
|------------------------------------------------------------------------
local table (size: 2, argc: 2 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 2] _@0<Arg> [ 1] _@1<Arg>
0000 putobject true ( 32)[LiBc]
0002 leave [Br]
```
Instructions after:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(34,8)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] h@0
0000 putnil ( 32)[Li]
0001 putobject true
0003 getconstant :Hash
0005 send <calldata!mid:new, argc:0, ARGS_SIMPLE>, nil
0008 setlocal h@0, 0
0011 getlocal h@0, 0 ( 33)[Li]
0014 putspecialobject 1
0016 send <calldata!mid:lambda, argc:0, FCALL>, block in <compiled>
0019 send <calldata!mid:default_proc=, argc:1, ARGS_SIMPLE>, nil
0022 pop
0023 getlocal h@0, 0 ( 34)[Li]
0026 putobject :nope
0028 send <calldata!mid:[], argc:1, ARGS_SIMPLE>, nil
0031 leave
== disasm: #<ISeq:block in <compiled>@<compiled>:33 (33,19)-(33,32)>
local table (size: 2, argc: 2 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 2] _@0<Arg> [ 1] _@1<Arg>
0000 putobject true ( 33)[LiBc]
0002 leave [Br]
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:31 (31,0)-(33,8)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] h@0
0000 putnil ( 31)[Li]
0001 putobject true
0003 getconstant :Hash
0005 send <calldata!mid:new, argc:0, ARGS_SIMPLE>, nil
0008 setlocal h@0, 0
0011 getlocal h@0, 0 ( 32)[Li]
0014 putspecialobject 1
0016 send <calldata!mid:lambda, argc:0, FCALL>, block in <compiled>
0019 send <calldata!mid:default_proc=, argc:1, ARGS_SIMPLE>, nil
0022 pop
0023 getlocal h@0, 0 ( 33)[Li]
0026 putobject :nope
0028 send <calldata!mid:[], argc:1, ARGS_SIMPLE>, nil
0031 leave ( 31)
== disasm: #<ISeq:block in <compiled>@<compiled>:32 (32,17)-(32,32)>
local table (size: 2, argc: 2 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 2] _@0<Arg> [ 1] _@1<Arg>
0000 putobject true ( 32)[LiBc]
0002 leave [Br]
```
2023-12-15 19:32:10 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, setn, INT2FIX(orig_argc + 1));
|
|
|
|
}
|
2024-01-29 17:47:52 +03:00
|
|
|
}
|
2024-01-11 20:27:50 +03:00
|
|
|
|
2024-01-29 17:47:52 +03:00
|
|
|
if ((flags & VM_CALL_KW_SPLAT) && (flags & VM_CALL_ARGS_BLOCKARG) && !(flags & VM_CALL_KW_SPLAT_MUT)) {
|
|
|
|
ADD_INSN(ret, &dummy_line_node, splatkw);
|
[PRISM] Fix `PM_CALL_NODE` assignment
This PR fixes ruby/prism#1963. Array and variable assignment was broken
for call nodes. The change checks if the `method_id` is related to
assignment and if is adds a `putnil`, `setn` and a `pop`.
The incorrect instructions meant that in some cases (demonstrated in
tests) the wrong value would be returned.
I verified that this fixes the test mentioned in the issue
(run: `RUBY_ISEQ_DUMP_DEBUG=prism make test/-ext-/st/test_numhash.rb`)
Incorrect instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(4,10)>
0000 putnil ( 4)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:3 (3,0)-(3,10)>
0000 putself ( 3)[Li]
0001 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0004 putself
0005 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0008 putself
0009 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0012 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0015 leave
```
Fixed instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(4,10)>
0000 putnil ( 4)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:3 (3,0)-(3,10)>
0000 putnil ( 3)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
```
Fixes ruby/prism#1963
2023-12-08 23:00:48 +03:00
|
|
|
}
|
2024-01-29 17:47:52 +03:00
|
|
|
|
|
|
|
ADD_SEND_R(ret, &dummy_line_node, method_id, INT2FIX(orig_argc), block_iseq, INT2FIX(flags), kw_arg);
|
|
|
|
|
|
|
|
if (pm_node->flags & PM_CALL_NODE_FLAGS_ATTRIBUTE_WRITE) {
|
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-12-12 22:24:00 +03:00
|
|
|
}
|
2023-12-15 00:44:38 +03:00
|
|
|
|
|
|
|
if (call_node->base.flags & PM_CALL_NODE_FLAGS_SAFE_NAVIGATION) {
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, end_label);
|
|
|
|
ADD_LABEL(ret, else_label);
|
|
|
|
}
|
2024-01-26 20:17:04 +03:00
|
|
|
|
|
|
|
if ((block_iseq && ISEQ_BODY(block_iseq)->catch_table) || (call_node->base.flags & PM_CALL_NODE_FLAGS_SAFE_NAVIGATION)) {
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
}
|
[PRISM] Fix `PM_CALL_NODE` assignment
This PR fixes ruby/prism#1963. Array and variable assignment was broken
for call nodes. The change checks if the `method_id` is related to
assignment and if is adds a `putnil`, `setn` and a `pop`.
The incorrect instructions meant that in some cases (demonstrated in
tests) the wrong value would be returned.
I verified that this fixes the test mentioned in the issue
(run: `RUBY_ISEQ_DUMP_DEBUG=prism make test/-ext-/st/test_numhash.rb`)
Incorrect instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(4,10)>
0000 putnil ( 4)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:3 (3,0)-(3,10)>
0000 putself ( 3)[Li]
0001 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0004 putself
0005 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0008 putself
0009 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0012 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0015 leave
```
Fixed instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(4,10)>
0000 putnil ( 4)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:3 (3,0)-(3,10)>
0000 putnil ( 3)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
```
Fixes ruby/prism#1963
2023-12-08 23:00:48 +03:00
|
|
|
|
2023-12-06 01:07:50 +03:00
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
}
|
|
|
|
|
2023-12-11 20:14:21 +03:00
|
|
|
// This is exactly the same as add_ensure_iseq, except it compiled
|
|
|
|
// the node as a Prism node, and not a CRuby node
|
|
|
|
static void
|
|
|
|
pm_add_ensure_iseq(LINK_ANCHOR *const ret, rb_iseq_t *iseq, int is_return, const uint8_t *src, pm_scope_node_t *scope_node)
|
|
|
|
{
|
|
|
|
assert(can_add_ensure_iseq(iseq));
|
|
|
|
|
|
|
|
struct iseq_compile_data_ensure_node_stack *enlp =
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->ensure_node_stack;
|
|
|
|
struct iseq_compile_data_ensure_node_stack *prev_enlp = enlp;
|
|
|
|
DECL_ANCHOR(ensure);
|
|
|
|
|
|
|
|
INIT_ANCHOR(ensure);
|
|
|
|
while (enlp) {
|
|
|
|
if (enlp->erange != NULL) {
|
|
|
|
DECL_ANCHOR(ensure_part);
|
|
|
|
LABEL *lstart = NEW_LABEL(0);
|
|
|
|
LABEL *lend = NEW_LABEL(0);
|
|
|
|
INIT_ANCHOR(ensure_part);
|
|
|
|
|
|
|
|
add_ensure_range(iseq, enlp->erange, lstart, lend);
|
|
|
|
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->ensure_node_stack = enlp->prev;
|
|
|
|
ADD_LABEL(ensure_part, lstart);
|
|
|
|
bool popped = true;
|
|
|
|
PM_COMPILE_INTO_ANCHOR(ensure_part, (pm_node_t *)enlp->ensure_node);
|
|
|
|
ADD_LABEL(ensure_part, lend);
|
|
|
|
ADD_SEQ(ensure, ensure_part);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if (!is_return) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
enlp = enlp->prev;
|
|
|
|
}
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->ensure_node_stack = prev_enlp;
|
|
|
|
ADD_SEQ(ret, ensure);
|
|
|
|
}
|
|
|
|
|
2024-01-23 23:11:21 +03:00
|
|
|
struct pm_local_table_insert_ctx {
|
|
|
|
pm_scope_node_t *scope_node;
|
|
|
|
rb_ast_id_table_t *local_table_for_iseq;
|
|
|
|
int local_index;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int
|
|
|
|
pm_local_table_insert_func(st_data_t *key, st_data_t *value, st_data_t arg, int existing)
|
|
|
|
{
|
|
|
|
if (!existing) {
|
2024-01-26 22:51:25 +03:00
|
|
|
pm_constant_id_t constant_id = (pm_constant_id_t)*key;
|
2024-01-23 23:11:21 +03:00
|
|
|
struct pm_local_table_insert_ctx * ctx = (struct pm_local_table_insert_ctx *)arg;
|
|
|
|
|
|
|
|
pm_scope_node_t *scope_node = ctx->scope_node;
|
|
|
|
rb_ast_id_table_t *local_table_for_iseq = ctx->local_table_for_iseq;
|
|
|
|
int local_index = ctx->local_index;
|
|
|
|
|
|
|
|
ID local = pm_constant_id_lookup(scope_node, constant_id);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
|
2024-01-26 22:51:25 +03:00
|
|
|
*value = (st_data_t)local_index;
|
2024-01-23 23:11:21 +03:00
|
|
|
|
|
|
|
ctx->local_index++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ST_CONTINUE;
|
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
static void
|
|
|
|
pm_insert_local_index(pm_constant_id_t constant_id, int local_index, st_table *index_lookup_table, rb_ast_id_table_t *local_table_for_iseq, pm_scope_node_t *scope_node)
|
|
|
|
{
|
2024-01-23 22:43:53 +03:00
|
|
|
RUBY_ASSERT((constant_id & PM_SPECIAL_CONSTANT_FLAG) == 0);
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
ID local = pm_constant_id_lookup(scope_node, constant_id);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
2024-01-26 22:51:25 +03:00
|
|
|
st_insert(index_lookup_table, (st_data_t)constant_id, local_index);
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
|
2024-01-24 18:39:40 +03:00
|
|
|
/**
|
|
|
|
* Compile the locals of a multi target node that is used as a positional
|
|
|
|
* parameter in a method, block, or lambda definition. Note that this doesn't
|
|
|
|
* actually add any instructions to the iseq. Instead, it adds locals to the
|
|
|
|
* local and index lookup tables and increments the local index as necessary.
|
|
|
|
*/
|
2023-12-06 18:05:14 +03:00
|
|
|
static int
|
2024-01-24 18:39:40 +03:00
|
|
|
pm_compile_destructured_param_locals(const pm_multi_target_node_t *node, st_table *index_lookup_table, rb_ast_id_table_t *local_table_for_iseq, pm_scope_node_t *scope_node, int local_index)
|
2023-12-06 18:05:14 +03:00
|
|
|
{
|
2024-01-24 18:39:40 +03:00
|
|
|
for (size_t index = 0; index < node->lefts.size; index++) {
|
|
|
|
const pm_node_t *left = node->lefts.nodes[index];
|
2023-12-06 18:05:14 +03:00
|
|
|
|
2024-01-24 18:39:40 +03:00
|
|
|
if (PM_NODE_TYPE_P(left, PM_REQUIRED_PARAMETER_NODE)) {
|
|
|
|
pm_insert_local_index(((const pm_required_parameter_node_t *) left)->name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
2023-12-06 18:05:14 +03:00
|
|
|
local_index++;
|
2024-01-24 18:39:40 +03:00
|
|
|
} else {
|
|
|
|
RUBY_ASSERT(PM_NODE_TYPE_P(left, PM_MULTI_TARGET_NODE));
|
|
|
|
local_index = pm_compile_destructured_param_locals((const pm_multi_target_node_t *) left, index_lookup_table, local_table_for_iseq, scope_node, local_index);
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-01-24 18:39:40 +03:00
|
|
|
if (node->rest != NULL && PM_NODE_TYPE_P(node->rest, PM_SPLAT_NODE)) {
|
|
|
|
const pm_splat_node_t *rest = (const pm_splat_node_t *) node->rest;
|
|
|
|
|
|
|
|
if (rest->expression != NULL) {
|
|
|
|
RUBY_ASSERT(PM_NODE_TYPE_P(rest->expression, PM_REQUIRED_PARAMETER_NODE));
|
|
|
|
pm_insert_local_index(((const pm_required_parameter_node_t *) rest->expression)->name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
2023-12-06 18:05:14 +03:00
|
|
|
local_index++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-01-24 18:39:40 +03:00
|
|
|
for (size_t index = 0; index < node->rights.size; index++) {
|
|
|
|
const pm_node_t *right = node->rights.nodes[index];
|
2023-12-06 18:05:14 +03:00
|
|
|
|
2024-01-24 18:39:40 +03:00
|
|
|
if (PM_NODE_TYPE_P(right, PM_REQUIRED_PARAMETER_NODE)) {
|
|
|
|
pm_insert_local_index(((const pm_required_parameter_node_t *) right)->name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
2023-12-06 18:05:14 +03:00
|
|
|
local_index++;
|
2024-01-24 18:39:40 +03:00
|
|
|
} else {
|
|
|
|
RUBY_ASSERT(PM_NODE_TYPE_P(right, PM_MULTI_TARGET_NODE));
|
|
|
|
local_index = pm_compile_destructured_param_locals((const pm_multi_target_node_t *) right, index_lookup_table, local_table_for_iseq, scope_node, local_index);
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return local_index;
|
|
|
|
}
|
|
|
|
|
2024-01-24 18:39:40 +03:00
|
|
|
/**
|
|
|
|
* Compile a required parameter node that is part of a destructure that is used
|
|
|
|
* as a positional parameter in a method, block, or lambda definition.
|
|
|
|
*/
|
|
|
|
static inline void
|
|
|
|
pm_compile_destructured_param_write(rb_iseq_t *iseq, const pm_required_parameter_node_t *node, LINK_ANCHOR *const ret, const pm_scope_node_t *scope_node)
|
|
|
|
{
|
|
|
|
int lineno = (int) pm_newline_list_line_column(&scope_node->parser->newline_list, node->base.location.start).line;
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, node->name, 0);
|
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Compile a multi target node that is used as a positional parameter in a
|
|
|
|
* method, block, or lambda definition. Note that this is effectively the same
|
|
|
|
* as a multi write, but with the added context that all of the targets
|
|
|
|
* contained in the write are required parameter nodes. With this context, we
|
|
|
|
* know they won't have any parent expressions so we build a separate code path
|
|
|
|
* for this simplified case.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
pm_compile_destructured_param_writes(rb_iseq_t *iseq, const pm_multi_target_node_t *node, LINK_ANCHOR *const ret, const pm_scope_node_t *scope_node)
|
|
|
|
{
|
|
|
|
int lineno = (int) pm_newline_list_line_column(&scope_node->parser->newline_list, node->base.location.start).line;
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
bool has_rest = (node->rest && PM_NODE_TYPE_P(node->rest, PM_SPLAT_NODE) && (((pm_splat_node_t *) node->rest)->expression) != NULL);
|
|
|
|
bool has_rights = node->rights.size > 0;
|
|
|
|
|
|
|
|
int flag = (has_rest || has_rights) ? 1 : 0;
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, expandarray, INT2FIX(node->lefts.size), INT2FIX(flag));
|
|
|
|
|
|
|
|
for (size_t index = 0; index < node->lefts.size; index++) {
|
|
|
|
const pm_node_t *left = node->lefts.nodes[index];
|
|
|
|
|
|
|
|
if (PM_NODE_TYPE_P(left, PM_REQUIRED_PARAMETER_NODE)) {
|
|
|
|
pm_compile_destructured_param_write(iseq, (const pm_required_parameter_node_t *) left, ret, scope_node);
|
|
|
|
} else {
|
|
|
|
RUBY_ASSERT(PM_NODE_TYPE_P(left, PM_MULTI_TARGET_NODE));
|
|
|
|
pm_compile_destructured_param_writes(iseq, (const pm_multi_target_node_t *) left, ret, scope_node);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_rest) {
|
|
|
|
if (has_rights) {
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, expandarray, INT2FIX(node->rights.size), INT2FIX(3));
|
|
|
|
}
|
|
|
|
|
|
|
|
const pm_node_t *rest = ((pm_splat_node_t *) node->rest)->expression;
|
|
|
|
RUBY_ASSERT(PM_NODE_TYPE_P(rest, PM_REQUIRED_PARAMETER_NODE));
|
|
|
|
|
|
|
|
pm_compile_destructured_param_write(iseq, (const pm_required_parameter_node_t *) rest, ret, scope_node);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_rights) {
|
|
|
|
if (!has_rest) {
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, expandarray, INT2FIX(node->rights.size), INT2FIX(2));
|
|
|
|
}
|
|
|
|
|
|
|
|
for (size_t index = 0; index < node->rights.size; index++) {
|
|
|
|
const pm_node_t *right = node->rights.nodes[index];
|
|
|
|
|
|
|
|
if (PM_NODE_TYPE_P(right, PM_REQUIRED_PARAMETER_NODE)) {
|
|
|
|
pm_compile_destructured_param_write(iseq, (const pm_required_parameter_node_t *) right, ret, scope_node);
|
|
|
|
} else {
|
|
|
|
RUBY_ASSERT(PM_NODE_TYPE_P(right, PM_MULTI_TARGET_NODE));
|
|
|
|
pm_compile_destructured_param_writes(iseq, (const pm_multi_target_node_t *) right, ret, scope_node);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This is a node in the multi target state linked list. It tracks the
|
|
|
|
* information for a particular target that necessarily has a parent expression.
|
|
|
|
*/
|
2024-01-12 23:23:47 +03:00
|
|
|
typedef struct pm_multi_target_state_node {
|
|
|
|
// The pointer to the topn instruction that will need to be modified after
|
|
|
|
// we know the total stack size of all of the targets.
|
|
|
|
INSN *topn;
|
|
|
|
|
|
|
|
// The index of the stack from the base of the entire multi target at which
|
|
|
|
// the parent expression is located.
|
|
|
|
size_t stack_index;
|
|
|
|
|
|
|
|
// The number of slots in the stack that this node occupies.
|
|
|
|
size_t stack_size;
|
|
|
|
|
|
|
|
// The position of the node in the list of targets.
|
|
|
|
size_t position;
|
|
|
|
|
|
|
|
// A pointer to the next node in this linked list.
|
|
|
|
struct pm_multi_target_state_node *next;
|
|
|
|
} pm_multi_target_state_node_t;
|
|
|
|
|
2024-01-24 18:39:40 +03:00
|
|
|
/**
|
|
|
|
* As we're compiling a multi target, we need to track additional information
|
|
|
|
* whenever there is a parent expression on the left hand side of the target.
|
|
|
|
* This is because we need to go back and tell the expression where to fetch its
|
|
|
|
* parent expression from the stack. We use a linked list of nodes to track this
|
|
|
|
* information.
|
|
|
|
*/
|
2024-01-12 23:23:47 +03:00
|
|
|
typedef struct {
|
|
|
|
// The total number of slots in the stack that this multi target occupies.
|
|
|
|
size_t stack_size;
|
|
|
|
|
|
|
|
// The position of the current node being compiled. This is forwarded to
|
|
|
|
// nodes when they are allocated.
|
|
|
|
size_t position;
|
|
|
|
|
|
|
|
// A pointer to the head of this linked list.
|
|
|
|
pm_multi_target_state_node_t *head;
|
|
|
|
|
|
|
|
// A pointer to the tail of this linked list.
|
|
|
|
pm_multi_target_state_node_t *tail;
|
|
|
|
} pm_multi_target_state_t;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Push a new state node onto the multi target state.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
pm_multi_target_state_push(pm_multi_target_state_t *state, INSN *topn, size_t stack_size) {
|
|
|
|
pm_multi_target_state_node_t *node = ALLOC(pm_multi_target_state_node_t);
|
|
|
|
node->topn = topn;
|
|
|
|
node->stack_index = state->stack_size + 1;
|
|
|
|
node->stack_size = stack_size;
|
|
|
|
node->position = state->position;
|
|
|
|
node->next = NULL;
|
|
|
|
|
|
|
|
if (state->head == NULL) {
|
|
|
|
state->head = node;
|
|
|
|
state->tail = node;
|
|
|
|
} else {
|
|
|
|
state->tail->next = node;
|
|
|
|
state->tail = node;
|
|
|
|
}
|
|
|
|
|
|
|
|
state->stack_size += stack_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Walk through a multi target state's linked list and update the topn
|
|
|
|
* instructions that were inserted into the write sequence to make sure they can
|
|
|
|
* correctly retrieve their parent expressions.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
pm_multi_target_state_update(pm_multi_target_state_t *state) {
|
|
|
|
// If nothing was ever pushed onto the stack, then we don't need to do any
|
|
|
|
// kind of updates.
|
|
|
|
if (state->stack_size == 0) return;
|
|
|
|
|
|
|
|
pm_multi_target_state_node_t *current = state->head;
|
|
|
|
pm_multi_target_state_node_t *previous;
|
|
|
|
|
|
|
|
while (current != NULL) {
|
|
|
|
VALUE offset = INT2FIX(state->stack_size - current->stack_index + current->position);
|
|
|
|
current->topn->operands[0] = offset;
|
|
|
|
|
|
|
|
// stack_size will be > 1 in the case that we compiled an index target
|
|
|
|
// and it had arguments. In this case, we use multiple topn instructions
|
|
|
|
// to grab up all of the arguments as well, so those offsets need to be
|
|
|
|
// updated as well.
|
|
|
|
if (current->stack_size > 1) {
|
|
|
|
INSN *insn = current->topn;
|
|
|
|
|
|
|
|
for (size_t index = 1; index < current->stack_size; index += 1) {
|
|
|
|
LINK_ELEMENT *element = get_next_insn(insn);
|
|
|
|
RUBY_ASSERT(IS_INSN(element));
|
|
|
|
|
|
|
|
insn = (INSN *) element;
|
|
|
|
RUBY_ASSERT(insn->insn_id == BIN(topn));
|
|
|
|
|
|
|
|
insn->operands[0] = offset;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
previous = current;
|
|
|
|
current = current->next;
|
|
|
|
|
|
|
|
free(previous);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static size_t
|
|
|
|
pm_compile_multi_target_node(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const parents, LINK_ANCHOR *const writes, LINK_ANCHOR *const cleanup, const uint8_t *src, pm_scope_node_t *scope_node, pm_multi_target_state_t *state);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* A target node represents an indirect write to a variable or a method call to
|
|
|
|
* a method ending in =. Compiling one of these nodes requires three sequences:
|
|
|
|
*
|
|
|
|
* * The first is to compile retrieving the parent expression if there is one.
|
|
|
|
* This could be the object that owns a constant or the receiver of a method
|
|
|
|
* call.
|
|
|
|
* * The second is to compile the writes to the targets. This could be writing
|
|
|
|
* to variables, or it could be performing method calls.
|
|
|
|
* * The third is to compile any cleanup that needs to happen, i.e., popping the
|
|
|
|
* appropriate number of values off the stack.
|
|
|
|
*
|
|
|
|
* When there is a parent expression and this target is part of a multi write, a
|
|
|
|
* topn instruction will be inserted into the write sequence. This is to move
|
|
|
|
* the parent expression to the top of the stack so that it can be used as the
|
|
|
|
* receiver of the method call or the owner of the constant. To facilitate this,
|
|
|
|
* we return a pointer to the topn instruction that was used to be later
|
|
|
|
* modified with the correct offset.
|
|
|
|
*
|
|
|
|
* These nodes can appear in a couple of places, but most commonly:
|
|
|
|
*
|
|
|
|
* * For loops - the index variable is a target node
|
|
|
|
* * Rescue clauses - the exception reference variable is a target node
|
|
|
|
* * Multi writes - the left hand side contains a list of target nodes
|
|
|
|
*
|
|
|
|
* For the comments with examples within this function, we'll use for loops as
|
|
|
|
* the containing node.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
pm_compile_target_node(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const parents, LINK_ANCHOR *const writes, LINK_ANCHOR *const cleanup, const uint8_t *src, pm_scope_node_t *scope_node, pm_multi_target_state_t *state) {
|
|
|
|
int lineno = (int) pm_newline_list_line_column(&scope_node->parser->newline_list, node->location.start).line;
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(node)) {
|
|
|
|
case PM_LOCAL_VARIABLE_TARGET_NODE: {
|
|
|
|
// Local variable targets have no parent expression, so they only need
|
|
|
|
// to compile the write.
|
|
|
|
//
|
|
|
|
// for i in []; end
|
|
|
|
//
|
|
|
|
pm_local_variable_target_node_t *cast = (pm_local_variable_target_node_t *) node;
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, cast->name, cast->depth);
|
2024-01-12 23:23:47 +03:00
|
|
|
|
|
|
|
ADD_SETLOCAL(writes, &dummy_line_node, index.index, index.level);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_CLASS_VARIABLE_TARGET_NODE: {
|
|
|
|
// Class variable targets have no parent expression, so they only need
|
|
|
|
// to compile the write.
|
|
|
|
//
|
|
|
|
// for @@i in []; end
|
|
|
|
//
|
|
|
|
pm_class_variable_target_node_t *cast = (pm_class_variable_target_node_t *) node;
|
|
|
|
ID name = pm_constant_id_lookup(scope_node, cast->name);
|
|
|
|
|
|
|
|
ADD_INSN2(writes, &dummy_line_node, setclassvariable, ID2SYM(name), get_cvar_ic_value(iseq, name));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_CONSTANT_TARGET_NODE: {
|
|
|
|
// Constant targets have no parent expression, so they only need to
|
|
|
|
// compile the write.
|
|
|
|
//
|
|
|
|
// for I in []; end
|
|
|
|
//
|
|
|
|
pm_constant_target_node_t *cast = (pm_constant_target_node_t *) node;
|
|
|
|
ID name = pm_constant_id_lookup(scope_node, cast->name);
|
|
|
|
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_CONST_BASE));
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, setconstant, ID2SYM(name));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_GLOBAL_VARIABLE_TARGET_NODE: {
|
|
|
|
// Global variable targets have no parent expression, so they only need
|
|
|
|
// to compile the write.
|
|
|
|
//
|
|
|
|
// for $i in []; end
|
|
|
|
//
|
|
|
|
pm_global_variable_target_node_t *cast = (pm_global_variable_target_node_t *) node;
|
|
|
|
ID name = pm_constant_id_lookup(scope_node, cast->name);
|
|
|
|
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, setglobal, ID2SYM(name));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_INSTANCE_VARIABLE_TARGET_NODE: {
|
|
|
|
// Instance variable targets have no parent expression, so they only
|
|
|
|
// need to compile the write.
|
|
|
|
//
|
|
|
|
// for @i in []; end
|
|
|
|
//
|
|
|
|
pm_instance_variable_target_node_t *cast = (pm_instance_variable_target_node_t *) node;
|
|
|
|
ID name = pm_constant_id_lookup(scope_node, cast->name);
|
|
|
|
|
|
|
|
ADD_INSN2(writes, &dummy_line_node, setinstancevariable, ID2SYM(name), get_ivar_ic_value(iseq, name));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_CONSTANT_PATH_TARGET_NODE: {
|
|
|
|
// Constant path targets have a parent expression that is the object
|
|
|
|
// that owns the constant. This needs to be compiled first into the
|
|
|
|
// parents sequence. If no parent is found, then it represents using the
|
|
|
|
// unary :: operator to indicate a top-level constant. In that case we
|
|
|
|
// need to push Object onto the stack.
|
|
|
|
//
|
|
|
|
// for I::J in []; end
|
|
|
|
//
|
|
|
|
const pm_constant_path_target_node_t *cast = (const pm_constant_path_target_node_t *) node;
|
|
|
|
ID name = pm_constant_id_lookup(scope_node, ((const pm_constant_read_node_t *) cast->child)->name);
|
|
|
|
|
|
|
|
if (cast->parent != NULL) {
|
|
|
|
pm_compile_node(iseq, cast->parent, parents, src, false, scope_node);
|
|
|
|
} else {
|
|
|
|
ADD_INSN1(parents, &dummy_line_node, putobject, rb_cObject);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (state == NULL) {
|
|
|
|
ADD_INSN(writes, &dummy_line_node, swap);
|
|
|
|
} else {
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, topn, INT2FIX(1));
|
|
|
|
pm_multi_target_state_push(state, (INSN *) LAST_ELEMENT(writes), 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, setconstant, ID2SYM(name));
|
|
|
|
|
|
|
|
if (state != NULL) {
|
|
|
|
ADD_INSN(cleanup, &dummy_line_node, pop);
|
|
|
|
}
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_CALL_TARGET_NODE: {
|
|
|
|
// Call targets have a parent expression that is the receiver of the
|
|
|
|
// method being called. This needs to be compiled first into the parents
|
|
|
|
// sequence. These nodes cannot have arguments, so the method call is
|
|
|
|
// compiled with a single argument which represents the value being
|
|
|
|
// written.
|
|
|
|
//
|
|
|
|
// for i.j in []; end
|
|
|
|
//
|
|
|
|
const pm_call_target_node_t *cast = (const pm_call_target_node_t *) node;
|
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, cast->name);
|
|
|
|
|
|
|
|
pm_compile_node(iseq, cast->receiver, parents, src, false, scope_node);
|
|
|
|
|
|
|
|
if (state != NULL) {
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, topn, INT2FIX(1));
|
|
|
|
pm_multi_target_state_push(state, (INSN *) LAST_ELEMENT(writes), 1);
|
|
|
|
ADD_INSN(writes, &dummy_line_node, swap);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_SEND(writes, &dummy_line_node, method_id, INT2NUM(1));
|
|
|
|
ADD_INSN(writes, &dummy_line_node, pop);
|
|
|
|
|
|
|
|
if (state != NULL) {
|
|
|
|
ADD_INSN(cleanup, &dummy_line_node, pop);
|
|
|
|
}
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_INDEX_TARGET_NODE: {
|
|
|
|
// Index targets have a parent expression that is the receiver of the
|
|
|
|
// method being called and any additional arguments that are being
|
|
|
|
// passed along with the value being written. The receiver and arguments
|
|
|
|
// both need to be on the stack. Note that this is even more complicated
|
|
|
|
// by the fact that these nodes can hold a block using the unary &
|
|
|
|
// operator.
|
|
|
|
//
|
|
|
|
// for i[:j] in []; end
|
|
|
|
//
|
|
|
|
const pm_index_target_node_t *cast = (const pm_index_target_node_t *) node;
|
|
|
|
|
|
|
|
pm_compile_node(iseq, cast->receiver, parents, src, false, scope_node);
|
|
|
|
|
|
|
|
int flags = 0;
|
|
|
|
struct rb_callinfo_kwarg *kwargs = NULL;
|
|
|
|
int argc = pm_setup_args(cast->arguments, &flags, &kwargs, iseq, parents, src, false, scope_node, dummy_line_node, scope_node->parser);
|
|
|
|
|
|
|
|
if (cast->block != NULL) {
|
|
|
|
flags |= VM_CALL_ARGS_BLOCKARG;
|
2024-01-22 19:36:55 +03:00
|
|
|
if (cast->block != NULL) pm_compile_node(iseq, cast->block, parents, src, false, scope_node);
|
2024-01-12 23:23:47 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (state != NULL) {
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, topn, INT2FIX(argc + 1));
|
|
|
|
pm_multi_target_state_push(state, (INSN *) LAST_ELEMENT(writes), argc + 1);
|
|
|
|
|
|
|
|
if (argc == 0) {
|
|
|
|
ADD_INSN(writes, &dummy_line_node, swap);
|
|
|
|
} else {
|
|
|
|
for (int index = 0; index < argc; index++) {
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, topn, INT2FIX(argc + 1));
|
|
|
|
}
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, topn, INT2FIX(argc + 1));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-01-22 19:36:55 +03:00
|
|
|
// The argc that we're going to pass to the send instruction is the
|
|
|
|
// number of arguments + 1 for the value being written. If there's a
|
|
|
|
// splat, then we need to insert newarray and concatarray instructions
|
|
|
|
// after the arguments have been written.
|
|
|
|
int ci_argc = argc + 1;
|
|
|
|
if (flags & VM_CALL_ARGS_SPLAT) {
|
|
|
|
ci_argc--;
|
|
|
|
ADD_INSN1(writes, &dummy_line_node, newarray, INT2FIX(1));
|
|
|
|
ADD_INSN(writes, &dummy_line_node, concatarray);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_SEND_R(writes, &dummy_line_node, idASET, INT2NUM(ci_argc), NULL, INT2FIX(flags), kwargs);
|
2024-01-12 23:23:47 +03:00
|
|
|
ADD_INSN(writes, &dummy_line_node, pop);
|
|
|
|
|
|
|
|
if (state != NULL) {
|
|
|
|
if (argc != 0) {
|
|
|
|
ADD_INSN(writes, &dummy_line_node, pop);
|
|
|
|
}
|
|
|
|
|
|
|
|
for (int index = 0; index < argc + 1; index++) {
|
|
|
|
ADD_INSN(cleanup, &dummy_line_node, pop);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_MULTI_TARGET_NODE: {
|
|
|
|
// Multi target nodes represent a set of writes to multiple variables.
|
|
|
|
// The parent expressions are the combined set of the parent expressions
|
|
|
|
// of its inner target nodes.
|
|
|
|
//
|
|
|
|
// for i, j in []; end
|
|
|
|
//
|
2024-01-23 19:32:35 +03:00
|
|
|
if (state != NULL) state->position--;
|
2024-01-12 23:23:47 +03:00
|
|
|
pm_compile_multi_target_node(iseq, node, parents, writes, cleanup, src, scope_node, state);
|
2024-01-23 19:32:35 +03:00
|
|
|
if (state != NULL) state->position++;
|
2024-01-12 23:23:47 +03:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
rb_bug("Unexpected node type: %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Compile a multi target or multi write node. It returns the number of values
|
|
|
|
* on the stack that correspond to the parent expressions of the various
|
|
|
|
* targets.
|
|
|
|
*/
|
|
|
|
static size_t
|
|
|
|
pm_compile_multi_target_node(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const parents, LINK_ANCHOR *const writes, LINK_ANCHOR *const cleanup, const uint8_t *src, pm_scope_node_t *scope_node, pm_multi_target_state_t *state) {
|
|
|
|
int lineno = (int) pm_newline_list_line_column(&scope_node->parser->newline_list, node->location.start).line;
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
const pm_node_list_t *lefts;
|
|
|
|
const pm_node_t *rest;
|
|
|
|
const pm_node_list_t *rights;
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(node)) {
|
|
|
|
case PM_MULTI_TARGET_NODE: {
|
|
|
|
pm_multi_target_node_t *cast = (pm_multi_target_node_t *) node;
|
|
|
|
lefts = &cast->lefts;
|
|
|
|
rest = cast->rest;
|
|
|
|
rights = &cast->rights;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_MULTI_WRITE_NODE: {
|
|
|
|
pm_multi_write_node_t *cast = (pm_multi_write_node_t *) node;
|
|
|
|
lefts = &cast->lefts;
|
|
|
|
rest = cast->rest;
|
|
|
|
rights = &cast->rights;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
rb_bug("Unsupported node %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool has_rest = (rest != NULL) && PM_NODE_TYPE_P(rest, PM_SPLAT_NODE) && ((pm_splat_node_t *) rest)->expression != NULL;
|
|
|
|
bool has_posts = rights->size > 0;
|
|
|
|
|
|
|
|
// The first instruction in the writes sequence is going to spread the
|
|
|
|
// top value of the stack onto the number of values that we're going to
|
|
|
|
// write.
|
|
|
|
ADD_INSN2(writes, &dummy_line_node, expandarray, INT2FIX(lefts->size), INT2FIX((has_rest || has_posts) ? 1 : 0));
|
|
|
|
|
|
|
|
// We need to keep track of some additional state information as we're
|
|
|
|
// going through the targets because we will need to revisit them once
|
|
|
|
// we know how many values are being pushed onto the stack.
|
|
|
|
pm_multi_target_state_t target_state = { 0 };
|
|
|
|
size_t base_position = state == NULL ? 0 : state->position;
|
|
|
|
size_t splat_position = has_rest ? 1 : 0;
|
|
|
|
|
|
|
|
// Next, we'll iterate through all of the leading targets.
|
|
|
|
for (size_t index = 0; index < lefts->size; index++) {
|
|
|
|
const pm_node_t *target = lefts->nodes[index];
|
|
|
|
target_state.position = lefts->size - index + splat_position + base_position;
|
|
|
|
pm_compile_target_node(iseq, target, parents, writes, cleanup, src, scope_node, &target_state);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Next, we'll compile the rest target if there is one.
|
|
|
|
if (has_rest) {
|
|
|
|
const pm_node_t *target = ((pm_splat_node_t *) rest)->expression;
|
|
|
|
target_state.position = 1 + rights->size + base_position;
|
|
|
|
|
|
|
|
if (has_posts) {
|
|
|
|
ADD_INSN2(writes, &dummy_line_node, expandarray, INT2FIX(rights->size), INT2FIX(3));
|
|
|
|
}
|
|
|
|
|
|
|
|
pm_compile_target_node(iseq, target, parents, writes, cleanup, src, scope_node, &target_state);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Finally, we'll compile the trailing targets.
|
|
|
|
if (has_posts) {
|
|
|
|
if (!has_rest && rest != NULL) {
|
|
|
|
ADD_INSN2(writes, &dummy_line_node, expandarray, INT2FIX(rights->size), INT2FIX(2));
|
|
|
|
}
|
|
|
|
|
|
|
|
for (size_t index = 0; index < rights->size; index++) {
|
|
|
|
const pm_node_t *target = rights->nodes[index];
|
|
|
|
target_state.position = rights->size - index + base_position;
|
|
|
|
pm_compile_target_node(iseq, target, parents, writes, cleanup, src, scope_node, &target_state);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Now, we need to go back and modify the topn instructions in order to
|
|
|
|
// ensure they can correctly retrieve the parent expressions.
|
|
|
|
pm_multi_target_state_update(&target_state);
|
2024-01-23 19:32:35 +03:00
|
|
|
|
|
|
|
if (state != NULL) state->stack_size += target_state.stack_size;
|
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
return target_state.stack_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* When compiling a for loop, we need to write the iteration variable to
|
|
|
|
* whatever expression exists in the index slot. This function performs that
|
|
|
|
* compilation.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
pm_compile_for_node_index(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, pm_scope_node_t *scope_node) {
|
|
|
|
int lineno = (int) pm_newline_list_line_column(&scope_node->parser->newline_list, node->location.start).line;
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(node)) {
|
|
|
|
case PM_LOCAL_VARIABLE_TARGET_NODE: {
|
|
|
|
// For local variables, all we have to do is retrieve the value and then
|
|
|
|
// compile the index node.
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, 1, 0);
|
|
|
|
pm_compile_target_node(iseq, node, ret, ret, ret, src, scope_node, NULL);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_CLASS_VARIABLE_TARGET_NODE:
|
|
|
|
case PM_CONSTANT_TARGET_NODE:
|
|
|
|
case PM_GLOBAL_VARIABLE_TARGET_NODE:
|
|
|
|
case PM_INSTANCE_VARIABLE_TARGET_NODE:
|
|
|
|
case PM_CONSTANT_PATH_TARGET_NODE:
|
|
|
|
case PM_CALL_TARGET_NODE:
|
|
|
|
case PM_INDEX_TARGET_NODE: {
|
|
|
|
// For other targets, we need to potentially compile the parent or
|
|
|
|
// owning expression of this target, then retrieve the value, expand it,
|
|
|
|
// and then compile the necessary writes.
|
|
|
|
DECL_ANCHOR(writes);
|
|
|
|
INIT_ANCHOR(writes);
|
|
|
|
|
|
|
|
DECL_ANCHOR(cleanup);
|
|
|
|
INIT_ANCHOR(cleanup);
|
|
|
|
|
|
|
|
pm_multi_target_state_t state = { 0 };
|
|
|
|
state.position = 1;
|
|
|
|
pm_compile_target_node(iseq, node, ret, writes, cleanup, src, scope_node, &state);
|
|
|
|
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, 1, 0);
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, expandarray, INT2FIX(1), INT2FIX(0));
|
|
|
|
|
|
|
|
ADD_SEQ(ret, writes);
|
|
|
|
ADD_SEQ(ret, cleanup);
|
|
|
|
|
|
|
|
pm_multi_target_state_update(&state);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_MULTI_TARGET_NODE: {
|
|
|
|
DECL_ANCHOR(writes);
|
|
|
|
INIT_ANCHOR(writes);
|
|
|
|
|
|
|
|
DECL_ANCHOR(cleanup);
|
|
|
|
INIT_ANCHOR(cleanup);
|
|
|
|
|
|
|
|
pm_compile_target_node(iseq, node, ret, writes, cleanup, src, scope_node, NULL);
|
|
|
|
|
|
|
|
LABEL *not_single = NEW_LABEL(lineno);
|
|
|
|
LABEL *not_ary = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
// When there are multiple targets, we'll do a bunch of work to convert
|
|
|
|
// the value into an array before we expand it. Effectively we're trying
|
|
|
|
// to accomplish:
|
|
|
|
//
|
|
|
|
// (args.length == 1 && Array.try_convert(args[0])) || args
|
|
|
|
//
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, 1, 0);
|
|
|
|
ADD_INSN(ret, &dummy_line_node, dup);
|
|
|
|
ADD_CALL(ret, &dummy_line_node, idLength, INT2FIX(0));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, INT2FIX(1));
|
|
|
|
ADD_CALL(ret, &dummy_line_node, idEq, INT2FIX(1));
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, not_single);
|
|
|
|
ADD_INSN(ret, &dummy_line_node, dup);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, INT2FIX(0));
|
|
|
|
ADD_CALL(ret, &dummy_line_node, idAREF, INT2FIX(1));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_cArray);
|
2024-01-22 23:21:09 +03:00
|
|
|
PM_SWAP;
|
2024-01-12 23:23:47 +03:00
|
|
|
ADD_CALL(ret, &dummy_line_node, rb_intern("try_convert"), INT2FIX(1));
|
|
|
|
ADD_INSN(ret, &dummy_line_node, dup);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, not_ary);
|
2024-01-22 23:21:09 +03:00
|
|
|
PM_SWAP;
|
2024-01-12 23:23:47 +03:00
|
|
|
|
|
|
|
ADD_LABEL(ret, not_ary);
|
2024-01-22 23:16:14 +03:00
|
|
|
PM_POP;
|
2024-01-12 23:23:47 +03:00
|
|
|
|
|
|
|
ADD_LABEL(ret, not_single);
|
|
|
|
ADD_SEQ(ret, writes);
|
|
|
|
ADD_SEQ(ret, cleanup);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
rb_bug("Unexpected node type for index in for node: %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-01-22 22:24:34 +03:00
|
|
|
static void
|
|
|
|
pm_compile_rescue(rb_iseq_t *iseq, pm_begin_node_t *begin_node, LINK_ANCHOR *const ret, const uint8_t *src, int lineno, bool popped, pm_scope_node_t *scope_node)
|
|
|
|
{
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
pm_parser_t *parser = scope_node->parser;
|
|
|
|
LABEL *lstart = NEW_LABEL(lineno);
|
|
|
|
LABEL *lend = NEW_LABEL(lineno);
|
|
|
|
LABEL *lcont = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
pm_scope_node_t rescue_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t *)begin_node->rescue_clause, &rescue_scope_node, scope_node, parser);
|
|
|
|
rb_iseq_t *rescue_iseq = NEW_CHILD_ISEQ(&rescue_scope_node,
|
|
|
|
rb_str_concat(rb_str_new2("rescue in"),
|
|
|
|
ISEQ_BODY(iseq)->location.label),
|
|
|
|
ISEQ_TYPE_RESCUE, 1);
|
|
|
|
pm_scope_node_destroy(&rescue_scope_node);
|
|
|
|
|
|
|
|
lstart->rescued = LABEL_RESCUE_BEG;
|
|
|
|
lend->rescued = LABEL_RESCUE_END;
|
|
|
|
ADD_LABEL(ret, lstart);
|
|
|
|
bool prev_in_rescue = ISEQ_COMPILE_DATA(iseq)->in_rescue;
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->in_rescue = true;
|
|
|
|
if (begin_node->statements) {
|
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)begin_node->statements);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->in_rescue = prev_in_rescue;
|
|
|
|
|
|
|
|
if (begin_node->else_clause) {
|
|
|
|
PM_POP_UNLESS_POPPED;
|
|
|
|
PM_COMPILE((pm_node_t *)begin_node->else_clause);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, lend);
|
|
|
|
PM_NOP;
|
|
|
|
ADD_LABEL(ret, lcont);
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_RESCUE, lstart, lend, rescue_iseq, lcont);
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_RETRY, lend, lcont, NULL, lstart);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pm_compile_ensure(rb_iseq_t *iseq, pm_begin_node_t *begin_node, LINK_ANCHOR *const ret, const uint8_t *src, int lineno, bool popped, pm_scope_node_t *scope_node)
|
|
|
|
{
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
pm_parser_t *parser = scope_node->parser;
|
|
|
|
|
|
|
|
LABEL *estart = NEW_LABEL(lineno);
|
|
|
|
LABEL *eend = NEW_LABEL(lineno);
|
|
|
|
LABEL *econt = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
struct ensure_range er;
|
|
|
|
struct iseq_compile_data_ensure_node_stack enl;
|
|
|
|
struct ensure_range *erange;
|
|
|
|
|
|
|
|
er.begin = estart;
|
|
|
|
er.end = eend;
|
|
|
|
er.next = 0;
|
|
|
|
push_ensure_entry(iseq, &enl, &er, (void *)begin_node->ensure_clause);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, estart);
|
|
|
|
if (begin_node->rescue_clause) {
|
|
|
|
pm_compile_rescue(iseq, begin_node, ret, src, lineno, popped, scope_node);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if (begin_node->statements) {
|
|
|
|
PM_COMPILE((pm_node_t *)begin_node->statements);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, eend);
|
|
|
|
ADD_LABEL(ret, econt);
|
|
|
|
|
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t *)begin_node->ensure_clause, &next_scope_node, scope_node, parser);
|
|
|
|
rb_iseq_t * child_iseq = NEW_CHILD_ISEQ(&next_scope_node,
|
|
|
|
rb_str_new2("ensure in"),
|
|
|
|
ISEQ_TYPE_ENSURE, lineno);
|
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
|
|
|
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = child_iseq;
|
|
|
|
|
|
|
|
erange = ISEQ_COMPILE_DATA(iseq)->ensure_node_stack->erange;
|
|
|
|
if (estart->link.next != &eend->link) {
|
|
|
|
while (erange) {
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_ENSURE, erange->begin, erange->end, child_iseq, econt);
|
|
|
|
erange = erange->next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->ensure_node_stack = enl.prev;
|
|
|
|
|
|
|
|
// Compile the ensure entry
|
|
|
|
pm_statements_node_t *statements = begin_node->ensure_clause->statements;
|
|
|
|
if (statements) {
|
|
|
|
PM_COMPILE((pm_node_t *)statements);
|
|
|
|
PM_POP_UNLESS_POPPED;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-08-29 19:27:00 +03:00
|
|
|
/*
|
2023-09-27 19:39:53 +03:00
|
|
|
* Compiles a prism node into instruction sequences
|
2023-08-29 19:27:00 +03:00
|
|
|
*
|
|
|
|
* iseq - The current instruction sequence object (used for locals)
|
2023-09-27 19:39:53 +03:00
|
|
|
* node - The prism node to compile
|
2023-10-20 12:58:23 +03:00
|
|
|
* ret - The linked list of instructions to append instructions onto
|
2023-08-29 19:27:00 +03:00
|
|
|
* popped - True if compiling something with no side effects, so instructions don't
|
|
|
|
* need to be added
|
2023-10-17 01:36:25 +03:00
|
|
|
* scope_node - Stores parser and local information
|
2023-08-29 19:27:00 +03:00
|
|
|
*/
|
2023-08-28 23:55:58 +03:00
|
|
|
static void
|
2023-10-23 20:49:39 +03:00
|
|
|
pm_compile_node(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret, const uint8_t *src, bool popped, pm_scope_node_t *scope_node)
|
2023-08-30 00:17:08 +03:00
|
|
|
{
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_parser_t *parser = scope_node->parser;
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_newline_list_t newline_list = parser->newline_list;
|
|
|
|
int lineno = (int)pm_newline_list_line_column(&newline_list, node->location.start).line;
|
2023-08-29 19:27:00 +03:00
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
2024-01-22 19:55:50 +03:00
|
|
|
if (node->flags & PM_NODE_FLAG_NEWLINE && ISEQ_COMPILE_DATA(iseq)->last_line != lineno) {
|
2023-11-24 14:36:55 +03:00
|
|
|
int event = RUBY_EVENT_LINE;
|
|
|
|
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->last_line = lineno;
|
|
|
|
if (ISEQ_COVERAGE(iseq) && ISEQ_LINE_COVERAGE(iseq)) {
|
|
|
|
event |= RUBY_EVENT_COVERAGE_LINE;
|
|
|
|
}
|
|
|
|
ADD_TRACE(ret, event);
|
|
|
|
}
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
switch (PM_NODE_TYPE(node)) {
|
2023-10-16 22:00:01 +03:00
|
|
|
case PM_ALIAS_GLOBAL_VARIABLE_NODE: {
|
|
|
|
pm_alias_global_variable_node_t *alias_node = (pm_alias_global_variable_node_t *) node;
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
|
2023-10-19 23:50:21 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, ID2SYM(parse_location_symbol(&alias_node->new_name->location, parser)));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, ID2SYM(parse_location_symbol(&alias_node->old_name->location, parser)));
|
2023-10-16 22:00:01 +03:00
|
|
|
|
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_set_variable_alias, INT2FIX(2));
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_ALIAS_METHOD_NODE: {
|
|
|
|
pm_alias_method_node_t *alias_node = (pm_alias_method_node_t *) node;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-09-05 20:58:16 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_CBASE));
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(alias_node->new_name);
|
|
|
|
PM_COMPILE_NOT_POPPED(alias_node->old_name);
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_set_method_alias, INT2FIX(3));
|
2023-09-20 18:05:45 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-09-20 18:05:45 +03:00
|
|
|
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_AND_NODE: {
|
|
|
|
pm_and_node_t *and_node = (pm_and_node_t *) node;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(and_node->left);
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(and_node->right);
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_ARGUMENTS_NODE: {
|
2023-12-07 23:03:06 +03:00
|
|
|
// These are ArgumentsNodes that are not compiled directly by their
|
|
|
|
// parent call nodes, used in the cases of NextNodes, ReturnNodes
|
|
|
|
// and BreakNodes
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_arguments_node_t *arguments_node = (pm_arguments_node_t *) node;
|
|
|
|
pm_node_list_t node_list = arguments_node->arguments;
|
2023-08-29 19:27:00 +03:00
|
|
|
for (size_t index = 0; index < node_list.size; index++) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(node_list.nodes[index]);
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
2023-12-07 22:13:33 +03:00
|
|
|
if (node_list.size > 1) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(node_list.size));
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_ARRAY_NODE: {
|
2023-09-28 21:25:47 +03:00
|
|
|
// If every node in the array is static, then we can compile the entire
|
|
|
|
// array now instead of later.
|
2023-09-28 22:19:56 +03:00
|
|
|
if (pm_static_literal_p(node)) {
|
2023-09-28 21:25:47 +03:00
|
|
|
// We're only going to compile this node if it's not popped. If it
|
|
|
|
// is popped, then we know we don't need to do anything since it's
|
|
|
|
// statically known.
|
|
|
|
if (!popped) {
|
2023-11-29 23:02:32 +03:00
|
|
|
pm_array_node_t *cast = (pm_array_node_t *) node;
|
|
|
|
if (cast->elements.size) {
|
|
|
|
VALUE value = pm_static_literal_value(node, scope_node, parser);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, duparray, value);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, value);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(0));
|
|
|
|
}
|
2023-09-28 21:25:47 +03:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// Here since we know there are possible side-effects inside the
|
|
|
|
// array contents, we're going to build it entirely at runtime.
|
|
|
|
// We'll do this by pushing all of the elements onto the stack and
|
|
|
|
// then combining them with newarray.
|
|
|
|
//
|
|
|
|
// If this hash is popped, then this serves only to ensure we enact
|
|
|
|
// all side-effects (like method calls) that are contained within
|
|
|
|
// the hash contents.
|
2023-09-28 22:19:56 +03:00
|
|
|
pm_array_node_t *cast = (pm_array_node_t *) node;
|
|
|
|
pm_node_list_t *elements = &cast->elements;
|
|
|
|
|
2023-11-22 17:49:26 +03:00
|
|
|
// In the case that there is a splat node within the array,
|
|
|
|
// the array gets compiled slightly differently.
|
|
|
|
if (node->flags & PM_ARRAY_NODE_FLAGS_CONTAINS_SPLAT) {
|
|
|
|
if (elements->size == 1) {
|
|
|
|
// If the only nodes is a SplatNode, we never
|
|
|
|
// need to emit the newarray or concatarray
|
|
|
|
// instructions
|
|
|
|
PM_COMPILE_NOT_POPPED(elements->nodes[0]);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
// We treat all sequences of non-splat elements as their
|
|
|
|
// own arrays, followed by a newarray, and then continually
|
|
|
|
// concat the arrays with the SplatNodes
|
|
|
|
int new_array_size = 0;
|
|
|
|
bool need_to_concat_array = false;
|
|
|
|
for (size_t index = 0; index < elements->size; index++) {
|
|
|
|
pm_node_t *array_element = elements->nodes[index];
|
|
|
|
if (PM_NODE_TYPE_P(array_element, PM_SPLAT_NODE)) {
|
|
|
|
pm_splat_node_t *splat_element = (pm_splat_node_t *)array_element;
|
|
|
|
|
|
|
|
// If we already have non-splat elements, we need to emit a newarray
|
|
|
|
// instruction
|
|
|
|
if (new_array_size) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(new_array_size));
|
|
|
|
|
|
|
|
// We don't want to emit a concat array in the case where
|
|
|
|
// we're seeing our first splat, and already have elements
|
|
|
|
if (need_to_concat_array) {
|
|
|
|
ADD_INSN(ret, &dummy_line_node, concatarray);
|
|
|
|
}
|
|
|
|
|
|
|
|
new_array_size = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
PM_COMPILE_NOT_POPPED(splat_element->expression);
|
|
|
|
|
|
|
|
if (index > 0) {
|
|
|
|
ADD_INSN(ret, &dummy_line_node, concatarray);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
// If this is the first element, we need to splatarray
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, splatarray, Qtrue);
|
|
|
|
}
|
|
|
|
|
|
|
|
need_to_concat_array = true;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
new_array_size++;
|
|
|
|
PM_COMPILE_NOT_POPPED(array_element);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (new_array_size) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(new_array_size));
|
|
|
|
if (need_to_concat_array) {
|
|
|
|
ADD_INSN(ret, &dummy_line_node, concatarray);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-11-22 17:49:26 +03:00
|
|
|
else {
|
2024-01-15 18:28:39 +03:00
|
|
|
bool has_kw_splat = false;
|
|
|
|
|
2023-11-22 17:49:26 +03:00
|
|
|
for (size_t index = 0; index < elements->size; index++) {
|
2024-01-15 18:28:39 +03:00
|
|
|
pm_node_t *element_node = elements->nodes[index];
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(element_node)) {
|
|
|
|
case PM_KEYWORD_HASH_NODE: {
|
|
|
|
has_kw_splat = true;
|
|
|
|
|
2024-01-17 23:29:37 +03:00
|
|
|
pm_arg_compile_keyword_hash_node((pm_keyword_hash_node_t *)element_node, iseq, ret, src, popped, scope_node, dummy_line_node);
|
2024-01-15 18:28:39 +03:00
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default: {
|
|
|
|
PM_COMPILE(element_node);
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2023-11-22 17:49:26 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-11-22 17:49:26 +03:00
|
|
|
if (!popped) {
|
2024-01-15 18:28:39 +03:00
|
|
|
if (has_kw_splat) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarraykwsplat, INT2FIX(elements->size));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newarray, INT2FIX(elements->size));
|
|
|
|
}
|
2023-11-22 17:49:26 +03:00
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_ASSOC_NODE: {
|
|
|
|
pm_assoc_node_t *assoc_node = (pm_assoc_node_t *) node;
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(assoc_node->key);
|
2023-08-30 00:17:08 +03:00
|
|
|
if (assoc_node->value) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(assoc_node->value);
|
2023-08-30 00:17:08 +03:00
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_ASSOC_SPLAT_NODE: {
|
|
|
|
pm_assoc_splat_node_t *assoc_splat_node = (pm_assoc_splat_node_t *)node;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(assoc_splat_node->value);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_BACK_REFERENCE_READ_NODE: {
|
2023-09-01 21:30:22 +03:00
|
|
|
if (!popped) {
|
|
|
|
// Since a back reference is `$<char>`, ruby represents the ID as the
|
|
|
|
// an rb_intern on the value after the `$`.
|
|
|
|
char *char_ptr = (char *)(node->location.start) + 1;
|
|
|
|
ID backref_val = INT2FIX(rb_intern2(char_ptr, 1)) << 1 | 1;
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getspecial, INT2FIX(1), backref_val);
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_BEGIN_NODE: {
|
|
|
|
pm_begin_node_t *begin_node = (pm_begin_node_t *) node;
|
2023-11-10 17:51:14 +03:00
|
|
|
|
2023-12-04 15:27:34 +03:00
|
|
|
if (begin_node->ensure_clause) {
|
2024-01-22 22:24:34 +03:00
|
|
|
// Compiling the ensure clause will compile the rescue clause (if
|
|
|
|
// there is one), which will compile the begin statements
|
|
|
|
pm_compile_ensure(iseq, begin_node, ret, src, lineno, popped, scope_node);
|
2023-12-04 15:27:34 +03:00
|
|
|
}
|
2024-01-22 22:24:34 +03:00
|
|
|
else if (begin_node->rescue_clause) {
|
|
|
|
// Compiling rescue will compile begin statements (if applicable)
|
|
|
|
pm_compile_rescue(iseq, begin_node, ret, src, lineno, popped, scope_node);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
// If there is neither ensure or rescue, the just compile statements
|
2023-11-10 17:51:14 +03:00
|
|
|
if (begin_node->statements) {
|
|
|
|
PM_COMPILE((pm_node_t *)begin_node->statements);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
}
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_BLOCK_ARGUMENT_NODE: {
|
|
|
|
pm_block_argument_node_t *block_argument_node = (pm_block_argument_node_t *) node;
|
2023-10-13 20:59:37 +03:00
|
|
|
if (block_argument_node->expression) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(block_argument_node->expression);
|
2023-10-13 20:59:37 +03:00
|
|
|
}
|
2024-01-23 22:43:53 +03:00
|
|
|
else {
|
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, PM_CONSTANT_AND, 0);
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
|
|
|
}
|
2023-09-27 18:08:54 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_BREAK_NODE: {
|
|
|
|
pm_break_node_t *break_node = (pm_break_node_t *) node;
|
2023-12-11 18:27:46 +03:00
|
|
|
unsigned long throw_flag = 0;
|
|
|
|
if (ISEQ_COMPILE_DATA(iseq)->redo_label != 0 && can_add_ensure_iseq(iseq)) {
|
|
|
|
/* while/until */
|
|
|
|
LABEL *splabel = NEW_LABEL(0);
|
|
|
|
ADD_LABEL(ret, splabel);
|
|
|
|
ADD_ADJUST(ret, &dummy_line_node, ISEQ_COMPILE_DATA(iseq)->redo_label);
|
|
|
|
if (break_node->arguments) {
|
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)break_node->arguments);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
2024-01-19 02:11:17 +03:00
|
|
|
|
|
|
|
pm_add_ensure_iseq(ret, iseq, 0, src, scope_node);
|
2023-12-11 18:27:46 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, ISEQ_COMPILE_DATA(iseq)->end_label);
|
|
|
|
ADD_ADJUST_RESTORE(ret, splabel);
|
|
|
|
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
} else {
|
|
|
|
const rb_iseq_t *ip = iseq;
|
|
|
|
|
|
|
|
while (ip) {
|
|
|
|
if (!ISEQ_COMPILE_DATA(ip)) {
|
|
|
|
ip = 0;
|
|
|
|
break;
|
|
|
|
}
|
2023-08-31 00:27:08 +03:00
|
|
|
|
2023-12-11 18:27:46 +03:00
|
|
|
if (ISEQ_COMPILE_DATA(ip)->redo_label != 0) {
|
|
|
|
throw_flag = VM_THROW_NO_ESCAPE_FLAG;
|
|
|
|
}
|
|
|
|
else if (ISEQ_BODY(ip)->type == ISEQ_TYPE_BLOCK) {
|
|
|
|
throw_flag = 0;
|
|
|
|
}
|
|
|
|
else if (ISEQ_BODY(ip)->type == ISEQ_TYPE_EVAL) {
|
|
|
|
COMPILE_ERROR(ERROR_ARGS "Can't escape from eval with break");
|
|
|
|
rb_bug("Can't escape from eval with break");
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ip = ISEQ_BODY(ip)->parent_iseq;
|
|
|
|
continue;
|
|
|
|
}
|
2023-08-31 00:27:08 +03:00
|
|
|
|
2023-12-11 18:27:46 +03:00
|
|
|
/* escape from block */
|
|
|
|
if (break_node->arguments) {
|
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)break_node->arguments);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, throw, INT2FIX(throw_flag | TAG_BREAK));
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
COMPILE_ERROR(ERROR_ARGS "Invalid break");
|
2023-12-13 21:28:19 +03:00
|
|
|
rb_bug("Invalid break");
|
2023-12-11 18:27:46 +03:00
|
|
|
}
|
2023-08-31 00:27:08 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CALL_NODE: {
|
|
|
|
pm_call_node_t *call_node = (pm_call_node_t *) node;
|
2023-12-12 01:35:13 +03:00
|
|
|
LABEL *start = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
if (call_node->block) {
|
|
|
|
ADD_LABEL(ret, start);
|
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
[PRISM] Fix `PM_CALL_NODE` assignment
This PR fixes ruby/prism#1963. Array and variable assignment was broken
for call nodes. The change checks if the `method_id` is related to
assignment and if is adds a `putnil`, `setn` and a `pop`.
The incorrect instructions meant that in some cases (demonstrated in
tests) the wrong value would be returned.
I verified that this fixes the test mentioned in the issue
(run: `RUBY_ISEQ_DUMP_DEBUG=prism make test/-ext-/st/test_numhash.rb`)
Incorrect instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(4,10)>
0000 putnil ( 4)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:3 (3,0)-(3,10)>
0000 putself ( 3)[Li]
0001 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0004 putself
0005 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0008 putself
0009 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0012 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0015 leave
```
Fixed instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(4,10)>
0000 putnil ( 4)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:3 (3,0)-(3,10)>
0000 putnil ( 3)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
```
Fixes ruby/prism#1963
2023-12-08 23:00:48 +03:00
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, call_node->name);
|
2023-12-12 22:24:00 +03:00
|
|
|
if (node->flags & PM_CALL_NODE_FLAGS_ATTRIBUTE_WRITE) {
|
[PRISM] Fix incorrect instructions for `default_proc=`
This is kind of specific and was found via debugging ruby/prism#2061 but
does not actually fix that issue.
The change here checks for `!popped` for the additional instructions
that are normally added for nodes with the `attribute_write` flag.
I also removed the extra catch table by deleting the
`ISEQ_COMPILE_DATA(iseq)->catch_except_p = true;` line. I'm...not
entirely sure why it was added but it doesn't match the upstream
compiler
[code](https://github.com/ruby/ruby/blob/92b10f5be7453aceb5863e46ac775a4ddbf83b97/compile.c#L887-L892).
The changes here unfortunately don't improve the test failures mentioned in
the linked issue so we still have other issues with instructions for
hashes.
Instructions before:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(34,8)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] h@0
0000 putnil ( 32)[Li]
0001 putobject true
0003 getconstant :Hash
0005 send <calldata!mid:new, argc:0, ARGS_SIMPLE>, nil
0008 setlocal h@0, 0
0011 getlocal h@0, 0 ( 33)[Li]
0014 putspecialobject 1
0016 send <calldata!mid:lambda, argc:0, FCALL>, block in <compiled>
0019 send <calldata!mid:default_proc=, argc:1, ARGS_SIMPLE>, nil
0022 pop
0023 getlocal h@0, 0 ( 34)[Li]
0026 putobject :nope
0028 send <calldata!mid:[], argc:1, ARGS_SIMPLE>, nil
0031 leave
== disasm: #<ISeq:block in <compiled>@<compiled>:33 (33,19)-(33,32)>
local table (size: 2, argc: 2 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 2] _@0<Arg> [ 1] _@1<Arg>
0000 putobject true ( 33)[LiBc]
0002 leave [Br]
true
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:31 (31,0)-(33,8)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] h@0
0000 putnil ( 31)[Li]
0001 putobject true
0003 getconstant :Hash
0005 send <calldata!mid:new, argc:0, ARGS_SIMPLE>, nil
0008 setlocal h@0, 0
0011 putnil ( 32)[Li]
0012 getlocal h@0, 0
0015 putspecialobject 1
0017 send <calldata!mid:lambda, argc:0, FCALL>, block in <compiled>
0020 setn 2
0022 send <calldata!mid:default_proc=, argc:1, ARGS_SIMPLE>, nil
0025 pop
0026 pop
0027 getlocal h@0, 0 ( 33)[Li]
0030 putobject :nope
0032 send <calldata!mid:[], argc:1, ARGS_SIMPLE>, nil
0035 leave ( 31)
== disasm: #<ISeq:block in <compiled>@<compiled>:32 (32,17)-(32,32)>
== catch table
| catch type: redo st: 0000 ed: 0002 sp: 0000 cont: 0000
| catch type: next st: 0000 ed: 0002 sp: 0000 cont: 0002
|------------------------------------------------------------------------
local table (size: 2, argc: 2 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 2] _@0<Arg> [ 1] _@1<Arg>
0000 putobject true ( 32)[LiBc]
0002 leave [Br]
```
Instructions after:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(34,8)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] h@0
0000 putnil ( 32)[Li]
0001 putobject true
0003 getconstant :Hash
0005 send <calldata!mid:new, argc:0, ARGS_SIMPLE>, nil
0008 setlocal h@0, 0
0011 getlocal h@0, 0 ( 33)[Li]
0014 putspecialobject 1
0016 send <calldata!mid:lambda, argc:0, FCALL>, block in <compiled>
0019 send <calldata!mid:default_proc=, argc:1, ARGS_SIMPLE>, nil
0022 pop
0023 getlocal h@0, 0 ( 34)[Li]
0026 putobject :nope
0028 send <calldata!mid:[], argc:1, ARGS_SIMPLE>, nil
0031 leave
== disasm: #<ISeq:block in <compiled>@<compiled>:33 (33,19)-(33,32)>
local table (size: 2, argc: 2 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 2] _@0<Arg> [ 1] _@1<Arg>
0000 putobject true ( 33)[LiBc]
0002 leave [Br]
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:31 (31,0)-(33,8)>
local table (size: 1, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 1] h@0
0000 putnil ( 31)[Li]
0001 putobject true
0003 getconstant :Hash
0005 send <calldata!mid:new, argc:0, ARGS_SIMPLE>, nil
0008 setlocal h@0, 0
0011 getlocal h@0, 0 ( 32)[Li]
0014 putspecialobject 1
0016 send <calldata!mid:lambda, argc:0, FCALL>, block in <compiled>
0019 send <calldata!mid:default_proc=, argc:1, ARGS_SIMPLE>, nil
0022 pop
0023 getlocal h@0, 0 ( 33)[Li]
0026 putobject :nope
0028 send <calldata!mid:[], argc:1, ARGS_SIMPLE>, nil
0031 leave ( 31)
== disasm: #<ISeq:block in <compiled>@<compiled>:32 (32,17)-(32,32)>
local table (size: 2, argc: 2 [opts: 0, rest: -1, post: 0, block: -1, kw: -1@-1, kwrest: -1])
[ 2] _@0<Arg> [ 1] _@1<Arg>
0000 putobject true ( 32)[LiBc]
0002 leave [Br]
```
2023-12-15 19:32:10 +03:00
|
|
|
if (!popped) {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
[PRISM] Fix `PM_CALL_NODE` assignment
This PR fixes ruby/prism#1963. Array and variable assignment was broken
for call nodes. The change checks if the `method_id` is related to
assignment and if is adds a `putnil`, `setn` and a `pop`.
The incorrect instructions meant that in some cases (demonstrated in
tests) the wrong value would be returned.
I verified that this fixes the test mentioned in the issue
(run: `RUBY_ISEQ_DUMP_DEBUG=prism make test/-ext-/st/test_numhash.rb`)
Incorrect instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(4,10)>
0000 putnil ( 4)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:3 (3,0)-(3,10)>
0000 putself ( 3)[Li]
0001 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0004 putself
0005 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0008 putself
0009 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0012 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0015 leave
```
Fixed instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(4,10)>
0000 putnil ( 4)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:3 (3,0)-(3,10)>
0000 putnil ( 3)[Li]
0001 putself
0002 send <calldata!mid:tbl, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0005 putself
0006 send <calldata!mid:i, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0009 putself
0010 send <calldata!mid:j, argc:0, FCALL|VCALL|ARGS_SIMPLE>, nil
0013 setn 3
0015 send <calldata!mid:[]=, argc:2, ARGS_SIMPLE>, nil
0018 pop
0019 leave
```
Fixes ruby/prism#1963
2023-12-08 23:00:48 +03:00
|
|
|
}
|
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
if (call_node->receiver == NULL) {
|
2023-10-30 19:56:30 +03:00
|
|
|
PM_PUTSELF;
|
2024-01-29 19:58:26 +03:00
|
|
|
pm_compile_call(iseq, call_node, ret, src, popped, scope_node, method_id, start);
|
|
|
|
}
|
|
|
|
else if (method_id == idFreeze &&
|
|
|
|
PM_NODE_TYPE_P(call_node->receiver, PM_STRING_NODE) &&
|
|
|
|
call_node->arguments == NULL &&
|
|
|
|
call_node->block == NULL &&
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->option->specialized_instruction) {
|
|
|
|
VALUE str = rb_fstring(parse_string_encoded(call_node->receiver, &((pm_string_node_t *)call_node->receiver)->unescaped, parser));
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, opt_str_freeze, str, new_callinfo(iseq, idFreeze, 0, 0, NULL, FALSE));
|
|
|
|
}
|
|
|
|
else {
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(call_node->receiver);
|
2024-01-29 19:58:26 +03:00
|
|
|
pm_compile_call(iseq, call_node, ret, src, popped, scope_node, method_id, start);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-10-25 18:20:07 +03:00
|
|
|
case PM_CALL_AND_WRITE_NODE: {
|
|
|
|
pm_call_and_write_node_t *call_and_write_node = (pm_call_and_write_node_t*) node;
|
|
|
|
|
2023-12-15 00:44:38 +03:00
|
|
|
bool safe_nav = node->flags & PM_CALL_NODE_FLAGS_SAFE_NAVIGATION;
|
|
|
|
|
|
|
|
pm_compile_call_and_or_write_node(true, call_and_write_node->receiver, call_and_write_node->value, call_and_write_node->write_name, call_and_write_node->read_name, safe_nav, ret, iseq, lineno, src, popped, scope_node);
|
2023-10-25 18:40:30 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
case PM_CALL_OR_WRITE_NODE: {
|
|
|
|
pm_call_or_write_node_t *call_or_write_node = (pm_call_or_write_node_t*) node;
|
2023-12-15 00:44:38 +03:00
|
|
|
bool safe_nav = node->flags & PM_CALL_NODE_FLAGS_SAFE_NAVIGATION;
|
2023-10-25 18:40:30 +03:00
|
|
|
|
2023-12-15 00:44:38 +03:00
|
|
|
pm_compile_call_and_or_write_node(false, call_or_write_node->receiver, call_or_write_node->value, call_or_write_node->write_name, call_or_write_node->read_name, safe_nav, ret, iseq, lineno, src, popped, scope_node);
|
2023-10-25 18:40:30 +03:00
|
|
|
|
2023-10-25 18:20:07 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-10-25 18:58:45 +03:00
|
|
|
case PM_CALL_OPERATOR_WRITE_NODE: {
|
|
|
|
pm_call_operator_write_node_t *call_operator_write_node = (pm_call_operator_write_node_t*) node;
|
|
|
|
|
|
|
|
NODE dummy_line_node = generate_dummy_line_node(lineno, lineno);
|
|
|
|
|
|
|
|
int flag = 0;
|
|
|
|
|
|
|
|
if (PM_NODE_TYPE_P(call_operator_write_node->receiver, PM_SELF_NODE)) {
|
|
|
|
flag = VM_CALL_FCALL;
|
|
|
|
}
|
|
|
|
|
2023-11-02 21:08:03 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(call_operator_write_node->receiver);
|
2023-10-25 18:58:45 +03:00
|
|
|
|
|
|
|
ID write_name_id = pm_constant_id_lookup(scope_node, call_operator_write_node->write_name);
|
|
|
|
ID read_name_id = pm_constant_id_lookup(scope_node, call_operator_write_node->read_name);
|
|
|
|
ID operator_id = pm_constant_id_lookup(scope_node, call_operator_write_node->operator);
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-10-25 18:58:45 +03:00
|
|
|
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, read_name_id, INT2FIX(0), INT2FIX(flag));
|
|
|
|
|
2023-11-02 21:08:03 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(call_operator_write_node->value);
|
2023-10-25 18:58:45 +03:00
|
|
|
ADD_SEND(ret, &dummy_line_node, operator_id, INT2FIX(1));
|
|
|
|
|
|
|
|
if (!popped) {
|
|
|
|
PM_SWAP;
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(1));
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, write_name_id, INT2FIX(1), INT2FIX(flag));
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_POP;
|
2023-10-25 18:58:45 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2024-01-12 01:05:42 +03:00
|
|
|
case PM_CALL_TARGET_NODE: {
|
|
|
|
// Call targets can be used to indirectly call a method in places like
|
|
|
|
// rescue references, for loops, and multiple assignment. In those
|
|
|
|
// circumstances, it's necessary to first compile the receiver, then to
|
|
|
|
// compile the method call itself.
|
|
|
|
//
|
|
|
|
// Therefore in the main switch case here where we're compiling a call
|
|
|
|
// target, we're only going to compile the receiver. Then wherever
|
|
|
|
// we've called into pm_compile_node when we're compiling call targets,
|
|
|
|
// we'll need to make sure we compile the method call as well.
|
|
|
|
pm_call_target_node_t *cast = (pm_call_target_node_t*) node;
|
|
|
|
PM_COMPILE_NOT_POPPED(cast->receiver);
|
|
|
|
return;
|
|
|
|
}
|
2023-10-24 21:24:36 +03:00
|
|
|
case PM_CASE_NODE: {
|
|
|
|
pm_case_node_t *case_node = (pm_case_node_t *)node;
|
|
|
|
bool has_predicate = case_node->predicate;
|
|
|
|
if (has_predicate) {
|
|
|
|
PM_COMPILE_NOT_POPPED(case_node->predicate);
|
|
|
|
}
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
pm_node_list_t conditions = case_node->conditions;
|
|
|
|
|
2024-01-18 18:36:49 +03:00
|
|
|
LABEL **conditions_labels = (LABEL **)ALLOCA_N(VALUE, conditions.size + 1);
|
2023-10-24 21:24:36 +03:00
|
|
|
LABEL *label;
|
|
|
|
|
|
|
|
for (size_t i = 0; i < conditions.size; i++) {
|
|
|
|
label = NEW_LABEL(lineno);
|
|
|
|
conditions_labels[i] = label;
|
2024-01-12 21:04:59 +03:00
|
|
|
pm_when_node_t *when_node = (pm_when_node_t *)conditions.nodes[i];
|
2023-10-24 21:24:36 +03:00
|
|
|
|
2024-01-12 21:04:59 +03:00
|
|
|
for (size_t i = 0; i < when_node->conditions.size; i++) {
|
|
|
|
pm_node_t *condition_node = when_node->conditions.nodes[i];
|
2024-01-12 18:40:23 +03:00
|
|
|
|
2024-01-12 21:04:59 +03:00
|
|
|
if (PM_NODE_TYPE_P(condition_node, PM_SPLAT_NODE)) {
|
2024-01-17 19:44:58 +03:00
|
|
|
int checkmatch_type = has_predicate ? VM_CHECKMATCH_TYPE_CASE : VM_CHECKMATCH_TYPE_WHEN;
|
2024-01-12 21:04:59 +03:00
|
|
|
ADD_INSN (ret, &dummy_line_node, dup);
|
|
|
|
PM_COMPILE_NOT_POPPED(condition_node);
|
2024-01-17 19:44:58 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, checkmatch,
|
|
|
|
INT2FIX(checkmatch_type | VM_CHECKMATCH_ARRAY));
|
2024-01-12 21:04:59 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_COMPILE_NOT_POPPED(condition_node);
|
|
|
|
if (has_predicate) {
|
2024-01-12 18:40:23 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(1));
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, idEqq, INT2NUM(1), INT2FIX(VM_CALL_FCALL | VM_CALL_ARGS_SIMPLE));
|
|
|
|
}
|
2023-10-24 21:24:36 +03:00
|
|
|
}
|
2024-01-12 21:04:59 +03:00
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, label);
|
2023-10-24 21:24:36 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_predicate) {
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_POP;
|
2024-01-12 21:04:59 +03:00
|
|
|
}
|
2023-10-24 21:24:36 +03:00
|
|
|
|
2024-01-12 21:04:59 +03:00
|
|
|
if (case_node->consequent) {
|
|
|
|
PM_COMPILE((pm_node_t *)case_node->consequent);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
2023-10-24 21:24:36 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, end_label);
|
|
|
|
|
|
|
|
for (size_t i = 0; i < conditions.size; i++) {
|
|
|
|
label = conditions_labels[i];
|
|
|
|
ADD_LABEL(ret, label);
|
|
|
|
if (has_predicate) {
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_POP;
|
2023-10-24 21:24:36 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
pm_while_node_t *condition_node = (pm_while_node_t *)conditions.nodes[i];
|
|
|
|
if (condition_node->statements) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE((pm_node_t *)condition_node->statements);
|
2023-10-24 21:24:36 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, end_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
return;
|
|
|
|
}
|
2023-12-13 19:34:05 +03:00
|
|
|
case PM_CASE_MATCH_NODE: {
|
|
|
|
// If you use the `case` keyword to create a case match node, it will
|
|
|
|
// match against all of the `in` clauses until it finds one that
|
|
|
|
// matches. If it doesn't find one, it can optionally fall back to an
|
|
|
|
// `else` clause. If none is present and a match wasn't found, it will
|
|
|
|
// raise an appropriate error.
|
|
|
|
const pm_case_match_node_t *cast = (const pm_case_match_node_t *) node;
|
|
|
|
|
|
|
|
// This is the anchor that we will compile the bodies of the various
|
|
|
|
// `in` nodes into. We'll make sure that the patterns that are compiled
|
|
|
|
// jump into the correct spots within this anchor.
|
|
|
|
DECL_ANCHOR(body_seq);
|
|
|
|
INIT_ANCHOR(body_seq);
|
|
|
|
|
|
|
|
// This is the anchor that we will compile the patterns of the various
|
|
|
|
// `in` nodes into. If a match is found, they will need to jump into the
|
|
|
|
// body_seq anchor to the correct spot.
|
|
|
|
DECL_ANCHOR(cond_seq);
|
|
|
|
INIT_ANCHOR(cond_seq);
|
|
|
|
|
|
|
|
// This label is used to indicate the end of the entire node. It is
|
|
|
|
// jumped to after the entire stack is cleaned up.
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
// This label is used as the fallback for the case match. If no match is
|
|
|
|
// found, then we jump to this label. This is either an `else` clause or
|
|
|
|
// an error handler.
|
|
|
|
LABEL *else_label = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
// We're going to use this to uniquely identify each branch so that we
|
|
|
|
// can track coverage information.
|
|
|
|
int branch_id = 0;
|
|
|
|
// VALUE branches = 0;
|
|
|
|
|
|
|
|
// If there is only one pattern, then the behavior changes a bit. It
|
|
|
|
// effectively gets treated as a match required node (this is how it is
|
|
|
|
// represented in the other parser).
|
|
|
|
bool in_single_pattern = cast->consequent == NULL && cast->conditions.size == 1;
|
|
|
|
|
|
|
|
// First, we're going to push a bunch of stuff onto the stack that is
|
|
|
|
// going to serve as our scratch space.
|
|
|
|
if (in_single_pattern) {
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil); // key error key
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil); // key error matchee
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qfalse); // key error?
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil); // error string
|
|
|
|
}
|
|
|
|
|
|
|
|
// Now we're going to compile the value to match against.
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil); // deconstruct cache
|
|
|
|
PM_COMPILE_NOT_POPPED(cast->predicate);
|
|
|
|
|
|
|
|
// Next, we'll loop through every in clause and compile its body into
|
|
|
|
// the body_seq anchor and its pattern into the cond_seq anchor. We'll
|
|
|
|
// make sure the pattern knows how to jump correctly into the body if it
|
|
|
|
// finds a match.
|
|
|
|
for (size_t index = 0; index < cast->conditions.size; index++) {
|
|
|
|
const pm_node_t *condition = cast->conditions.nodes[index];
|
|
|
|
assert(PM_NODE_TYPE_P(condition, PM_IN_NODE));
|
|
|
|
|
2023-12-14 23:25:54 +03:00
|
|
|
const pm_in_node_t *in_node = (const pm_in_node_t *) condition;
|
2023-12-13 19:34:05 +03:00
|
|
|
|
|
|
|
pm_line_node_t in_line;
|
|
|
|
pm_line_node(&in_line, scope_node, (const pm_node_t *) in_node);
|
|
|
|
|
|
|
|
pm_line_node_t pattern_line;
|
|
|
|
pm_line_node(&pattern_line, scope_node, (const pm_node_t *) in_node->pattern);
|
|
|
|
|
|
|
|
if (branch_id) {
|
|
|
|
ADD_INSN(body_seq, &in_line.node, putnil);
|
|
|
|
}
|
|
|
|
|
|
|
|
LABEL *body_label = NEW_LABEL(in_line.lineno);
|
|
|
|
ADD_LABEL(body_seq, body_label);
|
|
|
|
ADD_INSN1(body_seq, &in_line.node, adjuststack, INT2FIX(in_single_pattern ? 6 : 2));
|
|
|
|
|
|
|
|
// TODO: We need to come back to this and enable trace branch
|
|
|
|
// coverage. At the moment we can't call this function because it
|
|
|
|
// accepts a NODE* and not a pm_node_t*.
|
|
|
|
// add_trace_branch_coverage(iseq, body_seq, in_node->statements || in, branch_id++, "in", branches);
|
|
|
|
|
|
|
|
branch_id++;
|
|
|
|
if (in_node->statements != NULL) {
|
|
|
|
PM_COMPILE_INTO_ANCHOR(body_seq, (const pm_node_t *) in_node->statements);
|
|
|
|
} else if (!popped) {
|
|
|
|
ADD_INSN(body_seq, &in_line.node, putnil);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(body_seq, &in_line.node, jump, end_label);
|
|
|
|
LABEL *next_pattern_label = NEW_LABEL(pattern_line.lineno);
|
|
|
|
|
|
|
|
ADD_INSN(cond_seq, &pattern_line.node, dup);
|
|
|
|
pm_compile_pattern(iseq, scope_node, in_node->pattern, cond_seq, src, body_label, next_pattern_label, in_single_pattern, false, true, 2);
|
|
|
|
ADD_LABEL(cond_seq, next_pattern_label);
|
|
|
|
LABEL_UNREMOVABLE(next_pattern_label);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (cast->consequent != NULL) {
|
|
|
|
// If we have an `else` clause, then this becomes our fallback (and
|
|
|
|
// there is no need to compile in code to potentially raise an
|
|
|
|
// error).
|
|
|
|
const pm_else_node_t *else_node = (const pm_else_node_t *) cast->consequent;
|
|
|
|
|
|
|
|
ADD_LABEL(cond_seq, else_label);
|
|
|
|
ADD_INSN(cond_seq, &dummy_line_node, pop);
|
|
|
|
ADD_INSN(cond_seq, &dummy_line_node, pop);
|
|
|
|
|
|
|
|
// TODO: trace branch coverage
|
|
|
|
// add_trace_branch_coverage(iseq, cond_seq, cast->consequent, branch_id, "else", branches);
|
|
|
|
|
|
|
|
if (else_node->statements != NULL) {
|
|
|
|
PM_COMPILE_INTO_ANCHOR(cond_seq, (const pm_node_t *) else_node->statements);
|
|
|
|
} else if (!popped) {
|
|
|
|
ADD_INSN(cond_seq, &dummy_line_node, putnil);
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSNL(cond_seq, &dummy_line_node, jump, end_label);
|
|
|
|
ADD_INSN(cond_seq, &dummy_line_node, putnil);
|
|
|
|
if (popped) {
|
|
|
|
ADD_INSN(cond_seq, &dummy_line_node, putnil);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// Otherwise, if we do not have an `else` clause, we will compile in
|
|
|
|
// the code to handle raising an appropriate error.
|
|
|
|
ADD_LABEL(cond_seq, else_label);
|
|
|
|
|
|
|
|
// TODO: trace branch coverage
|
|
|
|
// add_trace_branch_coverage(iseq, cond_seq, orig_node, branch_id, "else", branches);
|
|
|
|
|
|
|
|
if (in_single_pattern) {
|
|
|
|
pm_compile_pattern_error_handler(iseq, scope_node, node, cond_seq, src, end_label, popped);
|
|
|
|
} else {
|
|
|
|
ADD_INSN1(cond_seq, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(cond_seq, &dummy_line_node, putobject, rb_eNoMatchingPatternError);
|
|
|
|
ADD_INSN1(cond_seq, &dummy_line_node, topn, INT2FIX(2));
|
|
|
|
ADD_SEND(cond_seq, &dummy_line_node, id_core_raise, INT2FIX(2));
|
|
|
|
|
|
|
|
ADD_INSN1(cond_seq, &dummy_line_node, adjuststack, INT2FIX(3));
|
|
|
|
if (!popped) ADD_INSN(cond_seq, &dummy_line_node, putnil);
|
|
|
|
ADD_INSNL(cond_seq, &dummy_line_node, jump, end_label);
|
|
|
|
ADD_INSN1(cond_seq, &dummy_line_node, dupn, INT2FIX(1));
|
|
|
|
if (popped) ADD_INSN(cond_seq, &dummy_line_node, putnil);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// At the end of all of this compilation, we will add the code for the
|
|
|
|
// conditions first, then the various bodies, then mark the end of the
|
|
|
|
// entire sequence with the end label.
|
|
|
|
ADD_SEQ(ret, cond_seq);
|
|
|
|
ADD_SEQ(ret, body_seq);
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CLASS_NODE: {
|
|
|
|
pm_class_node_t *class_node = (pm_class_node_t *)node;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID class_id = pm_constant_id_lookup(scope_node, class_node->name);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
VALUE class_name = rb_str_freeze(rb_sprintf("<class:%"PRIsVALUE">", rb_id2str(class_id)));
|
|
|
|
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t *)class_node, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
const rb_iseq_t *class_iseq = NEW_CHILD_ISEQ(&next_scope_node, class_name, ISEQ_TYPE_CLASS, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
// TODO: Once we merge constant path nodes correctly, fix this flag
|
|
|
|
const int flags = VM_DEFINECLASS_TYPE_CLASS |
|
|
|
|
(class_node->superclass ? VM_DEFINECLASS_FLAG_HAS_SUPERCLASS : 0) |
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_class_path(ret, iseq, class_node->constant_path, &dummy_line_node, src, false, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
if (class_node->superclass) {
|
2023-10-13 20:59:37 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(class_node->superclass);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defineclass, ID2SYM(class_id), class_iseq, INT2FIX(flags));
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, (VALUE)class_iseq);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CLASS_VARIABLE_AND_WRITE_NODE: {
|
|
|
|
pm_class_variable_and_write_node_t *class_variable_and_write_node = (pm_class_variable_and_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID class_variable_name_id = pm_constant_id_lookup(scope_node, class_variable_and_write_node->name);
|
2023-09-02 00:20:03 +03:00
|
|
|
VALUE class_variable_name_val = ID2SYM(class_variable_name_id);
|
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getclassvariable,
|
|
|
|
class_variable_name_val,
|
|
|
|
get_cvar_ic_value(iseq, class_variable_name_id));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(class_variable_and_write_node->value);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, setclassvariable,
|
|
|
|
class_variable_name_val,
|
|
|
|
get_cvar_ic_value(iseq, class_variable_name_id));
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CLASS_VARIABLE_OPERATOR_WRITE_NODE: {
|
|
|
|
pm_class_variable_operator_write_node_t *class_variable_operator_write_node = (pm_class_variable_operator_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID class_variable_name_id = pm_constant_id_lookup(scope_node, class_variable_operator_write_node->name);
|
2023-09-02 00:20:03 +03:00
|
|
|
VALUE class_variable_name_val = ID2SYM(class_variable_name_id);
|
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getclassvariable,
|
|
|
|
class_variable_name_val,
|
|
|
|
get_cvar_ic_value(iseq, class_variable_name_id));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(class_variable_operator_write_node->value);
|
2023-10-17 01:36:25 +03:00
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, class_variable_operator_write_node->operator);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
int flags = VM_CALL_ARGS_SIMPLE;
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, method_id, INT2NUM(1), INT2FIX(flags));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, setclassvariable,
|
|
|
|
class_variable_name_val,
|
|
|
|
get_cvar_ic_value(iseq, class_variable_name_id));
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CLASS_VARIABLE_OR_WRITE_NODE: {
|
|
|
|
pm_class_variable_or_write_node_t *class_variable_or_write_node = (pm_class_variable_or_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
[Prism] Fix cvar or assignment instructions
The instructions for `PM_CLASS_VARIABLE_OR_WRITE_NODE` were incorrect as
they were missing a `putnil`, a `defined`, and a `branchunless`.
I verified this is fixed via the instructions and running the following:
`RUBY_ISEQ_DUMP_DEBUG=prism make test/csv/interface/test_read_write.rb`.
These new instructions can't go in the defined function because
`defined?(@@fop ||= 1)` should return "assignment" not "class variable".
Instructions before:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(30,11)>
0000 putnil ( 30)[Li]
0001 defined class variable, :@@foo, true
0005 branchunless 14
0007 getclassvariable :@@foo, <is:0>
0010 dup
0011 branchif 20
0013 pop
0014 putobject 1
0016 dup
0017 setclassvariable :@@foo, <is:0>
0020 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:29 (29,0)-(29,11)>
0000 getclassvariable :@@foo, <is:0> ( 29)[Li]
0003 dup
0004 branchif 13
0006 pop
0007 putobject 1
0009 dup
0010 setclassvariable :@@foo, <is:0>
0013 leave
```
Instructions after:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(30,11)>
0000 putnil ( 30)[Li]
0001 defined class variable, :@@foo, true
0005 branchunless 14
0007 getclassvariable :@@foo, <is:0>
0010 dup
0011 branchif 20
0013 pop
0014 putobject 1
0016 dup
0017 setclassvariable :@@foo, <is:0>
0020 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:29 (29,0)-(29,11)>
0000 putnil ( 29)[Li]
0001 defined class variable, :@@foo, true
0005 branchunless 14
0007 getclassvariable :@@foo, <is:0>
0010 dup
0011 branchif 20
0013 pop
0014 putobject 1
0016 dup
0017 setclassvariable :@@foo, <is:0>
0020 leave
```
Fixes ruby/prism#2064
2023-12-14 20:20:24 +03:00
|
|
|
LABEL *start_label = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil);
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_CVAR),
|
|
|
|
ID2SYM(pm_constant_id_lookup(scope_node, class_variable_or_write_node->name)), Qtrue);
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, start_label);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID class_variable_name_id = pm_constant_id_lookup(scope_node, class_variable_or_write_node->name);
|
2023-09-02 00:20:03 +03:00
|
|
|
VALUE class_variable_name_val = ID2SYM(class_variable_name_id);
|
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getclassvariable,
|
|
|
|
class_variable_name_val,
|
|
|
|
get_cvar_ic_value(iseq, class_variable_name_id));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
[Prism] Fix cvar or assignment instructions
The instructions for `PM_CLASS_VARIABLE_OR_WRITE_NODE` were incorrect as
they were missing a `putnil`, a `defined`, and a `branchunless`.
I verified this is fixed via the instructions and running the following:
`RUBY_ISEQ_DUMP_DEBUG=prism make test/csv/interface/test_read_write.rb`.
These new instructions can't go in the defined function because
`defined?(@@fop ||= 1)` should return "assignment" not "class variable".
Instructions before:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(30,11)>
0000 putnil ( 30)[Li]
0001 defined class variable, :@@foo, true
0005 branchunless 14
0007 getclassvariable :@@foo, <is:0>
0010 dup
0011 branchif 20
0013 pop
0014 putobject 1
0016 dup
0017 setclassvariable :@@foo, <is:0>
0020 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:29 (29,0)-(29,11)>
0000 getclassvariable :@@foo, <is:0> ( 29)[Li]
0003 dup
0004 branchif 13
0006 pop
0007 putobject 1
0009 dup
0010 setclassvariable :@@foo, <is:0>
0013 leave
```
Instructions after:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(30,11)>
0000 putnil ( 30)[Li]
0001 defined class variable, :@@foo, true
0005 branchunless 14
0007 getclassvariable :@@foo, <is:0>
0010 dup
0011 branchif 20
0013 pop
0014 putobject 1
0016 dup
0017 setclassvariable :@@foo, <is:0>
0020 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:29 (29,0)-(29,11)>
0000 putnil ( 29)[Li]
0001 defined class variable, :@@foo, true
0005 branchunless 14
0007 getclassvariable :@@foo, <is:0>
0010 dup
0011 branchif 20
0013 pop
0014 putobject 1
0016 dup
0017 setclassvariable :@@foo, <is:0>
0020 leave
```
Fixes ruby/prism#2064
2023-12-14 20:20:24 +03:00
|
|
|
ADD_LABEL(ret, start_label);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(class_variable_or_write_node->value);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, setclassvariable,
|
|
|
|
class_variable_name_val,
|
|
|
|
get_cvar_ic_value(iseq, class_variable_name_id));
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CLASS_VARIABLE_READ_NODE: {
|
2023-09-02 00:20:03 +03:00
|
|
|
if (!popped) {
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_class_variable_read_node_t *class_variable_read_node = (pm_class_variable_read_node_t *) node;
|
2023-10-17 01:36:25 +03:00
|
|
|
ID cvar_name = pm_constant_id_lookup(scope_node, class_variable_read_node->name);
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, getclassvariable, ID2SYM(cvar_name), get_cvar_ic_value(iseq, cvar_name));
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CLASS_VARIABLE_WRITE_NODE: {
|
|
|
|
pm_class_variable_write_node_t *write_node = (pm_class_variable_write_node_t *) node;
|
|
|
|
PM_COMPILE_NOT_POPPED(write_node->value);
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID cvar_name = pm_constant_id_lookup(scope_node, write_node->name);
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, setclassvariable, ID2SYM(cvar_name), get_cvar_ic_value(iseq, cvar_name));
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CONSTANT_PATH_NODE: {
|
|
|
|
pm_constant_path_node_t *constant_path_node = (pm_constant_path_node_t*) node;
|
2023-08-29 19:27:00 +03:00
|
|
|
if (constant_path_node->parent) {
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(constant_path_node->parent);
|
2023-09-28 19:14:38 +03:00
|
|
|
} else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_cObject);
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qfalse);
|
2023-09-11 21:36:09 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
assert(PM_NODE_TYPE_P(constant_path_node->child, PM_CONSTANT_READ_NODE));
|
|
|
|
pm_constant_read_node_t *child = (pm_constant_read_node_t *) constant_path_node->child;
|
2023-09-11 21:36:09 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, getconstant, ID2SYM(pm_constant_id_lookup(scope_node, child->name)));
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-10-26 13:02:55 +03:00
|
|
|
case PM_CONSTANT_PATH_AND_WRITE_NODE: {
|
|
|
|
pm_constant_path_and_write_node_t *constant_path_and_write_node = (pm_constant_path_and_write_node_t*) node;
|
|
|
|
|
|
|
|
LABEL *lfin = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
pm_constant_path_node_t *target = constant_path_and_write_node->target;
|
2023-12-06 19:05:43 +03:00
|
|
|
if (target->parent) {
|
|
|
|
PM_COMPILE_NOT_POPPED(target->parent);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_cObject);
|
|
|
|
}
|
2023-10-26 13:02:55 +03:00
|
|
|
|
|
|
|
pm_constant_read_node_t *child = (pm_constant_read_node_t *)target->child;
|
|
|
|
VALUE child_name = ID2SYM(pm_constant_id_lookup(scope_node, child->name));
|
|
|
|
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-10-26 13:02:55 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, getconstant, child_name);
|
|
|
|
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, lfin);
|
|
|
|
|
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-11-02 21:18:40 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(constant_path_and_write_node->value);
|
2023-10-26 13:02:55 +03:00
|
|
|
|
|
|
|
if (popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(1));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, dupn, INT2FIX(2));
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_SWAP;
|
2023-10-26 13:02:55 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setconstant, child_name);
|
|
|
|
ADD_LABEL(ret, lfin);
|
|
|
|
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_SWAP_UNLESS_POPPED;
|
2023-10-26 13:02:55 +03:00
|
|
|
PM_POP;
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-10-26 12:57:05 +03:00
|
|
|
case PM_CONSTANT_PATH_OR_WRITE_NODE: {
|
|
|
|
pm_constant_path_or_write_node_t *constant_path_or_write_node = (pm_constant_path_or_write_node_t*) node;
|
|
|
|
|
|
|
|
LABEL *lassign = NEW_LABEL(lineno);
|
|
|
|
LABEL *lfin = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
pm_constant_path_node_t *target = constant_path_or_write_node->target;
|
2023-12-06 19:05:43 +03:00
|
|
|
if (target->parent) {
|
|
|
|
PM_COMPILE_NOT_POPPED(target->parent);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_cObject);
|
|
|
|
}
|
2023-10-26 12:57:05 +03:00
|
|
|
|
|
|
|
pm_constant_read_node_t *child = (pm_constant_read_node_t *)target->child;
|
|
|
|
VALUE child_name = ID2SYM(pm_constant_id_lookup(scope_node, child->name));
|
|
|
|
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-10-26 12:57:05 +03:00
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_CONST_FROM), child_name, Qtrue);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, lassign);
|
|
|
|
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-10-26 12:57:05 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, getconstant, child_name);
|
|
|
|
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, lfin);
|
|
|
|
|
|
|
|
PM_POP_UNLESS_POPPED;
|
|
|
|
ADD_LABEL(ret, lassign);
|
2023-11-02 20:45:44 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(constant_path_or_write_node->value);
|
2023-10-26 12:57:05 +03:00
|
|
|
|
|
|
|
if (popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(1));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, dupn, INT2FIX(2));
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_SWAP;
|
2023-10-26 12:57:05 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setconstant, child_name);
|
|
|
|
ADD_LABEL(ret, lfin);
|
|
|
|
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_SWAP_UNLESS_POPPED;
|
2023-10-26 12:57:05 +03:00
|
|
|
PM_POP;
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-10-25 21:00:24 +03:00
|
|
|
case PM_CONSTANT_PATH_OPERATOR_WRITE_NODE: {
|
|
|
|
pm_constant_path_operator_write_node_t *constant_path_operator_write_node = (pm_constant_path_operator_write_node_t*) node;
|
|
|
|
|
|
|
|
pm_constant_path_node_t *target = constant_path_operator_write_node->target;
|
2023-12-06 19:05:43 +03:00
|
|
|
if (target->parent) {
|
|
|
|
PM_COMPILE_NOT_POPPED(target->parent);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_cObject);
|
|
|
|
}
|
2023-10-25 21:00:24 +03:00
|
|
|
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-10-25 21:00:24 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
|
|
|
|
pm_constant_read_node_t *child = (pm_constant_read_node_t *)target->child;
|
|
|
|
VALUE child_name = ID2SYM(pm_constant_id_lookup(scope_node, child->name));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, getconstant, child_name);
|
|
|
|
|
2023-11-02 20:46:40 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(constant_path_operator_write_node->value);
|
2023-10-25 21:00:24 +03:00
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, constant_path_operator_write_node->operator);
|
|
|
|
ADD_CALL(ret, &dummy_line_node, method_id, INT2FIX(1));
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_SWAP;
|
2023-10-25 21:00:24 +03:00
|
|
|
|
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(1));
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_SWAP;
|
2023-10-25 21:00:24 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setconstant, child_name);
|
2024-01-12 01:05:42 +03:00
|
|
|
return;
|
2023-10-25 21:00:24 +03:00
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CONSTANT_PATH_TARGET_NODE: {
|
2024-01-12 01:05:42 +03:00
|
|
|
// Constant path targets can be used to indirectly write a constant in
|
|
|
|
// places like rescue references, for loops, and multiple assignment. In
|
|
|
|
// those circumstances, it's necessary to first compile the parent, then
|
|
|
|
// to compile the child.
|
|
|
|
//
|
|
|
|
// Therefore in the main switch case here where we're compiling a
|
|
|
|
// constant path target, we're only going to compile the parent. Then
|
|
|
|
// wherever we've called into pm_compile_node when we're compiling
|
|
|
|
// constant path targets, we'll need to make sure we compile the child
|
|
|
|
// as well.
|
|
|
|
pm_constant_path_target_node_t *cast = (pm_constant_path_target_node_t *) node;
|
2023-09-19 23:59:07 +03:00
|
|
|
|
2023-10-13 20:59:37 +03:00
|
|
|
if (cast->parent) {
|
2024-01-12 01:05:42 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(cast->parent);
|
2023-10-13 20:59:37 +03:00
|
|
|
}
|
2023-09-19 23:59:07 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CONSTANT_PATH_WRITE_NODE: {
|
|
|
|
pm_constant_path_write_node_t *constant_path_write_node = (pm_constant_path_write_node_t*) node;
|
2023-10-16 16:31:32 +03:00
|
|
|
if (constant_path_write_node->target->parent) {
|
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)constant_path_write_node->target->parent);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_cObject);
|
|
|
|
}
|
|
|
|
PM_COMPILE_NOT_POPPED(constant_path_write_node->value);
|
|
|
|
if (!popped) {
|
2023-10-25 18:34:03 +03:00
|
|
|
PM_SWAP;
|
2023-10-16 16:31:32 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, topn, INT2FIX(1));
|
|
|
|
}
|
2023-10-25 18:34:03 +03:00
|
|
|
PM_SWAP;
|
2023-10-17 01:36:25 +03:00
|
|
|
VALUE constant_name = ID2SYM(pm_constant_id_lookup(scope_node,
|
2023-10-16 16:31:32 +03:00
|
|
|
((pm_constant_read_node_t *)constant_path_write_node->target->child)->name));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setconstant, constant_name);
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CONSTANT_READ_NODE: {
|
|
|
|
pm_constant_read_node_t *constant_read_node = (pm_constant_read_node_t *) node;
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
2023-10-17 01:36:25 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, getconstant, ID2SYM(pm_constant_id_lookup(scope_node, constant_read_node->name)));
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CONSTANT_AND_WRITE_NODE: {
|
|
|
|
pm_constant_and_write_node_t *constant_and_write_node = (pm_constant_and_write_node_t*) node;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
VALUE constant_name = ID2SYM(pm_constant_id_lookup(scope_node, constant_and_write_node->name));
|
2023-09-05 17:54:21 +03:00
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-05 17:54:21 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, getconstant, constant_name);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(constant_and_write_node->value);
|
2023-09-05 17:54:21 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_CONST_BASE));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setconstant, constant_name);
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CONSTANT_OPERATOR_WRITE_NODE: {
|
|
|
|
pm_constant_operator_write_node_t *constant_operator_write_node = (pm_constant_operator_write_node_t*) node;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID constant_name = pm_constant_id_lookup(scope_node, constant_operator_write_node->name);
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-05 17:54:21 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, getconstant, ID2SYM(constant_name));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(constant_operator_write_node->value);
|
2023-10-17 01:36:25 +03:00
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, constant_operator_write_node->operator);
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
int flags = VM_CALL_ARGS_SIMPLE;
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, method_id, INT2NUM(1), INT2FIX(flags));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_CONST_BASE));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setconstant, ID2SYM(constant_name));
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CONSTANT_OR_WRITE_NODE: {
|
|
|
|
pm_constant_or_write_node_t *constant_or_write_node = (pm_constant_or_write_node_t*) node;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
LABEL *set_label= NEW_LABEL(lineno);
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-17 01:36:25 +03:00
|
|
|
VALUE constant_name = ID2SYM(pm_constant_id_lookup(scope_node, constant_or_write_node->name));
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_CONST), constant_name, Qtrue);
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, set_label);
|
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-05 17:54:21 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, getconstant, constant_name);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
ADD_LABEL(ret, set_label);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(constant_or_write_node->value);
|
2023-09-05 17:54:21 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-05 17:54:21 +03:00
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_CONST_BASE));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setconstant, constant_name);
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_CONSTANT_WRITE_NODE: {
|
|
|
|
pm_constant_write_node_t *constant_write_node = (pm_constant_write_node_t *) node;
|
|
|
|
PM_COMPILE_NOT_POPPED(constant_write_node->value);
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_CONST_BASE));
|
2023-10-17 01:36:25 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, setconstant, ID2SYM(pm_constant_id_lookup(scope_node, constant_write_node->name)));
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_DEF_NODE: {
|
|
|
|
pm_def_node_t *def_node = (pm_def_node_t *) node;
|
2023-10-17 01:36:25 +03:00
|
|
|
ID method_name = pm_constant_id_lookup(scope_node, def_node->name);
|
2024-01-18 19:55:31 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t *)def_node, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
rb_iseq_t *method_iseq = NEW_ISEQ(&next_scope_node, rb_id2str(method_name), ISEQ_TYPE_METHOD, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-10-20 04:01:09 +03:00
|
|
|
if (def_node->receiver) {
|
2023-10-24 23:08:50 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(def_node->receiver);
|
2023-10-20 04:01:09 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, definesmethod, ID2SYM(method_name), method_iseq);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, definemethod, ID2SYM(method_name), method_iseq);
|
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, (VALUE)method_iseq);
|
|
|
|
|
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, ID2SYM(method_name));
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_DEFINED_NODE: {
|
|
|
|
pm_defined_node_t *defined_node = (pm_defined_node_t *)node;
|
2023-10-27 00:54:38 +03:00
|
|
|
pm_compile_defined_expr(iseq, defined_node->value, ret, src, popped, scope_node, dummy_line_node, lineno, false);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_EMBEDDED_STATEMENTS_NODE: {
|
|
|
|
pm_embedded_statements_node_t *embedded_statements_node = (pm_embedded_statements_node_t *)node;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-07 17:59:51 +03:00
|
|
|
if (embedded_statements_node->statements) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE((pm_node_t *) (embedded_statements_node->statements));
|
2023-09-07 17:59:51 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-07 17:59:51 +03:00
|
|
|
}
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
// TODO: Concatenate the strings that exist here
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_EMBEDDED_VARIABLE_NODE: {
|
|
|
|
pm_embedded_variable_node_t *embedded_node = (pm_embedded_variable_node_t *)node;
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(embedded_node->variable);
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_FALSE_NODE:
|
2023-08-29 19:27:00 +03:00
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qfalse);
|
|
|
|
}
|
|
|
|
return;
|
2023-12-07 13:24:33 +03:00
|
|
|
case PM_ENSURE_NODE: {
|
|
|
|
pm_ensure_node_t *ensure_node = (pm_ensure_node_t *)node;
|
|
|
|
|
|
|
|
LABEL *start = NEW_LABEL(lineno);
|
|
|
|
LABEL *end = NEW_LABEL(lineno);
|
|
|
|
ADD_LABEL(ret, start);
|
|
|
|
if (ensure_node->statements) {
|
2024-01-19 02:11:17 +03:00
|
|
|
LABEL *prev_end_label = ISEQ_COMPILE_DATA(iseq)->end_label;
|
2023-12-07 13:24:33 +03:00
|
|
|
ISEQ_COMPILE_DATA(iseq)->end_label = end;
|
|
|
|
PM_COMPILE((pm_node_t *)ensure_node->statements);
|
2024-01-19 02:11:17 +03:00
|
|
|
ISEQ_COMPILE_DATA(iseq)->end_label = prev_end_label;
|
2023-12-07 13:24:33 +03:00
|
|
|
}
|
|
|
|
ADD_LABEL(ret, end);
|
2024-01-17 19:19:54 +03:00
|
|
|
return;
|
2023-12-07 13:24:33 +03:00
|
|
|
}
|
[Prism] Fix IfNode and ElseNode
ElseNode looks to have been implemented at the same time as IfNode, but
was resulting in a stack underflow error.
The following is from the test code
```
if foo
bar
end
```
```
❯ make run
compiling compile.c
linking miniruby
./miniruby -I./lib -I. -I.ext/common -r./arm64-darwin22-fake ./test.rb
CRUBY: **************************************************
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(2,19)>
0000 putself ( 2)[Li]
0001 opt_send_without_block <calldata!mid:foo, argc:0, FCALL|VCALL|ARGS_SIMPLE>
0003 branchunless 9
0005 putself
0006 opt_send_without_block <calldata!mid:bar, argc:0, FCALL|VCALL|ARGS_SIMPLE>
0008 pop
0009 putobject_INT2FIX_1_
0010 leave
PRISM: **************************************************
-- raw disasm--------
0000 putself ( 2)
0001 send <calldata:foo, 0>, nil ( 2)
0004 branchunless <L001> ( 2)
0006 jump <L000> ( 2)
<L000> [sp: 0]
* 0008 pop ( 1)
0009 putself ( 2)
0010 send <calldata:bar, 0>, nil ( 2)
0013 pop ( 2)
0014 jump <L002> ( 1)
<L001> [sp: 0]
<L002> [sp: -1]
0016 putobject 1 ( 2)
0018 leave ( 1)
---------------------
<compiled>: <compiled>:1: argument stack underflow (-1) (SyntaxError)
make: *** [run] Error 1
```
This commit fixes the stack underflow error for both IfNode and ElseNode
and introduces tests for them.
2023-10-02 19:51:14 +03:00
|
|
|
case PM_ELSE_NODE: {
|
|
|
|
pm_else_node_t *cast = (pm_else_node_t *)node;
|
2023-10-20 18:03:02 +03:00
|
|
|
if (cast->statements) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE((pm_node_t *)cast->statements);
|
2023-10-20 18:03:02 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-12-09 00:17:07 +03:00
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
2023-10-20 18:03:02 +03:00
|
|
|
}
|
[Prism] Fix IfNode and ElseNode
ElseNode looks to have been implemented at the same time as IfNode, but
was resulting in a stack underflow error.
The following is from the test code
```
if foo
bar
end
```
```
❯ make run
compiling compile.c
linking miniruby
./miniruby -I./lib -I. -I.ext/common -r./arm64-darwin22-fake ./test.rb
CRUBY: **************************************************
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(2,19)>
0000 putself ( 2)[Li]
0001 opt_send_without_block <calldata!mid:foo, argc:0, FCALL|VCALL|ARGS_SIMPLE>
0003 branchunless 9
0005 putself
0006 opt_send_without_block <calldata!mid:bar, argc:0, FCALL|VCALL|ARGS_SIMPLE>
0008 pop
0009 putobject_INT2FIX_1_
0010 leave
PRISM: **************************************************
-- raw disasm--------
0000 putself ( 2)
0001 send <calldata:foo, 0>, nil ( 2)
0004 branchunless <L001> ( 2)
0006 jump <L000> ( 2)
<L000> [sp: 0]
* 0008 pop ( 1)
0009 putself ( 2)
0010 send <calldata:bar, 0>, nil ( 2)
0013 pop ( 2)
0014 jump <L002> ( 1)
<L001> [sp: 0]
<L002> [sp: -1]
0016 putobject 1 ( 2)
0018 leave ( 1)
---------------------
<compiled>: <compiled>:1: argument stack underflow (-1) (SyntaxError)
make: *** [run] Error 1
```
This commit fixes the stack underflow error for both IfNode and ElseNode
and introduces tests for them.
2023-10-02 19:51:14 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_FLIP_FLOP_NODE: {
|
|
|
|
pm_flip_flop_node_t *flip_flop_node = (pm_flip_flop_node_t *)node;
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-10-16 16:31:32 +03:00
|
|
|
LABEL *final_label = NEW_LABEL(lineno);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
LABEL *then_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *else_label = NEW_LABEL(lineno);
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-10-20 18:03:02 +03:00
|
|
|
pm_compile_flip_flop(flip_flop_node, else_label, then_label, iseq, lineno, ret, src, popped, scope_node);
|
2023-10-16 16:31:32 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_LABEL(ret, then_label);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
2023-10-16 16:31:32 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, final_label);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_LABEL(ret, else_label);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qfalse);
|
2023-10-16 16:31:32 +03:00
|
|
|
ADD_LABEL(ret, final_label);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_FLOAT_NODE: {
|
2023-08-29 19:27:00 +03:00
|
|
|
if (!popped) {
|
2023-09-08 22:33:51 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, parse_float(node));
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-10-20 12:59:02 +03:00
|
|
|
case PM_FOR_NODE: {
|
2024-01-12 23:23:47 +03:00
|
|
|
pm_for_node_t *cast = (pm_for_node_t *) node;
|
2023-10-20 12:59:02 +03:00
|
|
|
|
|
|
|
LABEL *retry_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *retry_end_l = NEW_LABEL(lineno);
|
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
// First, compile the collection that we're going to be iterating over.
|
2023-10-20 12:59:02 +03:00
|
|
|
ADD_LABEL(ret, retry_label);
|
2024-01-12 23:23:47 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(cast->collection);
|
2023-10-20 12:59:02 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
// Next, create the new scope that is going to contain the block that
|
|
|
|
// will be passed to the each method.
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_t next_scope_node;
|
2024-01-12 23:23:47 +03:00
|
|
|
pm_scope_node_init((pm_node_t *) cast, &next_scope_node, scope_node, parser);
|
|
|
|
|
|
|
|
const rb_iseq_t *child_iseq = NEW_CHILD_ISEQ(&next_scope_node, make_name_for_block(iseq), ISEQ_TYPE_BLOCK, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
2024-01-18 19:38:53 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
const rb_iseq_t *prev_block = ISEQ_COMPILE_DATA(iseq)->current_block;
|
2023-10-20 12:59:02 +03:00
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = child_iseq;
|
2024-01-12 23:23:47 +03:00
|
|
|
|
|
|
|
// Now, create the method call to each that will be used to iterate over
|
|
|
|
// the collection, and pass the newly created iseq as the block.
|
2023-10-20 12:59:02 +03:00
|
|
|
ADD_SEND_WITH_BLOCK(ret, &dummy_line_node, idEach, INT2FIX(0), child_iseq);
|
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
// We need to put the label "retry_end_l" immediately after the last
|
|
|
|
// "send" instruction. This because vm_throw checks if the break cont is
|
|
|
|
// equal to the index of next insn of the "send". (Otherwise, it is
|
|
|
|
// considered "break from proc-closure". See "TAG_BREAK" handling in
|
|
|
|
// "vm_throw_start".)
|
|
|
|
//
|
|
|
|
// Normally, "send" instruction is at the last. However, qcall under
|
|
|
|
// branch coverage measurement adds some instructions after the "send".
|
|
|
|
//
|
|
|
|
// Note that "invokesuper" appears instead of "send".
|
|
|
|
{
|
|
|
|
INSN *iobj;
|
|
|
|
LINK_ELEMENT *last_elem = LAST_ELEMENT(ret);
|
|
|
|
iobj = IS_INSN(last_elem) ? (INSN*) last_elem : (INSN*) get_prev_insn((INSN*) last_elem);
|
|
|
|
while (INSN_OF(iobj) != BIN(send) && INSN_OF(iobj) != BIN(invokesuper)) {
|
|
|
|
iobj = (INSN*) get_prev_insn(iobj);
|
|
|
|
}
|
|
|
|
ELEM_INSERT_NEXT(&iobj->link, (LINK_ELEMENT*) retry_end_l);
|
2023-10-20 12:59:02 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
// LINK_ANCHOR has a pointer to the last element, but
|
|
|
|
// ELEM_INSERT_NEXT does not update it even if we add an insn to the
|
|
|
|
// last of LINK_ANCHOR. So this updates it manually.
|
|
|
|
if (&iobj->link == LAST_ELEMENT(ret)) {
|
|
|
|
ret->last = (LINK_ELEMENT*) retry_end_l;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = prev_block;
|
2023-10-20 12:59:02 +03:00
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_BREAK, retry_label, retry_end_l, child_iseq, retry_end_l);
|
2023-10-30 19:56:30 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-11-08 18:00:32 +03:00
|
|
|
case PM_FORWARDING_ARGUMENTS_NODE: {
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Cannot compile a ForwardingArgumentsNode directly\n");
|
2023-11-08 18:00:32 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-10-30 19:56:30 +03:00
|
|
|
case PM_FORWARDING_SUPER_NODE: {
|
|
|
|
pm_forwarding_super_node_t *forwarding_super_node = (pm_forwarding_super_node_t *) node;
|
|
|
|
const rb_iseq_t *block = NULL;
|
|
|
|
PM_PUTSELF;
|
|
|
|
int flag = VM_CALL_ZSUPER | VM_CALL_SUPER | VM_CALL_FCALL;
|
2023-10-20 12:59:02 +03:00
|
|
|
|
2023-10-30 19:56:30 +03:00
|
|
|
if (forwarding_super_node->block) {
|
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t *)forwarding_super_node->block, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
block = NEW_CHILD_ISEQ(&next_scope_node, make_name_for_block(iseq), ISEQ_TYPE_BLOCK, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
2024-01-18 19:38:53 +03:00
|
|
|
|
2023-10-30 19:56:30 +03:00
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, (VALUE)block);
|
|
|
|
}
|
|
|
|
|
2023-12-12 19:08:40 +03:00
|
|
|
DECL_ANCHOR(args);
|
|
|
|
INIT_ANCHOR(args);
|
|
|
|
|
|
|
|
struct rb_iseq_constant_body *const body = ISEQ_BODY(iseq);
|
|
|
|
|
|
|
|
const rb_iseq_t *local_iseq = body->local_iseq;
|
|
|
|
const struct rb_iseq_constant_body *const local_body = ISEQ_BODY(local_iseq);
|
|
|
|
|
|
|
|
int argc = 0;
|
|
|
|
int depth = get_lvar_level(iseq);
|
|
|
|
|
|
|
|
if (local_body->param.flags.has_lead) {
|
|
|
|
/* required arguments */
|
|
|
|
for (int i = 0; i < local_body->param.lead_num; i++) {
|
|
|
|
int idx = local_body->local_table_size - i;
|
|
|
|
ADD_GETLOCAL(args, &dummy_line_node, idx, depth);
|
|
|
|
}
|
|
|
|
argc += local_body->param.lead_num;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
if (local_body->param.flags.has_opt) {
|
|
|
|
/* optional arguments */
|
|
|
|
for (int j = 0; j < local_body->param.opt_num; j++) {
|
|
|
|
int idx = local_body->local_table_size - (argc + j);
|
|
|
|
ADD_GETLOCAL(args, &dummy_line_node, idx, depth);
|
|
|
|
}
|
|
|
|
argc += local_body->param.opt_num;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (local_body->param.flags.has_rest) {
|
|
|
|
/* rest argument */
|
|
|
|
int idx = local_body->local_table_size - local_body->param.rest_start;
|
|
|
|
ADD_GETLOCAL(args, &dummy_line_node, idx, depth);
|
|
|
|
ADD_INSN1(args, &dummy_line_node, splatarray, Qfalse);
|
|
|
|
|
|
|
|
argc = local_body->param.rest_start + 1;
|
|
|
|
flag |= VM_CALL_ARGS_SPLAT;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (local_body->param.flags.has_post) {
|
|
|
|
/* post arguments */
|
|
|
|
int post_len = local_body->param.post_num;
|
|
|
|
int post_start = local_body->param.post_start;
|
|
|
|
|
|
|
|
int j = 0;
|
|
|
|
for (; j < post_len; j++) {
|
|
|
|
int idx = local_body->local_table_size - (post_start + j);
|
|
|
|
ADD_GETLOCAL(args, &dummy_line_node, idx, depth);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (local_body->param.flags.has_rest) {
|
|
|
|
// argc remains unchanged from rest branch
|
|
|
|
ADD_INSN1(args, &dummy_line_node, newarray, INT2FIX(j));
|
|
|
|
ADD_INSN (args, &dummy_line_node, concatarray);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
argc = post_len + post_start;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
const struct rb_iseq_param_keyword *const local_keyword = local_body->param.keyword;
|
|
|
|
if (local_body->param.flags.has_kw) {
|
|
|
|
int local_size = local_body->local_table_size;
|
|
|
|
argc++;
|
|
|
|
|
|
|
|
ADD_INSN1(args, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
|
|
|
|
if (local_body->param.flags.has_kwrest) {
|
|
|
|
int idx = local_body->local_table_size - local_keyword->rest_start;
|
|
|
|
ADD_GETLOCAL(args, &dummy_line_node, idx, depth);
|
|
|
|
if (local_keyword->num > 0) {
|
|
|
|
ADD_SEND(args, &dummy_line_node, rb_intern("dup"), INT2FIX(0));
|
|
|
|
flag |= VM_CALL_KW_SPLAT_MUT;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(args, &dummy_line_node, newhash, INT2FIX(0));
|
|
|
|
flag |= VM_CALL_KW_SPLAT_MUT;
|
|
|
|
}
|
|
|
|
int i = 0;
|
|
|
|
for (; i < local_keyword->num; ++i) {
|
|
|
|
ID id = local_keyword->table[i];
|
|
|
|
int idx = local_size - get_local_var_idx(local_iseq, id);
|
|
|
|
ADD_INSN1(args, &dummy_line_node, putobject, ID2SYM(id));
|
|
|
|
ADD_GETLOCAL(args, &dummy_line_node, idx, depth);
|
|
|
|
}
|
|
|
|
ADD_SEND(args, &dummy_line_node, id_core_hash_merge_ptr, INT2FIX(i * 2 + 1));
|
|
|
|
flag |= VM_CALL_KW_SPLAT;
|
|
|
|
}
|
|
|
|
else if (local_body->param.flags.has_kwrest) {
|
|
|
|
int idx = local_body->local_table_size - local_keyword->rest_start;
|
|
|
|
ADD_GETLOCAL(args, &dummy_line_node, idx, depth);
|
|
|
|
argc++;
|
|
|
|
flag |= VM_CALL_KW_SPLAT | VM_CALL_KW_SPLAT_MUT;
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_SEQ(ret, args);
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, invokesuper, new_callinfo(iseq, 0, argc, flag, NULL, block != NULL), block);
|
2023-10-30 19:56:30 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-10-20 12:59:02 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_GLOBAL_VARIABLE_AND_WRITE_NODE: {
|
|
|
|
pm_global_variable_and_write_node_t *global_variable_and_write_node = (pm_global_variable_and_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
VALUE global_variable_name = ID2SYM(pm_constant_id_lookup(scope_node, global_variable_and_write_node->name));
|
2023-09-06 17:28:29 +03:00
|
|
|
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, getglobal, global_variable_name);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(global_variable_and_write_node->value);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setglobal, global_variable_name);
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_GLOBAL_VARIABLE_OPERATOR_WRITE_NODE: {
|
|
|
|
pm_global_variable_operator_write_node_t *global_variable_operator_write_node = (pm_global_variable_operator_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
VALUE global_variable_name = ID2SYM(pm_constant_id_lookup(scope_node, global_variable_operator_write_node->name));
|
2023-09-06 17:28:29 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, getglobal, global_variable_name);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(global_variable_operator_write_node->value);
|
2023-10-17 01:36:25 +03:00
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, global_variable_operator_write_node->operator);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
int flags = VM_CALL_ARGS_SIMPLE;
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, method_id, INT2NUM(1), INT2FIX(flags));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-06 17:28:29 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, setglobal, global_variable_name);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_GLOBAL_VARIABLE_OR_WRITE_NODE: {
|
|
|
|
pm_global_variable_or_write_node_t *global_variable_or_write_node = (pm_global_variable_or_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
LABEL *set_label= NEW_LABEL(lineno);
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-10-17 01:36:25 +03:00
|
|
|
VALUE global_variable_name = ID2SYM(pm_constant_id_lookup(scope_node, global_variable_or_write_node->name));
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_GVAR), global_variable_name, Qtrue);
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, set_label);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, getglobal, global_variable_name);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_LABEL(ret, set_label);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(global_variable_or_write_node->value);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setglobal, global_variable_name);
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_GLOBAL_VARIABLE_READ_NODE: {
|
|
|
|
pm_global_variable_read_node_t *global_variable_read_node = (pm_global_variable_read_node_t *)node;
|
2023-10-17 01:36:25 +03:00
|
|
|
VALUE global_variable_name = ID2SYM(pm_constant_id_lookup(scope_node, global_variable_read_node->name));
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, getglobal, global_variable_name);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_GLOBAL_VARIABLE_WRITE_NODE: {
|
|
|
|
pm_global_variable_write_node_t *write_node = (pm_global_variable_write_node_t *) node;
|
|
|
|
PM_COMPILE_NOT_POPPED(write_node->value);
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-10-17 01:36:25 +03:00
|
|
|
ID ivar_name = pm_constant_id_lookup(scope_node, write_node->name);
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, setglobal, ID2SYM(ivar_name));
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_HASH_NODE: {
|
2023-09-28 17:48:24 +03:00
|
|
|
// If every node in the hash is static, then we can compile the entire
|
|
|
|
// hash now instead of later.
|
2023-09-28 22:19:56 +03:00
|
|
|
if (pm_static_literal_p(node)) {
|
2023-09-28 17:48:24 +03:00
|
|
|
// We're only going to compile this node if it's not popped. If it
|
|
|
|
// is popped, then we know we don't need to do anything since it's
|
|
|
|
// statically known.
|
|
|
|
if (!popped) {
|
2023-10-19 23:50:21 +03:00
|
|
|
VALUE value = pm_static_literal_value(node, scope_node, parser);
|
2023-09-28 22:19:56 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, duphash, value);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, value);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 17:48:24 +03:00
|
|
|
} else {
|
|
|
|
// Here since we know there are possible side-effects inside the
|
|
|
|
// hash contents, we're going to build it entirely at runtime. We'll
|
|
|
|
// do this by pushing all of the key-value pairs onto the stack and
|
|
|
|
// then combining them with newhash.
|
|
|
|
//
|
|
|
|
// If this hash is popped, then this serves only to ensure we enact
|
|
|
|
// all side-effects (like method calls) that are contained within
|
|
|
|
// the hash contents.
|
2023-09-28 22:19:56 +03:00
|
|
|
pm_hash_node_t *cast = (pm_hash_node_t *) node;
|
2023-10-23 16:33:38 +03:00
|
|
|
// Elements must be non-empty, otherwise it would be static literal
|
2023-09-28 22:19:56 +03:00
|
|
|
pm_node_list_t *elements = &cast->elements;
|
|
|
|
|
2023-10-23 16:33:38 +03:00
|
|
|
pm_node_t *cur_node = elements->nodes[0];
|
|
|
|
pm_node_type_t cur_type = PM_NODE_TYPE(cur_node);
|
|
|
|
int elements_of_cur_type = 0;
|
|
|
|
int allocated_hashes = 0;
|
|
|
|
|
2023-11-02 20:56:40 +03:00
|
|
|
if (!PM_NODE_TYPE_P(cur_node, PM_ASSOC_NODE) && !popped) {
|
2023-10-23 16:33:38 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newhash, INT2FIX(0));
|
|
|
|
allocated_hashes++;
|
|
|
|
}
|
|
|
|
|
2023-09-28 22:19:56 +03:00
|
|
|
for (size_t index = 0; index < elements->size; index++) {
|
2023-10-23 16:33:38 +03:00
|
|
|
pm_node_t *cur_node = elements->nodes[index];
|
|
|
|
if (!popped) {
|
|
|
|
if (!PM_NODE_TYPE_P(cur_node, cur_type)) {
|
|
|
|
if (!allocated_hashes) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newhash, INT2FIX(elements_of_cur_type * 2));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if (cur_type == PM_ASSOC_NODE) {
|
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_hash_merge_ptr, INT2FIX(3));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_hash_merge_kwd, INT2FIX(2));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
2023-10-25 18:34:03 +03:00
|
|
|
PM_SWAP;
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(elements->nodes[index]);
|
2023-10-23 16:33:38 +03:00
|
|
|
|
|
|
|
allocated_hashes++;
|
|
|
|
elements_of_cur_type = 0;
|
|
|
|
cur_type = PM_NODE_TYPE(cur_node);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
elements_of_cur_type++;
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(elements->nodes[index]);
|
2023-10-23 16:33:38 +03:00
|
|
|
}
|
|
|
|
}
|
2023-11-02 20:56:40 +03:00
|
|
|
else {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(elements->nodes[index]);
|
2023-11-02 20:56:40 +03:00
|
|
|
}
|
2023-09-28 17:48:24 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-09-28 17:48:24 +03:00
|
|
|
if (!popped) {
|
2023-10-23 16:33:38 +03:00
|
|
|
if (!allocated_hashes) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newhash, INT2FIX(elements_of_cur_type * 2));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if (cur_type == PM_ASSOC_NODE) {
|
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_hash_merge_ptr, INT2FIX(3));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_hash_merge_kwd, INT2FIX(2));
|
|
|
|
}
|
|
|
|
}
|
2023-09-28 17:48:24 +03:00
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_IF_NODE: {
|
|
|
|
const int line = (int)pm_newline_list_line_column(&(parser->newline_list), node->location.start).line;
|
|
|
|
pm_if_node_t *if_node = (pm_if_node_t *)node;
|
|
|
|
pm_statements_node_t *node_body = if_node->statements;
|
|
|
|
pm_node_t *node_else = if_node->consequent;
|
|
|
|
pm_node_t *predicate = if_node->predicate;
|
2023-08-30 00:17:08 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_if(iseq, line, node_body, node_else, predicate, ret, src, popped, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_IMAGINARY_NODE: {
|
2023-08-29 19:27:00 +03:00
|
|
|
if (!popped) {
|
2023-09-27 19:39:53 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, parse_imaginary((pm_imaginary_node_t *)node));
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-28 17:51:57 +03:00
|
|
|
case PM_IMPLICIT_NODE: {
|
|
|
|
// Implicit nodes mark places in the syntax tree where explicit syntax
|
|
|
|
// was omitted, but implied. For example,
|
|
|
|
//
|
|
|
|
// { foo: }
|
|
|
|
//
|
|
|
|
// In this case a method call/local variable read is implied by virtue
|
|
|
|
// of the missing value. To compile these nodes, we simply compile the
|
|
|
|
// value that is implied, which is helpfully supplied by the parser.
|
|
|
|
pm_implicit_node_t *cast = (pm_implicit_node_t *)node;
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(cast->value);
|
2023-09-28 17:51:57 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-12-13 19:34:05 +03:00
|
|
|
case PM_IN_NODE: {
|
|
|
|
// In nodes are handled by the case match node directly, so we should
|
|
|
|
// never end up hitting them through this path.
|
|
|
|
rb_bug("Should not ever enter an in node directly");
|
|
|
|
return;
|
|
|
|
}
|
2023-11-27 19:12:24 +03:00
|
|
|
case PM_INDEX_AND_WRITE_NODE: {
|
|
|
|
pm_index_and_write_node_t *index_and_write_node = (pm_index_and_write_node_t *)node;
|
|
|
|
|
|
|
|
pm_compile_index_and_or_write_node(true, index_and_write_node->receiver, index_and_write_node->value, index_and_write_node->arguments, index_and_write_node->block, ret, iseq, lineno, src, popped, scope_node, parser);
|
|
|
|
return;
|
|
|
|
}
|
2023-11-27 16:04:24 +03:00
|
|
|
case PM_INDEX_OR_WRITE_NODE: {
|
|
|
|
pm_index_or_write_node_t *index_or_write_node = (pm_index_or_write_node_t *)node;
|
|
|
|
|
2023-11-27 19:12:24 +03:00
|
|
|
pm_compile_index_and_or_write_node(false, index_or_write_node->receiver, index_or_write_node->value, index_or_write_node->arguments, index_or_write_node->block, ret, iseq, lineno, src, popped, scope_node, parser);
|
2023-11-27 16:04:24 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-11-27 20:48:51 +03:00
|
|
|
case PM_INDEX_OPERATOR_WRITE_NODE: {
|
|
|
|
pm_index_operator_write_node_t *index_operator_write_node = (pm_index_operator_write_node_t *)node;
|
|
|
|
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
|
|
|
|
PM_COMPILE_NOT_POPPED(index_operator_write_node->receiver);
|
|
|
|
|
|
|
|
int flag = 0;
|
|
|
|
struct rb_callinfo_kwarg *keywords = NULL;
|
|
|
|
int argc_int = 0;
|
|
|
|
|
|
|
|
if (index_operator_write_node->arguments) {
|
|
|
|
argc_int = pm_setup_args(index_operator_write_node->arguments, &flag, &keywords, iseq, ret, src, popped, scope_node, dummy_line_node, parser);
|
|
|
|
}
|
|
|
|
|
|
|
|
VALUE argc = INT2FIX(argc_int);
|
2023-11-27 22:07:27 +03:00
|
|
|
|
|
|
|
int block_offset = 0;
|
2023-11-27 20:48:51 +03:00
|
|
|
|
|
|
|
if (index_operator_write_node->block) {
|
|
|
|
PM_COMPILE_NOT_POPPED(index_operator_write_node->block);
|
|
|
|
flag |= VM_CALL_ARGS_BLOCKARG;
|
2023-11-27 22:07:27 +03:00
|
|
|
block_offset = 1;
|
2023-11-27 20:48:51 +03:00
|
|
|
}
|
|
|
|
|
2023-11-27 22:07:27 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, dupn, FIXNUM_INC(argc, 1 + block_offset));
|
2023-11-27 20:48:51 +03:00
|
|
|
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, idAREF, argc, INT2FIX(flag));
|
|
|
|
|
|
|
|
PM_COMPILE_NOT_POPPED(index_operator_write_node->value);
|
|
|
|
|
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, index_operator_write_node->operator);
|
|
|
|
ADD_SEND(ret, &dummy_line_node, method_id, INT2FIX(1));
|
|
|
|
|
2024-01-22 18:46:12 +03:00
|
|
|
pm_compile_index_write_nodes_add_send(popped, ret, iseq, dummy_line_node, argc, flag, block_offset, NULL);
|
2023-11-27 20:48:51 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INSTANCE_VARIABLE_AND_WRITE_NODE: {
|
|
|
|
pm_instance_variable_and_write_node_t *instance_variable_and_write_node = (pm_instance_variable_and_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
2023-10-17 01:36:25 +03:00
|
|
|
ID instance_variable_name_id = pm_constant_id_lookup(scope_node, instance_variable_and_write_node->name);
|
2023-09-02 00:20:03 +03:00
|
|
|
VALUE instance_variable_name_val = ID2SYM(instance_variable_name_id);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, getinstancevariable, instance_variable_name_val, get_ivar_ic_value(iseq, instance_variable_name_id));
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-06 17:28:29 +03:00
|
|
|
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, end_label);
|
|
|
|
PM_POP_UNLESS_POPPED;
|
|
|
|
|
|
|
|
PM_COMPILE_NOT_POPPED(instance_variable_and_write_node->value);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, setinstancevariable, instance_variable_name_val, get_ivar_ic_value(iseq, instance_variable_name_id));
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INSTANCE_VARIABLE_OPERATOR_WRITE_NODE: {
|
|
|
|
pm_instance_variable_operator_write_node_t *instance_variable_operator_write_node = (pm_instance_variable_operator_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID instance_variable_name_id = pm_constant_id_lookup(scope_node, instance_variable_operator_write_node->name);
|
2023-09-02 00:20:03 +03:00
|
|
|
VALUE instance_variable_name_val = ID2SYM(instance_variable_name_id);
|
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getinstancevariable,
|
|
|
|
instance_variable_name_val,
|
|
|
|
get_ivar_ic_value(iseq, instance_variable_name_id));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(instance_variable_operator_write_node->value);
|
2023-10-17 01:36:25 +03:00
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, instance_variable_operator_write_node->operator);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
int flags = VM_CALL_ARGS_SIMPLE;
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, method_id, INT2NUM(1), INT2FIX(flags));
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, setinstancevariable,
|
|
|
|
instance_variable_name_val,
|
|
|
|
get_ivar_ic_value(iseq, instance_variable_name_id));
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INSTANCE_VARIABLE_OR_WRITE_NODE: {
|
|
|
|
pm_instance_variable_or_write_node_t *instance_variable_or_write_node = (pm_instance_variable_or_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID instance_variable_name_id = pm_constant_id_lookup(scope_node, instance_variable_or_write_node->name);
|
2023-09-02 00:20:03 +03:00
|
|
|
VALUE instance_variable_name_val = ID2SYM(instance_variable_name_id);
|
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getinstancevariable, instance_variable_name_val, get_ivar_ic_value(iseq, instance_variable_name_id));
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, end_label);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(instance_variable_or_write_node->value);
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, setinstancevariable, instance_variable_name_val, get_ivar_ic_value(iseq, instance_variable_name_id));
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INSTANCE_VARIABLE_READ_NODE: {
|
2023-08-29 19:27:00 +03:00
|
|
|
if (!popped) {
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_instance_variable_read_node_t *instance_variable_read_node = (pm_instance_variable_read_node_t *) node;
|
2023-10-17 01:36:25 +03:00
|
|
|
ID ivar_name = pm_constant_id_lookup(scope_node, instance_variable_read_node->name);
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, getinstancevariable, ID2SYM(ivar_name), get_ivar_ic_value(iseq, ivar_name));
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INSTANCE_VARIABLE_WRITE_NODE: {
|
|
|
|
pm_instance_variable_write_node_t *write_node = (pm_instance_variable_write_node_t *) node;
|
|
|
|
PM_COMPILE_NOT_POPPED(write_node->value);
|
2023-08-31 00:26:22 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-08-31 00:26:22 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID ivar_name = pm_constant_id_lookup(scope_node, write_node->name);
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, setinstancevariable,
|
|
|
|
ID2SYM(ivar_name),
|
|
|
|
get_ivar_ic_value(iseq, ivar_name));
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTEGER_NODE: {
|
2023-08-29 19:27:00 +03:00
|
|
|
if (!popped) {
|
2023-09-27 19:39:53 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, parse_integer((pm_integer_node_t *) node));
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-28 17:18:43 +03:00
|
|
|
case PM_INTERPOLATED_MATCH_LAST_LINE_NODE: {
|
|
|
|
pm_interpolated_match_last_line_node_t *cast = (pm_interpolated_match_last_line_node_t *) node;
|
2023-11-14 03:03:24 +03:00
|
|
|
|
[Prism] Fix InterpolatedMatchLastLine Instructions
I looked at this at RubyConf with Kevin, and we noticed that there was a
`putobject` empty string missing from the instructions. I just got back
around to implementing this and pushing a PR and while doing that
noticed that we also have a `getspecial` when we want a `getglobal`.
This change adds the `putobject` instruction and replaces the
`getspecial` with a `getglobal`. If we look at the parsetree for the
following code:
```ruby
$pit = '.oo'; if /"#{$pit}"/mix; end
```
We can see it has a `NODE_GVAR` and the [Ruby
compiler](https://github.com/ruby/ruby/blob/a4b43e92645e46ee5a8c9af42d3de57cd052e87c/compile.c#L10024-L10030) shows that should
use `getglobal.
```
@ NODE_SCOPE (id: 14, line: 1, location: (1,0)-(22,36))
+- nd_tbl: (empty)
+- nd_args:
| (null node)
+- nd_body:
@ NODE_BLOCK (id: 12, line: 22, location: (22,0)-(22,36))
+- nd_head (1):
| @ NODE_GASGN (id: 0, line: 22, location: (22,0)-(22,12))*
| +- nd_vid: :$pit
| +- nd_value:
| @ NODE_STR (id: 1, line: 22, location: (22,7)-(22,12))
| +- nd_lit: ".oo"
+- nd_head (2):
@ NODE_IF (id: 11, line: 22, location: (22,14)-(22,36))*
+- nd_cond:
| @ NODE_MATCH2 (id: 10, line: 22, location: (22,14)-(22,36))
| +- nd_recv:
| | @ NODE_DREGX (id: 2, line: 22, location: (22,17)-(22,31))
| | +- nd_lit: "\""
| | +- nd_next->nd_head:
| | | @ NODE_EVSTR (id: 4, line: 22, location: (22,19)-(22,26))
| | | +- nd_body:
| | | @ NODE_GVAR (id: 3, line: 22, location: (22,21)-(22,25))
| | | +- nd_vid: :$pit
| | +- nd_next->nd_next:
| | @ NODE_LIST (id: 7, line: 22, location: (22,26)-(22,27))
| | +- as.nd_alen: 1
| | +- nd_head:
| | | @ NODE_STR (id: 6, line: 22, location: (22,26)-(22,27))
| | | +- nd_lit: "\""
| | +- nd_next:
| | (null node)
| +- nd_value:
| @ NODE_GVAR (id: 9, line: 22, location: (22,14)-(22,36))
| +- nd_vid: :$_
+- nd_body:
| @ NODE_BEGIN (id: 8, line: 22, location: (22,32)-(22,32))
| +- nd_body:
| (null node)
+- nd_else:
(null node)
```
I'm struggling with writing a failing test, but the before/after
instructions show that `getglobal` is correct here. I compared the
instructions for the other `InterpolatedMatchLastLine` node tests
and they also used `getglobal`. I've edited the existing
`InterpolatedLastMatchLineNode` test so that it will use that instruction when
copied out of the test. Without the quotes it thinks it's just a
`MatchLastLineNode`.
Incorrect instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(22,36)>
0000 putstring ".oo" ( 22)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:21 (21,0)-(21,36)>
0000 putstring ".oo" ( 21)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getspecial 0, 0
0020 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0023 branchunless 31
0025 jump 27
0027 putnil
0028 jump 32
0030 pop
0031 putnil
0032 leave
```
Fixed instructions:
```
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(22,36)>
0000 putstring ".oo" ( 22)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:21 (21,0)-(21,36)>
0000 putstring ".oo" ( 21)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
```
2023-12-12 23:52:53 +03:00
|
|
|
int parts_size = (int)cast->parts.size;
|
|
|
|
if (parts_size > 0 && !PM_NODE_TYPE_P(cast->parts.nodes[0], PM_STRING_NODE)) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_new(0, 0));
|
|
|
|
parts_size++;
|
|
|
|
}
|
|
|
|
|
2023-11-14 03:03:24 +03:00
|
|
|
pm_interpolated_node_compile(&cast->parts, iseq, dummy_line_node, ret, src, popped, scope_node, parser);
|
2023-09-28 17:18:43 +03:00
|
|
|
|
[Prism] Fix InterpolatedMatchLastLine Instructions
I looked at this at RubyConf with Kevin, and we noticed that there was a
`putobject` empty string missing from the instructions. I just got back
around to implementing this and pushing a PR and while doing that
noticed that we also have a `getspecial` when we want a `getglobal`.
This change adds the `putobject` instruction and replaces the
`getspecial` with a `getglobal`. If we look at the parsetree for the
following code:
```ruby
$pit = '.oo'; if /"#{$pit}"/mix; end
```
We can see it has a `NODE_GVAR` and the [Ruby
compiler](https://github.com/ruby/ruby/blob/a4b43e92645e46ee5a8c9af42d3de57cd052e87c/compile.c#L10024-L10030) shows that should
use `getglobal.
```
@ NODE_SCOPE (id: 14, line: 1, location: (1,0)-(22,36))
+- nd_tbl: (empty)
+- nd_args:
| (null node)
+- nd_body:
@ NODE_BLOCK (id: 12, line: 22, location: (22,0)-(22,36))
+- nd_head (1):
| @ NODE_GASGN (id: 0, line: 22, location: (22,0)-(22,12))*
| +- nd_vid: :$pit
| +- nd_value:
| @ NODE_STR (id: 1, line: 22, location: (22,7)-(22,12))
| +- nd_lit: ".oo"
+- nd_head (2):
@ NODE_IF (id: 11, line: 22, location: (22,14)-(22,36))*
+- nd_cond:
| @ NODE_MATCH2 (id: 10, line: 22, location: (22,14)-(22,36))
| +- nd_recv:
| | @ NODE_DREGX (id: 2, line: 22, location: (22,17)-(22,31))
| | +- nd_lit: "\""
| | +- nd_next->nd_head:
| | | @ NODE_EVSTR (id: 4, line: 22, location: (22,19)-(22,26))
| | | +- nd_body:
| | | @ NODE_GVAR (id: 3, line: 22, location: (22,21)-(22,25))
| | | +- nd_vid: :$pit
| | +- nd_next->nd_next:
| | @ NODE_LIST (id: 7, line: 22, location: (22,26)-(22,27))
| | +- as.nd_alen: 1
| | +- nd_head:
| | | @ NODE_STR (id: 6, line: 22, location: (22,26)-(22,27))
| | | +- nd_lit: "\""
| | +- nd_next:
| | (null node)
| +- nd_value:
| @ NODE_GVAR (id: 9, line: 22, location: (22,14)-(22,36))
| +- nd_vid: :$_
+- nd_body:
| @ NODE_BEGIN (id: 8, line: 22, location: (22,32)-(22,32))
| +- nd_body:
| (null node)
+- nd_else:
(null node)
```
I'm struggling with writing a failing test, but the before/after
instructions show that `getglobal` is correct here. I compared the
instructions for the other `InterpolatedMatchLastLine` node tests
and they also used `getglobal`. I've edited the existing
`InterpolatedLastMatchLineNode` test so that it will use that instruction when
copied out of the test. Without the quotes it thinks it's just a
`MatchLastLineNode`.
Incorrect instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(22,36)>
0000 putstring ".oo" ( 22)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:21 (21,0)-(21,36)>
0000 putstring ".oo" ( 21)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getspecial 0, 0
0020 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0023 branchunless 31
0025 jump 27
0027 putnil
0028 jump 32
0030 pop
0031 putnil
0032 leave
```
Fixed instructions:
```
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(22,36)>
0000 putstring ".oo" ( 22)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:21 (21,0)-(21,36)>
0000 putstring ".oo" ( 21)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
```
2023-12-12 23:52:53 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, toregexp, INT2FIX(pm_reg_flags(node)), INT2FIX(parts_size));
|
2023-09-28 17:18:43 +03:00
|
|
|
|
[Prism] Fix InterpolatedMatchLastLine Instructions
I looked at this at RubyConf with Kevin, and we noticed that there was a
`putobject` empty string missing from the instructions. I just got back
around to implementing this and pushing a PR and while doing that
noticed that we also have a `getspecial` when we want a `getglobal`.
This change adds the `putobject` instruction and replaces the
`getspecial` with a `getglobal`. If we look at the parsetree for the
following code:
```ruby
$pit = '.oo'; if /"#{$pit}"/mix; end
```
We can see it has a `NODE_GVAR` and the [Ruby
compiler](https://github.com/ruby/ruby/blob/a4b43e92645e46ee5a8c9af42d3de57cd052e87c/compile.c#L10024-L10030) shows that should
use `getglobal.
```
@ NODE_SCOPE (id: 14, line: 1, location: (1,0)-(22,36))
+- nd_tbl: (empty)
+- nd_args:
| (null node)
+- nd_body:
@ NODE_BLOCK (id: 12, line: 22, location: (22,0)-(22,36))
+- nd_head (1):
| @ NODE_GASGN (id: 0, line: 22, location: (22,0)-(22,12))*
| +- nd_vid: :$pit
| +- nd_value:
| @ NODE_STR (id: 1, line: 22, location: (22,7)-(22,12))
| +- nd_lit: ".oo"
+- nd_head (2):
@ NODE_IF (id: 11, line: 22, location: (22,14)-(22,36))*
+- nd_cond:
| @ NODE_MATCH2 (id: 10, line: 22, location: (22,14)-(22,36))
| +- nd_recv:
| | @ NODE_DREGX (id: 2, line: 22, location: (22,17)-(22,31))
| | +- nd_lit: "\""
| | +- nd_next->nd_head:
| | | @ NODE_EVSTR (id: 4, line: 22, location: (22,19)-(22,26))
| | | +- nd_body:
| | | @ NODE_GVAR (id: 3, line: 22, location: (22,21)-(22,25))
| | | +- nd_vid: :$pit
| | +- nd_next->nd_next:
| | @ NODE_LIST (id: 7, line: 22, location: (22,26)-(22,27))
| | +- as.nd_alen: 1
| | +- nd_head:
| | | @ NODE_STR (id: 6, line: 22, location: (22,26)-(22,27))
| | | +- nd_lit: "\""
| | +- nd_next:
| | (null node)
| +- nd_value:
| @ NODE_GVAR (id: 9, line: 22, location: (22,14)-(22,36))
| +- nd_vid: :$_
+- nd_body:
| @ NODE_BEGIN (id: 8, line: 22, location: (22,32)-(22,32))
| +- nd_body:
| (null node)
+- nd_else:
(null node)
```
I'm struggling with writing a failing test, but the before/after
instructions show that `getglobal` is correct here. I compared the
instructions for the other `InterpolatedMatchLastLine` node tests
and they also used `getglobal`. I've edited the existing
`InterpolatedLastMatchLineNode` test so that it will use that instruction when
copied out of the test. Without the quotes it thinks it's just a
`MatchLastLineNode`.
Incorrect instructions:
```
"********* Ruby *************"
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(22,36)>
0000 putstring ".oo" ( 22)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:21 (21,0)-(21,36)>
0000 putstring ".oo" ( 21)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getspecial 0, 0
0020 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0023 branchunless 31
0025 jump 27
0027 putnil
0028 jump 32
0030 pop
0031 putnil
0032 leave
```
Fixed instructions:
```
== disasm: #<ISeq:<compiled>@<compiled>:1 (1,0)-(22,36)>
0000 putstring ".oo" ( 22)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
"********* PRISM *************"
== disasm: #<ISeq:<compiled>@<compiled>:21 (21,0)-(21,36)>
0000 putstring ".oo" ( 21)[Li]
0002 setglobal :$pit
0004 putobject "\""
0006 getglobal :$pit
0008 dup
0009 objtostring <calldata!mid:to_s, argc:0, FCALL|ARGS_SIMPLE>
0011 anytostring
0012 putobject "\""
0014 toregexp 7, 3
0017 getglobal :$_
0019 send <calldata!mid:=~, argc:1, ARGS_SIMPLE>, nil
0022 branchunless 30
0024 jump 26
0026 putnil
0027 jump 31
0029 pop
0030 putnil
0031 leave
```
2023-12-12 23:52:53 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, getglobal, rb_id2sym(idLASTLINE));
|
2023-09-28 17:18:43 +03:00
|
|
|
ADD_SEND(ret, &dummy_line_node, idEqTilde, INT2NUM(1));
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTERPOLATED_REGULAR_EXPRESSION_NODE: {
|
2023-11-14 02:52:03 +03:00
|
|
|
if (node->flags & PM_REGULAR_EXPRESSION_FLAGS_ONCE) {
|
|
|
|
const rb_iseq_t *prevblock = ISEQ_COMPILE_DATA(iseq)->current_block;
|
|
|
|
const rb_iseq_t *block_iseq = NULL;
|
|
|
|
int ic_index = ISEQ_BODY(iseq)->ise_size++;
|
|
|
|
|
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t*)node, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
block_iseq = NEW_CHILD_ISEQ(&next_scope_node, make_name_for_block(iseq), ISEQ_TYPE_BLOCK, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
|
|
|
|
2023-11-14 02:52:03 +03:00
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = block_iseq;
|
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, once, block_iseq, INT2FIX(ic_index));
|
|
|
|
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = prevblock;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-09-28 17:18:43 +03:00
|
|
|
pm_interpolated_regular_expression_node_t *cast = (pm_interpolated_regular_expression_node_t *) node;
|
2023-11-14 02:52:03 +03:00
|
|
|
|
|
|
|
int parts_size = (int)cast->parts.size;
|
|
|
|
if (cast->parts.size > 0 && !PM_NODE_TYPE_P(cast->parts.nodes[0], PM_STRING_NODE)) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_new(0, 0));
|
|
|
|
parts_size++;
|
|
|
|
}
|
|
|
|
|
2023-11-14 03:03:24 +03:00
|
|
|
pm_interpolated_node_compile(&cast->parts, iseq, dummy_line_node, ret, src, popped, scope_node, parser);
|
2023-09-08 19:09:30 +03:00
|
|
|
|
2023-11-14 02:52:03 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, toregexp, INT2FIX(pm_reg_flags(node)), INT2FIX(parts_size));
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-09-08 19:09:30 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTERPOLATED_STRING_NODE: {
|
|
|
|
pm_interpolated_string_node_t *interp_string_node = (pm_interpolated_string_node_t *) node;
|
2024-01-29 18:29:49 +03:00
|
|
|
int number_of_items_pushed = 0;
|
|
|
|
if (!PM_NODE_TYPE_P(interp_string_node->parts.nodes[0], PM_STRING_NODE)) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putstring, rb_str_new(0, 0));
|
|
|
|
number_of_items_pushed++;
|
|
|
|
}
|
|
|
|
number_of_items_pushed += pm_interpolated_node_compile(&interp_string_node->parts, iseq, dummy_line_node, ret, src, popped, scope_node, parser);
|
2023-09-08 19:09:30 +03:00
|
|
|
|
2023-12-16 00:28:29 +03:00
|
|
|
if (number_of_items_pushed > 1) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, concatstrings, INT2FIX(number_of_items_pushed));
|
2023-09-08 19:09:30 +03:00
|
|
|
}
|
2023-09-21 22:28:08 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTERPOLATED_SYMBOL_NODE: {
|
|
|
|
pm_interpolated_symbol_node_t *interp_symbol_node = (pm_interpolated_symbol_node_t *) node;
|
2023-12-16 00:28:29 +03:00
|
|
|
int number_of_items_pushed = pm_interpolated_node_compile(&interp_symbol_node->parts, iseq, dummy_line_node, ret, src, popped, scope_node, parser);
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-12-16 00:28:29 +03:00
|
|
|
if (number_of_items_pushed > 1) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, concatstrings, INT2FIX(number_of_items_pushed));
|
2023-09-08 19:09:30 +03:00
|
|
|
}
|
|
|
|
|
2023-08-29 19:27:00 +03:00
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN(ret, &dummy_line_node, intern);
|
|
|
|
}
|
2023-09-21 22:28:08 +03:00
|
|
|
else {
|
2023-10-24 23:08:50 +03:00
|
|
|
PM_POP;
|
2023-09-21 22:28:08 +03:00
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_INTERPOLATED_X_STRING_NODE: {
|
|
|
|
pm_interpolated_x_string_node_t *interp_x_string_node = (pm_interpolated_x_string_node_t *) node;
|
2023-10-30 19:56:30 +03:00
|
|
|
PM_PUTSELF;
|
2023-12-16 00:28:29 +03:00
|
|
|
int number_of_items_pushed = pm_interpolated_node_compile(&interp_x_string_node->parts, iseq, dummy_line_node, ret, src, false, scope_node, parser);
|
2023-09-08 17:40:07 +03:00
|
|
|
|
2023-12-16 00:28:29 +03:00
|
|
|
if (number_of_items_pushed > 1) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, concatstrings, INT2FIX(number_of_items_pushed));
|
2023-09-08 19:09:30 +03:00
|
|
|
}
|
|
|
|
|
2023-09-22 18:43:00 +03:00
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, idBackquote, INT2NUM(1), INT2FIX(VM_CALL_FCALL | VM_CALL_ARGS_SIMPLE));
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-09-08 17:40:07 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_KEYWORD_HASH_NODE: {
|
|
|
|
pm_keyword_hash_node_t *keyword_hash_node = (pm_keyword_hash_node_t *) node;
|
|
|
|
pm_node_list_t elements = keyword_hash_node->elements;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
for (size_t index = 0; index < elements.size; index++) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(elements.nodes[index]);
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
|
2023-10-13 20:59:37 +03:00
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newhash, INT2FIX(elements.size * 2));
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_LAMBDA_NODE: {
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init(node, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
const rb_iseq_t *block = NEW_CHILD_ISEQ(&next_scope_node, make_name_for_block(iseq), ISEQ_TYPE_BLOCK, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
VALUE argc = INT2FIX(0);
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_CALL_WITH_BLOCK(ret, &dummy_line_node, idLambda, argc, block);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, (VALUE)block);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_LOCAL_VARIABLE_AND_WRITE_NODE: {
|
|
|
|
pm_local_variable_and_write_node_t *local_variable_and_write_node = (pm_local_variable_and_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_constant_id_t constant_id = local_variable_and_write_node->name;
|
2024-01-16 01:32:30 +03:00
|
|
|
pm_local_index_t local_index = pm_lookup_local_index(iseq, scope_node, constant_id, local_variable_and_write_node->depth);
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, local_index.index, local_index.level);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(local_variable_and_write_node->value);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, local_index.index, local_index.level);
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_LOCAL_VARIABLE_OPERATOR_WRITE_NODE: {
|
|
|
|
pm_local_variable_operator_write_node_t *local_variable_operator_write_node = (pm_local_variable_operator_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_constant_id_t constant_id = local_variable_operator_write_node->name;
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t local_index = pm_lookup_local_index(iseq, scope_node, constant_id, local_variable_operator_write_node->depth);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, local_index.index, local_index.level);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(local_variable_operator_write_node->value);
|
2023-10-17 01:36:25 +03:00
|
|
|
ID method_id = pm_constant_id_lookup(scope_node, local_variable_operator_write_node->operator);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
int flags = VM_CALL_ARGS_SIMPLE | VM_CALL_FCALL | VM_CALL_VCALL;
|
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, method_id, INT2NUM(1), INT2FIX(flags));
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, local_index.index, local_index.level);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_LOCAL_VARIABLE_OR_WRITE_NODE: {
|
|
|
|
pm_local_variable_or_write_node_t *local_variable_or_write_node = (pm_local_variable_or_write_node_t*) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
LABEL *set_label= NEW_LABEL(lineno);
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, set_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_constant_id_t constant_id = local_variable_or_write_node->name;
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t local_index = pm_lookup_local_index(iseq, scope_node, constant_id, local_variable_or_write_node->depth);
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, local_index.index, local_index.level);
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, end_label);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_LABEL(ret, set_label);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(local_variable_or_write_node->value);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, local_index.index, local_index.level);
|
2023-09-02 00:20:03 +03:00
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_LOCAL_VARIABLE_READ_NODE: {
|
|
|
|
pm_local_variable_read_node_t *local_read_node = (pm_local_variable_read_node_t *) node;
|
2023-09-02 00:20:03 +03:00
|
|
|
|
|
|
|
if (!popped) {
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, local_read_node->name, local_read_node->depth);
|
2024-01-16 01:03:04 +03:00
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_LOCAL_VARIABLE_WRITE_NODE: {
|
|
|
|
pm_local_variable_write_node_t *local_write_node = (pm_local_variable_write_node_t *) node;
|
|
|
|
PM_COMPILE_NOT_POPPED(local_write_node->value);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_constant_id_t constant_id = local_write_node->name;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, constant_id, local_write_node->depth);
|
2023-11-29 22:12:31 +03:00
|
|
|
|
2024-01-16 00:42:16 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 23:53:37 +03:00
|
|
|
case PM_MATCH_LAST_LINE_NODE: {
|
|
|
|
if (!popped) {
|
2023-09-28 17:18:43 +03:00
|
|
|
pm_match_last_line_node_t *cast = (pm_match_last_line_node_t *) node;
|
2023-09-27 23:53:37 +03:00
|
|
|
|
2023-10-19 23:50:21 +03:00
|
|
|
VALUE regex_str = parse_string(&cast->unescaped, parser);
|
2023-09-28 17:18:43 +03:00
|
|
|
VALUE regex = rb_reg_new(RSTRING_PTR(regex_str), RSTRING_LEN(regex_str), pm_reg_flags(node));
|
2023-09-27 23:53:37 +03:00
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, regex);
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, getspecial, INT2FIX(0), INT2FIX(0));
|
|
|
|
ADD_SEND(ret, &dummy_line_node, idEqTilde, INT2NUM(1));
|
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-28 19:14:38 +03:00
|
|
|
case PM_MATCH_PREDICATE_NODE: {
|
|
|
|
pm_match_predicate_node_t *cast = (pm_match_predicate_node_t *) node;
|
|
|
|
|
|
|
|
// First, allocate some stack space for the cached return value of any
|
|
|
|
// calls to #deconstruct.
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-28 19:14:38 +03:00
|
|
|
|
|
|
|
// Next, compile the expression that we're going to match against.
|
|
|
|
PM_COMPILE_NOT_POPPED(cast->value);
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-09-28 19:14:38 +03:00
|
|
|
|
|
|
|
// Now compile the pattern that is going to be used to match against the
|
|
|
|
// expression.
|
|
|
|
LABEL *matched_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *unmatched_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *done_label = NEW_LABEL(lineno);
|
2023-12-13 19:34:05 +03:00
|
|
|
pm_compile_pattern(iseq, scope_node, cast->pattern, ret, src, matched_label, unmatched_label, false, false, true, 2);
|
2023-09-28 19:14:38 +03:00
|
|
|
|
|
|
|
// If the pattern did not match, then compile the necessary instructions
|
|
|
|
// to handle pushing false onto the stack, then jump to the end.
|
|
|
|
ADD_LABEL(ret, unmatched_label);
|
2023-10-24 23:08:50 +03:00
|
|
|
PM_POP;
|
|
|
|
PM_POP;
|
2023-09-28 19:14:38 +03:00
|
|
|
|
|
|
|
if (!popped) ADD_INSN1(ret, &dummy_line_node, putobject, Qfalse);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, done_label);
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-28 19:14:38 +03:00
|
|
|
|
|
|
|
// If the pattern did match, then compile the necessary instructions to
|
|
|
|
// handle pushing true onto the stack, then jump to the end.
|
|
|
|
ADD_LABEL(ret, matched_label);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, adjuststack, INT2FIX(2));
|
|
|
|
if (!popped) ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, done_label);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, done_label);
|
|
|
|
return;
|
|
|
|
}
|
2023-12-13 19:34:05 +03:00
|
|
|
case PM_MATCH_REQUIRED_NODE: {
|
|
|
|
// A match required node represents pattern matching against a single
|
|
|
|
// pattern using the => operator. For example,
|
|
|
|
//
|
|
|
|
// foo => bar
|
|
|
|
//
|
|
|
|
// This is somewhat analogous to compiling a case match statement with a
|
|
|
|
// single pattern. In both cases, if the pattern fails it should
|
|
|
|
// immediately raise an error.
|
|
|
|
const pm_match_required_node_t *cast = (const pm_match_required_node_t *) node;
|
|
|
|
|
|
|
|
LABEL *matched_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *unmatched_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *done_label = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
// First, we're going to push a bunch of stuff onto the stack that is
|
|
|
|
// going to serve as our scratch space.
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil); // key error key
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil); // key error matchee
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qfalse); // key error?
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil); // error string
|
|
|
|
ADD_INSN(ret, &dummy_line_node, putnil); // deconstruct cache
|
|
|
|
|
|
|
|
// Next we're going to compile the value expression such that it's on
|
|
|
|
// the stack.
|
|
|
|
PM_COMPILE_NOT_POPPED(cast->value);
|
|
|
|
|
|
|
|
// Here we'll dup it so that it can be used for comparison, but also be
|
|
|
|
// used for error handling.
|
|
|
|
ADD_INSN(ret, &dummy_line_node, dup);
|
|
|
|
|
|
|
|
// Next we'll compile the pattern. We indicate to the pm_compile_pattern
|
|
|
|
// function that this is the only pattern that will be matched against
|
|
|
|
// through the in_single_pattern parameter. We also indicate that the
|
|
|
|
// value to compare against is 2 slots from the top of the stack (the
|
|
|
|
// base_index parameter).
|
|
|
|
pm_compile_pattern(iseq, scope_node, cast->pattern, ret, src, matched_label, unmatched_label, true, false, true, 2);
|
|
|
|
|
|
|
|
// If the pattern did not match the value, then we're going to compile
|
|
|
|
// in our error handler code. This will determine which error to raise
|
|
|
|
// and raise it.
|
|
|
|
ADD_LABEL(ret, unmatched_label);
|
|
|
|
pm_compile_pattern_error_handler(iseq, scope_node, node, ret, src, done_label, popped);
|
|
|
|
|
|
|
|
// If the pattern did match, we'll clean up the values we've pushed onto
|
|
|
|
// the stack and then push nil onto the stack if it's not popped.
|
|
|
|
ADD_LABEL(ret, matched_label);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, adjuststack, INT2FIX(6));
|
|
|
|
if (!popped) ADD_INSN(ret, &dummy_line_node, putnil);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, done_label);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, done_label);
|
|
|
|
return;
|
|
|
|
}
|
2023-09-21 21:52:24 +03:00
|
|
|
case PM_MATCH_WRITE_NODE: {
|
2023-11-21 00:09:51 +03:00
|
|
|
// Match write nodes are specialized call nodes that have a regular
|
|
|
|
// expression with valid named capture groups on the left, the =~
|
|
|
|
// operator, and some value on the right. The nodes themselves simply
|
|
|
|
// wrap the call with the local variable targets that will be written
|
|
|
|
// when the call is executed.
|
|
|
|
pm_match_write_node_t *cast = (pm_match_write_node_t *) node;
|
2023-09-21 21:52:24 +03:00
|
|
|
LABEL *fail_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
// First, we'll compile the call so that all of its instructions are
|
|
|
|
// present. Then we'll compile all of the local variable targets.
|
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *) cast->call);
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
// Now, check if the match was successful. If it was, then we'll
|
|
|
|
// continue on and assign local variables. Otherwise we'll skip over the
|
|
|
|
// assignment code.
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, getglobal, rb_id2sym(idBACKREF));
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-09-21 21:52:24 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchunless, fail_label);
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
// If there's only a single local variable target, we can skip some of
|
|
|
|
// the bookkeeping, so we'll put a special branch here.
|
|
|
|
size_t targets_count = cast->targets.size;
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
if (targets_count == 1) {
|
|
|
|
pm_node_t *target = cast->targets.nodes[0];
|
|
|
|
assert(PM_NODE_TYPE_P(target, PM_LOCAL_VARIABLE_TARGET_NODE));
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
pm_local_variable_target_node_t *local_target = (pm_local_variable_target_node_t *) target;
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, local_target->name, local_target->depth);
|
2023-11-21 00:09:51 +03:00
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_id2sym(pm_constant_id_lookup(scope_node, local_target->name)));
|
2023-09-21 21:52:24 +03:00
|
|
|
ADD_SEND(ret, &dummy_line_node, idAREF, INT2FIX(1));
|
2023-11-21 00:09:51 +03:00
|
|
|
ADD_LABEL(ret, fail_label);
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
2023-11-02 20:53:33 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-09-21 21:52:24 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
// Otherwise there is more than one local variable target, so we'll need
|
|
|
|
// to do some bookkeeping.
|
|
|
|
for (size_t targets_index = 0; targets_index < targets_count; targets_index++) {
|
|
|
|
pm_node_t *target = cast->targets.nodes[targets_index];
|
|
|
|
assert(PM_NODE_TYPE_P(target, PM_LOCAL_VARIABLE_TARGET_NODE));
|
|
|
|
|
|
|
|
pm_local_variable_target_node_t *local_target = (pm_local_variable_target_node_t *) target;
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, local_target->name, local_target->depth);
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
if (((size_t) targets_index) < (targets_count - 1)) {
|
2023-10-26 18:03:18 +03:00
|
|
|
PM_DUP;
|
2023-09-21 21:52:24 +03:00
|
|
|
}
|
2023-11-21 00:09:51 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_id2sym(pm_constant_id_lookup(scope_node, local_target->name)));
|
2023-09-21 21:52:24 +03:00
|
|
|
ADD_SEND(ret, &dummy_line_node, idAREF, INT2FIX(1));
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
2023-09-21 21:52:24 +03:00
|
|
|
}
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
// Since we matched successfully, now we'll jump to the end.
|
2023-09-21 21:52:24 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, end_label);
|
2023-11-21 00:09:51 +03:00
|
|
|
|
|
|
|
// In the case that the match failed, we'll loop through each local
|
|
|
|
// variable target and set all of them to `nil`.
|
2023-09-21 21:52:24 +03:00
|
|
|
ADD_LABEL(ret, fail_label);
|
2023-11-21 00:09:51 +03:00
|
|
|
PM_POP;
|
|
|
|
|
|
|
|
for (size_t targets_index = 0; targets_index < targets_count; targets_index++) {
|
|
|
|
pm_node_t *target = cast->targets.nodes[targets_index];
|
|
|
|
assert(PM_NODE_TYPE_P(target, PM_LOCAL_VARIABLE_TARGET_NODE));
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-11-21 00:09:51 +03:00
|
|
|
pm_local_variable_target_node_t *local_target = (pm_local_variable_target_node_t *) target;
|
2024-01-23 23:33:45 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, local_target->name, local_target->depth);
|
2023-09-28 18:55:43 +03:00
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
2023-09-21 21:52:24 +03:00
|
|
|
}
|
2023-11-21 00:09:51 +03:00
|
|
|
|
|
|
|
// Finally, we can push the end label for either case.
|
|
|
|
PM_POP_IF_POPPED;
|
2023-09-21 21:52:24 +03:00
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_MISSING_NODE: {
|
|
|
|
rb_bug("A pm_missing_node_t should not exist in prism's AST.");
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_MODULE_NODE: {
|
|
|
|
pm_module_node_t *module_node = (pm_module_node_t *)node;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
ID module_id = pm_constant_id_lookup(scope_node, module_node->name);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
VALUE module_name = rb_str_freeze(rb_sprintf("<module:%"PRIsVALUE">", rb_id2str(module_id)));
|
|
|
|
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t *)module_node, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
const rb_iseq_t *module_iseq = NEW_CHILD_ISEQ(&next_scope_node, module_name, ISEQ_TYPE_CLASS, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
const int flags = VM_DEFINECLASS_TYPE_MODULE |
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_class_path(ret, iseq, module_node->constant_path, &dummy_line_node, src, false, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_INSN3(ret, &dummy_line_node, defineclass, ID2SYM(module_id), module_iseq, INT2FIX(flags));
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, (VALUE)module_iseq);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-12-11 23:17:48 +03:00
|
|
|
case PM_REQUIRED_PARAMETER_NODE: {
|
|
|
|
pm_required_parameter_node_t *required_parameter_node = (pm_required_parameter_node_t *)node;
|
2024-01-16 01:32:30 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, required_parameter_node->name, 0);
|
2023-12-11 23:17:48 +03:00
|
|
|
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
2023-12-11 23:17:48 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_MULTI_WRITE_NODE: {
|
2024-01-12 23:23:47 +03:00
|
|
|
// A multi write node represents writing to multiple values using an =
|
|
|
|
// operator. Importantly these nodes are only parsed when the left-hand
|
|
|
|
// side of the operator has multiple targets. The right-hand side of the
|
|
|
|
// operator having multiple targets represents an implicit array
|
|
|
|
// instead.
|
|
|
|
const pm_multi_write_node_t *cast = (const pm_multi_write_node_t *) node;
|
2023-09-19 23:59:07 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
DECL_ANCHOR(writes);
|
|
|
|
INIT_ANCHOR(writes);
|
2023-12-14 00:09:39 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
DECL_ANCHOR(cleanup);
|
|
|
|
INIT_ANCHOR(cleanup);
|
2023-12-15 23:07:49 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
pm_multi_target_state_t state = { 0 };
|
|
|
|
state.position = popped ? 0 : 1;
|
|
|
|
size_t stack_size = pm_compile_multi_target_node(iseq, node, ret, writes, cleanup, src, scope_node, &state);
|
2023-12-15 23:07:49 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(cast->value);
|
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-12-15 23:07:49 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
ADD_SEQ(ret, writes);
|
|
|
|
if (!popped && stack_size >= 1) {
|
|
|
|
// Make sure the value on the right-hand side of the = operator is
|
|
|
|
// being returned before we pop the parent expressions.
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, setn, INT2FIX(stack_size));
|
2023-09-19 23:59:07 +03:00
|
|
|
}
|
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
ADD_SEQ(ret, cleanup);
|
2023-11-01 21:22:08 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_NEXT_NODE: {
|
|
|
|
pm_next_node_t *next_node = (pm_next_node_t *) node;
|
2023-12-04 19:36:35 +03:00
|
|
|
|
|
|
|
if (ISEQ_COMPILE_DATA(iseq)->redo_label != 0 && can_add_ensure_iseq(iseq)) {
|
|
|
|
LABEL *splabel = NEW_LABEL(0);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, splabel);
|
|
|
|
|
2023-12-12 19:23:50 +03:00
|
|
|
if (next_node->arguments) {
|
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)next_node->arguments);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
2023-12-11 20:14:21 +03:00
|
|
|
pm_add_ensure_iseq(ret, iseq, 0, src, scope_node);
|
2023-12-04 19:36:35 +03:00
|
|
|
|
|
|
|
ADD_ADJUST(ret, &dummy_line_node, ISEQ_COMPILE_DATA(iseq)->redo_label);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, ISEQ_COMPILE_DATA(iseq)->start_label);
|
|
|
|
|
|
|
|
ADD_ADJUST_RESTORE(ret, splabel);
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
2023-08-31 00:27:08 +03:00
|
|
|
}
|
2023-12-04 19:36:35 +03:00
|
|
|
else if (ISEQ_COMPILE_DATA(iseq)->end_label && can_add_ensure_iseq(iseq)) {
|
|
|
|
LABEL *splabel = NEW_LABEL(0);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, splabel);
|
|
|
|
ADD_ADJUST(ret, &dummy_line_node, ISEQ_COMPILE_DATA(iseq)->start_label);
|
|
|
|
|
|
|
|
if (next_node->arguments) {
|
2023-12-07 22:13:33 +03:00
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)next_node->arguments);
|
2023-12-04 19:36:35 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
|
|
|
|
2023-12-11 20:14:21 +03:00
|
|
|
pm_add_ensure_iseq(ret, iseq, 0, src, scope_node);
|
2023-12-04 19:36:35 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, ISEQ_COMPILE_DATA(iseq)->end_label);
|
|
|
|
ADD_ADJUST_RESTORE(ret, splabel);
|
|
|
|
splabel->unremovable = FALSE;
|
|
|
|
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
2023-08-31 00:27:08 +03:00
|
|
|
}
|
2023-12-04 19:36:35 +03:00
|
|
|
else {
|
|
|
|
const rb_iseq_t *ip = iseq;
|
2023-08-31 00:27:08 +03:00
|
|
|
|
2023-12-04 19:36:35 +03:00
|
|
|
unsigned long throw_flag = 0;
|
|
|
|
while (ip) {
|
|
|
|
if (!ISEQ_COMPILE_DATA(ip)) {
|
|
|
|
ip = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
throw_flag = VM_THROW_NO_ESCAPE_FLAG;
|
|
|
|
if (ISEQ_COMPILE_DATA(ip)->redo_label != 0) {
|
|
|
|
/* while loop */
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
else if (ISEQ_BODY(ip)->type == ISEQ_TYPE_BLOCK) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
else if (ISEQ_BODY(ip)->type == ISEQ_TYPE_EVAL) {
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_raise(rb_eSyntaxError, "Can't escape from eval with next");
|
2023-12-04 19:36:35 +03:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
ip = ISEQ_BODY(ip)->parent_iseq;
|
|
|
|
}
|
|
|
|
if (ip != 0) {
|
|
|
|
if (next_node->arguments) {
|
2023-12-07 22:13:33 +03:00
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)next_node->arguments);
|
2023-12-04 19:36:35 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, throw, INT2FIX(throw_flag | TAG_NEXT));
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
rb_raise(rb_eArgError, "Invalid next");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
2023-08-31 00:27:08 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_NIL_NODE:
|
2024-01-22 23:22:12 +03:00
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
2023-10-24 14:42:51 +03:00
|
|
|
case PM_NO_KEYWORDS_PARAMETER_NODE: {
|
|
|
|
ISEQ_BODY(iseq)->param.flags.accepts_no_kwarg = TRUE;
|
2023-10-23 17:24:35 +03:00
|
|
|
return;
|
2023-10-24 14:42:51 +03:00
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_NUMBERED_REFERENCE_READ_NODE: {
|
2023-09-01 21:30:22 +03:00
|
|
|
if (!popped) {
|
2023-09-27 19:39:53 +03:00
|
|
|
uint32_t reference_number = ((pm_numbered_reference_read_node_t *)node)->number;
|
2023-09-01 21:30:22 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, getspecial, INT2FIX(1), INT2FIX(reference_number << 1));
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_OR_NODE: {
|
|
|
|
pm_or_node_t *or_node = (pm_or_node_t *) node;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
LABEL *end_label = NEW_LABEL(lineno);
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(or_node->left);
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_DUP_UNLESS_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, end_label);
|
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_UNLESS_POPPED;
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(or_node->right);
|
2023-08-29 19:27:00 +03:00
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_OPTIONAL_PARAMETER_NODE: {
|
|
|
|
pm_optional_parameter_node_t *optional_parameter_node = (pm_optional_parameter_node_t *)node;
|
|
|
|
PM_COMPILE_NOT_POPPED(optional_parameter_node->value);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2024-01-16 01:32:30 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, optional_parameter_node->name, 0);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-10-23 17:28:04 +03:00
|
|
|
case PM_PARAMETERS_NODE: {
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Cannot compile a ParametersNode directly\n");
|
2023-10-23 17:28:04 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_PARENTHESES_NODE: {
|
|
|
|
pm_parentheses_node_t *parentheses_node = (pm_parentheses_node_t *) node;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
if (parentheses_node->body == NULL) {
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
} else {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(parentheses_node->body);
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-10-23 16:46:37 +03:00
|
|
|
case PM_PRE_EXECUTION_NODE: {
|
|
|
|
pm_pre_execution_node_t *pre_execution_node = (pm_pre_execution_node_t *) node;
|
|
|
|
|
|
|
|
DECL_ANCHOR(pre_ex);
|
|
|
|
INIT_ANCHOR(pre_ex);
|
|
|
|
|
|
|
|
if (pre_execution_node->statements) {
|
|
|
|
pm_node_list_t node_list = pre_execution_node->statements->body;
|
|
|
|
for (size_t index = 0; index < node_list.size; index++) {
|
|
|
|
pm_compile_node(iseq, node_list.nodes[index], pre_ex, src, true, scope_node);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN(pre_ex, &dummy_line_node, putnil);
|
|
|
|
}
|
|
|
|
|
|
|
|
pre_ex->last->next = ret->anchor.next;
|
2023-10-23 20:49:39 +03:00
|
|
|
ret->anchor.next = pre_ex->anchor.next;
|
|
|
|
ret->anchor.next->prev = pre_ex->anchor.next;
|
|
|
|
|
|
|
|
if (ret->last == (LINK_ELEMENT *)ret) {
|
|
|
|
ret->last = pre_ex->last;
|
|
|
|
}
|
|
|
|
|
2023-10-23 16:46:37 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-10-30 23:57:27 +03:00
|
|
|
case PM_POST_EXECUTION_NODE: {
|
|
|
|
const rb_iseq_t *child_iseq;
|
|
|
|
const rb_iseq_t *prevblock = ISEQ_COMPILE_DATA(iseq)->current_block;
|
|
|
|
|
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init(node, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
child_iseq = NEW_CHILD_ISEQ(&next_scope_node, make_name_for_block(iseq), ISEQ_TYPE_BLOCK, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
|
|
|
|
2023-10-30 23:57:27 +03:00
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = child_iseq;
|
|
|
|
|
|
|
|
int is_index = ISEQ_BODY(iseq)->ise_size++;
|
|
|
|
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, once, child_iseq, INT2FIX(is_index));
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, (VALUE)child_iseq);
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = prevblock;
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_PROGRAM_NODE: {
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Cannot compile a ProgramNode directly\n");
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_RANGE_NODE: {
|
|
|
|
pm_range_node_t *range_node = (pm_range_node_t *) node;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
bool exclusive = (range_node->operator_loc.end - range_node->operator_loc.start) == 3;
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
if (pm_optimizable_range_item_p(range_node->left) && pm_optimizable_range_item_p(range_node->right)) {
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
if (!popped) {
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_node_t *left = range_node->left;
|
|
|
|
pm_node_t *right = range_node->right;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
VALUE val = rb_range_new(
|
2023-09-27 19:39:53 +03:00
|
|
|
left && PM_NODE_TYPE_P(left, PM_INTEGER_NODE) ? parse_integer((pm_integer_node_t *) left) : Qnil,
|
|
|
|
right && PM_NODE_TYPE_P(right, PM_INTEGER_NODE) ? parse_integer((pm_integer_node_t *) right) : Qnil,
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
exclusive
|
|
|
|
);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, val);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, val);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if (range_node->left == NULL) {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
} else {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(range_node->left);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
if (range_node->right == NULL) {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
} else {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(range_node->right);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, newrange, INT2FIX(exclusive));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_RATIONAL_NODE: {
|
2023-09-08 22:33:51 +03:00
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, parse_rational(node));
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_REDO_NODE: {
|
2023-12-04 18:55:11 +03:00
|
|
|
if (ISEQ_COMPILE_DATA(iseq)->redo_label && can_add_ensure_iseq(iseq)) {
|
|
|
|
LABEL *splabel = NEW_LABEL(0);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, splabel);
|
|
|
|
|
|
|
|
ADD_ADJUST(ret, &dummy_line_node, ISEQ_COMPILE_DATA(iseq)->redo_label);
|
|
|
|
|
2023-12-11 20:14:21 +03:00
|
|
|
pm_add_ensure_iseq(ret, iseq, 0, src, scope_node);
|
2023-12-04 18:55:11 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, ISEQ_COMPILE_DATA(iseq)->redo_label);
|
|
|
|
ADD_ADJUST_RESTORE(ret, splabel);
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
}
|
|
|
|
else if (ISEQ_BODY(iseq)->type != ISEQ_TYPE_EVAL && ISEQ_COMPILE_DATA(iseq)->start_label && can_add_ensure_iseq(iseq)) {
|
|
|
|
LABEL *splabel = NEW_LABEL(0);
|
|
|
|
|
|
|
|
ADD_LABEL(ret, splabel);
|
2023-12-11 20:14:21 +03:00
|
|
|
pm_add_ensure_iseq(ret, iseq, 0, src, scope_node);
|
2023-12-04 18:55:11 +03:00
|
|
|
ADD_ADJUST(ret, &dummy_line_node, ISEQ_COMPILE_DATA(iseq)->start_label);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, ISEQ_COMPILE_DATA(iseq)->start_label);
|
|
|
|
ADD_ADJUST_RESTORE(ret, splabel);
|
|
|
|
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
const rb_iseq_t *ip = iseq;
|
|
|
|
|
|
|
|
while (ip) {
|
|
|
|
if (!ISEQ_COMPILE_DATA(ip)) {
|
|
|
|
ip = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ISEQ_COMPILE_DATA(ip)->redo_label != 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
else if (ISEQ_BODY(ip)->type == ISEQ_TYPE_BLOCK) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
else if (ISEQ_BODY(ip)->type == ISEQ_TYPE_EVAL) {
|
|
|
|
rb_bug("Invalid redo\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
ip = ISEQ_BODY(ip)->parent_iseq;
|
|
|
|
}
|
|
|
|
if (ip != 0) {
|
|
|
|
PM_PUTNIL;
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, throw, INT2FIX(VM_THROW_NO_ESCAPE_FLAG | TAG_REDO));
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
rb_bug("Invalid redo\n");
|
|
|
|
}
|
|
|
|
}
|
2023-08-31 00:27:08 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_REGULAR_EXPRESSION_NODE: {
|
2023-09-08 19:09:30 +03:00
|
|
|
if (!popped) {
|
2023-09-28 17:18:43 +03:00
|
|
|
pm_regular_expression_node_t *cast = (pm_regular_expression_node_t *) node;
|
2023-09-19 22:25:13 +03:00
|
|
|
|
2023-10-24 20:17:18 +03:00
|
|
|
VALUE regex = pm_new_regex(cast, parser);
|
2023-09-19 22:25:13 +03:00
|
|
|
|
2023-09-08 19:09:30 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, regex);
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-11-10 17:51:14 +03:00
|
|
|
case PM_RESCUE_NODE: {
|
2024-01-12 01:05:42 +03:00
|
|
|
pm_rescue_node_t *cast = (pm_rescue_node_t *) node;
|
2023-11-10 17:51:14 +03:00
|
|
|
iseq_set_exception_local_table(iseq);
|
|
|
|
|
2024-01-12 01:05:42 +03:00
|
|
|
// First, establish the labels that we need to be able to jump to within
|
|
|
|
// this compilation block.
|
|
|
|
LABEL *exception_match_label = NEW_LABEL(lineno);
|
|
|
|
LABEL *rescue_end_label = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
// Next, compile each of the exceptions that we're going to be
|
|
|
|
// handling. For each one, we'll add instructions to check if the
|
|
|
|
// exception matches the raised one, and if it does then jump to the
|
|
|
|
// exception_match_label label. Otherwise it will fall through to the
|
|
|
|
// subsequent check. If there are no exceptions, we'll only check
|
|
|
|
// StandardError.
|
|
|
|
pm_node_list_t *exceptions = &cast->exceptions;
|
|
|
|
|
|
|
|
if (exceptions->size > 0) {
|
|
|
|
for (size_t index = 0; index < exceptions->size; index++) {
|
2023-11-10 17:51:14 +03:00
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, LVAR_ERRINFO, 0);
|
2024-01-12 01:05:42 +03:00
|
|
|
PM_COMPILE(exceptions->nodes[index]);
|
2024-01-18 17:39:32 +03:00
|
|
|
int checkmatch_flags = VM_CHECKMATCH_TYPE_RESCUE;
|
|
|
|
if (PM_NODE_TYPE_P(exceptions->nodes[index], PM_SPLAT_NODE)) {
|
|
|
|
checkmatch_flags |= VM_CHECKMATCH_ARRAY;
|
|
|
|
}
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, checkmatch, INT2FIX(checkmatch_flags));
|
2024-01-27 00:19:21 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, exception_match_label);
|
2023-11-10 17:51:14 +03:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, LVAR_ERRINFO, 0);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_eStandardError);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, checkmatch, INT2FIX(VM_CHECKMATCH_TYPE_RESCUE));
|
2024-01-26 20:17:04 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, exception_match_label);
|
2023-11-10 17:51:14 +03:00
|
|
|
}
|
|
|
|
|
2024-01-12 01:05:42 +03:00
|
|
|
// If none of the exceptions that we are matching against matched, then
|
|
|
|
// we'll jump straight to the rescue_end_label label.
|
2024-01-26 20:17:04 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, rescue_end_label);
|
2024-01-12 01:05:42 +03:00
|
|
|
|
|
|
|
// Here we have the exception_match_label, which is where the
|
|
|
|
// control-flow goes in the case that one of the exceptions matched.
|
|
|
|
// Here we will compile the instructions to handle the exception.
|
|
|
|
ADD_LABEL(ret, exception_match_label);
|
2023-11-10 17:51:14 +03:00
|
|
|
ADD_TRACE(ret, RUBY_EVENT_RESCUE);
|
2023-12-01 21:00:20 +03:00
|
|
|
|
2024-01-12 01:05:42 +03:00
|
|
|
// If we have a reference to the exception, then we'll compile the write
|
|
|
|
// into the instruction sequence. This can look quite different
|
|
|
|
// depending on the kind of write being performed.
|
|
|
|
if (cast->reference) {
|
2024-01-12 23:23:47 +03:00
|
|
|
DECL_ANCHOR(writes);
|
|
|
|
INIT_ANCHOR(writes);
|
2024-01-12 01:05:42 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
DECL_ANCHOR(cleanup);
|
|
|
|
INIT_ANCHOR(cleanup);
|
2024-01-12 01:05:42 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
pm_compile_target_node(iseq, cast->reference, ret, writes, cleanup, src, scope_node, NULL);
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, LVAR_ERRINFO, 0);
|
2024-01-12 01:05:42 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
ADD_SEQ(ret, writes);
|
|
|
|
ADD_SEQ(ret, cleanup);
|
2023-11-10 17:51:14 +03:00
|
|
|
}
|
2024-01-12 01:05:42 +03:00
|
|
|
|
|
|
|
// If we have statements to execute, we'll compile them here. Otherwise
|
|
|
|
// we'll push nil onto the stack.
|
|
|
|
if (cast->statements) {
|
2024-01-25 15:54:49 +03:00
|
|
|
|
|
|
|
// We'll temporarily remove the end_label location from the iseq
|
|
|
|
// when compiling the statements so that next/redo statements
|
|
|
|
// inside the body will throw to the correct place instead of
|
|
|
|
// jumping straight to the end of this iseq
|
|
|
|
LABEL *prev_end = ISEQ_COMPILE_DATA(iseq)->end_label;
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->end_label = NULL;
|
|
|
|
|
2024-01-12 01:05:42 +03:00
|
|
|
PM_COMPILE((pm_node_t *) cast->statements);
|
2024-01-25 15:54:49 +03:00
|
|
|
|
|
|
|
// Now restore the end_label
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->end_label = prev_end;
|
2024-01-12 01:05:42 +03:00
|
|
|
} else {
|
2023-12-01 21:00:20 +03:00
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
|
|
|
|
2023-11-10 17:51:14 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, leave);
|
|
|
|
|
2024-01-12 01:05:42 +03:00
|
|
|
// Here we'll insert the rescue_end_label label, which is jumped to if
|
|
|
|
// none of the exceptions matched. It will cause the control-flow to
|
|
|
|
// either jump to the next rescue clause or it will fall through to the
|
|
|
|
// subsequent instruction returning the raised error.
|
|
|
|
ADD_LABEL(ret, rescue_end_label);
|
|
|
|
if (cast->consequent) {
|
|
|
|
PM_COMPILE((pm_node_t *) cast->consequent);
|
2023-11-10 17:51:14 +03:00
|
|
|
} else {
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, 1, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-12-01 17:37:10 +03:00
|
|
|
case PM_RESCUE_MODIFIER_NODE: {
|
|
|
|
pm_rescue_modifier_node_t *rescue_node = (pm_rescue_modifier_node_t *)node;
|
2024-01-18 19:55:31 +03:00
|
|
|
|
|
|
|
pm_scope_node_t rescue_scope_node;
|
2023-12-01 17:37:10 +03:00
|
|
|
pm_scope_node_init((pm_node_t *)rescue_node, &rescue_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
rb_iseq_t *rescue_iseq = NEW_CHILD_ISEQ(&rescue_scope_node,
|
2023-12-01 17:37:10 +03:00
|
|
|
rb_str_concat(rb_str_new2("rescue in"),
|
|
|
|
ISEQ_BODY(iseq)->location.label),
|
|
|
|
ISEQ_TYPE_RESCUE, 1);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&rescue_scope_node);
|
2023-12-01 17:37:10 +03:00
|
|
|
|
|
|
|
LABEL *lstart = NEW_LABEL(lineno);
|
|
|
|
LABEL *lend = NEW_LABEL(lineno);
|
|
|
|
LABEL *lcont = NEW_LABEL(lineno);
|
|
|
|
|
|
|
|
lstart->rescued = LABEL_RESCUE_BEG;
|
|
|
|
lend->rescued = LABEL_RESCUE_END;
|
|
|
|
ADD_LABEL(ret, lstart);
|
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)rescue_node->expression);
|
|
|
|
ADD_LABEL(ret, lend);
|
2023-12-06 17:45:04 +03:00
|
|
|
PM_NOP;
|
2023-12-01 17:37:10 +03:00
|
|
|
ADD_LABEL(ret, lcont);
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_RESCUE, lstart, lend, rescue_iseq, lcont);
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_RETRY, lend, lcont, NULL, lstart);
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_RETURN_NODE: {
|
|
|
|
pm_arguments_node_t *arguments = ((pm_return_node_t *)node)->arguments;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-12-05 19:31:12 +03:00
|
|
|
if (iseq) {
|
|
|
|
enum rb_iseq_type type = ISEQ_BODY(iseq)->type;
|
|
|
|
LABEL *splabel = 0;
|
|
|
|
|
|
|
|
const rb_iseq_t *parent_iseq = iseq;
|
|
|
|
enum rb_iseq_type parent_type = ISEQ_BODY(parent_iseq)->type;
|
|
|
|
while (parent_type == ISEQ_TYPE_RESCUE || parent_type == ISEQ_TYPE_ENSURE) {
|
|
|
|
if (!(parent_iseq = ISEQ_BODY(parent_iseq)->parent_iseq)) break;
|
|
|
|
parent_type = ISEQ_BODY(parent_iseq)->type;
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-12-05 19:31:12 +03:00
|
|
|
switch (parent_type) {
|
|
|
|
case ISEQ_TYPE_TOP:
|
|
|
|
case ISEQ_TYPE_MAIN:
|
2023-12-07 18:08:16 +03:00
|
|
|
if (arguments) {
|
2023-12-05 19:31:12 +03:00
|
|
|
rb_warn("argument of top-level return is ignored");
|
|
|
|
}
|
|
|
|
if (parent_iseq == iseq) {
|
|
|
|
type = ISEQ_TYPE_METHOD;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-12-05 19:31:12 +03:00
|
|
|
if (type == ISEQ_TYPE_METHOD) {
|
|
|
|
splabel = NEW_LABEL(0);
|
|
|
|
ADD_LABEL(ret, splabel);
|
|
|
|
ADD_ADJUST(ret, &dummy_line_node, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (arguments) {
|
2023-12-07 18:08:16 +03:00
|
|
|
PM_COMPILE_NOT_POPPED((pm_node_t *)arguments);
|
2023-12-05 19:31:12 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (type == ISEQ_TYPE_METHOD && can_add_ensure_iseq(iseq)) {
|
2023-12-11 20:14:21 +03:00
|
|
|
pm_add_ensure_iseq(ret, iseq, 1, src, scope_node);
|
2023-12-05 19:31:12 +03:00
|
|
|
ADD_TRACE(ret, RUBY_EVENT_RETURN);
|
|
|
|
ADD_INSN(ret, &dummy_line_node, leave);
|
|
|
|
ADD_ADJUST_RESTORE(ret, splabel);
|
|
|
|
|
|
|
|
PM_PUTNIL_UNLESS_POPPED;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, throw, INT2FIX(TAG_RETURN));
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
2023-12-05 19:31:12 +03:00
|
|
|
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-12-04 15:27:34 +03:00
|
|
|
case PM_RETRY_NODE: {
|
|
|
|
if (ISEQ_BODY(iseq)->type == ISEQ_TYPE_RESCUE) {
|
|
|
|
PM_PUTNIL;
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, throw, INT2FIX(TAG_RETRY));
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
} else {
|
|
|
|
COMPILE_ERROR(ERROR_ARGS "Invalid retry");
|
|
|
|
rb_bug("Invalid retry");
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SCOPE_NODE: {
|
|
|
|
pm_scope_node_t *scope_node = (pm_scope_node_t *)node;
|
2023-11-01 16:02:00 +03:00
|
|
|
pm_constant_id_list_t *locals = &scope_node->locals;
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
pm_parameters_node_t *parameters_node = NULL;
|
2023-11-07 16:10:23 +03:00
|
|
|
pm_node_list_t *keywords_list = NULL;
|
2023-11-01 16:02:00 +03:00
|
|
|
pm_node_list_t *optionals_list = NULL;
|
2023-11-07 16:10:23 +03:00
|
|
|
pm_node_list_t *posts_list = NULL;
|
|
|
|
pm_node_list_t *requireds_list = NULL;
|
2023-12-06 18:05:14 +03:00
|
|
|
pm_node_list_t *block_locals = NULL;
|
2023-12-13 17:40:34 +03:00
|
|
|
pm_node_t *block_param_keyword_rest = NULL;
|
2024-01-23 03:03:58 +03:00
|
|
|
bool trailing_comma = false;
|
2023-11-07 16:10:23 +03:00
|
|
|
|
|
|
|
struct rb_iseq_constant_body *body = ISEQ_BODY(iseq);
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
if (scope_node->parameters) {
|
|
|
|
switch (PM_NODE_TYPE(scope_node->parameters)) {
|
|
|
|
case PM_BLOCK_PARAMETERS_NODE: {
|
|
|
|
pm_block_parameters_node_t *block_parameters_node = (pm_block_parameters_node_t *)scope_node->parameters;
|
|
|
|
parameters_node = block_parameters_node->parameters;
|
|
|
|
block_locals = &block_parameters_node->locals;
|
2023-12-13 17:40:34 +03:00
|
|
|
if (parameters_node) {
|
|
|
|
block_param_keyword_rest = parameters_node->keyword_rest;
|
2024-01-23 03:03:58 +03:00
|
|
|
if (parameters_node->rest && PM_NODE_TYPE_P(parameters_node->rest, PM_IMPLICIT_REST_NODE)) {
|
|
|
|
trailing_comma = true;
|
|
|
|
}
|
2023-12-13 17:40:34 +03:00
|
|
|
}
|
2023-12-06 18:05:14 +03:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_PARAMETERS_NODE: {
|
|
|
|
parameters_node = (pm_parameters_node_t *) scope_node->parameters;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_NUMBERED_PARAMETERS_NODE: {
|
|
|
|
body->param.lead_num = ((pm_numbered_parameters_node_t *) scope_node->parameters)->maximum;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
rb_bug("Unexpected node type for parameters: %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct rb_iseq_param_keyword *keyword = NULL;
|
|
|
|
|
2023-11-07 16:10:23 +03:00
|
|
|
if (parameters_node) {
|
2023-11-01 16:02:00 +03:00
|
|
|
optionals_list = ¶meters_node->optionals;
|
2023-11-07 16:10:23 +03:00
|
|
|
requireds_list = ¶meters_node->requireds;
|
|
|
|
keywords_list = ¶meters_node->keywords;
|
|
|
|
posts_list = ¶meters_node->posts;
|
2023-12-06 18:05:14 +03:00
|
|
|
} else if (scope_node->parameters && PM_NODE_TYPE_P(scope_node->parameters, PM_NUMBERED_PARAMETERS_NODE)) {
|
2023-11-07 16:10:23 +03:00
|
|
|
body->param.opt_num = 0;
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-11-07 16:10:23 +03:00
|
|
|
body->param.lead_num = 0;
|
|
|
|
body->param.opt_num = 0;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
//********STEP 1**********
|
|
|
|
// Goal: calculate the table size for the locals, accounting for
|
|
|
|
// hidden variables and multi target nodes
|
2023-11-07 16:10:23 +03:00
|
|
|
size_t locals_size = locals->size;
|
2023-09-28 16:47:46 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
// Index lookup table buffer size is only the number of the locals
|
|
|
|
st_table *index_lookup_table = st_init_numtable();
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-12-01 00:18:14 +03:00
|
|
|
int table_size = (int) locals_size;
|
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
// For nodes have a hidden iteration variable. We add that to the local
|
|
|
|
// table size here.
|
|
|
|
if (PM_NODE_TYPE_P(scope_node->ast_node, PM_FOR_NODE)) table_size++;
|
2023-12-06 18:05:14 +03:00
|
|
|
|
2023-12-01 00:18:14 +03:00
|
|
|
if (keywords_list && keywords_list->size) {
|
|
|
|
table_size++;
|
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
if (requireds_list) {
|
|
|
|
for (size_t i = 0; i < requireds_list->size; i++) {
|
|
|
|
// For each MultiTargetNode, we're going to have one
|
|
|
|
// additional anonymous local not represented in the locals table
|
|
|
|
// We want to account for this in our table size
|
|
|
|
pm_node_t *required = requireds_list->nodes[i];
|
|
|
|
if (PM_NODE_TYPE_P(required, PM_MULTI_TARGET_NODE)) {
|
|
|
|
table_size++;
|
|
|
|
}
|
2023-12-13 20:17:22 +03:00
|
|
|
else if (PM_NODE_TYPE_P(required, PM_REQUIRED_PARAMETER_NODE)) {
|
2024-01-11 03:27:00 +03:00
|
|
|
if (PM_NODE_FLAG_P(required, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
table_size++;
|
2023-12-13 20:17:22 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2024-01-24 00:13:56 +03:00
|
|
|
// Ensure there is enough room in the local table for any
|
|
|
|
// parameters that have been repeated
|
|
|
|
// ex: def underscore_parameters(_, _ = 1, _ = 2); _; end
|
|
|
|
// ^^^^^^^^^^^^
|
|
|
|
if (optionals_list && optionals_list->size) {
|
|
|
|
for (size_t i = 0; i < optionals_list->size; i++) {
|
|
|
|
pm_node_t * node = optionals_list->nodes[i];
|
|
|
|
if (PM_NODE_FLAG_P(node, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
table_size++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-01-12 01:50:09 +03:00
|
|
|
// If we have an anonymous "rest" node, we'll need to increase the local
|
|
|
|
// table size to take it in to account.
|
|
|
|
// def m(foo, *, bar)
|
|
|
|
// ^
|
2024-01-24 00:50:27 +03:00
|
|
|
if (parameters_node) {
|
|
|
|
if (parameters_node->rest) {
|
|
|
|
if (!(PM_NODE_TYPE_P(parameters_node->rest, PM_IMPLICIT_REST_NODE))) {
|
|
|
|
if (!((pm_rest_parameter_node_t *)parameters_node->rest)->name || PM_NODE_FLAG_P(parameters_node->rest, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
table_size++;
|
|
|
|
}
|
2024-01-12 01:50:09 +03:00
|
|
|
}
|
|
|
|
}
|
2024-01-24 00:50:27 +03:00
|
|
|
|
|
|
|
// def underscore_parameters(_, **_); _; end
|
|
|
|
// ^^^
|
|
|
|
if (parameters_node->keyword_rest && PM_NODE_FLAG_P(parameters_node->keyword_rest, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
table_size++;
|
|
|
|
}
|
2024-01-12 01:50:09 +03:00
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
if (posts_list) {
|
|
|
|
for (size_t i = 0; i < posts_list->size; i++) {
|
|
|
|
// For each MultiTargetNode, we're going to have one
|
|
|
|
// additional anonymous local not represented in the locals table
|
|
|
|
// We want to account for this in our table size
|
|
|
|
pm_node_t *required = posts_list->nodes[i];
|
2024-01-24 00:33:31 +03:00
|
|
|
if (PM_NODE_TYPE_P(required, PM_MULTI_TARGET_NODE) || PM_NODE_FLAG_P(required, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
2023-12-06 18:05:14 +03:00
|
|
|
table_size++;
|
|
|
|
}
|
|
|
|
}
|
2023-12-01 00:18:14 +03:00
|
|
|
}
|
|
|
|
|
2024-01-24 00:41:34 +03:00
|
|
|
if (keywords_list && keywords_list->size) {
|
|
|
|
for (size_t i = 0; i < keywords_list->size; i++) {
|
|
|
|
pm_node_t *keyword_parameter_node = keywords_list->nodes[i];
|
|
|
|
if (PM_NODE_FLAG_P(keyword_parameter_node, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
table_size++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-13 17:40:34 +03:00
|
|
|
if (block_param_keyword_rest) {
|
|
|
|
table_size++;
|
|
|
|
}
|
|
|
|
|
2024-01-24 00:55:46 +03:00
|
|
|
if (parameters_node && parameters_node->block) {
|
|
|
|
if (PM_NODE_FLAG_P(parameters_node->block, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
table_size++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-11 22:17:02 +03:00
|
|
|
// When we have a `...` as the keyword_rest, it's a forwarding_parameter_node and
|
|
|
|
// we need to leave space for 2 more locals on the locals table (`*` and `&`)
|
|
|
|
if (parameters_node && parameters_node->keyword_rest &&
|
|
|
|
PM_NODE_TYPE_P(parameters_node->keyword_rest, PM_FORWARDING_PARAMETER_NODE)) {
|
|
|
|
table_size += 2;
|
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
// We can create local_table_for_iseq with the correct size
|
|
|
|
VALUE idtmp = 0;
|
|
|
|
rb_ast_id_table_t *local_table_for_iseq = ALLOCV(idtmp, sizeof(rb_ast_id_table_t) + table_size * sizeof(ID));
|
|
|
|
local_table_for_iseq->size = table_size;
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
//********END OF STEP 1**********
|
2023-12-01 00:18:14 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
//********STEP 2**********
|
|
|
|
// Goal: populate iv index table as well as local table, keeping the
|
|
|
|
// layout of the local table consistent with the layout of the
|
|
|
|
// stack when calling the method
|
|
|
|
//
|
|
|
|
// Do a first pass on all of the parameters, setting their values in
|
|
|
|
// the local_table_for_iseq, _except_ for Multis who get a hidden
|
|
|
|
// variable in this step, and will get their names inserted in step 3
|
|
|
|
|
|
|
|
// local_index is a cursor that keeps track of the current
|
|
|
|
// index into local_table_for_iseq. The local table is actually a list,
|
|
|
|
// and the order of that list must match the order of the items pushed
|
|
|
|
// on the stack. We need to take in to account things pushed on the
|
|
|
|
// stack that _might not have a name_ (for example array destructuring).
|
|
|
|
// This index helps us know which item we're dealing with and also give
|
|
|
|
// those anonymous items temporary names (as below)
|
|
|
|
int local_index = 0;
|
|
|
|
|
2023-12-11 23:17:48 +03:00
|
|
|
// We will assign these values now, if applicable, and use them for
|
|
|
|
// the ISEQs on these multis
|
2024-01-19 22:33:49 +03:00
|
|
|
int required_multis_hidden_index = local_index;
|
2023-12-11 23:17:48 +03:00
|
|
|
int post_multis_hidden_index = 0;
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
// Here we figure out local table indices and insert them in to the
|
|
|
|
// index lookup table and local tables.
|
|
|
|
//
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^^^^^^^^^^^
|
|
|
|
if (requireds_list && requireds_list->size) {
|
|
|
|
for (size_t i = 0; i < requireds_list->size; i++, local_index++) {
|
|
|
|
ID local;
|
|
|
|
// For each MultiTargetNode, we're going to have one
|
|
|
|
// additional anonymous local not represented in the locals table
|
|
|
|
// We want to account for this in our table size
|
|
|
|
pm_node_t *required = requireds_list->nodes[i];
|
|
|
|
switch (PM_NODE_TYPE(required)) {
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^^^^^^^^
|
|
|
|
case PM_MULTI_TARGET_NODE: {
|
2024-01-18 22:59:59 +03:00
|
|
|
local = rb_make_temporary_id(local_index);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
break;
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^
|
|
|
|
case PM_REQUIRED_PARAMETER_NODE: {
|
2024-01-18 22:59:59 +03:00
|
|
|
pm_required_parameter_node_t * param = (pm_required_parameter_node_t *)required;
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2024-01-23 23:55:00 +03:00
|
|
|
if (PM_NODE_FLAG_P(required, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
ID local = pm_constant_id_lookup(scope_node, param->name);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
}
|
|
|
|
else {
|
2024-01-18 22:59:59 +03:00
|
|
|
pm_insert_local_index(param->name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
|
|
|
break;
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
default: {
|
2024-01-18 22:59:59 +03:00
|
|
|
rb_bug("Unsupported node in requireds in parameters %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-11-07 16:10:23 +03:00
|
|
|
body->param.lead_num = (int) requireds_list->size;
|
|
|
|
body->param.flags.has_lead = true;
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
2023-11-07 16:10:23 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^^^
|
|
|
|
if (optionals_list && optionals_list->size) {
|
|
|
|
body->param.opt_num = (int) optionals_list->size;
|
|
|
|
body->param.flags.has_opt = true;
|
|
|
|
|
|
|
|
for (size_t i = 0; i < optionals_list->size; i++, local_index++) {
|
2024-01-24 00:13:56 +03:00
|
|
|
pm_node_t * node = optionals_list->nodes[i];
|
|
|
|
pm_constant_id_t name = ((pm_optional_parameter_node_t *)node)->name;
|
|
|
|
|
|
|
|
if (PM_NODE_FLAG_P(node, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
ID local = pm_constant_id_lookup(scope_node, name);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_insert_local_index(name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
2023-11-07 16:10:23 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^
|
2023-12-01 00:18:14 +03:00
|
|
|
if (parameters_node && parameters_node->rest) {
|
2023-12-06 18:05:14 +03:00
|
|
|
body->param.rest_start = local_index;
|
2023-11-30 20:57:49 +03:00
|
|
|
// If there's a trailing comma, we'll have an implicit rest node,
|
|
|
|
// and we don't want it to impact the rest variables on param
|
|
|
|
if (!(PM_NODE_TYPE_P(parameters_node->rest, PM_IMPLICIT_REST_NODE))) {
|
|
|
|
body->param.flags.has_rest = true;
|
|
|
|
assert(body->param.rest_start != -1);
|
2023-12-06 18:05:14 +03:00
|
|
|
|
|
|
|
pm_constant_id_t name = ((pm_rest_parameter_node_t *)parameters_node->rest)->name;
|
|
|
|
if (name) {
|
2023-12-12 17:40:16 +03:00
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^
|
2024-01-24 00:20:49 +03:00
|
|
|
if (PM_NODE_FLAG_P(parameters_node->rest, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
ID local = pm_constant_id_lookup(scope_node, name);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_insert_local_index(name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
2023-12-12 17:40:16 +03:00
|
|
|
else {
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^
|
2024-01-24 00:13:18 +03:00
|
|
|
local_table_for_iseq->ids[local_index] = PM_CONSTANT_MULT;
|
2024-01-26 22:51:25 +03:00
|
|
|
st_insert(index_lookup_table, (st_data_t)PM_CONSTANT_MULT, local_index);
|
2023-12-12 17:40:16 +03:00
|
|
|
}
|
|
|
|
local_index++;
|
2023-11-30 20:57:49 +03:00
|
|
|
}
|
2023-12-01 00:18:14 +03:00
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^^^^^^^^^^^
|
2023-11-07 16:10:23 +03:00
|
|
|
if (posts_list && posts_list->size) {
|
|
|
|
body->param.post_num = (int) posts_list->size;
|
2023-12-06 18:05:14 +03:00
|
|
|
body->param.post_start = local_index;
|
2023-11-07 16:10:23 +03:00
|
|
|
body->param.flags.has_post = true;
|
2023-12-06 18:05:14 +03:00
|
|
|
|
|
|
|
for (size_t i = 0; i < posts_list->size; i++, local_index++) {
|
|
|
|
ID local;
|
|
|
|
// For each MultiTargetNode, we're going to have one
|
|
|
|
// additional anonymous local not represented in the locals table
|
|
|
|
// We want to account for this in our table size
|
|
|
|
pm_node_t *post_node = posts_list->nodes[i];
|
|
|
|
switch (PM_NODE_TYPE(post_node)) {
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^^^^^^^^
|
|
|
|
case PM_MULTI_TARGET_NODE: {
|
2024-01-19 19:18:47 +03:00
|
|
|
post_multis_hidden_index = local_index;
|
|
|
|
local = rb_make_temporary_id(local_index);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
break;
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^
|
|
|
|
case PM_REQUIRED_PARAMETER_NODE: {
|
2024-01-19 19:18:47 +03:00
|
|
|
pm_required_parameter_node_t * param = (pm_required_parameter_node_t *)post_node;
|
2024-01-24 00:33:31 +03:00
|
|
|
if (PM_NODE_FLAG_P(param, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
ID local = pm_constant_id_lookup(scope_node, param->name);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
}
|
|
|
|
else {
|
2023-12-06 18:05:14 +03:00
|
|
|
|
2024-01-24 00:33:31 +03:00
|
|
|
pm_insert_local_index(param->name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
2024-01-19 19:18:47 +03:00
|
|
|
break;
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
default: {
|
2024-01-19 19:18:47 +03:00
|
|
|
rb_bug("Unsupported node in posts in parameters %s", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2023-11-07 16:10:23 +03:00
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^^^^^^
|
2023-11-07 16:10:23 +03:00
|
|
|
// Keywords create an internal variable on the parse tree
|
|
|
|
if (keywords_list && keywords_list->size) {
|
|
|
|
body->param.keyword = keyword = ZALLOC_N(struct rb_iseq_param_keyword, 1);
|
|
|
|
keyword->num = (int) keywords_list->size;
|
|
|
|
|
2023-11-08 01:28:21 +03:00
|
|
|
body->param.flags.has_kw = true;
|
2023-11-07 16:10:23 +03:00
|
|
|
const VALUE default_values = rb_ary_hidden_new(1);
|
|
|
|
const VALUE complex_mark = rb_str_tmp_new(0);
|
|
|
|
|
2023-12-13 05:34:14 +03:00
|
|
|
ID *ids = xcalloc(keywords_list->size, sizeof(ID));
|
2023-11-08 20:49:58 +03:00
|
|
|
|
2024-01-19 23:00:35 +03:00
|
|
|
size_t kw_index = 0;
|
|
|
|
|
|
|
|
for (size_t i = 0; i < keywords_list->size; i++) {
|
2023-11-07 16:10:23 +03:00
|
|
|
pm_node_t *keyword_parameter_node = keywords_list->nodes[i];
|
2023-11-13 22:32:39 +03:00
|
|
|
pm_constant_id_t name;
|
2023-11-07 16:10:23 +03:00
|
|
|
|
2024-01-19 23:00:35 +03:00
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^
|
|
|
|
if (PM_NODE_TYPE_P(keyword_parameter_node, PM_REQUIRED_KEYWORD_PARAMETER_NODE)) {
|
|
|
|
name = ((pm_required_keyword_parameter_node_t *)keyword_parameter_node)->name;
|
|
|
|
keyword->required_num++;
|
|
|
|
ID local = pm_constant_id_lookup(scope_node, name);
|
2024-01-24 00:41:34 +03:00
|
|
|
|
|
|
|
if (PM_NODE_FLAG_P(keyword_parameter_node, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_insert_local_index(name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
2024-01-19 23:00:35 +03:00
|
|
|
local_index++;
|
|
|
|
ids[kw_index++] = local;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (size_t i = 0; i < keywords_list->size; i++) {
|
|
|
|
pm_node_t *keyword_parameter_node = keywords_list->nodes[i];
|
|
|
|
pm_constant_id_t name;
|
|
|
|
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^^
|
|
|
|
if (PM_NODE_TYPE_P(keyword_parameter_node, PM_OPTIONAL_KEYWORD_PARAMETER_NODE)) {
|
2023-11-09 16:29:44 +03:00
|
|
|
pm_optional_keyword_parameter_node_t *cast = ((pm_optional_keyword_parameter_node_t *)keyword_parameter_node);
|
2023-11-13 22:32:39 +03:00
|
|
|
|
2023-11-09 16:29:44 +03:00
|
|
|
pm_node_t *value = cast->value;
|
|
|
|
name = cast->name;
|
2023-11-07 16:10:23 +03:00
|
|
|
|
2023-12-14 14:58:50 +03:00
|
|
|
if (pm_static_literal_p(value) &&
|
|
|
|
!(PM_NODE_TYPE_P(value, PM_ARRAY_NODE) ||
|
|
|
|
PM_NODE_TYPE_P(value, PM_HASH_NODE) ||
|
|
|
|
PM_NODE_TYPE_P(value, PM_RANGE_NODE))) {
|
|
|
|
|
2023-12-14 00:41:45 +03:00
|
|
|
rb_ary_push(default_values, pm_static_literal_value(value, scope_node, parser));
|
2023-12-14 14:58:50 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-11-09 16:29:44 +03:00
|
|
|
rb_ary_push(default_values, complex_mark);
|
|
|
|
}
|
|
|
|
|
2024-01-19 23:00:35 +03:00
|
|
|
ID local = pm_constant_id_lookup(scope_node, name);
|
2024-01-24 00:41:34 +03:00
|
|
|
if (PM_NODE_FLAG_P(keyword_parameter_node, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_insert_local_index(name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
2024-01-19 23:00:35 +03:00
|
|
|
ids[kw_index++] = local;
|
|
|
|
local_index++;
|
2023-11-07 16:10:23 +03:00
|
|
|
}
|
2023-11-13 22:32:39 +03:00
|
|
|
|
2023-11-07 16:10:23 +03:00
|
|
|
}
|
2023-11-08 20:49:58 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
keyword->bits_start = local_index;
|
2023-11-13 22:32:39 +03:00
|
|
|
keyword->table = ids;
|
|
|
|
|
2023-11-08 20:49:58 +03:00
|
|
|
VALUE *dvs = ALLOC_N(VALUE, RARRAY_LEN(default_values));
|
|
|
|
|
|
|
|
for (int i = 0; i < RARRAY_LEN(default_values); i++) {
|
|
|
|
VALUE dv = RARRAY_AREF(default_values, i);
|
|
|
|
if (dv == complex_mark) dv = Qundef;
|
|
|
|
if (!SPECIAL_CONST_P(dv)) {
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, dv);
|
|
|
|
}
|
|
|
|
dvs[i] = dv;
|
|
|
|
}
|
|
|
|
|
|
|
|
keyword->default_values = dvs;
|
2023-12-06 18:05:14 +03:00
|
|
|
|
|
|
|
// Hidden local for keyword arguments
|
|
|
|
ID local = rb_make_temporary_id(local_index);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
local_index++;
|
|
|
|
}
|
|
|
|
|
2024-01-23 03:03:58 +03:00
|
|
|
if (body->type == ISEQ_TYPE_BLOCK && local_index == 1 && requireds_list && requireds_list->size == 1 && !trailing_comma) {
|
2023-12-06 18:05:14 +03:00
|
|
|
body->param.flags.ambiguous_param0 = true;
|
2023-11-07 16:10:23 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (parameters_node) {
|
2023-12-06 18:05:14 +03:00
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^
|
2023-11-07 16:10:23 +03:00
|
|
|
if (parameters_node->keyword_rest) {
|
2023-12-11 22:17:02 +03:00
|
|
|
switch (PM_NODE_TYPE(parameters_node->keyword_rest)) {
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **nil, &n)
|
|
|
|
// ^^^^^
|
|
|
|
case PM_NO_KEYWORDS_PARAMETER_NODE: {
|
2023-12-01 00:18:14 +03:00
|
|
|
|
2024-01-19 19:18:47 +03:00
|
|
|
body->param.flags.accepts_no_kwarg = true;
|
|
|
|
break;
|
2023-12-11 22:17:02 +03:00
|
|
|
}
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^
|
|
|
|
case PM_KEYWORD_REST_PARAMETER_NODE: {
|
2024-01-19 19:18:47 +03:00
|
|
|
pm_keyword_rest_parameter_node_t *kw_rest_node = (pm_keyword_rest_parameter_node_t *)parameters_node->keyword_rest;
|
|
|
|
if (!body->param.flags.has_kw) {
|
|
|
|
body->param.keyword = keyword = ZALLOC_N(struct rb_iseq_param_keyword, 1);
|
|
|
|
}
|
2023-12-06 18:05:14 +03:00
|
|
|
|
2024-01-19 19:18:47 +03:00
|
|
|
keyword->rest_start = local_index;
|
|
|
|
body->param.flags.has_kwrest = true;
|
2023-12-11 22:17:02 +03:00
|
|
|
|
2024-01-19 19:18:47 +03:00
|
|
|
pm_constant_id_t constant_id = kw_rest_node->name;
|
|
|
|
if (constant_id) {
|
2024-01-24 00:50:27 +03:00
|
|
|
if (PM_NODE_FLAG_P(kw_rest_node, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
ID local = pm_constant_id_lookup(scope_node, constant_id);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_insert_local_index(constant_id, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
2024-01-19 19:18:47 +03:00
|
|
|
}
|
|
|
|
else {
|
2024-01-24 18:22:46 +03:00
|
|
|
local_table_for_iseq->ids[local_index] = PM_CONSTANT_POW;
|
2024-01-26 22:51:25 +03:00
|
|
|
st_insert(index_lookup_table, (st_data_t)PM_CONSTANT_POW, local_index);
|
2024-01-19 19:18:47 +03:00
|
|
|
}
|
|
|
|
local_index++;
|
|
|
|
break;
|
2023-12-11 22:17:02 +03:00
|
|
|
}
|
|
|
|
// def foo(...)
|
|
|
|
// ^^^
|
|
|
|
case PM_FORWARDING_PARAMETER_NODE: {
|
2024-01-19 19:18:47 +03:00
|
|
|
body->param.rest_start = local_index;
|
|
|
|
body->param.flags.has_rest = true;
|
2024-01-24 21:43:26 +03:00
|
|
|
local_table_for_iseq->ids[local_index] = PM_CONSTANT_MULT;
|
2024-01-26 22:51:25 +03:00
|
|
|
st_insert(index_lookup_table, (st_data_t)PM_CONSTANT_MULT, local_index);
|
2024-01-19 19:18:47 +03:00
|
|
|
local_index++;
|
|
|
|
|
|
|
|
body->param.block_start = local_index;
|
|
|
|
body->param.flags.has_block = true;
|
2024-01-24 19:45:53 +03:00
|
|
|
local_table_for_iseq->ids[local_index] = PM_CONSTANT_AND;
|
2024-01-26 22:51:25 +03:00
|
|
|
st_insert(index_lookup_table, (st_data_t)PM_CONSTANT_AND, local_index);
|
2024-01-19 19:18:47 +03:00
|
|
|
local_index++;
|
|
|
|
|
2024-01-24 21:43:26 +03:00
|
|
|
local_table_for_iseq->ids[local_index] = PM_CONSTANT_DOT3;
|
2024-01-26 22:51:25 +03:00
|
|
|
st_insert(index_lookup_table, (st_data_t)PM_CONSTANT_DOT3, local_index);
|
2024-01-19 19:18:47 +03:00
|
|
|
local_index++;
|
|
|
|
break;
|
2023-12-11 22:17:02 +03:00
|
|
|
}
|
|
|
|
default: {
|
2024-01-19 19:18:47 +03:00
|
|
|
rb_bug("node type %s not expected as keyword_rest", pm_node_type_to_str(PM_NODE_TYPE(parameters_node->keyword_rest)));
|
2023-12-11 22:17:02 +03:00
|
|
|
}
|
2023-11-07 16:10:23 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^
|
2023-11-07 16:10:23 +03:00
|
|
|
if (parameters_node->block) {
|
2023-12-06 18:05:14 +03:00
|
|
|
body->param.block_start = local_index;
|
2023-11-07 16:10:23 +03:00
|
|
|
body->param.flags.has_block = true;
|
2023-12-06 18:05:14 +03:00
|
|
|
|
|
|
|
pm_constant_id_t name = ((pm_block_parameter_node_t *)parameters_node->block)->name;
|
2024-01-24 00:55:46 +03:00
|
|
|
|
2024-01-23 22:43:53 +03:00
|
|
|
if (name == 0) {
|
|
|
|
local_table_for_iseq->ids[local_index] = PM_CONSTANT_AND;
|
2024-01-26 22:51:25 +03:00
|
|
|
st_insert(index_lookup_table, (st_data_t)PM_CONSTANT_AND, local_index);
|
2024-01-23 22:43:53 +03:00
|
|
|
}
|
|
|
|
else {
|
2024-01-24 00:55:46 +03:00
|
|
|
if (PM_NODE_FLAG_P(parameters_node->block, PM_PARAMETER_FLAGS_REPEATED_PARAMETER)) {
|
|
|
|
ID local = pm_constant_id_lookup(scope_node, name);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
pm_insert_local_index(name, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
2024-01-23 20:11:14 +03:00
|
|
|
}
|
2024-01-23 22:43:53 +03:00
|
|
|
local_index++;
|
2023-11-07 16:10:23 +03:00
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
//********END OF STEP 2**********
|
|
|
|
// The local table is now consistent with expected
|
|
|
|
// stack layout
|
|
|
|
|
2023-11-30 20:57:49 +03:00
|
|
|
// If there's only one required element in the parameters
|
|
|
|
// CRuby needs to recognize it as an ambiguous parameter
|
2023-12-06 18:05:14 +03:00
|
|
|
|
|
|
|
//********STEP 3**********
|
|
|
|
// Goal: fill in the names of the parameters in MultiTargetNodes
|
|
|
|
//
|
|
|
|
// Go through requireds again to set the multis
|
2023-12-11 23:17:48 +03:00
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
if (requireds_list && requireds_list->size) {
|
|
|
|
for (size_t i = 0; i < requireds_list->size; i++) {
|
|
|
|
// For each MultiTargetNode, we're going to have one
|
|
|
|
// additional anonymous local not represented in the locals table
|
|
|
|
// We want to account for this in our table size
|
|
|
|
pm_node_t *required = requireds_list->nodes[i];
|
|
|
|
if (PM_NODE_TYPE_P(required, PM_MULTI_TARGET_NODE)) {
|
2024-01-24 18:39:40 +03:00
|
|
|
local_index = pm_compile_destructured_param_locals((pm_multi_target_node_t *)required, index_lookup_table, local_table_for_iseq, scope_node, local_index);
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
}
|
2023-11-30 20:57:49 +03:00
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
// Go through posts again to set the multis
|
|
|
|
if (posts_list && posts_list->size) {
|
|
|
|
for (size_t i = 0; i < posts_list->size; i++) {
|
|
|
|
// For each MultiTargetNode, we're going to have one
|
|
|
|
// additional anonymous local not represented in the locals table
|
|
|
|
// We want to account for this in our table size
|
|
|
|
pm_node_t *post= posts_list->nodes[i];
|
|
|
|
if (PM_NODE_TYPE_P(post, PM_MULTI_TARGET_NODE)) {
|
2024-01-24 18:39:40 +03:00
|
|
|
local_index = pm_compile_destructured_param_locals((pm_multi_target_node_t *)post, index_lookup_table, local_table_for_iseq, scope_node, local_index);
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Set any anonymous locals for the for node
|
|
|
|
if (PM_NODE_TYPE_P(scope_node->ast_node, PM_FOR_NODE)) {
|
2024-01-12 23:23:47 +03:00
|
|
|
if (PM_NODE_TYPE_P(((const pm_for_node_t *) scope_node->ast_node)->index, PM_LOCAL_VARIABLE_TARGET_NODE)) {
|
|
|
|
body->param.lead_num++;
|
|
|
|
} else {
|
|
|
|
body->param.rest_start = local_index;
|
|
|
|
body->param.flags.has_rest = true;
|
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
ID local = rb_make_temporary_id(local_index);
|
|
|
|
local_table_for_iseq->ids[local_index] = local;
|
|
|
|
local_index++;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Fill in any NumberedParameters, if they exist
|
|
|
|
if (scope_node->parameters && PM_NODE_TYPE_P(scope_node->parameters, PM_NUMBERED_PARAMETERS_NODE)) {
|
|
|
|
int maximum = ((pm_numbered_parameters_node_t *)scope_node->parameters)->maximum;
|
|
|
|
for (int i = 0; i < maximum; i++, local_index++) {
|
|
|
|
pm_constant_id_t constant_id = locals->ids[i];
|
|
|
|
pm_insert_local_index(constant_id, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
//********END OF STEP 3**********
|
|
|
|
|
|
|
|
//********STEP 4**********
|
|
|
|
// Goal: fill in the method body locals
|
|
|
|
// To be explicit, these are the non-parameter locals
|
2024-01-24 03:48:28 +03:00
|
|
|
// We fill in the block_locals, if they exist
|
|
|
|
// lambda { |x; y| y }
|
|
|
|
// ^
|
|
|
|
if (block_locals && block_locals->size) {
|
|
|
|
for (size_t i = 0; i < block_locals->size; i++, local_index++) {
|
|
|
|
pm_constant_id_t constant_id = ((pm_block_local_variable_node_t *)block_locals->nodes[i])->name;
|
|
|
|
pm_insert_local_index(constant_id, local_index, index_lookup_table, local_table_for_iseq, scope_node);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Fill in any locals we missed
|
2023-12-06 18:05:14 +03:00
|
|
|
if (scope_node->locals.size) {
|
2024-01-23 23:11:21 +03:00
|
|
|
for (size_t i = 0; i < scope_node->locals.size; i++) {
|
2023-12-06 18:05:14 +03:00
|
|
|
pm_constant_id_t constant_id = locals->ids[i];
|
|
|
|
if (constant_id) {
|
2024-01-23 23:11:21 +03:00
|
|
|
struct pm_local_table_insert_ctx ctx;
|
|
|
|
ctx.scope_node = scope_node;
|
|
|
|
ctx.local_table_for_iseq = local_table_for_iseq;
|
|
|
|
ctx.local_index = local_index;
|
|
|
|
|
2024-01-26 22:51:25 +03:00
|
|
|
st_update(index_lookup_table, (st_data_t)constant_id, pm_local_table_insert_func, (st_data_t)&ctx);
|
2024-01-23 23:11:21 +03:00
|
|
|
|
|
|
|
local_index = ctx.local_index;
|
2023-12-06 18:05:14 +03:00
|
|
|
}
|
|
|
|
}
|
2023-12-01 18:51:41 +03:00
|
|
|
}
|
|
|
|
|
2023-12-06 18:05:14 +03:00
|
|
|
//********END OF STEP 4**********
|
|
|
|
|
|
|
|
// We set the index_lookup_table on the scope node so we can
|
|
|
|
// refer to the parameters correctly
|
2024-01-18 19:55:31 +03:00
|
|
|
if (scope_node->index_lookup_table) {
|
|
|
|
st_free_table(scope_node->index_lookup_table);
|
|
|
|
}
|
2023-12-06 18:05:14 +03:00
|
|
|
scope_node->index_lookup_table = index_lookup_table;
|
|
|
|
iseq_calc_param_size(iseq);
|
|
|
|
iseq_set_local_table(iseq, local_table_for_iseq);
|
|
|
|
scope_node->local_table_for_iseq_size = local_table_for_iseq->size;
|
|
|
|
|
|
|
|
//********STEP 5************
|
|
|
|
// Goal: compile anything that needed to be compiled
|
2024-01-24 22:41:43 +03:00
|
|
|
if (optionals_list && optionals_list->size) {
|
|
|
|
LABEL **opt_table = (LABEL **)ALLOC_N(VALUE, optionals_list->size + 1);
|
|
|
|
LABEL *label;
|
|
|
|
|
|
|
|
// TODO: Should we make an api for NEW_LABEL where you can pass
|
|
|
|
// a pointer to the label it should fill out? We already
|
|
|
|
// have a list of labels allocated above so it seems wasteful
|
|
|
|
// to do the copies.
|
|
|
|
for (size_t i = 0; i < optionals_list->size; i++) {
|
|
|
|
label = NEW_LABEL(lineno);
|
|
|
|
opt_table[i] = label;
|
|
|
|
ADD_LABEL(ret, label);
|
|
|
|
pm_node_t *optional_node = optionals_list->nodes[i];
|
|
|
|
PM_COMPILE_NOT_POPPED(optional_node);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Set the last label
|
|
|
|
label = NEW_LABEL(lineno);
|
|
|
|
opt_table[optionals_list->size] = label;
|
|
|
|
ADD_LABEL(ret, label);
|
|
|
|
|
|
|
|
body->param.opt_table = (const VALUE *)opt_table;
|
|
|
|
}
|
|
|
|
|
2023-12-14 00:41:45 +03:00
|
|
|
if (keywords_list && keywords_list->size) {
|
2024-01-23 01:51:12 +03:00
|
|
|
size_t optional_index = 0;
|
2024-01-24 03:48:28 +03:00
|
|
|
for (size_t i = 0; i < keywords_list->size; i++) {
|
2023-12-14 00:41:45 +03:00
|
|
|
pm_node_t *keyword_parameter_node = keywords_list->nodes[i];
|
|
|
|
pm_constant_id_t name;
|
|
|
|
|
|
|
|
switch (PM_NODE_TYPE(keyword_parameter_node)) {
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^^^
|
|
|
|
case PM_OPTIONAL_KEYWORD_PARAMETER_NODE: {
|
|
|
|
pm_optional_keyword_parameter_node_t *cast = ((pm_optional_keyword_parameter_node_t *)keyword_parameter_node);
|
|
|
|
|
|
|
|
pm_node_t *value = cast->value;
|
|
|
|
name = cast->name;
|
|
|
|
|
2023-12-14 14:58:50 +03:00
|
|
|
if (!(pm_static_literal_p(value)) ||
|
|
|
|
PM_NODE_TYPE_P(value, PM_ARRAY_NODE) ||
|
|
|
|
PM_NODE_TYPE_P(value, PM_HASH_NODE) ||
|
|
|
|
PM_NODE_TYPE_P(value, PM_RANGE_NODE)) {
|
2023-12-14 00:41:45 +03:00
|
|
|
LABEL *end_label = NEW_LABEL(nd_line(&dummy_line_node));
|
|
|
|
|
2024-01-16 01:32:30 +03:00
|
|
|
pm_local_index_t index = pm_lookup_local_index(iseq, scope_node, name, 0);
|
2023-12-14 00:41:45 +03:00
|
|
|
int kw_bits_idx = table_size - body->param.keyword->bits_start;
|
2024-01-23 01:51:12 +03:00
|
|
|
ADD_INSN2(ret, &dummy_line_node, checkkeyword, INT2FIX(kw_bits_idx + VM_ENV_DATA_SIZE - 1), INT2FIX(optional_index));
|
2023-12-14 00:41:45 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, end_label);
|
|
|
|
PM_COMPILE(value);
|
2024-01-15 23:59:11 +03:00
|
|
|
ADD_SETLOCAL(ret, &dummy_line_node, index.index, index.level);
|
2023-12-14 00:41:45 +03:00
|
|
|
|
|
|
|
ADD_LABEL(ret, end_label);
|
|
|
|
}
|
2024-01-23 01:51:12 +03:00
|
|
|
optional_index++;
|
2023-12-14 14:58:50 +03:00
|
|
|
break;
|
2023-12-14 00:41:45 +03:00
|
|
|
}
|
|
|
|
// def foo(a, (b, *c, d), e = 1, *f, g, (h, *i, j), k:, l: 1, **m, &n)
|
|
|
|
// ^^
|
|
|
|
case PM_REQUIRED_KEYWORD_PARAMETER_NODE: {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default: {
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Unexpected keyword parameter node type %s", pm_node_type_to_str(PM_NODE_TYPE(keyword_parameter_node)));
|
2023-12-14 00:41:45 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-11 23:17:48 +03:00
|
|
|
if (requireds_list && requireds_list->size) {
|
|
|
|
for (size_t i = 0; i < requireds_list->size; i++) {
|
2024-01-24 18:39:40 +03:00
|
|
|
// For each MultiTargetNode, we're going to have one additional
|
|
|
|
// anonymous local not represented in the locals table. We want
|
|
|
|
// to account for this in our table size.
|
|
|
|
const pm_node_t *required = requireds_list->nodes[i];
|
|
|
|
|
2023-12-11 23:17:48 +03:00
|
|
|
if (PM_NODE_TYPE_P(required, PM_MULTI_TARGET_NODE)) {
|
2024-01-24 18:39:40 +03:00
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, table_size - required_multis_hidden_index - (int) i, 0);
|
|
|
|
pm_compile_destructured_param_writes(iseq, (const pm_multi_target_node_t *) required, ret, scope_node);
|
2023-12-11 23:17:48 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (posts_list && posts_list->size) {
|
|
|
|
for (size_t i = 0; i < posts_list->size; i++) {
|
2024-01-24 18:39:40 +03:00
|
|
|
// For each MultiTargetNode, we're going to have one additional
|
|
|
|
// anonymous local not represented in the locals table. We want
|
|
|
|
// to account for this in our table size.
|
|
|
|
const pm_node_t *post = posts_list->nodes[i];
|
|
|
|
|
2023-12-11 23:17:48 +03:00
|
|
|
if (PM_NODE_TYPE_P(post, PM_MULTI_TARGET_NODE)) {
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, table_size - post_multis_hidden_index, 0);
|
2024-01-24 18:39:40 +03:00
|
|
|
pm_compile_destructured_param_writes(iseq, (const pm_multi_target_node_t *) post, ret, scope_node);
|
2023-12-11 23:17:48 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-11-07 16:10:23 +03:00
|
|
|
switch (body->type) {
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
case ISEQ_TYPE_BLOCK: {
|
|
|
|
LABEL *start = ISEQ_COMPILE_DATA(iseq)->start_label = NEW_LABEL(0);
|
|
|
|
LABEL *end = ISEQ_COMPILE_DATA(iseq)->end_label = NEW_LABEL(0);
|
2024-01-12 23:23:47 +03:00
|
|
|
NODE dummy_line_node = generate_dummy_line_node(body->location.first_lineno, -1);
|
2023-09-28 16:47:46 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
start->rescued = LABEL_RESCUE_BEG;
|
|
|
|
end->rescued = LABEL_RESCUE_END;
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
// For nodes automatically assign the iteration variable to whatever
|
|
|
|
// index variable. We need to handle that write here because it has
|
|
|
|
// to happen in the context of the block. Note that this happens
|
|
|
|
// before the B_CALL tracepoint event.
|
|
|
|
if (PM_NODE_TYPE_P(scope_node->ast_node, PM_FOR_NODE)) {
|
|
|
|
pm_compile_for_node_index(iseq, ((const pm_for_node_t *) scope_node->ast_node)->index, ret, src, scope_node);
|
2023-12-11 18:33:52 +03:00
|
|
|
}
|
2024-01-12 23:23:47 +03:00
|
|
|
|
|
|
|
ADD_TRACE(ret, RUBY_EVENT_B_CALL);
|
|
|
|
PM_NOP;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_LABEL(ret, start);
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2024-01-12 23:23:47 +03:00
|
|
|
if (scope_node->body != NULL) {
|
2023-10-30 23:57:27 +03:00
|
|
|
switch (PM_NODE_TYPE(scope_node->ast_node)) {
|
|
|
|
case PM_POST_EXECUTION_NODE: {
|
|
|
|
pm_post_execution_node_t *post_execution_node = (pm_post_execution_node_t *)scope_node->ast_node;
|
|
|
|
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
|
|
|
|
// We create another ScopeNode from the statements within the PostExecutionNode
|
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t *)post_execution_node->statements, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
const rb_iseq_t *block = NEW_CHILD_ISEQ(&next_scope_node, make_name_for_block(body->parent_iseq), ISEQ_TYPE_BLOCK, lineno);
|
2024-01-19 19:26:28 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
2023-10-30 23:57:27 +03:00
|
|
|
|
|
|
|
ADD_CALL_WITH_BLOCK(ret, &dummy_line_node, id_core_set_postexe, INT2FIX(0), block);
|
|
|
|
break;
|
|
|
|
}
|
2023-11-14 02:52:03 +03:00
|
|
|
case PM_INTERPOLATED_REGULAR_EXPRESSION_NODE: {
|
|
|
|
pm_interpolated_regular_expression_node_t *cast = (pm_interpolated_regular_expression_node_t *) scope_node->ast_node;
|
|
|
|
|
|
|
|
int parts_size = (int)cast->parts.size;
|
|
|
|
if (parts_size > 0 && !PM_NODE_TYPE_P(cast->parts.nodes[0], PM_STRING_NODE)) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_new(0, 0));
|
|
|
|
parts_size++;
|
|
|
|
}
|
|
|
|
|
|
|
|
pm_interpolated_node_compile(&cast->parts, iseq, dummy_line_node, ret, src, false, scope_node, parser);
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, toregexp, INT2FIX(pm_reg_flags((pm_node_t *)cast)), INT2FIX(parts_size));
|
|
|
|
break;
|
2023-10-30 23:57:27 +03:00
|
|
|
}
|
2024-01-12 23:23:47 +03:00
|
|
|
default:
|
|
|
|
pm_compile_node(iseq, scope_node->body, ret, src, popped, scope_node);
|
|
|
|
break;
|
2023-10-20 12:59:02 +03:00
|
|
|
}
|
2024-01-12 23:23:47 +03:00
|
|
|
} else {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-07 17:59:51 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ADD_LABEL(ret, end);
|
|
|
|
ADD_TRACE(ret, RUBY_EVENT_B_RETURN);
|
2023-11-07 16:10:23 +03:00
|
|
|
ISEQ_COMPILE_DATA(iseq)->last_line = body->location.code_location.end_pos.lineno;
|
2023-09-28 16:47:46 +03:00
|
|
|
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
/* wide range catch handler must put at last */
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_REDO, start, end, NULL, start);
|
|
|
|
ADD_CATCH_ENTRY(CATCH_TYPE_NEXT, start, end, NULL, end);
|
|
|
|
break;
|
2024-01-12 23:23:47 +03:00
|
|
|
}
|
|
|
|
case ISEQ_TYPE_ENSURE: {
|
2023-11-03 02:29:20 +03:00
|
|
|
iseq_set_exception_local_table(iseq);
|
2023-11-29 22:12:31 +03:00
|
|
|
|
|
|
|
if (scope_node->body) {
|
|
|
|
PM_COMPILE_POPPED((pm_node_t *)scope_node->body);
|
|
|
|
}
|
2023-11-03 02:29:20 +03:00
|
|
|
|
2023-11-09 01:05:51 +03:00
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, 1, 0);
|
2023-11-03 02:29:20 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, throw, INT2FIX(0));
|
|
|
|
return;
|
2024-01-12 23:23:47 +03:00
|
|
|
}
|
2024-01-22 14:26:04 +03:00
|
|
|
case ISEQ_TYPE_METHOD: {
|
|
|
|
ADD_TRACE(ret, RUBY_EVENT_CALL);
|
|
|
|
if (scope_node->body) {
|
|
|
|
PM_COMPILE((pm_node_t *)scope_node->body);
|
|
|
|
} else {
|
|
|
|
PM_PUTNIL;
|
|
|
|
}
|
|
|
|
ADD_TRACE(ret, RUBY_EVENT_RETURN);
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
2024-01-12 23:23:47 +03:00
|
|
|
case ISEQ_TYPE_RESCUE: {
|
2023-11-10 17:51:14 +03:00
|
|
|
iseq_set_exception_local_table(iseq);
|
2023-12-01 17:37:10 +03:00
|
|
|
if (PM_NODE_TYPE_P(scope_node->ast_node, PM_RESCUE_MODIFIER_NODE)) {
|
|
|
|
LABEL *lab = NEW_LABEL(lineno);
|
|
|
|
LABEL *rescue_end = NEW_LABEL(lineno);
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, LVAR_ERRINFO, 0);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_eStandardError);
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, checkmatch, INT2FIX(VM_CHECKMATCH_TYPE_RESCUE));
|
2024-01-26 20:17:04 +03:00
|
|
|
ADD_INSNL(ret, &dummy_line_node, branchif, lab);
|
|
|
|
ADD_INSNL(ret, &dummy_line_node, jump, rescue_end);
|
2023-12-01 17:37:10 +03:00
|
|
|
ADD_LABEL(ret, lab);
|
|
|
|
PM_COMPILE((pm_node_t *)scope_node->body);
|
|
|
|
ADD_INSN(ret, &dummy_line_node, leave);
|
|
|
|
ADD_LABEL(ret, rescue_end);
|
|
|
|
ADD_GETLOCAL(ret, &dummy_line_node, LVAR_ERRINFO, 0);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
PM_COMPILE((pm_node_t *)scope_node->ast_node);
|
|
|
|
}
|
2023-11-10 17:51:14 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, throw, INT2FIX(0));
|
|
|
|
|
|
|
|
return;
|
2024-01-12 23:23:47 +03:00
|
|
|
}
|
|
|
|
default:
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
if (scope_node->body) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE((pm_node_t *)scope_node->body);
|
2024-01-12 23:23:47 +03:00
|
|
|
} else {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2024-01-12 23:23:47 +03:00
|
|
|
break;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
}
|
2023-09-28 16:47:46 +03:00
|
|
|
|
2023-11-07 00:32:02 +03:00
|
|
|
if (!PM_NODE_TYPE_P(scope_node->ast_node, PM_ENSURE_NODE)) {
|
2024-01-22 19:55:50 +03:00
|
|
|
NODE dummy_line_node = generate_dummy_line_node(ISEQ_COMPILE_DATA(iseq)->last_line, -1);
|
2023-11-03 02:29:20 +03:00
|
|
|
ADD_INSN(ret, &dummy_line_node, leave);
|
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SELF_NODE:
|
2023-09-07 17:59:51 +03:00
|
|
|
if (!popped) {
|
2023-10-30 19:56:30 +03:00
|
|
|
PM_PUTSELF;
|
2023-09-07 17:59:51 +03:00
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SINGLETON_CLASS_NODE: {
|
|
|
|
pm_singleton_class_node_t *singleton_class_node = (pm_singleton_class_node_t *)node;
|
2024-01-18 19:55:31 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init((pm_node_t *)singleton_class_node, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
const rb_iseq_t *singleton_class = NEW_ISEQ(&next_scope_node, rb_fstring_lit("singleton class"), ISEQ_TYPE_CLASS, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-11-02 21:04:09 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(singleton_class_node->expression);
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
ID singletonclass;
|
|
|
|
CONST_ID(singletonclass, "singletonclass");
|
|
|
|
|
|
|
|
ADD_INSN3(ret, &dummy_line_node, defineclass,
|
|
|
|
ID2SYM(singletonclass), singleton_class,
|
|
|
|
INT2FIX(VM_DEFINECLASS_TYPE_SINGLETON_CLASS));
|
2023-11-02 21:04:09 +03:00
|
|
|
PM_POP_IF_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, (VALUE)singleton_class);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SOURCE_ENCODING_NODE: {
|
2023-09-28 22:19:56 +03:00
|
|
|
// Source encoding nodes are generated by the __ENCODING__ syntax. They
|
|
|
|
// reference the encoding object corresponding to the encoding of the
|
|
|
|
// source file, and can be changed by a magic encoding comment.
|
2023-08-31 19:56:13 +03:00
|
|
|
if (!popped) {
|
2023-10-19 23:50:21 +03:00
|
|
|
VALUE value = pm_static_literal_value(node, scope_node, parser);
|
2023-09-28 22:19:56 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, value);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, value);
|
2023-08-31 19:56:13 +03:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SOURCE_FILE_NODE: {
|
2023-09-28 22:19:56 +03:00
|
|
|
// Source file nodes are generated by the __FILE__ syntax. They
|
|
|
|
// reference the file name of the source file.
|
2023-08-31 19:56:13 +03:00
|
|
|
if (!popped) {
|
2023-10-19 23:50:21 +03:00
|
|
|
VALUE value = pm_static_literal_value(node, scope_node, parser);
|
2023-09-28 22:19:56 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putstring, value);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, value);
|
2023-08-31 19:56:13 +03:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SOURCE_LINE_NODE: {
|
2023-09-28 22:19:56 +03:00
|
|
|
// Source line nodes are generated by the __LINE__ syntax. They
|
|
|
|
// reference the line number where they occur in the source file.
|
2023-08-31 19:56:13 +03:00
|
|
|
if (!popped) {
|
2023-10-19 23:50:21 +03:00
|
|
|
VALUE value = pm_static_literal_value(node, scope_node, parser);
|
2023-09-28 22:19:56 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, value);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, value);
|
2023-08-31 19:56:13 +03:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SPLAT_NODE: {
|
|
|
|
pm_splat_node_t *splat_node = (pm_splat_node_t *)node;
|
2023-10-13 20:59:37 +03:00
|
|
|
if (splat_node->expression) {
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(splat_node->expression);
|
2023-10-13 20:59:37 +03:00
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-10-16 15:22:07 +03:00
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, splatarray, Qtrue);
|
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_STATEMENTS_NODE: {
|
|
|
|
pm_statements_node_t *statements_node = (pm_statements_node_t *) node;
|
|
|
|
pm_node_list_t node_list = statements_node->body;
|
2023-09-07 17:59:51 +03:00
|
|
|
if (node_list.size > 0) {
|
2023-10-17 01:36:25 +03:00
|
|
|
for (size_t index = 0; index < node_list.size - 1; index++) {
|
|
|
|
PM_COMPILE_POPPED(node_list.nodes[index]);
|
|
|
|
}
|
2023-11-03 02:29:20 +03:00
|
|
|
PM_COMPILE(node_list.nodes[node_list.size - 1]);
|
2023-09-07 17:59:51 +03:00
|
|
|
}
|
|
|
|
else {
|
2023-10-23 16:46:37 +03:00
|
|
|
PM_PUTNIL;
|
2023-09-07 17:59:51 +03:00
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_STRING_NODE: {
|
2023-08-29 19:27:00 +03:00
|
|
|
if (!popped) {
|
2023-12-06 20:54:16 +03:00
|
|
|
pm_string_node_t *cast = (pm_string_node_t *) node;
|
|
|
|
VALUE value = parse_string_encoded(node, &cast->unescaped, parser);
|
2023-12-14 18:19:31 +03:00
|
|
|
if (node->flags & PM_STRING_FLAGS_FROZEN) {
|
2024-01-09 18:52:23 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, rb_fstring(value));
|
2023-12-14 18:19:31 +03:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putstring, value);
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
2023-10-31 18:19:38 +03:00
|
|
|
case PM_SUPER_NODE: {
|
|
|
|
pm_super_node_t *super_node = (pm_super_node_t *) node;
|
|
|
|
|
|
|
|
DECL_ANCHOR(args);
|
|
|
|
|
|
|
|
int flags = 0;
|
|
|
|
struct rb_callinfo_kwarg *keywords = NULL;
|
|
|
|
const rb_iseq_t *parent_block = ISEQ_COMPILE_DATA(iseq)->current_block;
|
|
|
|
|
|
|
|
INIT_ANCHOR(args);
|
|
|
|
ISEQ_COMPILE_DATA(iseq)->current_block = NULL;
|
|
|
|
|
2023-12-12 19:08:40 +03:00
|
|
|
PM_PUTSELF;
|
2023-10-31 18:19:38 +03:00
|
|
|
|
|
|
|
int argc = pm_setup_args(super_node->arguments, &flags, &keywords, iseq, ret, src, popped, scope_node, dummy_line_node, parser);
|
|
|
|
|
|
|
|
flags |= VM_CALL_SUPER | VM_CALL_FCALL;
|
|
|
|
|
|
|
|
if (super_node->block) {
|
|
|
|
switch (PM_NODE_TYPE(super_node->block)) {
|
|
|
|
case PM_BLOCK_ARGUMENT_NODE: {
|
|
|
|
PM_COMPILE_NOT_POPPED(super_node->block);
|
|
|
|
flags |= VM_CALL_ARGS_BLOCKARG;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case PM_BLOCK_NODE: {
|
|
|
|
pm_scope_node_t next_scope_node;
|
|
|
|
pm_scope_node_init(super_node->block, &next_scope_node, scope_node, parser);
|
2024-01-18 19:38:53 +03:00
|
|
|
parent_block = NEW_CHILD_ISEQ(&next_scope_node, make_name_for_block(iseq), ISEQ_TYPE_BLOCK, lineno);
|
2024-01-18 19:55:31 +03:00
|
|
|
pm_scope_node_destroy(&next_scope_node);
|
2023-10-31 18:19:38 +03:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
default: {
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Unexpected node type on a SuperNode's block: %s", pm_node_type_to_str(PM_NODE_TYPE(super_node->block)));
|
2023-10-31 18:19:38 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ADD_SEQ(ret, args);
|
|
|
|
ADD_INSN2(ret, &dummy_line_node, invokesuper,
|
|
|
|
new_callinfo(iseq, 0, argc, flags, keywords, parent_block != NULL),
|
|
|
|
parent_block);
|
|
|
|
|
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_SYMBOL_NODE: {
|
2023-09-28 22:19:56 +03:00
|
|
|
// Symbols nodes are symbol literals with no interpolation. They are
|
|
|
|
// always marked as static literals.
|
2023-09-07 17:59:51 +03:00
|
|
|
if (!popped) {
|
2023-10-19 23:50:21 +03:00
|
|
|
VALUE value = pm_static_literal_value(node, scope_node, parser);
|
2023-09-28 22:19:56 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, value);
|
|
|
|
RB_OBJ_WRITTEN(iseq, Qundef, value);
|
2023-09-07 17:59:51 +03:00
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_TRUE_NODE:
|
2023-08-29 19:27:00 +03:00
|
|
|
if (!popped) {
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, Qtrue);
|
|
|
|
}
|
|
|
|
return;
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_UNDEF_NODE: {
|
|
|
|
pm_undef_node_t *undef_node = (pm_undef_node_t *) node;
|
2023-08-29 19:27:00 +03:00
|
|
|
|
|
|
|
for (size_t index = 0; index < undef_node->names.size; index++) {
|
2023-09-07 17:59:51 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE));
|
|
|
|
ADD_INSN1(ret, &dummy_line_node, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_CBASE));
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-10-13 20:59:37 +03:00
|
|
|
PM_COMPILE_NOT_POPPED(undef_node->names.nodes[index]);
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-09-22 18:43:00 +03:00
|
|
|
ADD_SEND(ret, &dummy_line_node, id_core_undef_method, INT2NUM(2));
|
2023-08-29 19:27:00 +03:00
|
|
|
|
2023-10-24 23:08:50 +03:00
|
|
|
if (index < undef_node->names.size - 1) {
|
|
|
|
PM_POP;
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
}
|
|
|
|
|
2023-10-13 20:59:37 +03:00
|
|
|
PM_POP_IF_POPPED;
|
|
|
|
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_UNLESS_NODE: {
|
|
|
|
const int line = (int)pm_newline_list_line_column(&(parser->newline_list), node->location.start).line;
|
|
|
|
pm_unless_node_t *unless_node = (pm_unless_node_t *)node;
|
2023-10-20 18:03:02 +03:00
|
|
|
pm_node_t *node_body = (pm_node_t *)(unless_node->statements);
|
|
|
|
pm_statements_node_t *node_else = NULL;
|
|
|
|
if (unless_node->consequent != NULL) {
|
|
|
|
node_else = ((pm_else_node_t *)unless_node->consequent)->statements;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
pm_node_t *predicate = unless_node->predicate;
|
2023-08-30 00:17:08 +03:00
|
|
|
|
2023-10-20 18:03:02 +03:00
|
|
|
pm_compile_if(iseq, line, node_else, node_body, predicate, ret, src, popped, scope_node);
|
2023-08-30 00:17:08 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_UNTIL_NODE: {
|
|
|
|
pm_until_node_t *until_node = (pm_until_node_t *)node;
|
|
|
|
pm_statements_node_t *statements = until_node->statements;
|
|
|
|
pm_node_t *predicate = until_node->predicate;
|
|
|
|
pm_node_flags_t flags = node->flags;
|
2023-08-30 00:17:08 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_while(iseq, lineno, flags, node->type, statements, predicate, ret, src, popped, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-10-24 21:24:36 +03:00
|
|
|
case PM_WHEN_NODE: {
|
2024-01-02 19:34:04 +03:00
|
|
|
rb_bug("Cannot compile a WhenNode directly\n");
|
2023-10-24 21:24:36 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_WHILE_NODE: {
|
|
|
|
pm_while_node_t *while_node = (pm_while_node_t *)node;
|
|
|
|
pm_statements_node_t *statements = while_node->statements;
|
|
|
|
pm_node_t *predicate = while_node->predicate;
|
|
|
|
pm_node_flags_t flags = node->flags;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-10-17 01:36:25 +03:00
|
|
|
pm_compile_while(iseq, lineno, flags, node->type, statements, predicate, ret, src, popped, scope_node);
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_X_STRING_NODE: {
|
2023-12-06 20:54:16 +03:00
|
|
|
pm_x_string_node_t *cast = (pm_x_string_node_t *) node;
|
|
|
|
VALUE value = parse_string_encoded(node, &cast->unescaped, parser);
|
|
|
|
|
2023-10-30 19:56:30 +03:00
|
|
|
PM_PUTSELF;
|
2023-12-06 20:54:16 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, putobject, value);
|
2023-09-22 18:43:00 +03:00
|
|
|
ADD_SEND_WITH_FLAG(ret, &dummy_line_node, idBackquote, INT2NUM(1), INT2FIX(VM_CALL_FCALL | VM_CALL_ARGS_SIMPLE));
|
2023-09-21 22:28:08 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-09-27 19:39:53 +03:00
|
|
|
case PM_YIELD_NODE: {
|
2023-11-07 16:10:23 +03:00
|
|
|
pm_yield_node_t *yield_node = (pm_yield_node_t *)node;
|
|
|
|
|
2023-11-27 23:55:15 +03:00
|
|
|
int flags = 0;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
struct rb_callinfo_kwarg *keywords = NULL;
|
|
|
|
|
2023-11-07 16:10:23 +03:00
|
|
|
int argc = 0;
|
|
|
|
|
|
|
|
if (yield_node->arguments) {
|
2023-11-27 23:55:15 +03:00
|
|
|
argc = pm_setup_args(yield_node->arguments, &flags, &keywords, iseq, ret, src, popped, scope_node, dummy_line_node, parser);
|
2023-11-07 16:10:23 +03:00
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-11-27 23:55:15 +03:00
|
|
|
ADD_INSN1(ret, &dummy_line_node, invokeblock, new_callinfo(iseq, 0, argc, flags, keywords, FALSE));
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
2023-09-27 19:39:53 +03:00
|
|
|
PM_POP_IF_POPPED;
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
int level = 0;
|
|
|
|
const rb_iseq_t *tmp_iseq = iseq;
|
|
|
|
for (; tmp_iseq != ISEQ_BODY(iseq)->local_iseq; level++ ) {
|
|
|
|
tmp_iseq = ISEQ_BODY(tmp_iseq)->parent_iseq;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (level > 0) access_outer_variables(iseq, level, rb_intern("yield"), true);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
2023-08-29 19:27:00 +03:00
|
|
|
default:
|
2023-09-27 19:39:53 +03:00
|
|
|
rb_raise(rb_eNotImpError, "node type %s not implemented", pm_node_type_to_str(PM_NODE_TYPE(node)));
|
2023-08-29 19:27:00 +03:00
|
|
|
return;
|
|
|
|
}
|
2023-08-28 23:55:58 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static VALUE
|
2023-10-30 16:49:17 +03:00
|
|
|
rb_translate_prism(pm_parser_t *parser, rb_iseq_t *iseq, pm_scope_node_t *scope_node, LINK_ANCHOR *const ret)
|
2023-08-28 23:55:58 +03:00
|
|
|
{
|
|
|
|
RUBY_ASSERT(ISEQ_COMPILE_DATA(iseq));
|
|
|
|
|
2023-10-30 16:49:17 +03:00
|
|
|
st_table *index_lookup_table = st_init_numtable();
|
|
|
|
pm_constant_id_list_t *locals = &scope_node->locals;
|
|
|
|
for (size_t i = 0; i < locals->size; i++) {
|
|
|
|
st_insert(index_lookup_table, locals->ids[i], i);
|
|
|
|
}
|
2024-01-18 19:55:31 +03:00
|
|
|
|
|
|
|
if (scope_node->index_lookup_table) {
|
|
|
|
st_free_table(scope_node->index_lookup_table);
|
|
|
|
}
|
2023-10-30 16:49:17 +03:00
|
|
|
scope_node->index_lookup_table = index_lookup_table;
|
|
|
|
|
2023-10-19 00:53:02 +03:00
|
|
|
pm_compile_node(iseq, (pm_node_t *)scope_node, ret, scope_node->base.location.start, false, (pm_scope_node_t *)scope_node);
|
2023-10-30 16:49:17 +03:00
|
|
|
|
2023-08-28 23:55:58 +03:00
|
|
|
return Qnil;
|
|
|
|
}
|
Compile more YARP node types (#8322)
* Add several more node simple types to YARP's compiler:
Nodes include: DefinedNode, EmbeddedStatementsNode,
LocalVariableReadNode, LocalVariableWriteNode, MultiWriteNode,
OptionalParameterNode, SplatNode, YieldNode
* Add AssocSplatNode, RangeNode
* Add RangeNode, other helpers for future nodes
* Add ArrayNode, HashNode, static literal helpers
* Add branch conditionals
* Add IfNode, UnlessNode
* Add ScopeNode
* NEW_ISEQ and NEW_CHILD_ISEQ implemented for YARP
* Add nodes that depend on ScopeNode
* Addressed PR comments
2023-08-29 23:13:15 +03:00
|
|
|
|
|
|
|
#undef NEW_ISEQ
|
|
|
|
#define NEW_ISEQ OLD_ISEQ
|
|
|
|
|
|
|
|
#undef NEW_CHILD_ISEQ
|
|
|
|
#define NEW_CHILD_ISEQ OLD_CHILD_ISEQ
|