* win32/win32.c (dupfd): argument of _osfhnd and so on should not

have side effect.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

ChangeLog

@@ -1,3 +1,8 @@
+Tue Nov 22 11:33:58 2011  Nobuyoshi Nakada  <nobu@ruby-lang.org>
+
+	* win32/win32.c (dupfd): argument of _osfhnd and so on should not
+	  have side effect.
+
 Tue Nov 22 11:26:08 2011  NARUSE, Yui  <naruse@ruby-lang.org>
 
 	* bignum.c (): refix of r33536. Don't change behavior of Bignum#/.

win32/win32.c

@@ -3818,8 +3818,9 @@ dupfd(HANDLE hDup, char flags, int minfd)
   close_fds_and_return:
     save_errno = errno;
     while (filled > 0) {
-	_osfhnd(fds[--filled]) = (intptr_t)INVALID_HANDLE_VALUE;
-	close(fds[filled]);
+	int fd = fds[--filled];
+	_osfhnd(fd) = (intptr_t)INVALID_HANDLE_VALUE;
+	close(fd);
     }
     errno = save_errno;