From 1a4bb80cd79dcae1b2be418e70e1f5a5bcd36887 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Fri, 24 May 2019 20:32:45 +0200 Subject: [PATCH] [bundler/bundler] Skip specs that need coloring on Windows ANSI codes don't work there. https://github.com/bundler/bundler/commit/4f05417ca7 --- spec/bundler/bundler/source_spec.rb | 6 +++--- spec/bundler/spec_helper.rb | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/spec/bundler/bundler/source_spec.rb b/spec/bundler/bundler/source_spec.rb index 00eb05ed88..9ae6b3e3eb 100644 --- a/spec/bundler/bundler/source_spec.rb +++ b/spec/bundler/bundler/source_spec.rb @@ -56,7 +56,7 @@ RSpec.describe Bundler::Source do context "with a different version" do let(:locked_gem) { double(:locked_gem, :name => "nokogiri", :version => "< 1.5") } - context "with color" do + context "with color", :non_windows do before { Bundler.ui = Bundler::UI::Shell.new } it "should return a string with the spec name and version and locked spec version" do @@ -77,7 +77,7 @@ RSpec.describe Bundler::Source do let(:spec) { double(:spec, :name => "nokogiri", :version => "1.6.1", :platform => rb) } let(:locked_gem) { double(:locked_gem, :name => "nokogiri", :version => "1.7.0") } - context "with color" do + context "with color", :non_windows do before { Bundler.ui = Bundler::UI::Shell.new } it "should return a string with the locked spec version in yellow" do @@ -98,7 +98,7 @@ RSpec.describe Bundler::Source do let(:spec) { double(:spec, :name => "nokogiri", :version => "1.7.1", :platform => rb) } let(:locked_gem) { double(:locked_gem, :name => "nokogiri", :version => "1.7.0") } - context "with color" do + context "with color", :non_windows do before { Bundler.ui = Bundler::UI::Shell.new } it "should return a string with the locked spec version in green" do diff --git a/spec/bundler/spec_helper.rb b/spec/bundler/spec_helper.rb index d3de1ff784..444f3a3cf3 100644 --- a/spec/bundler/spec_helper.rb +++ b/spec/bundler/spec_helper.rb @@ -74,6 +74,7 @@ RSpec.configure do |config| config.filter_run_excluding :rubygems_master => (ENV["RGV"] != "master") config.filter_run_excluding :bundler => RequirementChecker.against(Bundler::VERSION.split(".")[0]) config.filter_run_excluding :ruby_repo => !(ENV["BUNDLE_RUBY"] && ENV["BUNDLE_GEM"]).nil? + config.filter_run_excluding :non_windows => Gem.win_platform? config.filter_run_when_matching :focus unless ENV["CI"]