зеркало из https://github.com/github/ruby.git
thread_sync.c (rb_mutex_lock): acquire lock before being killed
We (the thread acquiring the mutex) need to acquire the mutex
before being killed to work with ConditionVariable#wait.
Thus we reinstate the acquire-immediately-after-sleeping logic
from pre-r63711 while still retaining the
acquire-after-checking-for-interrupts logic from r63711.
This regression was introduced in
commit 501069b8a4
(r63711)
("thread_sync.c (rb_mutex_lock): fix deadlock") for
[Bug #14841]
[ruby-core:88503] [Bug #14999] [Bug #14841]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64398 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
Родитель
4bf11e21f9
Коммит
2cf3bd5bb2
|
@ -272,17 +272,23 @@ rb_mutex_lock(VALUE self)
|
|||
list_add_tail(&mutex->waitq, &w.node);
|
||||
native_sleep(th, timeout); /* release GVL */
|
||||
list_del(&w.node);
|
||||
|
||||
if (!mutex->th) {
|
||||
mutex->th = th;
|
||||
}
|
||||
|
||||
if (patrol_thread == th)
|
||||
patrol_thread = NULL;
|
||||
|
||||
th->locking_mutex = Qfalse;
|
||||
if (timeout && !RUBY_VM_INTERRUPTED(th->ec)) {
|
||||
if (mutex->th && timeout && !RUBY_VM_INTERRUPTED(th->ec)) {
|
||||
rb_check_deadlock(th->vm);
|
||||
}
|
||||
if (th->status == THREAD_STOPPED_FOREVER) {
|
||||
th->status = prev_status;
|
||||
}
|
||||
th->vm->sleeper--;
|
||||
if (mutex->th == th) mutex_locked(th, self);
|
||||
|
||||
RUBY_VM_CHECK_INTS_BLOCKING(th->ec); /* may release mutex */
|
||||
if (!mutex->th) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче