зеркало из https://github.com/github/ruby.git
vm_method.c: fix visibility on anonymous module
* vm_method.c (rb_mod_public_method): fix visibility on anonymous module. set visibility of singleton method, not method in base class. [ruby-core:54404] [Bug #8284] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
Родитель
a4188556d3
Коммит
335dfa1255
|
@ -1,3 +1,9 @@
|
|||
Thu Apr 18 16:58:51 2013 Nobuyoshi Nakada <nobu@ruby-lang.org>
|
||||
|
||||
* vm_method.c (rb_mod_public_method): fix visibility on anonymous
|
||||
module. set visibility of singleton method, not method in base
|
||||
class. [ruby-core:54404] [Bug #8284]
|
||||
|
||||
Thu Apr 18 16:20:51 2013 Nobuyoshi Nakada <nobu@ruby-lang.org>
|
||||
|
||||
* dir.c (glob_helper): should skip dot directories only for recursion,
|
||||
|
|
|
@ -1721,6 +1721,13 @@ class TestModule < Test::Unit::TestCase
|
|||
assert_equal [mod, obj.singleton_class, Object], obj.singleton_class.ancestors.first(3)
|
||||
end
|
||||
|
||||
def test_anonymous_module_public_class_method
|
||||
bug8284 = '[ruby-core:54404] [Bug #8284]'
|
||||
assert_raise(NoMethodError) {Object.define_method}
|
||||
Module.new.public_class_method(:define_method)
|
||||
assert_raise(NoMethodError, bug8284) {Object.define_method}
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def assert_top_method_is_private(method)
|
||||
|
|
|
@ -1374,7 +1374,7 @@ rb_mod_private(int argc, VALUE *argv, VALUE module)
|
|||
static VALUE
|
||||
rb_mod_public_method(int argc, VALUE *argv, VALUE obj)
|
||||
{
|
||||
set_method_visibility(CLASS_OF(obj), argc, argv, NOEX_PUBLIC);
|
||||
set_method_visibility(rb_singleton_class(obj), argc, argv, NOEX_PUBLIC);
|
||||
return obj;
|
||||
}
|
||||
|
||||
|
@ -1400,7 +1400,7 @@ rb_mod_public_method(int argc, VALUE *argv, VALUE obj)
|
|||
static VALUE
|
||||
rb_mod_private_method(int argc, VALUE *argv, VALUE obj)
|
||||
{
|
||||
set_method_visibility(CLASS_OF(obj), argc, argv, NOEX_PRIVATE);
|
||||
set_method_visibility(rb_singleton_class(obj), argc, argv, NOEX_PRIVATE);
|
||||
return obj;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче