* io.c (io_fwrite): allocate frozen str only when str is not converted.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44471 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
glass 2013-12-31 12:25:16 +00:00
Родитель 5d26de2694
Коммит 4e4e65a148
2 изменённых файлов: 10 добавлений и 4 удалений

Просмотреть файл

@ -1,3 +1,7 @@
Tue Dec 31 21:02:27 2013 Masaki Matsushita <glass.saga@gmail.com>
* io.c (io_fwrite): allocate frozen str only when str is not converted.
Tue Dec 31 15:44:48 2013 Nobuyoshi Nakada <nobu@ruby-lang.org> Tue Dec 31 15:44:48 2013 Nobuyoshi Nakada <nobu@ruby-lang.org>
* lib/mkmf.rb (RbConfig): expand RUBY_SO_NAME for extensions * lib/mkmf.rb (RbConfig): expand RUBY_SO_NAME for extensions

10
io.c
Просмотреть файл

@ -1291,7 +1291,7 @@ io_binwrite(VALUE str, const char *ptr, long len, rb_io_t *fptr, int nosync)
# define MODE_BTMODE(a,b,c) ((fmode & FMODE_BINMODE) ? (b) : \ # define MODE_BTMODE(a,b,c) ((fmode & FMODE_BINMODE) ? (b) : \
(fmode & FMODE_TEXTMODE) ? (c) : (a)) (fmode & FMODE_TEXTMODE) ? (c) : (a))
static VALUE static VALUE
do_writeconv(VALUE str, rb_io_t *fptr) do_writeconv(VALUE str, rb_io_t *fptr, int *converted)
{ {
if (NEED_WRITECONV(fptr)) { if (NEED_WRITECONV(fptr)) {
VALUE common_encoding = Qnil; VALUE common_encoding = Qnil;
@ -1319,10 +1319,12 @@ do_writeconv(VALUE str, rb_io_t *fptr)
if (!NIL_P(common_encoding)) { if (!NIL_P(common_encoding)) {
str = rb_str_encode(str, common_encoding, str = rb_str_encode(str, common_encoding,
fptr->writeconv_pre_ecflags, fptr->writeconv_pre_ecopts); fptr->writeconv_pre_ecflags, fptr->writeconv_pre_ecopts);
*converted = 1;
} }
if (fptr->writeconv) { if (fptr->writeconv) {
str = rb_econv_str_convert(fptr->writeconv, str, ECONV_PARTIAL_INPUT); str = rb_econv_str_convert(fptr->writeconv, str, ECONV_PARTIAL_INPUT);
*converted = 1;
} }
} }
#if defined(RUBY_TEST_CRLF_ENVIRONMENT) || defined(_WIN32) #if defined(RUBY_TEST_CRLF_ENVIRONMENT) || defined(_WIN32)
@ -1348,13 +1350,15 @@ do_writeconv(VALUE str, rb_io_t *fptr)
static long static long
io_fwrite(VALUE str, rb_io_t *fptr, int nosync) io_fwrite(VALUE str, rb_io_t *fptr, int nosync)
{ {
int converted = 0;
#ifdef _WIN32 #ifdef _WIN32
if (fptr->mode & FMODE_TTY) { if (fptr->mode & FMODE_TTY) {
long len = rb_w32_write_console(str, fptr->fd); long len = rb_w32_write_console(str, fptr->fd);
if (len > 0) return len; if (len > 0) return len;
} }
#endif #endif
str = do_writeconv(str, fptr); str = do_writeconv(str, fptr, &converted);
if (!converted) str = rb_str_new_frozen(str);
return io_binwrite(str, RSTRING_PTR(str), RSTRING_LEN(str), return io_binwrite(str, RSTRING_PTR(str), RSTRING_LEN(str),
fptr, nosync); fptr, nosync);
} }
@ -1386,8 +1390,6 @@ io_write(VALUE io, VALUE str, int nosync)
io = tmp; io = tmp;
if (RSTRING_LEN(str) == 0) return INT2FIX(0); if (RSTRING_LEN(str) == 0) return INT2FIX(0);
str = rb_str_new_frozen(str);
GetOpenFile(io, fptr); GetOpenFile(io, fptr);
rb_io_check_writable(fptr); rb_io_check_writable(fptr);