* gc.c (vm_malloc_increase): do gc_rest_sweep() before GC.

gc_rest_sweep() can reduce malloc_increase, so try it before GC.
  Otherwise, malloc_increase can be less than malloc_limit at
  gc_before_sweep(). This means that re-calculation of malloc_limit
  may be wrong value.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43424 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
ko1 2013-10-26 02:34:23 +00:00
Родитель 59735e2c61
Коммит 6c458aec30
2 изменённых файлов: 19 добавлений и 1 удалений

Просмотреть файл

@ -1,3 +1,11 @@
Sat Oct 26 11:30:07 2013 Koichi Sasada <ko1@atdot.net>
* gc.c (vm_malloc_increase): do gc_rest_sweep() before GC.
gc_rest_sweep() can reduce malloc_increase, so try it before GC.
Otherwise, malloc_increase can be less than malloc_limit at
gc_before_sweep(). This means that re-calculation of malloc_limit
may be wrong value.
Sat Oct 26 06:35:41 2013 Masaya Tarui <tarui@ruby-lang.org> Sat Oct 26 06:35:41 2013 Masaya Tarui <tarui@ruby-lang.org>
* gc.c (gc_before_heap_sweep): Restructure code to mean clearly. * gc.c (gc_before_heap_sweep): Restructure code to mean clearly.

12
gc.c
Просмотреть файл

@ -5033,9 +5033,19 @@ vm_malloc_increase(rb_objspace_t *objspace, size_t new_size, size_t old_size, in
} }
if (do_gc) { if (do_gc) {
if ((ruby_gc_stress && !ruby_disable_gc_stress) || (malloc_increase > malloc_limit)) { if (ruby_gc_stress && !ruby_disable_gc_stress) {
garbage_collect_with_gvl(objspace, 0, 0, GPR_FLAG_MALLOC); garbage_collect_with_gvl(objspace, 0, 0, GPR_FLAG_MALLOC);
} }
else {
retry:
if (malloc_increase > malloc_limit) {
if (is_lazy_sweeping(heap_eden)) {
gc_rest_sweep(objspace); /* rest_sweep can reduce malloc_increase */
goto retry;
}
garbage_collect_with_gvl(objspace, 0, 0, GPR_FLAG_MALLOC);
}
}
} }
} }