diff --git a/ChangeLog b/ChangeLog index 6796325e86..5a6df2cc04 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Mon Dec 22 13:40:19 2003 NAKAMURA, Hiroshi + + * lib/soap/property.rb: passing block by reference. + Mon Dec 22 00:32:43 2003 Yukihiro Matsumoto * ext/syck/emitter.c (syck_emitter_write): str bigger than diff --git a/lib/soap/property.rb b/lib/soap/property.rb index e0516aa419..079c294a77 100644 --- a/lib/soap/property.rb +++ b/lib/soap/property.rb @@ -35,15 +35,11 @@ class Property include Enumerable def self.load(stream) - prop = new - prop.load(stream) - prop + new.load(stream) end def self.open(filename) - File.open(filename) do |f| - load(f) - end + File.open(filename) { |f| load(f) } end # find property from $:. @@ -117,9 +113,9 @@ class Property # hook: block which will be called with 2 args, name and value def add_hook(name = nil, &hook) if name.nil? - assign_self_hook(hook) + assign_self_hook(&hook) else - assign_hook(name_to_a(name), hook) + assign_hook(name_to_a(name), &hook) end end @@ -200,7 +196,7 @@ protected @self_hook + (@hook[key] || NO_HOOK) end - def local_assign_hook(key, hook) + def local_assign_hook(key, &hook) check_lock(key) @store[key] ||= nil (@hook[key] ||= []) << hook @@ -229,13 +225,13 @@ private hook + ref.local_hook(last_key) end - def assign_hook(ary, hook) + def assign_hook(ary, &hook) ary[0..-2].inject(self) { |ref, name| ref.deref_key(to_key(name)) - }.local_assign_hook(to_key(ary.last), hook) + }.local_assign_hook(to_key(ary.last), &hook) end - def assign_self_hook(hook) + def assign_self_hook(&hook) check_lock(nil) @self_hook << hook end