[rubygems/rubygems] Only validate resolution info in Bundler

This commit switches out the full gemspec validation for a partial one
which only performs resolution related checks. This will allow gem
authors to run `bundle` commands immediately after creating a new gem
with Bundler, rather than having to fix metadata validation issues in
the default gemspec.

https://github.com/rubygems/rubygems/commit/d5aa9cae9d
This commit is contained in:
Thomas Marshall 2024-05-31 20:45:41 +01:00 коммит произвёл git
Родитель 39951293b4
Коммит b88ac94eec
3 изменённых файлов: 6 добавлений и 5 удалений

Просмотреть файл

@ -52,7 +52,7 @@ module Bundler
end
def validate(spec)
Bundler.ui.silence { spec.validate(false) }
Bundler.ui.silence { spec.validate_for_resolution }
rescue Gem::InvalidSpecificationException => e
error_message = "The gemspec at #{spec.loaded_from} is not valid. Please fix this gemspec.\n" \
"The validation error was '#{e.message}'\n"

Просмотреть файл

@ -11,14 +11,14 @@ RSpec.describe Bundler::RubygemsIntegration do
end
subject { Bundler.rubygems.validate(spec) }
it "validates with packaging mode disabled" do
expect(spec).to receive(:validate).with(false)
it "validates for resolution" do
expect(spec).to receive(:validate_for_resolution)
subject
end
context "with an invalid spec" do
before do
expect(spec).to receive(:validate).with(false).
expect(spec).to receive(:validate_for_resolution).
and_raise(Gem::InvalidSpecificationException.new("TODO is not an author"))
end

Просмотреть файл

@ -674,6 +674,7 @@ RSpec.describe "bundle exec" do
s.version = '1.0'
s.summary = 'TODO: Add summary'
s.authors = 'Me'
s.rubygems_version = nil
end
G
end
@ -686,7 +687,7 @@ RSpec.describe "bundle exec" do
bundle "exec irb", raise_on_error: false
expect(err).to match("The gemspec at #{lib_path("foo-1.0").join("foo.gemspec")} is not valid")
expect(err).to match('"TODO" is not a summary')
expect(err).to match(/missing value for attribute rubygems_version|rubygems_version must not be nil/)
end
end