From d5b5a7ab31099a14b5933696991dfc55c37005cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Wed, 8 Jul 2020 18:38:01 +0200 Subject: [PATCH] [rubygems/rubygems] Remove very old TODO note It was added 10 years ago on a "146 additions, 170 deletions" commit named "Deprecation removals and minor cleanup." that didn't explain much other than that. This TODO doesn't necessarily apply nowadays. I don't see how anyways. TODO notes, if useful at all, should include a clear explanation of what should be done either via the note itself or the commit message. This note doens't meet any of these. So I want to remove it because it distracts me every time I go through it. https://github.com/rubygems/rubygems/commit/58d81e8a32 --- lib/rubygems/specification.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb index ddcd0aa327..a2b982cd74 100644 --- a/lib/rubygems/specification.rb +++ b/lib/rubygems/specification.rb @@ -1006,7 +1006,6 @@ class Gem::Specification < Gem::BasicSpecification # Return currently unresolved specs that contain the file matching +path+. def self.find_in_unresolved(path) - # TODO: do we need these?? Kill it specs = unresolved_deps.values.map {|dep| dep.to_specs }.flatten specs.find_all {|spec| spec.contains_requirable_file? path }