From dc8d595461308a79c406cb16e6abb763b589bd3a Mon Sep 17 00:00:00 2001 From: nobu Date: Fri, 13 Mar 2015 02:37:49 +0000 Subject: [PATCH] libff: fix enable-shared condition * ext/fiddle/extconf.rb: needs --enable-shared when linked to libruby or fiddle.so. since --with-static-linked-ext does no longer link extensions to ruby program with --enable-shared, the only combination needs --enable-static is --disable-shared and --with-static-linked-ext. [ruby-dev:48901] [Bug #10960] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 8 ++++++++ ext/fiddle/extconf.rb | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6450be1d31..214a5690a8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +Fri Mar 13 11:37:46 2015 Nobuyoshi Nakada + + * ext/fiddle/extconf.rb: needs --enable-shared when linked to + libruby or fiddle.so. since --with-static-linked-ext does no + longer link extensions to ruby program with --enable-shared, the + only combination needs --enable-static is --disable-shared and + --with-static-linked-ext. [ruby-dev:48901] [Bug #10960] + Fri Mar 13 07:02:20 2015 Eric Wong * ext/socket/init.c (rsock_s_accept_nonblock): use rb_hash_lookup2 diff --git a/ext/fiddle/extconf.rb b/ext/fiddle/extconf.rb index 37bbfdc247..f13e4144b6 100644 --- a/ext/fiddle/extconf.rb +++ b/ext/fiddle/extconf.rb @@ -72,7 +72,7 @@ begin --host=#{libffi.arch} --enable-builddir=#{RUBY_PLATFORM} ] - args << ($enable_shared && !$static ? '--enable-shared' : '--enable-static') + args << ($enable_shared || !$static ? '--enable-shared' : '--enable-static') args << libffi.opt if libffi.opt args.concat %W[ CC=#{cc} CFLAGS=#{libffi.cflags}