зеркало из https://github.com/github/ruby.git
vm_method.c: method defined should not use refinements.
* vm_method.c (check_definition): Module#public_method_defined?, Module#private_method_defined?, Module#protected_method_defined? should not use refinements. [ruby-core:67656] [Bug #10753] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49322 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
Родитель
6d2e8b0546
Коммит
dd1baaabcd
|
@ -1,3 +1,9 @@
|
|||
Sun Jan 18 15:57:32 2015 Seiei Higa <hanachin@gmail.com>
|
||||
|
||||
* vm_method.c (check_definition): Module#public_method_defined?,
|
||||
Module#private_method_defined?, Module#protected_method_defined?
|
||||
should not use refinements. [ruby-core:67656] [Bug #10753]
|
||||
|
||||
Sun Jan 18 15:50:39 2015 Nobuyoshi Nakada <nobu@ruby-lang.org>
|
||||
|
||||
* vm_dump.c (rb_vm_bugreport): check by configured result instead
|
||||
|
|
|
@ -1235,6 +1235,81 @@ class TestRefinement < Test::Unit::TestCase
|
|||
end;
|
||||
end
|
||||
|
||||
def test_refined_method_defined
|
||||
assert_separately([], <<-"end;")
|
||||
bug10753 = '[ruby-core:67656] [Bug #10753]'
|
||||
|
||||
c = Class.new do
|
||||
def refined_public; end
|
||||
def refined_protected; end
|
||||
def refined_private; end
|
||||
|
||||
public :refined_public
|
||||
protected :refined_protected
|
||||
private :refined_private
|
||||
end
|
||||
|
||||
m = Module.new do
|
||||
refine(c) do
|
||||
def refined_public; end
|
||||
def refined_protected; end
|
||||
def refined_private; end
|
||||
|
||||
public :refined_public
|
||||
protected :refined_protected
|
||||
private :refined_private
|
||||
end
|
||||
end
|
||||
|
||||
using m
|
||||
|
||||
assert_equal(true, c.public_method_defined?(:refined_public), bug10753)
|
||||
assert_equal(false, c.public_method_defined?(:refined_protected), bug10753)
|
||||
assert_equal(false, c.public_method_defined?(:refined_private), bug10753)
|
||||
|
||||
assert_equal(false, c.protected_method_defined?(:refined_public), bug10753)
|
||||
assert_equal(true, c.protected_method_defined?(:refined_protected), bug10753)
|
||||
assert_equal(false, c.protected_method_defined?(:refined_private), bug10753)
|
||||
|
||||
assert_equal(false, c.private_method_defined?(:refined_public), bug10753)
|
||||
assert_equal(false, c.private_method_defined?(:refined_protected), bug10753)
|
||||
assert_equal(true, c.private_method_defined?(:refined_private), bug10753)
|
||||
end;
|
||||
end
|
||||
|
||||
def test_undefined_refined_method_defined
|
||||
assert_separately([], <<-"end;")
|
||||
bug10753 = '[ruby-core:67656] [Bug #10753]'
|
||||
|
||||
c = Class.new
|
||||
|
||||
m = Module.new do
|
||||
refine(c) do
|
||||
def undefined_refined_public; end
|
||||
def undefined_refined_protected; end
|
||||
def undefined_refined_private; end
|
||||
public :undefined_refined_public
|
||||
protected :undefined_refined_protected
|
||||
private :undefined_refined_private
|
||||
end
|
||||
end
|
||||
|
||||
using m
|
||||
|
||||
assert_equal(false, c.public_method_defined?(:undefined_refined_public), bug10753)
|
||||
assert_equal(false, c.public_method_defined?(:undefined_refined_protected), bug10753)
|
||||
assert_equal(false, c.public_method_defined?(:undefined_refined_private), bug10753)
|
||||
|
||||
assert_equal(false, c.protected_method_defined?(:undefined_refined_public), bug10753)
|
||||
assert_equal(false, c.protected_method_defined?(:undefined_refined_protected), bug10753)
|
||||
assert_equal(false, c.protected_method_defined?(:undefined_refined_private), bug10753)
|
||||
|
||||
assert_equal(false, c.private_method_defined?(:undefined_refined_public), bug10753)
|
||||
assert_equal(false, c.private_method_defined?(:undefined_refined_protected), bug10753)
|
||||
assert_equal(false, c.private_method_defined?(:undefined_refined_private), bug10753)
|
||||
end;
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def eval_using(mod, s)
|
||||
|
|
|
@ -1061,7 +1061,7 @@ check_definition(VALUE mod, VALUE mid, rb_method_flag_t noex)
|
|||
const rb_method_entry_t *me;
|
||||
ID id = rb_check_id(&mid);
|
||||
if (!id) return Qfalse;
|
||||
me = rb_method_entry(mod, id, 0);
|
||||
me = rb_method_entry_without_refinements(mod, id, 0);
|
||||
if (me) {
|
||||
if (VISI_CHECK(me->flag, noex))
|
||||
return Qtrue;
|
||||
|
|
Загрузка…
Ссылка в новой задаче