From e6202c41b5685ef0a6551e008c567230ec85d2bf Mon Sep 17 00:00:00 2001 From: k0kubun Date: Sun, 21 Oct 2018 15:54:50 +0000 Subject: [PATCH] try to remove some test skips for MJIT Eric Wong made some effort to keep compatibility around fd with MJIT. Also I'm hoping r65279 (and r65280) eliminates major MJIT bugs, so I want to start solely testing MJIT. Other test skips branched by MJIT enablement seemed reasonable to me. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- test/-ext-/thread_fd_close/test_thread_fd_close.rb | 2 -- test/ruby/test_autoload.rb | 1 - test/ruby/test_string.rb | 4 ---- test/rubygems/test_gem_util.rb | 1 - 4 files changed, 8 deletions(-) diff --git a/test/-ext-/thread_fd_close/test_thread_fd_close.rb b/test/-ext-/thread_fd_close/test_thread_fd_close.rb index 90993cf63d..e6c3895da7 100644 --- a/test/-ext-/thread_fd_close/test_thread_fd_close.rb +++ b/test/-ext-/thread_fd_close/test_thread_fd_close.rb @@ -6,8 +6,6 @@ require 'io/wait' class TestThreadFdClose < Test::Unit::TestCase def test_thread_fd_close - skip "MJIT thread is unexpected for this" if RubyVM::MJIT.enabled? - IO.pipe do |r, w| th = Thread.new do begin diff --git a/test/ruby/test_autoload.rb b/test/ruby/test_autoload.rb index 58757dbaa6..8311c40c35 100644 --- a/test/ruby/test_autoload.rb +++ b/test/ruby/test_autoload.rb @@ -336,7 +336,6 @@ p Foo::Bar end def test_no_leak - skip "This sometimes fails with -DMJIT_FORCE_ENABLE. To be investigated." if RubyVM::MJIT.enabled? assert_no_memory_leak([], '', <<~'end;', 'many autoloads', timeout: 30) 200000.times do |i| m = Module.new diff --git a/test/ruby/test_string.rb b/test/ruby/test_string.rb index 878ecb3083..1a6d87f11f 100644 --- a/test/ruby/test_string.rb +++ b/test/ruby/test_string.rb @@ -647,10 +647,6 @@ CODE end def test_crypt - if RubyVM::MJIT.enabled? - skip "This sometimes fails with -DMJIT_FORCE_ENABLE. This seems important to be fixed..." - end - assert_equal(S('aaGUC/JkO9/Sc'), S("mypassword").crypt(S("aa"))) assert_not_equal(S('aaGUC/JkO9/Sc'), S("mypassword").crypt(S("ab"))) assert_raise(ArgumentError) {S("mypassword").crypt(S(""))} diff --git a/test/rubygems/test_gem_util.rb b/test/rubygems/test_gem_util.rb index 205cd89611..d17fc77fd9 100644 --- a/test/rubygems/test_gem_util.rb +++ b/test/rubygems/test_gem_util.rb @@ -5,7 +5,6 @@ require 'rubygems/util' class TestGemUtil < Gem::TestCase def test_class_popen - skip "MJIT executes process and it's caught by Process.wait(-1)" if defined?(RubyVM::MJIT) && RubyVM::MJIT.enabled? assert_equal "0\n", Gem::Util.popen(Gem.ruby, '-e', 'p 0') assert_raises Errno::ECHILD do