From e6be06e4ef260a1a96fddd47fd632d61875b8b85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Wed, 22 Jul 2020 18:44:59 +0200 Subject: [PATCH] [rubygems/rubygems] Fix some intermittent test failures on truffleruby Since they changed their default to not generate documentation on `gem install`, we're getting some intermittent test failures. Can be reproduced with: ``` TRUFFLERUBYOPT="--experimental-options --testing-rubygems" TESTOPTS=--name="/^\(?:TestGemGemRunner#\(?:test_list_succeeds\)\|TestGemCommandsUpdateCommand#\(?:test_handle_options_system\)\)$/ --seed=54277 --verbose" rake ``` Fix it by resetting all permanent CLI options when CLI runner loads configuration. https://github.com/rubygems/rubygems/commit/7d896f4b74 --- test/rubygems/test_gem_gem_runner.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/rubygems/test_gem_gem_runner.rb b/test/rubygems/test_gem_gem_runner.rb index a2b145e7df..72a5c83431 100644 --- a/test/rubygems/test_gem_gem_runner.rb +++ b/test/rubygems/test_gem_gem_runner.rb @@ -8,6 +8,7 @@ class TestGemGemRunner < Gem::TestCase require 'rubygems/command' @orig_args = Gem::Command.build_args @orig_specific_extra_args = Gem::Command.specific_extra_args_hash.dup + @orig_extra_args = Gem::Command.extra_args.dup require 'rubygems/gem_runner' @runner = Gem::GemRunner.new @@ -18,6 +19,7 @@ class TestGemGemRunner < Gem::TestCase Gem::Command.build_args = @orig_args Gem::Command.specific_extra_args_hash = @orig_specific_extra_args + Gem::Command.extra_args = @orig_extra_args end def test_do_configuration